All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dafna Hirschfeld <dafna3@gmail.com>
To: helen.koike@collabora.com, hverkuil@xs4all.nl, mchehab@kernel.org
Cc: Dafna Hirschfeld <dafna3@gmail.com>, outreachy-kernel@googlegroups.com
Subject: [PATCH vicodec v4 0/3] Add support to more pixel formats in vicodec
Date: Mon,  5 Nov 2018 23:14:14 +0200	[thread overview]
Message-ID: <cover.1541451484.git.dafna3@gmail.com> (raw)

The new supported formats are
V4L2_PIX_FMT_GREY, V4L2_PIX_FMT_ARGB32, V4L2_PIX_FMT_ABGR32.

The returned encoded format is chaned to support various numbers
of planes instead of assuming 3 planes.

The first patch adds new fields to structs.
The second patch adds support for V4L2_PIX_FMT_GREY.
The third patch adds support for V4L2_PIX_FMT_ARGB32, V4L2_PIX_FMT_ABGR32.

Changes from v3:

patch 1,3: - no change

patch 2:
- replace the 2-bit flag FWHT_FL_COMPONENTS_NUM_BIT[01] with GENMASK
- add TODO comment - handle the case where the encoded stream is different format
than the decoded
- allocate maximal space for the V4L2_PIX_FMT_FWHT format

with the test 'flags & FWHT_FL_COMPONENTS_NUM_BIT[01]'

Dafna Hirschfeld (3):
  media: vicodec: prepare support for various number of planes
  media: vicodec: Add support of greyscale format
  media: vicodec: Add support for 4 planes formats

 drivers/media/platform/vicodec/codec-fwht.c   |  73 +++++++----
 drivers/media/platform/vicodec/codec-fwht.h   |  15 ++-
 .../media/platform/vicodec/codec-v4l2-fwht.c  | 123 +++++++++++++-----
 .../media/platform/vicodec/codec-v4l2-fwht.h  |   3 +-
 drivers/media/platform/vicodec/vicodec-core.c |  35 ++++-
 5 files changed, 182 insertions(+), 67 deletions(-)

-- 
2.17.1



WARNING: multiple messages have this Message-ID (diff)
From: Dafna Hirschfeld <dafna3@gmail.com>
To: helen.koike@collabora.com, hverkuil@xs4all.nl, mchehab@kernel.org
Cc: linux-media@vger.kernel.org, Dafna Hirschfeld <dafna3@gmail.com>,
	outreachy-kernel@googlegroups.com
Subject: [PATCH vicodec v4 0/3] Add support to more pixel formats in vicodec
Date: Thu, 15 Nov 2018 13:23:29 +0200	[thread overview]
Message-ID: <cover.1541451484.git.dafna3@gmail.com> (raw)

The new supported formats are
V4L2_PIX_FMT_GREY, V4L2_PIX_FMT_ARGB32, V4L2_PIX_FMT_ABGR32.

The returned encoded format is chaned to support various numbers
of planes instead of assuming 3 planes.

The first patch adds new fields to structs.
The second patch adds support for V4L2_PIX_FMT_GREY.
The third patch adds support for V4L2_PIX_FMT_ARGB32, V4L2_PIX_FMT_ABGR32.

The code used to test this patch is https://github.com/kamomil/outreachy
The script I used to test greyscale support:
https://github.com/kamomil/outreachy/blob/master/greyscale-full-example.sh 
The script I used to test argb/abgr:
https://github.com/kamomil/outreachy/blob/master/argb-and-abgr-full-example.sh

Changes from v3:

patch 1,3: - no change

patch 2:
- replace the 2-bit flag FWHT_FL_COMPONENTS_NUM_BIT[01] with GENMASK
- add TODO comment - handle the case where the encoded stream is different format
than the decoded
- allocate maximal space for the V4L2_PIX_FMT_FWHT format

with the test 'flags & FWHT_FL_COMPONENTS_NUM_BIT[01]'

Dafna Hirschfeld (3):
  media: vicodec: prepare support for various number of planes
  media: vicodec: Add support of greyscale format
  media: vicodec: Add support for 4 planes formats

 drivers/media/platform/vicodec/codec-fwht.c   |  73 +++++++----
 drivers/media/platform/vicodec/codec-fwht.h   |  15 ++-
 .../media/platform/vicodec/codec-v4l2-fwht.c  | 123 +++++++++++++-----
 .../media/platform/vicodec/codec-v4l2-fwht.h  |   3 +-
 drivers/media/platform/vicodec/vicodec-core.c |  35 ++++-
 5 files changed, 182 insertions(+), 67 deletions(-)

-- 
2.17.1

             reply	other threads:[~2018-11-05 21:14 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-05 21:14 Dafna Hirschfeld [this message]
2018-11-15 11:23 ` [PATCH vicodec v4 0/3] Add support to more pixel formats in vicodec Dafna Hirschfeld
2018-11-05 21:14 ` [PATCH vicodec v4 1/3] media: vicodec: prepare support for various number of planes Dafna Hirschfeld
2018-11-15 11:23   ` Dafna Hirschfeld
2018-11-05 21:14 ` [PATCH vicodec v4 2/3] media: vicodec: Add support of greyscale format Dafna Hirschfeld
2018-11-15 11:23   ` Dafna Hirschfeld
2018-11-05 21:14 ` [PATCH vicodec v4 3/3] media: vicodec: Add support for 4 planes formats Dafna Hirschfeld
2018-11-15 11:23   ` Dafna Hirschfeld
2018-11-08  0:51 ` [Outreachy kernel] [PATCH vicodec v4 0/3] Add support to more pixel formats in vicodec Ezequiel Garcia
2018-11-08  8:10   ` Dafna Hirschfeld
2018-11-08 17:54     ` Sasha Levin
2018-11-08 18:03       ` Ezequiel Garcia
2018-11-13 11:48 ` Hans Verkuil
2018-11-15 11:14   ` Dafna Hirschfeld
2018-11-15 11:58     ` Hans Verkuil
2018-11-15 12:09       ` Tomasz Figa
2018-11-15 13:04         ` Dafna Hirschfeld
2018-11-15 13:23           ` Tomasz Figa
2018-11-15 13:29           ` Hans Verkuil
2018-11-15 13:33             ` Tomasz Figa
2018-11-15 13:40               ` Hans Verkuil
2018-11-15 13:43                 ` Tomasz Figa
2018-11-15 13:48                   ` Hans Verkuil
2018-11-15 13:50                     ` Tomasz Figa
2018-11-15 14:22                       ` Hans Verkuil
2018-11-15 14:27                         ` Tomasz Figa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1541451484.git.dafna3@gmail.com \
    --to=dafna3@gmail.com \
    --cc=helen.koike@collabora.com \
    --cc=hverkuil@xs4all.nl \
    --cc=mchehab@kernel.org \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.