[PATCH 0/1] package.bbclass: Don not hide cpio's error

[PATCH 0/1] package.bbclass: Don not hide cpio's error

[Robert Yang]

The following changes since commit 20aea61385e1a53ac245353899277ba20104ed2f:

  gcc: Drop 7.3 since 8.2 is working fine for us (2018-12-15 17:10:44 +0000)

are available in the git repository at:

  git://git.openembedded.org/openembedded-core-contrib rbt/package
  http://cgit.openembedded.org/openembedded-core-contrib/log/?h=rbt/package

Robert Yang (1):
  package.bbclass: Don not hide cpio's error

 meta/classes/package.bbclass | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
2.7.4

[PATCH 1/1] package.bbclass: Don not hide cpio's error

[Robert Yang]

We use subprocess.check_output() to run the command, which means that we need care
about the error, so the 2>/dev/null should not be used, otherwise it is hard to
debug when the error happens.

I guess it was copied from previous lines, but that command's error can be
ignored (excpet: pass):
   try:
       subprocess.check_output(cmd, shell=True, stderr=subprocess.STDOUT)
   except subprocess.CalledProcessError:
       # Can "fail" if internal headers/transient sources are attempted
       pass

But we don't do this in the current location, so remove "2>/dev/null"

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 meta/classes/package.bbclass | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
index d1e9138..525d1c4 100644
--- a/meta/classes/package.bbclass
+++ b/meta/classes/package.bbclass
@@ -470,7 +470,8 @@ def copydebugsources(debugsrcdir, d):
 
         # cpio seems to have a bug with -lL together and symbolic links are just copied, not dereferenced.
         # Work around this by manually finding and copying any symbolic links that made it through.
-        cmd = "find %s%s -type l -print0 -delete | sed s#%s%s/##g | (cd '%s' ; cpio -pd0mL --no-preserve-owner '%s%s' 2>/dev/null)" % (dvar, debugsrcdir, dvar, debugsrcdir, workparentdir, dvar, debugsrcdir)
+        cmd = "find %s%s -type l -print0 -delete | sed s#%s%s/##g | (cd '%s' ; cpio -pd0mL --no-preserve-owner '%s%s')" % \
+                (dvar, debugsrcdir, dvar, debugsrcdir, workparentdir, dvar, debugsrcdir)
         subprocess.check_output(cmd, shell=True, stderr=subprocess.STDOUT)
 
         # The copy by cpio may have resulted in some empty directories!  Remove these
-- 
2.7.4

Re: [PATCH 0/1] package.bbclass: Don not hide cpio's error

[Robert Yang]

Sorry, the subject should be:

package.bbclass: Do not hide cpio's error

Fixed it in the repo.

// Robert

On 12/18/18 11:00 AM, Robert Yang wrote:
> The following changes since commit 20aea61385e1a53ac245353899277ba20104ed2f:
> 
>    gcc: Drop 7.3 since 8.2 is working fine for us (2018-12-15 17:10:44 +0000)
> 
> are available in the git repository at:
> 
>    git://git.openembedded.org/openembedded-core-contrib rbt/package
>    http://cgit.openembedded.org/openembedded-core-contrib/log/?h=rbt/package
> 
> Robert Yang (1):
>    package.bbclass: Don not hide cpio's error
> 
>   meta/classes/package.bbclass | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 

Re: [PATCH 0/1] package.bbclass: Don not hide cpio's error

[Robert Yang]

On 12/18/18 11:13 AM, Robert Yang wrote:
> Sorry, the subject should be:
> 
> package.bbclass: Do not hide cpio's error
> 
> Fixed it in the repo.
> 
> // Robert
> 
> On 12/18/18 11:00 AM, Robert Yang wrote:
>> The following changes since commit 20aea61385e1a53ac245353899277ba20104ed2f:
>>
>>    gcc: Drop 7.3 since 8.2 is working fine for us (2018-12-15 17:10:44 +0000)
>>
>> are available in the git repository at:
>>
>>    git://git.openembedded.org/openembedded-core-contrib rbt/package

Ping.

// Robert

>>    http://cgit.openembedded.org/openembedded-core-contrib/log/?h=rbt/package
>>
>> Robert Yang (1):
>>    package.bbclass: Don not hide cpio's error
>>
>>   meta/classes/package.bbclass | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>

Re: [PATCH 0/1] package.bbclass: Don not hide cpio's error

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 1178 bytes --]

Queued in mut already.

Ross

On Thu, 10 Jan 2019 at 07:48, Robert Yang <liezhi.yang@windriver.com> wrote:

>
>
> On 12/18/18 11:13 AM, Robert Yang wrote:
> > Sorry, the subject should be:
> >
> > package.bbclass: Do not hide cpio's error
> >
> > Fixed it in the repo.
> >
> > // Robert
> >
> > On 12/18/18 11:00 AM, Robert Yang wrote:
> >> The following changes since commit
> 20aea61385e1a53ac245353899277ba20104ed2f:
> >>
> >>    gcc: Drop 7.3 since 8.2 is working fine for us (2018-12-15 17:10:44
> +0000)
> >>
> >> are available in the git repository at:
> >>
> >>    git://git.openembedded.org/openembedded-core-contrib rbt/package
>
> Ping.
>
> // Robert
>
> >>
> http://cgit.openembedded.org/openembedded-core-contrib/log/?h=rbt/package
> >>
> >> Robert Yang (1):
> >>    package.bbclass: Don not hide cpio's error
> >>
> >>   meta/classes/package.bbclass | 3 ++-
> >>   1 file changed, 2 insertions(+), 1 deletion(-)
> >>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

[-- Attachment #2: Type: text/html, Size: 2126 bytes --]