[PATCH 0/8] Staging: vt6655: Fix checkpatch.pl issues

All of lore.kernel.org
 help / color / mirror / Atom feed

* [PATCH 0/8] Staging: vt6655: Fix checkpatch.pl issues
@ 2019-03-02  2:41 Madhumitha Prabakaran
  2019-03-02  2:41 ` [PATCH 1/8] Staging: vt6655: Fix line over 80 character Madhumitha Prabakaran
                   ` (8 more replies)
  0 siblings, 9 replies; 10+ messages in thread
From: Madhumitha Prabakaran @ 2019-03-02  2:41 UTC (permalink / raw)
  To: forest, gregkh, outreachy-kernel; +Cc: Madhumitha Prabakaran

These patches fix warnings of line over 80 characters, comment style
issues of SPDX License Identifier and remove unnecessary blank line. 

  Staging: vt6655: card.h: Fix line over 80 characters
  Staging: vt6655: card.h: Fix line over 80 characters
  Staging: vt6655: device.h: Fix comment style of SPDX License Identifier
  Staging: vt6655: device_cfg.h: Fix comment style of SPDX License Identifer
  Staging: vt6655: dpc.h: Fix comment style of SPDX License Identifier
  Staging: vt6655: key.h: Fix comment style of SPDX License Identifier
  Staging: vt6655: mac.c: Remove unnecessary blank line
  Staging: vt6655: mac.h: Fix comment style of SPDX License Identifier

 drivers/staging/vt6655/card.h       | 6 ++++--
 drivers/staging/vt6655/device.h     | 2 +-
 drivers/staging/vt6655/device_cfg.h | 2 +-
 drivers/staging/vt6655/dpc.h        | 2 +-
 drivers/staging/vt6655/key.h        | 2 +-
 drivers/staging/vt6655/mac.c        | 1 -
 drivers/staging/vt6655/mac.h        | 2 +-
 7 files changed, 9 insertions(+), 8 deletions(-)

-- 
2.17.1



^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH 1/8] Staging: vt6655: Fix line over 80 character
  2019-03-02  2:41 [PATCH 0/8] Staging: vt6655: Fix checkpatch.pl issues Madhumitha Prabakaran
@ 2019-03-02  2:41 ` Madhumitha Prabakaran
  2019-03-02  2:41 ` [PATCH 2/8] Staging: vt6655: Fix line over 80 characters Madhumitha Prabakaran
                   ` (7 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: Madhumitha Prabakaran @ 2019-03-02  2:41 UTC (permalink / raw)
  To: forest, gregkh, outreachy-kernel; +Cc: Madhumitha Prabakaran

Fix the warning
WARNING: line over 80 characters

Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
---
 drivers/staging/vt6655/card.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/vt6655/card.h b/drivers/staging/vt6655/card.h
index d71022aa3f86..6bbbbe1314d5 100644
--- a/drivers/staging/vt6655/card.h
+++ b/drivers/staging/vt6655/card.h
@@ -44,7 +44,8 @@ struct vnt_private;
 void CARDvSetRSPINF(struct vnt_private *priv, u8 bb_type);
 void CARDvUpdateBasicTopRate(struct vnt_private *priv);
 bool CARDbIsOFDMinBasicRate(struct vnt_private *priv);
-void CARDvSetLoopbackMode(struct vnt_private *priv, unsigned short wLoopbackMode);
+void CARDvSetLoopbackMode(struct vnt_private *priv,
+			  unsigned short wLoopbackMode);
 bool CARDbSoftwareReset(struct vnt_private *priv);
 void CARDvSetFirstNextTBTT(struct vnt_private *priv,
 			   unsigned short wBeaconInterval);
-- 
2.17.1



^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 2/8] Staging: vt6655: Fix line over 80 characters
  2019-03-02  2:41 [PATCH 0/8] Staging: vt6655: Fix checkpatch.pl issues Madhumitha Prabakaran
  2019-03-02  2:41 ` [PATCH 1/8] Staging: vt6655: Fix line over 80 character Madhumitha Prabakaran
@ 2019-03-02  2:41 ` Madhumitha Prabakaran
  2019-03-02  2:41 ` [PATCH 3/8] Staging: vt6655: Fix comment style of SPDX License Identifier Madhumitha Prabakaran
                   ` (6 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: Madhumitha Prabakaran @ 2019-03-02  2:41 UTC (permalink / raw)
  To: forest, gregkh, outreachy-kernel; +Cc: Madhumitha Prabakaran

Fix the warning
WARNING: line over 80 characters

Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
---
 drivers/staging/vt6655/card.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/vt6655/card.h b/drivers/staging/vt6655/card.h
index 6bbbbe1314d5..490cecf8fb9d 100644
--- a/drivers/staging/vt6655/card.h
+++ b/drivers/staging/vt6655/card.h
@@ -62,6 +62,7 @@ bool CARDbRadioPowerOn(struct vnt_private *priv);
 bool CARDbSetPhyParameter(struct vnt_private *priv, u8 bb_type);
 bool CARDbUpdateTSF(struct vnt_private *priv, unsigned char byRxRate,
 		    u64 qwBSSTimestamp);
-bool CARDbSetBeaconPeriod(struct vnt_private *priv, unsigned short wBeaconInterval);
+bool CARDbSetBeaconPeriod(struct vnt_private *priv,
+			  unsigned short wBeaconInterval);
 
 #endif /* __CARD_H__ */
-- 
2.17.1



^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 3/8] Staging: vt6655: Fix comment style of SPDX License Identifier
  2019-03-02  2:41 [PATCH 0/8] Staging: vt6655: Fix checkpatch.pl issues Madhumitha Prabakaran
  2019-03-02  2:41 ` [PATCH 1/8] Staging: vt6655: Fix line over 80 character Madhumitha Prabakaran
  2019-03-02  2:41 ` [PATCH 2/8] Staging: vt6655: Fix line over 80 characters Madhumitha Prabakaran
@ 2019-03-02  2:41 ` Madhumitha Prabakaran
  2019-03-02  2:41 ` [PATCH 4/8] Staging: vt6655: Fix comment style of SPDX License Identifer Madhumitha Prabakaran
                   ` (5 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: Madhumitha Prabakaran @ 2019-03-02  2:41 UTC (permalink / raw)
  To: forest, gregkh, outreachy-kernel; +Cc: Madhumitha Prabakaran

Fix comment style of SPDX License Identifier based on License Identifier
syntax for header type file.

Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
---
 drivers/staging/vt6655/device_cfg.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vt6655/device_cfg.h b/drivers/staging/vt6655/device_cfg.h
index 6b41c74f7c2a..04db6a8d3db3 100644
--- a/drivers/staging/vt6655/device_cfg.h
+++ b/drivers/staging/vt6655/device_cfg.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0+
+/* SPDX-License-Identifier: GPL-2.0+ */
 /*
  * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
  * All rights reserved.
-- 
2.17.1



^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 4/8] Staging: vt6655: Fix comment style of SPDX License Identifer
  2019-03-02  2:41 [PATCH 0/8] Staging: vt6655: Fix checkpatch.pl issues Madhumitha Prabakaran
                   ` (2 preceding siblings ...)
  2019-03-02  2:41 ` [PATCH 3/8] Staging: vt6655: Fix comment style of SPDX License Identifier Madhumitha Prabakaran
@ 2019-03-02  2:41 ` Madhumitha Prabakaran
  2019-03-02  2:41 ` [PATCH 5/8] Staging: vt6655: Fix comment style of SPDX License Identifier Madhumitha Prabakaran
                   ` (4 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: Madhumitha Prabakaran @ 2019-03-02  2:41 UTC (permalink / raw)
  To: forest, gregkh, outreachy-kernel; +Cc: Madhumitha Prabakaran

Fix comment style of SPDX License Identifer for header type file based
on License Identifier syntax.

Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
---
 drivers/staging/vt6655/device.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vt6655/device.h b/drivers/staging/vt6655/device.h
index 2f9e9219e8c8..29f354ced563 100644
--- a/drivers/staging/vt6655/device.h
+++ b/drivers/staging/vt6655/device.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0+
+/* SPDX-License-Identifier: GPL-2.0+ */
 /*
  * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
  * All rights reserved.
-- 
2.17.1



^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 5/8] Staging: vt6655: Fix comment style of SPDX License Identifier
  2019-03-02  2:41 [PATCH 0/8] Staging: vt6655: Fix checkpatch.pl issues Madhumitha Prabakaran
                   ` (3 preceding siblings ...)
  2019-03-02  2:41 ` [PATCH 4/8] Staging: vt6655: Fix comment style of SPDX License Identifer Madhumitha Prabakaran
@ 2019-03-02  2:41 ` Madhumitha Prabakaran
  2019-03-02  2:41 ` [PATCH 6/8] " Madhumitha Prabakaran
                   ` (3 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: Madhumitha Prabakaran @ 2019-03-02  2:41 UTC (permalink / raw)
  To: forest, gregkh, outreachy-kernel; +Cc: Madhumitha Prabakaran

Fix comment style of SPDX License Identifer for header file based on
License Identifier syntax.

Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
---
 drivers/staging/vt6655/dpc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vt6655/dpc.h b/drivers/staging/vt6655/dpc.h
index 93af4220605f..eac67794cc49 100644
--- a/drivers/staging/vt6655/dpc.h
+++ b/drivers/staging/vt6655/dpc.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0+
+/* SPDX-License-Identifier: GPL-2.0+ */
 /*
  * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
  * All rights reserved.
-- 
2.17.1



^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 6/8] Staging: vt6655: Fix comment style of SPDX License Identifier
  2019-03-02  2:41 [PATCH 0/8] Staging: vt6655: Fix checkpatch.pl issues Madhumitha Prabakaran
                   ` (4 preceding siblings ...)
  2019-03-02  2:41 ` [PATCH 5/8] Staging: vt6655: Fix comment style of SPDX License Identifier Madhumitha Prabakaran
@ 2019-03-02  2:41 ` Madhumitha Prabakaran
  2019-03-02  2:41 ` [PATCH 7/8] Staging: vt6655: Remove unnecessary blank line Madhumitha Prabakaran
                   ` (2 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: Madhumitha Prabakaran @ 2019-03-02  2:41 UTC (permalink / raw)
  To: forest, gregkh, outreachy-kernel; +Cc: Madhumitha Prabakaran

Fix comment style of SPDX License Identifier for header file type based
on License Identifer syntax.

Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
---
 drivers/staging/vt6655/key.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vt6655/key.h b/drivers/staging/vt6655/key.h
index 0942d8703f98..9347776fa3a5 100644
--- a/drivers/staging/vt6655/key.h
+++ b/drivers/staging/vt6655/key.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0+
+/* SPDX-License-Identifier: GPL-2.0+ */
 /*
  * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
  * All rights reserved.
-- 
2.17.1



^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 7/8] Staging: vt6655: Remove unnecessary blank line
  2019-03-02  2:41 [PATCH 0/8] Staging: vt6655: Fix checkpatch.pl issues Madhumitha Prabakaran
                   ` (5 preceding siblings ...)
  2019-03-02  2:41 ` [PATCH 6/8] " Madhumitha Prabakaran
@ 2019-03-02  2:41 ` Madhumitha Prabakaran
  2019-03-02  2:41 ` [PATCH 8/8] Staging: vt6655: Fix comment style of SPDX License Identifier Madhumitha Prabakaran
  2019-03-02  7:47 ` [PATCH 0/8] Staging: vt6655: Fix checkpatch.pl issues Greg KH
  8 siblings, 0 replies; 10+ messages in thread
From: Madhumitha Prabakaran @ 2019-03-02  2:41 UTC (permalink / raw)
  To: forest, gregkh, outreachy-kernel; +Cc: Madhumitha Prabakaran

Remove unnecessary blank line before end of block brace so that it fix
the check
CHECK: Blank lines aren't necessary before a close brace '}'

Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
---
 drivers/staging/vt6655/mac.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/vt6655/mac.c b/drivers/staging/vt6655/mac.c
index 4750863c1bb7..40a8f1ce837c 100644
--- a/drivers/staging/vt6655/mac.c
+++ b/drivers/staging/vt6655/mac.c
@@ -593,7 +593,6 @@ void MACvSetCurrRx1DescAddr(struct vnt_private *priv, u32 curr_desc_addr)
 	iowrite32(curr_desc_addr, io_base + MAC_REG_RXDMAPTR1);
 	if (org_dma_ctl & DMACTL_RUN)
 		iowrite8(DMACTL_RUN, io_base + MAC_REG_RXDMACTL1);
-
 }
 
 /*
-- 
2.17.1



^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 8/8] Staging: vt6655: Fix comment style of SPDX License Identifier
  2019-03-02  2:41 [PATCH 0/8] Staging: vt6655: Fix checkpatch.pl issues Madhumitha Prabakaran
                   ` (6 preceding siblings ...)
  2019-03-02  2:41 ` [PATCH 7/8] Staging: vt6655: Remove unnecessary blank line Madhumitha Prabakaran
@ 2019-03-02  2:41 ` Madhumitha Prabakaran
  2019-03-02  7:47 ` [PATCH 0/8] Staging: vt6655: Fix checkpatch.pl issues Greg KH
  8 siblings, 0 replies; 10+ messages in thread
From: Madhumitha Prabakaran @ 2019-03-02  2:41 UTC (permalink / raw)
  To: forest, gregkh, outreachy-kernel; +Cc: Madhumitha Prabakaran

Fix comment style of SPDX License Identifer for header type file based
on License Identifer syntax.

Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
---
 drivers/staging/vt6655/mac.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vt6655/mac.h b/drivers/staging/vt6655/mac.h
index b8ab09434773..8c8c26792343 100644
--- a/drivers/staging/vt6655/mac.h
+++ b/drivers/staging/vt6655/mac.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0+
+/* SPDX-License-Identifier: GPL-2.0+ */
 /*
  * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
  * All rights reserved.
-- 
2.17.1



^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH 0/8] Staging: vt6655: Fix checkpatch.pl issues
  2019-03-02  2:41 [PATCH 0/8] Staging: vt6655: Fix checkpatch.pl issues Madhumitha Prabakaran
                   ` (7 preceding siblings ...)
  2019-03-02  2:41 ` [PATCH 8/8] Staging: vt6655: Fix comment style of SPDX License Identifier Madhumitha Prabakaran
@ 2019-03-02  7:47 ` Greg KH
  8 siblings, 0 replies; 10+ messages in thread
From: Greg KH @ 2019-03-02  7:47 UTC (permalink / raw)
  To: Madhumitha Prabakaran; +Cc: forest, outreachy-kernel

On Fri, Mar 01, 2019 at 08:41:34PM -0600, Madhumitha Prabakaran wrote:
> These patches fix warnings of line over 80 characters, comment style
> issues of SPDX License Identifier and remove unnecessary blank line. 
> 
>   Staging: vt6655: card.h: Fix line over 80 characters
>   Staging: vt6655: card.h: Fix line over 80 characters
>   Staging: vt6655: device.h: Fix comment style of SPDX License Identifier
>   Staging: vt6655: device_cfg.h: Fix comment style of SPDX License Identifer
>   Staging: vt6655: dpc.h: Fix comment style of SPDX License Identifier
>   Staging: vt6655: key.h: Fix comment style of SPDX License Identifier
>   Staging: vt6655: mac.c: Remove unnecessary blank line
>   Staging: vt6655: mac.h: Fix comment style of SPDX License Identifier

These lines do not match up with the subject lines of your patches you
sent out.

Please fix up and resend.

thansk,

greg k-h


^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2019-03-02  7:47 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-02  2:41 [PATCH 0/8] Staging: vt6655: Fix checkpatch.pl issues Madhumitha Prabakaran
2019-03-02  2:41 ` [PATCH 1/8] Staging: vt6655: Fix line over 80 character Madhumitha Prabakaran
2019-03-02  2:41 ` [PATCH 2/8] Staging: vt6655: Fix line over 80 characters Madhumitha Prabakaran
2019-03-02  2:41 ` [PATCH 3/8] Staging: vt6655: Fix comment style of SPDX License Identifier Madhumitha Prabakaran
2019-03-02  2:41 ` [PATCH 4/8] Staging: vt6655: Fix comment style of SPDX License Identifer Madhumitha Prabakaran
2019-03-02  2:41 ` [PATCH 5/8] Staging: vt6655: Fix comment style of SPDX License Identifier Madhumitha Prabakaran
2019-03-02  2:41 ` [PATCH 6/8] " Madhumitha Prabakaran
2019-03-02  2:41 ` [PATCH 7/8] Staging: vt6655: Remove unnecessary blank line Madhumitha Prabakaran
2019-03-02  2:41 ` [PATCH 8/8] Staging: vt6655: Fix comment style of SPDX License Identifier Madhumitha Prabakaran
2019-03-02  7:47 ` [PATCH 0/8] Staging: vt6655: Fix checkpatch.pl issues Greg KH

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.