* [PATCH 1/6] Staging: vt6655: dpc.h: Fix comment style of SPDX License Identifier
2019-03-05 22:33 [PATCH 0/6] Staging: vt6655: Fix checkpatch.pl issues Madhumitha Prabakaran
@ 2019-03-05 22:34 ` Madhumitha Prabakaran
2019-03-05 22:34 ` [PATCH 2/6] Staging: vt6655: key.h: Fix comment style for SPDX-License Identifier Madhumitha Prabakaran
` (5 subsequent siblings)
6 siblings, 0 replies; 14+ messages in thread
From: Madhumitha Prabakaran @ 2019-03-05 22:34 UTC (permalink / raw)
To: forest, gregkh, outreachy-kernel; +Cc: Madhumitha Prabakaran
Modify comment style of SPDX License Identifier for header file type, as
per the license identifier syntax.
Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
---
drivers/staging/vt6655/dpc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vt6655/dpc.h b/drivers/staging/vt6655/dpc.h
index 93af4220605f..eac67794cc49 100644
--- a/drivers/staging/vt6655/dpc.h
+++ b/drivers/staging/vt6655/dpc.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0+
+/* SPDX-License-Identifier: GPL-2.0+ */
/*
* Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
* All rights reserved.
--
2.17.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH 2/6] Staging: vt6655: key.h: Fix comment style for SPDX-License Identifier
2019-03-05 22:33 [PATCH 0/6] Staging: vt6655: Fix checkpatch.pl issues Madhumitha Prabakaran
2019-03-05 22:34 ` [PATCH 1/6] Staging: vt6655: dpc.h: Fix comment style of SPDX License Identifier Madhumitha Prabakaran
@ 2019-03-05 22:34 ` Madhumitha Prabakaran
2019-03-05 22:34 ` [PATCH 3/6] Staging: vt6655: Remove unnecessary blank line Madhumitha Prabakaran
` (4 subsequent siblings)
6 siblings, 0 replies; 14+ messages in thread
From: Madhumitha Prabakaran @ 2019-03-05 22:34 UTC (permalink / raw)
To: forest, gregkh, outreachy-kernel; +Cc: Madhumitha Prabakaran
Modify comment style for SPDX-License Identifier based on license
identifier syntax.
Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
---
drivers/staging/vt6655/key.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vt6655/key.h b/drivers/staging/vt6655/key.h
index 0942d8703f98..9347776fa3a5 100644
--- a/drivers/staging/vt6655/key.h
+++ b/drivers/staging/vt6655/key.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0+
+/* SPDX-License-Identifier: GPL-2.0+ */
/*
* Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
* All rights reserved.
--
2.17.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH 3/6] Staging: vt6655: Remove unnecessary blank line
2019-03-05 22:33 [PATCH 0/6] Staging: vt6655: Fix checkpatch.pl issues Madhumitha Prabakaran
2019-03-05 22:34 ` [PATCH 1/6] Staging: vt6655: dpc.h: Fix comment style of SPDX License Identifier Madhumitha Prabakaran
2019-03-05 22:34 ` [PATCH 2/6] Staging: vt6655: key.h: Fix comment style for SPDX-License Identifier Madhumitha Prabakaran
@ 2019-03-05 22:34 ` Madhumitha Prabakaran
2019-03-05 22:34 ` [PATCH 4/6] Staging: vt6655: mac.h: Fix comment style for SPDX-License Identifier Madhumitha Prabakaran
` (3 subsequent siblings)
6 siblings, 0 replies; 14+ messages in thread
From: Madhumitha Prabakaran @ 2019-03-05 22:34 UTC (permalink / raw)
To: forest, gregkh, outreachy-kernel; +Cc: Madhumitha Prabakaran
Fix the check issue provided by checkpatch.pl
CHECK: Blank lines aren't necessary before a close brace '}'
Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
---
drivers/staging/vt6655/mac.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/vt6655/mac.c b/drivers/staging/vt6655/mac.c
index 4750863c1bb7..40a8f1ce837c 100644
--- a/drivers/staging/vt6655/mac.c
+++ b/drivers/staging/vt6655/mac.c
@@ -593,7 +593,6 @@ void MACvSetCurrRx1DescAddr(struct vnt_private *priv, u32 curr_desc_addr)
iowrite32(curr_desc_addr, io_base + MAC_REG_RXDMAPTR1);
if (org_dma_ctl & DMACTL_RUN)
iowrite8(DMACTL_RUN, io_base + MAC_REG_RXDMACTL1);
-
}
/*
--
2.17.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH 4/6] Staging: vt6655: mac.h: Fix comment style for SPDX-License Identifier
2019-03-05 22:33 [PATCH 0/6] Staging: vt6655: Fix checkpatch.pl issues Madhumitha Prabakaran
` (2 preceding siblings ...)
2019-03-05 22:34 ` [PATCH 3/6] Staging: vt6655: Remove unnecessary blank line Madhumitha Prabakaran
@ 2019-03-05 22:34 ` Madhumitha Prabakaran
2019-03-05 22:34 ` [PATCH 5/6] Staging: vt6655: Fix line over 80 characters Madhumitha Prabakaran
` (2 subsequent siblings)
6 siblings, 0 replies; 14+ messages in thread
From: Madhumitha Prabakaran @ 2019-03-05 22:34 UTC (permalink / raw)
To: forest, gregkh, outreachy-kernel; +Cc: Madhumitha Prabakaran
Modify comment style for header type file based on license identifier
syntax.
Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
---
drivers/staging/vt6655/mac.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vt6655/mac.h b/drivers/staging/vt6655/mac.h
index b8ab09434773..8c8c26792343 100644
--- a/drivers/staging/vt6655/mac.h
+++ b/drivers/staging/vt6655/mac.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0+
+/* SPDX-License-Identifier: GPL-2.0+ */
/*
* Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
* All rights reserved.
--
2.17.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH 5/6] Staging: vt6655: Fix line over 80 characters
2019-03-05 22:33 [PATCH 0/6] Staging: vt6655: Fix checkpatch.pl issues Madhumitha Prabakaran
` (3 preceding siblings ...)
2019-03-05 22:34 ` [PATCH 4/6] Staging: vt6655: mac.h: Fix comment style for SPDX-License Identifier Madhumitha Prabakaran
@ 2019-03-05 22:34 ` Madhumitha Prabakaran
2019-03-05 22:34 ` [PATCH 6/6] Staging: vt6655: Align function declaration Madhumitha Prabakaran
2019-03-05 22:48 ` [PATCH v2 0/6] Modify checkpatch.pl issues Madhumitha Prabakaran
6 siblings, 0 replies; 14+ messages in thread
From: Madhumitha Prabakaran @ 2019-03-05 22:34 UTC (permalink / raw)
To: forest, gregkh, outreachy-kernel; +Cc: Madhumitha Prabakaran
Fix the checkpatch.pl warning
WARNING: line over 80 characters
Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
---
drivers/staging/vt6655/mac.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/vt6655/mac.h b/drivers/staging/vt6655/mac.h
index 8c8c26792343..99de843b4551 100644
--- a/drivers/staging/vt6655/mac.h
+++ b/drivers/staging/vt6655/mac.h
@@ -883,7 +883,8 @@ bool MACbIsRegBitsOff(struct vnt_private *priv, unsigned char byRegOfs,
bool MACbIsIntDisable(struct vnt_private *priv);
-void MACvSetShortRetryLimit(struct vnt_private *priv, unsigned char byRetryLimit);
+void MACvSetShortRetryLimit(struct vnt_private *priv,
+ unsigned char byRetryLimit);
void MACvSetLongRetryLimit(struct vnt_private *priv, unsigned char byRetryLimit);
void MACvGetLongRetryLimit(struct vnt_private *priv,
--
2.17.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH 6/6] Staging: vt6655: Align function declaration
2019-03-05 22:33 [PATCH 0/6] Staging: vt6655: Fix checkpatch.pl issues Madhumitha Prabakaran
` (4 preceding siblings ...)
2019-03-05 22:34 ` [PATCH 5/6] Staging: vt6655: Fix line over 80 characters Madhumitha Prabakaran
@ 2019-03-05 22:34 ` Madhumitha Prabakaran
2019-03-05 22:48 ` [PATCH v2 0/6] Modify checkpatch.pl issues Madhumitha Prabakaran
6 siblings, 0 replies; 14+ messages in thread
From: Madhumitha Prabakaran @ 2019-03-05 22:34 UTC (permalink / raw)
To: forest, gregkh, outreachy-kernel; +Cc: Madhumitha Prabakaran
Fix function return type and function arguments to improve readbility.
Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
---
drivers/staging/vt6655/power.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/vt6655/power.c b/drivers/staging/vt6655/power.c
index d6c581b31569..9725de3bca6a 100644
--- a/drivers/staging/vt6655/power.c
+++ b/drivers/staging/vt6655/power.c
@@ -48,11 +48,8 @@
*
*/
-void
-PSvEnablePowerSaving(
- struct vnt_private *priv,
- unsigned short wListenInterval
-)
+void PSvEnablePowerSaving(struct vnt_private *priv,
+ unsigned short wListenInterval)
{
u16 wAID = priv->current_aid | BIT(14) | BIT(15);
--
2.17.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH v2 0/6] Modify checkpatch.pl issues
2019-03-05 22:33 [PATCH 0/6] Staging: vt6655: Fix checkpatch.pl issues Madhumitha Prabakaran
` (5 preceding siblings ...)
2019-03-05 22:34 ` [PATCH 6/6] Staging: vt6655: Align function declaration Madhumitha Prabakaran
@ 2019-03-05 22:48 ` Madhumitha Prabakaran
2019-03-05 22:48 ` [PATCH v2 1/6] Staging: vt6655: dpc.h: Fix comment style of SPDX License Identifier Madhumitha Prabakaran
` (5 more replies)
6 siblings, 6 replies; 14+ messages in thread
From: Madhumitha Prabakaran @ 2019-03-05 22:48 UTC (permalink / raw)
To: forest, gregkh, outreachy-kernel; +Cc: Madhumitha Prabakaran
This patchset modifies following -
1) Fix comment style for SPDX License Identifier in dpc.h
2) Fix comment style for SPDX License Identifier in key.h
3) Remove unnecessary blank line
4) Fix comment style for SPDX License Identifier in mac.h
5) Fix warning line over 80 characters
6) Align function declaration
Madhumitha Prabakaran (6):
Staging: vt6655: dpc.h: Fix comment style of SPDX License Identifier
Staging: vt6655: key.h: Fix comment style for SPDX-License Identifier
Staging: vt6655: Remove unnecessary blank line
Staging: vt6655: mac.h: Fix comment style for SPDX-License Identifier
Staging: vt6655: Fix the warning line over 80 characters
Staging: vt6655: Align function declaration
---
Change in v2
- Modified SUBJECT HERE for patch series
- Changed subject line for fifth patch
drivers/staging/vt6655/dpc.h | 2 +-
drivers/staging/vt6655/key.h | 2 +-
drivers/staging/vt6655/mac.c | 1 -
drivers/staging/vt6655/mac.h | 5 +++--
drivers/staging/vt6655/power.c | 7 ++-----
5 files changed, 7 insertions(+), 10 deletions(-)
--
2.17.1
^ permalink raw reply [flat|nested] 14+ messages in thread* [PATCH v2 1/6] Staging: vt6655: dpc.h: Fix comment style of SPDX License Identifier
2019-03-05 22:48 ` [PATCH v2 0/6] Modify checkpatch.pl issues Madhumitha Prabakaran
@ 2019-03-05 22:48 ` Madhumitha Prabakaran
2019-03-05 22:48 ` [PATCH v2 2/6] Staging: vt6655: key.h: Fix comment style for SPDX-License Identifier Madhumitha Prabakaran
` (4 subsequent siblings)
5 siblings, 0 replies; 14+ messages in thread
From: Madhumitha Prabakaran @ 2019-03-05 22:48 UTC (permalink / raw)
To: forest, gregkh, outreachy-kernel; +Cc: Madhumitha Prabakaran
Modify comment style of SPDX License Identifier for header file type, as
per the license identifier syntax.
Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
---
drivers/staging/vt6655/dpc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vt6655/dpc.h b/drivers/staging/vt6655/dpc.h
index 93af4220605f..eac67794cc49 100644
--- a/drivers/staging/vt6655/dpc.h
+++ b/drivers/staging/vt6655/dpc.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0+
+/* SPDX-License-Identifier: GPL-2.0+ */
/*
* Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
* All rights reserved.
--
2.17.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH v2 2/6] Staging: vt6655: key.h: Fix comment style for SPDX-License Identifier
2019-03-05 22:48 ` [PATCH v2 0/6] Modify checkpatch.pl issues Madhumitha Prabakaran
2019-03-05 22:48 ` [PATCH v2 1/6] Staging: vt6655: dpc.h: Fix comment style of SPDX License Identifier Madhumitha Prabakaran
@ 2019-03-05 22:48 ` Madhumitha Prabakaran
2019-03-05 22:48 ` [PATCH v2 3/6] Staging: vt6655: Remove unnecessary blank line Madhumitha Prabakaran
` (3 subsequent siblings)
5 siblings, 0 replies; 14+ messages in thread
From: Madhumitha Prabakaran @ 2019-03-05 22:48 UTC (permalink / raw)
To: forest, gregkh, outreachy-kernel; +Cc: Madhumitha Prabakaran
Modify comment style for SPDX-License Identifier based on license
identifier syntax.
Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
---
drivers/staging/vt6655/key.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vt6655/key.h b/drivers/staging/vt6655/key.h
index 0942d8703f98..9347776fa3a5 100644
--- a/drivers/staging/vt6655/key.h
+++ b/drivers/staging/vt6655/key.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0+
+/* SPDX-License-Identifier: GPL-2.0+ */
/*
* Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
* All rights reserved.
--
2.17.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH v2 3/6] Staging: vt6655: Remove unnecessary blank line
2019-03-05 22:48 ` [PATCH v2 0/6] Modify checkpatch.pl issues Madhumitha Prabakaran
2019-03-05 22:48 ` [PATCH v2 1/6] Staging: vt6655: dpc.h: Fix comment style of SPDX License Identifier Madhumitha Prabakaran
2019-03-05 22:48 ` [PATCH v2 2/6] Staging: vt6655: key.h: Fix comment style for SPDX-License Identifier Madhumitha Prabakaran
@ 2019-03-05 22:48 ` Madhumitha Prabakaran
2019-03-05 22:48 ` [PATCH v2 4/6] Staging: vt6655: mac.h: Fix comment style for SPDX-License Identifier Madhumitha Prabakaran
` (2 subsequent siblings)
5 siblings, 0 replies; 14+ messages in thread
From: Madhumitha Prabakaran @ 2019-03-05 22:48 UTC (permalink / raw)
To: forest, gregkh, outreachy-kernel; +Cc: Madhumitha Prabakaran
Fix the check issue provided by checkpatch.pl
CHECK: Blank lines aren't necessary before a close brace '}'
Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
---
drivers/staging/vt6655/mac.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/vt6655/mac.c b/drivers/staging/vt6655/mac.c
index 4750863c1bb7..40a8f1ce837c 100644
--- a/drivers/staging/vt6655/mac.c
+++ b/drivers/staging/vt6655/mac.c
@@ -593,7 +593,6 @@ void MACvSetCurrRx1DescAddr(struct vnt_private *priv, u32 curr_desc_addr)
iowrite32(curr_desc_addr, io_base + MAC_REG_RXDMAPTR1);
if (org_dma_ctl & DMACTL_RUN)
iowrite8(DMACTL_RUN, io_base + MAC_REG_RXDMACTL1);
-
}
/*
--
2.17.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH v2 4/6] Staging: vt6655: mac.h: Fix comment style for SPDX-License Identifier
2019-03-05 22:48 ` [PATCH v2 0/6] Modify checkpatch.pl issues Madhumitha Prabakaran
` (2 preceding siblings ...)
2019-03-05 22:48 ` [PATCH v2 3/6] Staging: vt6655: Remove unnecessary blank line Madhumitha Prabakaran
@ 2019-03-05 22:48 ` Madhumitha Prabakaran
2019-03-05 22:48 ` [PATCH v2 5/6] Staging: vt6655: Fix the warning line over 80 characters Madhumitha Prabakaran
2019-03-05 22:48 ` [PATCH v2 6/6] Staging: vt6655: Align function declaration Madhumitha Prabakaran
5 siblings, 0 replies; 14+ messages in thread
From: Madhumitha Prabakaran @ 2019-03-05 22:48 UTC (permalink / raw)
To: forest, gregkh, outreachy-kernel; +Cc: Madhumitha Prabakaran
Modify comment style for header type file based on license identifier
syntax.
Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
---
drivers/staging/vt6655/mac.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vt6655/mac.h b/drivers/staging/vt6655/mac.h
index b8ab09434773..8c8c26792343 100644
--- a/drivers/staging/vt6655/mac.h
+++ b/drivers/staging/vt6655/mac.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0+
+/* SPDX-License-Identifier: GPL-2.0+ */
/*
* Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
* All rights reserved.
--
2.17.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH v2 5/6] Staging: vt6655: Fix the warning line over 80 characters
2019-03-05 22:48 ` [PATCH v2 0/6] Modify checkpatch.pl issues Madhumitha Prabakaran
` (3 preceding siblings ...)
2019-03-05 22:48 ` [PATCH v2 4/6] Staging: vt6655: mac.h: Fix comment style for SPDX-License Identifier Madhumitha Prabakaran
@ 2019-03-05 22:48 ` Madhumitha Prabakaran
2019-03-05 22:48 ` [PATCH v2 6/6] Staging: vt6655: Align function declaration Madhumitha Prabakaran
5 siblings, 0 replies; 14+ messages in thread
From: Madhumitha Prabakaran @ 2019-03-05 22:48 UTC (permalink / raw)
To: forest, gregkh, outreachy-kernel; +Cc: Madhumitha Prabakaran
Fix the checkpatch.pl warning
WARNING: line over 80 characters
Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
---
drivers/staging/vt6655/mac.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/vt6655/mac.h b/drivers/staging/vt6655/mac.h
index 8c8c26792343..99de843b4551 100644
--- a/drivers/staging/vt6655/mac.h
+++ b/drivers/staging/vt6655/mac.h
@@ -883,7 +883,8 @@ bool MACbIsRegBitsOff(struct vnt_private *priv, unsigned char byRegOfs,
bool MACbIsIntDisable(struct vnt_private *priv);
-void MACvSetShortRetryLimit(struct vnt_private *priv, unsigned char byRetryLimit);
+void MACvSetShortRetryLimit(struct vnt_private *priv,
+ unsigned char byRetryLimit);
void MACvSetLongRetryLimit(struct vnt_private *priv, unsigned char byRetryLimit);
void MACvGetLongRetryLimit(struct vnt_private *priv,
--
2.17.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH v2 6/6] Staging: vt6655: Align function declaration
2019-03-05 22:48 ` [PATCH v2 0/6] Modify checkpatch.pl issues Madhumitha Prabakaran
` (4 preceding siblings ...)
2019-03-05 22:48 ` [PATCH v2 5/6] Staging: vt6655: Fix the warning line over 80 characters Madhumitha Prabakaran
@ 2019-03-05 22:48 ` Madhumitha Prabakaran
5 siblings, 0 replies; 14+ messages in thread
From: Madhumitha Prabakaran @ 2019-03-05 22:48 UTC (permalink / raw)
To: forest, gregkh, outreachy-kernel; +Cc: Madhumitha Prabakaran
Fix function return type and function arguments to improve readbility.
Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
---
drivers/staging/vt6655/power.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/vt6655/power.c b/drivers/staging/vt6655/power.c
index d6c581b31569..9725de3bca6a 100644
--- a/drivers/staging/vt6655/power.c
+++ b/drivers/staging/vt6655/power.c
@@ -48,11 +48,8 @@
*
*/
-void
-PSvEnablePowerSaving(
- struct vnt_private *priv,
- unsigned short wListenInterval
-)
+void PSvEnablePowerSaving(struct vnt_private *priv,
+ unsigned short wListenInterval)
{
u16 wAID = priv->current_aid | BIT(14) | BIT(15);
--
2.17.1
^ permalink raw reply related [flat|nested] 14+ messages in thread