[PATCH 0/2] Staging: vt6655: Remove unused function prototype and definition

[PATCH 0/2] Staging: vt6655: Remove unused function prototype and definition

[Madhumitha Prabakaran]

This patchset remove an unused function prototype and function
definition in vt6655 driver.

Madhumitha Prabakaran (2):
  Staging: vt6655: Remove an unused function prototype
  Staging: vt6655: Remove function definition

 drivers/staging/vt6655/mac.c | 7 -------
 drivers/staging/vt6655/mac.h | 2 --
 2 files changed, 9 deletions(-)

-- 
2.17.1

[PATCH 1/2] Staging: vt6655: Remove an unused function prototype

[Madhumitha Prabakaran]

Remove an unused function prototype, as the function definition is never
used in kernel tree.

Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
---
 drivers/staging/vt6655/mac.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/vt6655/mac.h b/drivers/staging/vt6655/mac.h
index 59538ac09fc5..c7888c4e96f2 100644
--- a/drivers/staging/vt6655/mac.h
+++ b/drivers/staging/vt6655/mac.h
@@ -876,8 +876,6 @@ do {								\
 #define MACvSetRFLE_LatchBase(iobase)                                 \
 	MACvWordRegBitsOn(iobase, MAC_REG_SOFTPWRCTL, SOFTPWRCTL_RFLEOPT)
 
-bool MACbIsRegBitsOn(struct vnt_private *priv, unsigned char byRegOfs,
-		     unsigned char byTestBits);
 bool MACbIsRegBitsOff(struct vnt_private *priv, unsigned char byRegOfs,
 		      unsigned char byTestBits);
 
-- 
2.17.1

[PATCH 2/2] Staging: vt6655: Remove function definition

[Madhumitha Prabakaran]

Remove function definition as it is never called in kernel tree.

Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
---
 drivers/staging/vt6655/mac.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/staging/vt6655/mac.c b/drivers/staging/vt6655/mac.c
index 40a8f1ce837c..2f773fdf8d64 100644
--- a/drivers/staging/vt6655/mac.c
+++ b/drivers/staging/vt6655/mac.c
@@ -57,13 +57,6 @@
  * Return Value: true if all test bits On; otherwise false
  *
  */
-bool MACbIsRegBitsOn(struct vnt_private *priv, unsigned char byRegOfs,
-		     unsigned char byTestBits)
-{
-	void __iomem *io_base = priv->PortOffset;
-
-	return (ioread8(io_base + byRegOfs) & byTestBits) == byTestBits;
-}
 
 /*
  * Description:
-- 
2.17.1

Re: [Outreachy kernel] [PATCH 0/2] Staging: vt6655: Remove unused function prototype and definition

[Julia Lawall]

On Thu, 7 Mar 2019, Madhumitha Prabakaran wrote:

> This patchset remove an unused function prototype and function
> definition in vt6655 driver.
>
> Madhumitha Prabakaran (2):
>   Staging: vt6655: Remove an unused function prototype
>   Staging: vt6655: Remove function definition

Actually, the prototype and the function definition go together.  It would
be better to remove them both in one patch.

julia

>
>  drivers/staging/vt6655/mac.c | 7 -------
>  drivers/staging/vt6655/mac.h | 2 --
>  2 files changed, 9 deletions(-)
>
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/cover.1551990063.git.madhumithabiw%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>