All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
	Jamal Hadi Salim <jhs@mojatatu.com>,
	Cong Wang <xiyou.wangcong@gmail.com>,
	Jiri Pirko <jiri@resnulli.us>,
	John Fastabend <john.fastabend@gmail.com>
Subject: [PATCH net 0/2] net: sched: fix stats accounting for child NOLOCK qdiscs
Date: Thu, 28 Mar 2019 16:53:11 +0100	[thread overview]
Message-ID: <cover.1553787684.git.pabeni@redhat.com> (raw)

Currently, stats accounting for NOLOCK qdisc enslaved to classful (lock)
qdiscs is buggy. Per CPU values are ignored in most places, as a result,
stats dump in the above scenario always report 0 length backlog and parent
backlog len is not updated correctly on NOLOCK qdisc removal.

The first patch address stats dumping, and the second one child qdisc removal.
I'm targeting the net tree as this is a bugfix, but it could be moved to
net-next due to the relatively large diffstat.

Paolo Abeni (2):
  net: sched: introduce and use qstats read helpers
  net: sched: introduce and use qdisc tree flush/purge helpers

 include/net/sch_generic.h | 44 ++++++++++++++++++++++++++++++++-------
 net/sched/sch_cbq.c       | 10 ++++-----
 net/sched/sch_drr.c       | 16 ++++----------
 net/sched/sch_hfsc.c      | 19 +++++------------
 net/sched/sch_htb.c       | 22 ++++++--------------
 net/sched/sch_mq.c        |  2 +-
 net/sched/sch_mqprio.c    |  3 +--
 net/sched/sch_multiq.c    | 10 ++++-----
 net/sched/sch_prio.c      | 10 +++------
 net/sched/sch_qfq.c       | 14 ++-----------
 net/sched/sch_red.c       |  3 +--
 net/sched/sch_sfb.c       |  3 +--
 net/sched/sch_taprio.c    |  2 +-
 net/sched/sch_tbf.c       |  3 +--
 14 files changed, 71 insertions(+), 90 deletions(-)

-- 
2.20.1


             reply	other threads:[~2019-03-28 15:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-28 15:53 Paolo Abeni [this message]
2019-03-28 15:53 ` [PATCH net 1/2] net: sched: introduce and use qstats read helpers Paolo Abeni
2019-03-28 15:53 ` [PATCH net 2/2] net: sched: introduce and use qdisc tree flush/purge helpers Paolo Abeni
2019-04-01 21:50 ` [PATCH net 0/2] net: sched: fix stats accounting for child NOLOCK qdiscs David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1553787684.git.pabeni@redhat.com \
    --to=pabeni@redhat.com \
    --cc=davem@davemloft.net \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=john.fastabend@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.