From: "Pavel Begunkov (Silence)" <asml.silence@gmail.com>
To: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
josef@toxicpanda.com, dennis@kernel.org
Cc: Pavel Begunkov <asml.silence@gmail.com>
Subject: [PATCH 0/2] Fix misuse of blk_rq_stats in blk-iolatency
Date: Fri, 14 Jun 2019 14:44:11 +0300 [thread overview]
Message-ID: <cover.1560510935.git.asml.silence@gmail.com> (raw)
From: Pavel Begunkov <asml.silence@gmail.com>
There are implicit assumptions about struct blk_rq_stats, which make
it's very easy to misuse. The first patch fixes consequences, and the
second employs type-system to prevent recurrences.
Pavel Begunkov (2):
blk-iolatency: Fix zero mean in previous stats
blk-stats: Introduce explicit stat staging buffers
block/blk-iolatency.c | 60 ++++++++++++++++++++++++++++++---------
block/blk-stat.c | 48 +++++++++++++++++++++++--------
block/blk-stat.h | 9 ++++--
include/linux/blk_types.h | 6 ++++
4 files changed, 94 insertions(+), 29 deletions(-)
--
2.22.0
WARNING: multiple messages have this Message-ID (diff)
From: "Pavel Begunkov (Silence)" <asml.silence@gmail.com>
To: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
josef@toxicpanda.com
Cc: Pavel Begunkov <asml.silence@gmail.com>
Subject: [RESEND RFC PATCH 0/2] Fix misuse of blk_rq_stats in blk-iolatency
Date: Thu, 25 Jul 2019 00:35:08 +0300 [thread overview]
Message-ID: <cover.1560510935.git.asml.silence@gmail.com> (raw)
Message-ID: <20190724213508.ZT6fZWY1D5Z11rlPjdv3PiP7ca3Bv7uLRd5XzBstCKQ@z> (raw)
From: Pavel Begunkov <asml.silence@gmail.com>
There are implicit assumptions about struct blk_rq_stats, which make
it's very easy to misuse. The first patch fixes consequences, and the
second employs type-system to prevent recurrences.
Acked-by: Josef Bacik <josef@toxicpanda.com>
Pavel Begunkov (2):
blk-iolatency: Fix zero mean in previous stats
blk-stats: Introduce explicit stat staging buffers
block/blk-iolatency.c | 60 ++++++++++++++++++++++++++++++---------
block/blk-stat.c | 48 +++++++++++++++++++++++--------
block/blk-stat.h | 9 ++++--
include/linux/blk_types.h | 6 ++++
4 files changed, 94 insertions(+), 29 deletions(-)
--
2.22.0
next reply other threads:[~2019-06-14 11:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 11:44 Pavel Begunkov (Silence) [this message]
2019-07-24 21:35 ` [RESEND RFC PATCH 0/2] Fix misuse of blk_rq_stats in blk-iolatency Pavel Begunkov (Silence)
2019-06-14 11:47 ` [PATCH 1/2] blk-iolatency: Fix zero mean in previous stats Pavel Begunkov (Silence)
2019-07-24 21:35 ` [RESEND RFC PATCH " Pavel Begunkov (Silence)
2019-06-14 11:47 ` [PATCH 2/2] blk-stats: Introduce explicit stat staging buffers Pavel Begunkov (Silence)
2019-07-24 21:35 ` [RESEND RFC PATCH " Pavel Begunkov (Silence)
2019-06-14 13:40 ` [PATCH 0/2] Fix misuse of blk_rq_stats in blk-iolatency Josef Bacik
2019-06-20 17:18 ` Pavel Begunkov
2019-06-29 15:37 ` Pavel Begunkov
2019-07-11 1:17 ` Pavel Begunkov
2019-09-30 8:29 ` [RESEND RFC PATCH " Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1560510935.git.asml.silence@gmail.com \
--to=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=dennis@kernel.org \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.