* [PATCH 0/2] imx: Fix typo in iMQ8MQ reset names @ 2019-07-31 16:43 ` Guido Günther 0 siblings, 0 replies; 10+ messages in thread From: Guido Günther @ 2019-07-31 16:43 UTC (permalink / raw) To: Philipp Zabel, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team, Rob Herring, Mark Rutland, linux-arm-kernel, linux-kernel, devicetree Some of the mipi dsi resets were called IMX8MQ_RESET_MIPI_DIS_ instead of IMX8MQ_RESET_MIPI_DSI_ Since they're DSI related this looks like a typo. Guido Günther (2): dt-bindings: reset: Fix typo in imx8mq resets reset: imx7: Fix IMX8MQ_RESET_MIPI_DSI_ defines drivers/reset/reset-imx7.c | 12 ++++++------ include/dt-bindings/reset/imx8mq-reset.h | 6 +++--- 2 files changed, 9 insertions(+), 9 deletions(-) -- 2.20.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 0/2] imx: Fix typo in iMQ8MQ reset names @ 2019-07-31 16:43 ` Guido Günther 0 siblings, 0 replies; 10+ messages in thread From: Guido Günther @ 2019-07-31 16:43 UTC (permalink / raw) To: Philipp Zabel, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team, Rob Herring, Mark Rutland, linux-arm-kernel, linux-kernel, devicetree Some of the mipi dsi resets were called IMX8MQ_RESET_MIPI_DIS_ instead of IMX8MQ_RESET_MIPI_DSI_ Since they're DSI related this looks like a typo. Guido Günther (2): dt-bindings: reset: Fix typo in imx8mq resets reset: imx7: Fix IMX8MQ_RESET_MIPI_DSI_ defines drivers/reset/reset-imx7.c | 12 ++++++------ include/dt-bindings/reset/imx8mq-reset.h | 6 +++--- 2 files changed, 9 insertions(+), 9 deletions(-) -- 2.20.1 ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/2] dt-bindings: reset: Fix typo in imx8mq resets 2019-07-31 16:43 ` Guido Günther @ 2019-07-31 16:43 ` Guido Günther -1 siblings, 0 replies; 10+ messages in thread From: Guido Günther @ 2019-07-31 16:43 UTC (permalink / raw) To: Philipp Zabel, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team, Rob Herring, Mark Rutland, linux-arm-kernel, linux-kernel, devicetree Some of the mipi dsi resets were called IMX8MQ_RESET_MIPI_DIS__ instead of IMX8MQ_RESET_MIPI_DSI__ Since they're DSI related this looks like a typo. Signed-off-by: Guido Günther <agx@sigxcpu.org> --- include/dt-bindings/reset/imx8mq-reset.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/dt-bindings/reset/imx8mq-reset.h b/include/dt-bindings/reset/imx8mq-reset.h index 57c592498aa0..bfa41b0e24f6 100644 --- a/include/dt-bindings/reset/imx8mq-reset.h +++ b/include/dt-bindings/reset/imx8mq-reset.h @@ -31,9 +31,9 @@ #define IMX8MQ_RESET_OTG2_PHY_RESET 20 #define IMX8MQ_RESET_MIPI_DSI_RESET_BYTE_N 21 #define IMX8MQ_RESET_MIPI_DSI_RESET_N 22 -#define IMX8MQ_RESET_MIPI_DIS_DPI_RESET_N 23 -#define IMX8MQ_RESET_MIPI_DIS_ESC_RESET_N 24 -#define IMX8MQ_RESET_MIPI_DIS_PCLK_RESET_N 25 +#define IMX8MQ_RESET_MIPI_DSI_DPI_RESET_N 23 +#define IMX8MQ_RESET_MIPI_DSI_ESC_RESET_N 24 +#define IMX8MQ_RESET_MIPI_DSI_PCLK_RESET_N 25 #define IMX8MQ_RESET_PCIEPHY 26 #define IMX8MQ_RESET_PCIEPHY_PERST 27 #define IMX8MQ_RESET_PCIE_CTRL_APPS_EN 28 -- 2.20.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 1/2] dt-bindings: reset: Fix typo in imx8mq resets @ 2019-07-31 16:43 ` Guido Günther 0 siblings, 0 replies; 10+ messages in thread From: Guido Günther @ 2019-07-31 16:43 UTC (permalink / raw) To: Philipp Zabel, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team, Rob Herring, Mark Rutland, linux-arm-kernel, linux-kernel, devicetree Some of the mipi dsi resets were called IMX8MQ_RESET_MIPI_DIS__ instead of IMX8MQ_RESET_MIPI_DSI__ Since they're DSI related this looks like a typo. Signed-off-by: Guido Günther <agx@sigxcpu.org> --- include/dt-bindings/reset/imx8mq-reset.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/dt-bindings/reset/imx8mq-reset.h b/include/dt-bindings/reset/imx8mq-reset.h index 57c592498aa0..bfa41b0e24f6 100644 --- a/include/dt-bindings/reset/imx8mq-reset.h +++ b/include/dt-bindings/reset/imx8mq-reset.h @@ -31,9 +31,9 @@ #define IMX8MQ_RESET_OTG2_PHY_RESET 20 #define IMX8MQ_RESET_MIPI_DSI_RESET_BYTE_N 21 #define IMX8MQ_RESET_MIPI_DSI_RESET_N 22 -#define IMX8MQ_RESET_MIPI_DIS_DPI_RESET_N 23 -#define IMX8MQ_RESET_MIPI_DIS_ESC_RESET_N 24 -#define IMX8MQ_RESET_MIPI_DIS_PCLK_RESET_N 25 +#define IMX8MQ_RESET_MIPI_DSI_DPI_RESET_N 23 +#define IMX8MQ_RESET_MIPI_DSI_ESC_RESET_N 24 +#define IMX8MQ_RESET_MIPI_DSI_PCLK_RESET_N 25 #define IMX8MQ_RESET_PCIEPHY 26 #define IMX8MQ_RESET_PCIEPHY_PERST 27 #define IMX8MQ_RESET_PCIE_CTRL_APPS_EN 28 -- 2.20.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 2/2] reset: imx7: Fix IMX8MQ_RESET_MIPI_DSI_ defines 2019-07-31 16:43 ` Guido Günther @ 2019-07-31 16:43 ` Guido Günther -1 siblings, 0 replies; 10+ messages in thread From: Guido Günther @ 2019-07-31 16:43 UTC (permalink / raw) To: Philipp Zabel, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team, Rob Herring, Mark Rutland, linux-arm-kernel, linux-kernel, devicetree Some of the mipi dsi resets were called IMX8MQ_RESET_MIPI_DIS_ instead of IMX8MQ_RESET_MIPI_DSI_ Since they're DSI related this looks like a typo. I wasn't sure if this should be a single patch since it otherwise breaks bisectability. I couldn't find any device trees using this yet. Signed-off-by: Guido Günther <agx@sigxcpu.org> --- drivers/reset/reset-imx7.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/reset/reset-imx7.c b/drivers/reset/reset-imx7.c index 3ecd770f910b..1443a55a0c29 100644 --- a/drivers/reset/reset-imx7.c +++ b/drivers/reset/reset-imx7.c @@ -169,9 +169,9 @@ static const struct imx7_src_signal imx8mq_src_signals[IMX8MQ_RESET_NUM] = { [IMX8MQ_RESET_OTG2_PHY_RESET] = { SRC_USBOPHY2_RCR, BIT(0) }, [IMX8MQ_RESET_MIPI_DSI_RESET_BYTE_N] = { SRC_MIPIPHY_RCR, BIT(1) }, [IMX8MQ_RESET_MIPI_DSI_RESET_N] = { SRC_MIPIPHY_RCR, BIT(2) }, - [IMX8MQ_RESET_MIPI_DIS_DPI_RESET_N] = { SRC_MIPIPHY_RCR, BIT(3) }, - [IMX8MQ_RESET_MIPI_DIS_ESC_RESET_N] = { SRC_MIPIPHY_RCR, BIT(4) }, - [IMX8MQ_RESET_MIPI_DIS_PCLK_RESET_N] = { SRC_MIPIPHY_RCR, BIT(5) }, + [IMX8MQ_RESET_MIPI_DSI_DPI_RESET_N] = { SRC_MIPIPHY_RCR, BIT(3) }, + [IMX8MQ_RESET_MIPI_DSI_ESC_RESET_N] = { SRC_MIPIPHY_RCR, BIT(4) }, + [IMX8MQ_RESET_MIPI_DSI_PCLK_RESET_N] = { SRC_MIPIPHY_RCR, BIT(5) }, [IMX8MQ_RESET_PCIEPHY] = { SRC_PCIEPHY_RCR, BIT(2) | BIT(1) }, [IMX8MQ_RESET_PCIEPHY_PERST] = { SRC_PCIEPHY_RCR, BIT(3) }, @@ -220,9 +220,9 @@ static int imx8mq_reset_set(struct reset_controller_dev *rcdev, case IMX8MQ_RESET_PCIE_CTRL_APPS_EN: case IMX8MQ_RESET_PCIE2_CTRL_APPS_EN: /* fallthrough */ - case IMX8MQ_RESET_MIPI_DIS_PCLK_RESET_N: /* fallthrough */ - case IMX8MQ_RESET_MIPI_DIS_ESC_RESET_N: /* fallthrough */ - case IMX8MQ_RESET_MIPI_DIS_DPI_RESET_N: /* fallthrough */ + case IMX8MQ_RESET_MIPI_DSI_PCLK_RESET_N: /* fallthrough */ + case IMX8MQ_RESET_MIPI_DSI_ESC_RESET_N: /* fallthrough */ + case IMX8MQ_RESET_MIPI_DSI_DPI_RESET_N: /* fallthrough */ case IMX8MQ_RESET_MIPI_DSI_RESET_N: /* fallthrough */ case IMX8MQ_RESET_MIPI_DSI_RESET_BYTE_N: /* fallthrough */ value = assert ? 0 : bit; -- 2.20.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 2/2] reset: imx7: Fix IMX8MQ_RESET_MIPI_DSI_ defines @ 2019-07-31 16:43 ` Guido Günther 0 siblings, 0 replies; 10+ messages in thread From: Guido Günther @ 2019-07-31 16:43 UTC (permalink / raw) To: Philipp Zabel, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team, Rob Herring, Mark Rutland, linux-arm-kernel, linux-kernel, devicetree Some of the mipi dsi resets were called IMX8MQ_RESET_MIPI_DIS_ instead of IMX8MQ_RESET_MIPI_DSI_ Since they're DSI related this looks like a typo. I wasn't sure if this should be a single patch since it otherwise breaks bisectability. I couldn't find any device trees using this yet. Signed-off-by: Guido Günther <agx@sigxcpu.org> --- drivers/reset/reset-imx7.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/reset/reset-imx7.c b/drivers/reset/reset-imx7.c index 3ecd770f910b..1443a55a0c29 100644 --- a/drivers/reset/reset-imx7.c +++ b/drivers/reset/reset-imx7.c @@ -169,9 +169,9 @@ static const struct imx7_src_signal imx8mq_src_signals[IMX8MQ_RESET_NUM] = { [IMX8MQ_RESET_OTG2_PHY_RESET] = { SRC_USBOPHY2_RCR, BIT(0) }, [IMX8MQ_RESET_MIPI_DSI_RESET_BYTE_N] = { SRC_MIPIPHY_RCR, BIT(1) }, [IMX8MQ_RESET_MIPI_DSI_RESET_N] = { SRC_MIPIPHY_RCR, BIT(2) }, - [IMX8MQ_RESET_MIPI_DIS_DPI_RESET_N] = { SRC_MIPIPHY_RCR, BIT(3) }, - [IMX8MQ_RESET_MIPI_DIS_ESC_RESET_N] = { SRC_MIPIPHY_RCR, BIT(4) }, - [IMX8MQ_RESET_MIPI_DIS_PCLK_RESET_N] = { SRC_MIPIPHY_RCR, BIT(5) }, + [IMX8MQ_RESET_MIPI_DSI_DPI_RESET_N] = { SRC_MIPIPHY_RCR, BIT(3) }, + [IMX8MQ_RESET_MIPI_DSI_ESC_RESET_N] = { SRC_MIPIPHY_RCR, BIT(4) }, + [IMX8MQ_RESET_MIPI_DSI_PCLK_RESET_N] = { SRC_MIPIPHY_RCR, BIT(5) }, [IMX8MQ_RESET_PCIEPHY] = { SRC_PCIEPHY_RCR, BIT(2) | BIT(1) }, [IMX8MQ_RESET_PCIEPHY_PERST] = { SRC_PCIEPHY_RCR, BIT(3) }, @@ -220,9 +220,9 @@ static int imx8mq_reset_set(struct reset_controller_dev *rcdev, case IMX8MQ_RESET_PCIE_CTRL_APPS_EN: case IMX8MQ_RESET_PCIE2_CTRL_APPS_EN: /* fallthrough */ - case IMX8MQ_RESET_MIPI_DIS_PCLK_RESET_N: /* fallthrough */ - case IMX8MQ_RESET_MIPI_DIS_ESC_RESET_N: /* fallthrough */ - case IMX8MQ_RESET_MIPI_DIS_DPI_RESET_N: /* fallthrough */ + case IMX8MQ_RESET_MIPI_DSI_PCLK_RESET_N: /* fallthrough */ + case IMX8MQ_RESET_MIPI_DSI_ESC_RESET_N: /* fallthrough */ + case IMX8MQ_RESET_MIPI_DSI_DPI_RESET_N: /* fallthrough */ case IMX8MQ_RESET_MIPI_DSI_RESET_N: /* fallthrough */ case IMX8MQ_RESET_MIPI_DSI_RESET_BYTE_N: /* fallthrough */ value = assert ? 0 : bit; -- 2.20.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] reset: imx7: Fix IMX8MQ_RESET_MIPI_DSI_ defines 2019-07-31 16:43 ` Guido Günther @ 2019-07-31 16:46 ` Lucas Stach -1 siblings, 0 replies; 10+ messages in thread From: Lucas Stach @ 2019-07-31 16:46 UTC (permalink / raw) To: Guido Günther, Philipp Zabel, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team, Rob Herring, Mark Rutland, linux-arm-kernel, linux-kernel, devicetree Am Mittwoch, den 31.07.2019, 18:43 +0200 schrieb Guido Günther: > Some of the mipi dsi resets were called > > IMX8MQ_RESET_MIPI_DIS_ > > instead of > > IMX8MQ_RESET_MIPI_DSI_ > > Since they're DSI related this looks like a typo. > > I wasn't sure if this should be a single patch since it otherwise breaks > bisectability. I couldn't find any device trees using this yet. Yes, I think this should be squashed into a single commit. Other than that, the change looks correct. Regards, Lucas > Signed-off-by: Guido Günther <agx@sigxcpu.org> > --- > drivers/reset/reset-imx7.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/reset/reset-imx7.c b/drivers/reset/reset-imx7.c > index 3ecd770f910b..1443a55a0c29 100644 > --- a/drivers/reset/reset-imx7.c > +++ b/drivers/reset/reset-imx7.c > @@ -169,9 +169,9 @@ static const struct imx7_src_signal imx8mq_src_signals[IMX8MQ_RESET_NUM] = { > > > [IMX8MQ_RESET_OTG2_PHY_RESET] = { SRC_USBOPHY2_RCR, BIT(0) }, > > > [IMX8MQ_RESET_MIPI_DSI_RESET_BYTE_N] = { SRC_MIPIPHY_RCR, BIT(1) }, > > > [IMX8MQ_RESET_MIPI_DSI_RESET_N] = { SRC_MIPIPHY_RCR, BIT(2) }, > > > - [IMX8MQ_RESET_MIPI_DIS_DPI_RESET_N] = { SRC_MIPIPHY_RCR, BIT(3) }, > > > - [IMX8MQ_RESET_MIPI_DIS_ESC_RESET_N] = { SRC_MIPIPHY_RCR, BIT(4) }, > > > - [IMX8MQ_RESET_MIPI_DIS_PCLK_RESET_N] = { SRC_MIPIPHY_RCR, BIT(5) }, > > > + [IMX8MQ_RESET_MIPI_DSI_DPI_RESET_N] = { SRC_MIPIPHY_RCR, BIT(3) }, > > > + [IMX8MQ_RESET_MIPI_DSI_ESC_RESET_N] = { SRC_MIPIPHY_RCR, BIT(4) }, > > > + [IMX8MQ_RESET_MIPI_DSI_PCLK_RESET_N] = { SRC_MIPIPHY_RCR, BIT(5) }, > > > [IMX8MQ_RESET_PCIEPHY] = { SRC_PCIEPHY_RCR, > > BIT(2) | BIT(1) }, > > > [IMX8MQ_RESET_PCIEPHY_PERST] = { SRC_PCIEPHY_RCR, BIT(3) }, > @@ -220,9 +220,9 @@ static int imx8mq_reset_set(struct reset_controller_dev *rcdev, > > > case IMX8MQ_RESET_PCIE_CTRL_APPS_EN: > > > case IMX8MQ_RESET_PCIE2_CTRL_APPS_EN: /* fallthrough */ > > > - case IMX8MQ_RESET_MIPI_DIS_PCLK_RESET_N: /* fallthrough */ > > > - case IMX8MQ_RESET_MIPI_DIS_ESC_RESET_N: /* fallthrough */ > > > - case IMX8MQ_RESET_MIPI_DIS_DPI_RESET_N: /* fallthrough */ > > > + case IMX8MQ_RESET_MIPI_DSI_PCLK_RESET_N: /* fallthrough */ > > > + case IMX8MQ_RESET_MIPI_DSI_ESC_RESET_N: /* fallthrough */ > > > + case IMX8MQ_RESET_MIPI_DSI_DPI_RESET_N: /* fallthrough */ > > > case IMX8MQ_RESET_MIPI_DSI_RESET_N: /* fallthrough */ > > > case IMX8MQ_RESET_MIPI_DSI_RESET_BYTE_N: /* fallthrough */ > > value = assert ? 0 : bit; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] reset: imx7: Fix IMX8MQ_RESET_MIPI_DSI_ defines @ 2019-07-31 16:46 ` Lucas Stach 0 siblings, 0 replies; 10+ messages in thread From: Lucas Stach @ 2019-07-31 16:46 UTC (permalink / raw) To: Guido Günther, Philipp Zabel, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team, Rob Herring, Mark Rutland, linux-arm-kernel, linux-kernel, devicetree Am Mittwoch, den 31.07.2019, 18:43 +0200 schrieb Guido Günther: > Some of the mipi dsi resets were called > > IMX8MQ_RESET_MIPI_DIS_ > > instead of > > IMX8MQ_RESET_MIPI_DSI_ > > Since they're DSI related this looks like a typo. > > I wasn't sure if this should be a single patch since it otherwise breaks > bisectability. I couldn't find any device trees using this yet. Yes, I think this should be squashed into a single commit. Other than that, the change looks correct. Regards, Lucas > Signed-off-by: Guido Günther <agx@sigxcpu.org> > --- > drivers/reset/reset-imx7.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/reset/reset-imx7.c b/drivers/reset/reset-imx7.c > index 3ecd770f910b..1443a55a0c29 100644 > --- a/drivers/reset/reset-imx7.c > +++ b/drivers/reset/reset-imx7.c > @@ -169,9 +169,9 @@ static const struct imx7_src_signal imx8mq_src_signals[IMX8MQ_RESET_NUM] = { > > > [IMX8MQ_RESET_OTG2_PHY_RESET] = { SRC_USBOPHY2_RCR, BIT(0) }, > > > [IMX8MQ_RESET_MIPI_DSI_RESET_BYTE_N] = { SRC_MIPIPHY_RCR, BIT(1) }, > > > [IMX8MQ_RESET_MIPI_DSI_RESET_N] = { SRC_MIPIPHY_RCR, BIT(2) }, > > > - [IMX8MQ_RESET_MIPI_DIS_DPI_RESET_N] = { SRC_MIPIPHY_RCR, BIT(3) }, > > > - [IMX8MQ_RESET_MIPI_DIS_ESC_RESET_N] = { SRC_MIPIPHY_RCR, BIT(4) }, > > > - [IMX8MQ_RESET_MIPI_DIS_PCLK_RESET_N] = { SRC_MIPIPHY_RCR, BIT(5) }, > > > + [IMX8MQ_RESET_MIPI_DSI_DPI_RESET_N] = { SRC_MIPIPHY_RCR, BIT(3) }, > > > + [IMX8MQ_RESET_MIPI_DSI_ESC_RESET_N] = { SRC_MIPIPHY_RCR, BIT(4) }, > > > + [IMX8MQ_RESET_MIPI_DSI_PCLK_RESET_N] = { SRC_MIPIPHY_RCR, BIT(5) }, > > > [IMX8MQ_RESET_PCIEPHY] = { SRC_PCIEPHY_RCR, > > BIT(2) | BIT(1) }, > > > [IMX8MQ_RESET_PCIEPHY_PERST] = { SRC_PCIEPHY_RCR, BIT(3) }, > @@ -220,9 +220,9 @@ static int imx8mq_reset_set(struct reset_controller_dev *rcdev, > > > case IMX8MQ_RESET_PCIE_CTRL_APPS_EN: > > > case IMX8MQ_RESET_PCIE2_CTRL_APPS_EN: /* fallthrough */ > > > - case IMX8MQ_RESET_MIPI_DIS_PCLK_RESET_N: /* fallthrough */ > > > - case IMX8MQ_RESET_MIPI_DIS_ESC_RESET_N: /* fallthrough */ > > > - case IMX8MQ_RESET_MIPI_DIS_DPI_RESET_N: /* fallthrough */ > > > + case IMX8MQ_RESET_MIPI_DSI_PCLK_RESET_N: /* fallthrough */ > > > + case IMX8MQ_RESET_MIPI_DSI_ESC_RESET_N: /* fallthrough */ > > > + case IMX8MQ_RESET_MIPI_DSI_DPI_RESET_N: /* fallthrough */ > > > case IMX8MQ_RESET_MIPI_DSI_RESET_N: /* fallthrough */ > > > case IMX8MQ_RESET_MIPI_DSI_RESET_BYTE_N: /* fallthrough */ > > value = assert ? 0 : bit; ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] reset: imx7: Fix IMX8MQ_RESET_MIPI_DSI_ defines 2019-07-31 16:46 ` Lucas Stach @ 2019-08-01 8:22 ` Guido Günther -1 siblings, 0 replies; 10+ messages in thread From: Guido Günther @ 2019-08-01 8:22 UTC (permalink / raw) To: Lucas Stach Cc: Mark Rutland, devicetree, Philipp Zabel, Shawn Guo, Sascha Hauer, linux-kernel, Rob Herring, NXP Linux Team, Pengutronix Kernel Team, Fabio Estevam, linux-arm-kernel Hi Lucas, On Wed, Jul 31, 2019 at 06:46:25PM +0200, Lucas Stach wrote: > Am Mittwoch, den 31.07.2019, 18:43 +0200 schrieb Guido Günther: > > Some of the mipi dsi resets were called > > > > IMX8MQ_RESET_MIPI_DIS_ > > > > instead of > > > > IMX8MQ_RESET_MIPI_DSI_ > > > > Since they're DSI related this looks like a typo. > > > > I wasn't sure if this should be a single patch since it otherwise breaks > > bisectability. I couldn't find any device trees using this yet. > > Yes, I think this should be squashed into a single commit. Other than > that, the change looks correct. Thanks for having a look. Sent out v2 as a single patch. Cheers, -- Guido > > Regards, > Lucas > > > Signed-off-by: Guido Günther <agx@sigxcpu.org> > > --- > > drivers/reset/reset-imx7.c | 12 ++++++------ > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/reset/reset-imx7.c b/drivers/reset/reset-imx7.c > > index 3ecd770f910b..1443a55a0c29 100644 > > --- a/drivers/reset/reset-imx7.c > > +++ b/drivers/reset/reset-imx7.c > > @@ -169,9 +169,9 @@ static const struct imx7_src_signal imx8mq_src_signals[IMX8MQ_RESET_NUM] = { > > > > [IMX8MQ_RESET_OTG2_PHY_RESET] = { SRC_USBOPHY2_RCR, BIT(0) }, > > > > [IMX8MQ_RESET_MIPI_DSI_RESET_BYTE_N] = { SRC_MIPIPHY_RCR, BIT(1) }, > > > > [IMX8MQ_RESET_MIPI_DSI_RESET_N] = { SRC_MIPIPHY_RCR, BIT(2) }, > > > > - [IMX8MQ_RESET_MIPI_DIS_DPI_RESET_N] = { SRC_MIPIPHY_RCR, BIT(3) }, > > > > - [IMX8MQ_RESET_MIPI_DIS_ESC_RESET_N] = { SRC_MIPIPHY_RCR, BIT(4) }, > > > > - [IMX8MQ_RESET_MIPI_DIS_PCLK_RESET_N] = { SRC_MIPIPHY_RCR, BIT(5) }, > > > > + [IMX8MQ_RESET_MIPI_DSI_DPI_RESET_N] = { SRC_MIPIPHY_RCR, BIT(3) }, > > > > + [IMX8MQ_RESET_MIPI_DSI_ESC_RESET_N] = { SRC_MIPIPHY_RCR, BIT(4) }, > > > > + [IMX8MQ_RESET_MIPI_DSI_PCLK_RESET_N] = { SRC_MIPIPHY_RCR, BIT(5) }, > > > > [IMX8MQ_RESET_PCIEPHY] = { SRC_PCIEPHY_RCR, > > > BIT(2) | BIT(1) }, > > > > [IMX8MQ_RESET_PCIEPHY_PERST] = { SRC_PCIEPHY_RCR, BIT(3) }, > > @@ -220,9 +220,9 @@ static int imx8mq_reset_set(struct reset_controller_dev *rcdev, > > > > > case IMX8MQ_RESET_PCIE_CTRL_APPS_EN: > > > > case IMX8MQ_RESET_PCIE2_CTRL_APPS_EN: /* fallthrough */ > > > > - case IMX8MQ_RESET_MIPI_DIS_PCLK_RESET_N: /* fallthrough */ > > > > - case IMX8MQ_RESET_MIPI_DIS_ESC_RESET_N: /* fallthrough */ > > > > - case IMX8MQ_RESET_MIPI_DIS_DPI_RESET_N: /* fallthrough */ > > > > + case IMX8MQ_RESET_MIPI_DSI_PCLK_RESET_N: /* fallthrough */ > > > > + case IMX8MQ_RESET_MIPI_DSI_ESC_RESET_N: /* fallthrough */ > > > > + case IMX8MQ_RESET_MIPI_DSI_DPI_RESET_N: /* fallthrough */ > > > > case IMX8MQ_RESET_MIPI_DSI_RESET_N: /* fallthrough */ > > > > case IMX8MQ_RESET_MIPI_DSI_RESET_BYTE_N: /* fallthrough */ > > > value = assert ? 0 : bit; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] reset: imx7: Fix IMX8MQ_RESET_MIPI_DSI_ defines @ 2019-08-01 8:22 ` Guido Günther 0 siblings, 0 replies; 10+ messages in thread From: Guido Günther @ 2019-08-01 8:22 UTC (permalink / raw) To: Lucas Stach Cc: Philipp Zabel, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team, Rob Herring, Mark Rutland, linux-arm-kernel, linux-kernel, devicetree Hi Lucas, On Wed, Jul 31, 2019 at 06:46:25PM +0200, Lucas Stach wrote: > Am Mittwoch, den 31.07.2019, 18:43 +0200 schrieb Guido Günther: > > Some of the mipi dsi resets were called > > > > IMX8MQ_RESET_MIPI_DIS_ > > > > instead of > > > > IMX8MQ_RESET_MIPI_DSI_ > > > > Since they're DSI related this looks like a typo. > > > > I wasn't sure if this should be a single patch since it otherwise breaks > > bisectability. I couldn't find any device trees using this yet. > > Yes, I think this should be squashed into a single commit. Other than > that, the change looks correct. Thanks for having a look. Sent out v2 as a single patch. Cheers, -- Guido > > Regards, > Lucas > > > Signed-off-by: Guido Günther <agx@sigxcpu.org> > > --- > > drivers/reset/reset-imx7.c | 12 ++++++------ > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/reset/reset-imx7.c b/drivers/reset/reset-imx7.c > > index 3ecd770f910b..1443a55a0c29 100644 > > --- a/drivers/reset/reset-imx7.c > > +++ b/drivers/reset/reset-imx7.c > > @@ -169,9 +169,9 @@ static const struct imx7_src_signal imx8mq_src_signals[IMX8MQ_RESET_NUM] = { > > > > [IMX8MQ_RESET_OTG2_PHY_RESET] = { SRC_USBOPHY2_RCR, BIT(0) }, > > > > [IMX8MQ_RESET_MIPI_DSI_RESET_BYTE_N] = { SRC_MIPIPHY_RCR, BIT(1) }, > > > > [IMX8MQ_RESET_MIPI_DSI_RESET_N] = { SRC_MIPIPHY_RCR, BIT(2) }, > > > > - [IMX8MQ_RESET_MIPI_DIS_DPI_RESET_N] = { SRC_MIPIPHY_RCR, BIT(3) }, > > > > - [IMX8MQ_RESET_MIPI_DIS_ESC_RESET_N] = { SRC_MIPIPHY_RCR, BIT(4) }, > > > > - [IMX8MQ_RESET_MIPI_DIS_PCLK_RESET_N] = { SRC_MIPIPHY_RCR, BIT(5) }, > > > > + [IMX8MQ_RESET_MIPI_DSI_DPI_RESET_N] = { SRC_MIPIPHY_RCR, BIT(3) }, > > > > + [IMX8MQ_RESET_MIPI_DSI_ESC_RESET_N] = { SRC_MIPIPHY_RCR, BIT(4) }, > > > > + [IMX8MQ_RESET_MIPI_DSI_PCLK_RESET_N] = { SRC_MIPIPHY_RCR, BIT(5) }, > > > > [IMX8MQ_RESET_PCIEPHY] = { SRC_PCIEPHY_RCR, > > > BIT(2) | BIT(1) }, > > > > [IMX8MQ_RESET_PCIEPHY_PERST] = { SRC_PCIEPHY_RCR, BIT(3) }, > > @@ -220,9 +220,9 @@ static int imx8mq_reset_set(struct reset_controller_dev *rcdev, > > > > > case IMX8MQ_RESET_PCIE_CTRL_APPS_EN: > > > > case IMX8MQ_RESET_PCIE2_CTRL_APPS_EN: /* fallthrough */ > > > > - case IMX8MQ_RESET_MIPI_DIS_PCLK_RESET_N: /* fallthrough */ > > > > - case IMX8MQ_RESET_MIPI_DIS_ESC_RESET_N: /* fallthrough */ > > > > - case IMX8MQ_RESET_MIPI_DIS_DPI_RESET_N: /* fallthrough */ > > > > + case IMX8MQ_RESET_MIPI_DSI_PCLK_RESET_N: /* fallthrough */ > > > > + case IMX8MQ_RESET_MIPI_DSI_ESC_RESET_N: /* fallthrough */ > > > > + case IMX8MQ_RESET_MIPI_DSI_DPI_RESET_N: /* fallthrough */ > > > > case IMX8MQ_RESET_MIPI_DSI_RESET_N: /* fallthrough */ > > > > case IMX8MQ_RESET_MIPI_DSI_RESET_BYTE_N: /* fallthrough */ > > > value = assert ? 0 : bit; > ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2019-08-01 8:29 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-07-31 16:43 [PATCH 0/2] imx: Fix typo in iMQ8MQ reset names Guido Günther 2019-07-31 16:43 ` Guido Günther 2019-07-31 16:43 ` [PATCH 1/2] dt-bindings: reset: Fix typo in imx8mq resets Guido Günther 2019-07-31 16:43 ` Guido Günther 2019-07-31 16:43 ` [PATCH 2/2] reset: imx7: Fix IMX8MQ_RESET_MIPI_DSI_ defines Guido Günther 2019-07-31 16:43 ` Guido Günther 2019-07-31 16:46 ` Lucas Stach 2019-07-31 16:46 ` Lucas Stach 2019-08-01 8:22 ` Guido Günther 2019-08-01 8:22 ` Guido Günther
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.