From: Leonard Crestez <leonard.crestez@nxp.com>
To: Stephen Boyd <sboyd@kernel.org>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Rob Herring <robh+dt@kernel.org>
Cc: "Shawn Guo" <shawnguo@kernel.org>,
"Michael Turquette" <mturquette@baylibre.com>,
"Chanwoo Choi" <cw00.choi@samsung.com>,
"Artur Świgoń" <a.swigon@partner.samsung.com>,
"Saravana Kannan" <saravanak@google.com>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Alexandre Bailon" <abailon@baylibre.com>,
"Georgi Djakov" <georgi.djakov@linaro.org>,
"Dong Aisheng" <aisheng.dong@nxp.com>,
"Abel Vesa" <abel.vesa@nxp.com>, "Jacky Bai" <ping.bai@nxp.com>,
"Anson Huang" <Anson.Huang@nxp.com>,
"Fabio Estevam" <fabio.estevam@nxp.com>,
"Viresh Kumar" <viresh.kumar@linaro.org>,
"Will Deacon" <will@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-pm@vger.kernel.org,
linux-imx@nxp.com, kernel@pengutronix.de,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/7] PM / devfreq: Add initial imx support
Date: Mon, 12 Aug 2019 21:49:44 +0300 [thread overview]
Message-ID: <cover.1565633880.git.leonard.crestez@nxp.com> (raw)
This adds devfreq support for imx8mm, covering dynamic scaling of
internal NOC and DDR Controller
Scaling for simple busses (NIC/NOC) is done through the clk framework
while DRAM scaling is performed in firmware with an "imx-ddrc" wrapper
for devfreq.
Changes since RFCv3:
* Implement passive support and set NOC parent to DDRC
* Drop scaling AHB/AXI for now (NOC/DDRC use most power anyway)
* Split into two devreq drivers (and bindings) because the ddrc is
really a distinct piece of hardware.
* Stop relying on clk_min_rate
* Fetch info about dram clk parents from firmware instead of
hardcoding in driver. This can more easily support additional rates.
* Perform DRAM frequency inside devfreq instead of clk, mostly due to
objections to earlier RFCs for "imx8m-dram-clk"
* Link: https://patchwork.kernel.org/cover/11056779/
* Link: https://patchwork.kernel.org/patch/11049429/
Stephen: It would be very helpful if you could comment on the dram
frequency switching code. I moved it outside of clk but now I have to
use provider APIs outside of drivers/clk for parent manipulation. Few
other drivers do that so maybe it's OK?
Scaling buses can cause problems for devices with realtime bandwith
requirements such as display, the intention is to use the interconnect
framework to make DEV_PM_QOS_MIN_FREQUENCY to devfreq. There are
separate patches for that:
* https://patchwork.kernel.org/patch/11084279/
* https://patchwork.kernel.org/cover/11078671/
Leonard Crestez (7):
clk: imx8m: Set CLK_GET_RATE_NOCACHE on dram_alt/apb
dt-bindings: devfreq: Add bindings for generic imx buses
PM / devfreq: Add generic imx bus driver
dt-bindings: devfreq: Add bindings for imx ddr controller
PM / devfreq: Add dynamic scaling for imx ddr controller
PM / devfreq: imx-ddrc: Measure bandwidth with perf
arm64: dts: imx8mm: Add devfreq nodes
.../devicetree/bindings/devfreq/imx-ddrc.yaml | 53 ++
.../devicetree/bindings/devfreq/imx.yaml | 50 ++
arch/arm64/boot/dts/freescale/imx8mm.dtsi | 51 +-
drivers/clk/imx/clk-imx8mm.c | 6 +-
drivers/clk/imx/clk-imx8mn.c | 6 +-
drivers/clk/imx/clk-imx8mq.c | 7 +-
drivers/devfreq/Kconfig | 12 +
drivers/devfreq/Makefile | 1 +
drivers/devfreq/imx-ddrc.c | 511 ++++++++++++++++++
drivers/devfreq/imx-devfreq.c | 148 +++++
10 files changed, 837 insertions(+), 8 deletions(-)
create mode 100644 Documentation/devicetree/bindings/devfreq/imx-ddrc.yaml
create mode 100644 Documentation/devicetree/bindings/devfreq/imx.yaml
create mode 100644 drivers/devfreq/imx-ddrc.c
create mode 100644 drivers/devfreq/imx-devfreq.c
--
2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Leonard Crestez <leonard.crestez@nxp.com>
To: Stephen Boyd <sboyd@kernel.org>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Rob Herring <robh+dt@kernel.org>
Cc: "Dong Aisheng" <aisheng.dong@nxp.com>,
"Artur Świgoń" <a.swigon@partner.samsung.com>,
"Abel Vesa" <abel.vesa@nxp.com>,
"Saravana Kannan" <saravanak@google.com>,
"Anson Huang" <Anson.Huang@nxp.com>,
linux-arm-kernel@lists.infradead.org,
"Viresh Kumar" <viresh.kumar@linaro.org>,
"Michael Turquette" <mturquette@baylibre.com>,
linux-pm@vger.kernel.org, linux-imx@nxp.com,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Chanwoo Choi" <cw00.choi@samsung.com>,
"Will Deacon" <will@kernel.org>,
"Alexandre Bailon" <abailon@baylibre.com>,
kernel@pengutronix.de, "Fabio Estevam" <fabio.estevam@nxp.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Shawn Guo" <shawnguo@kernel.org>,
"Georgi Djakov" <georgi.djakov@linaro.org>,
devicetree@vger.kernel.org, "Jacky Bai" <ping.bai@nxp.com>
Subject: [PATCH 0/7] PM / devfreq: Add initial imx support
Date: Mon, 12 Aug 2019 21:49:44 +0300 [thread overview]
Message-ID: <cover.1565633880.git.leonard.crestez@nxp.com> (raw)
This adds devfreq support for imx8mm, covering dynamic scaling of
internal NOC and DDR Controller
Scaling for simple busses (NIC/NOC) is done through the clk framework
while DRAM scaling is performed in firmware with an "imx-ddrc" wrapper
for devfreq.
Changes since RFCv3:
* Implement passive support and set NOC parent to DDRC
* Drop scaling AHB/AXI for now (NOC/DDRC use most power anyway)
* Split into two devreq drivers (and bindings) because the ddrc is
really a distinct piece of hardware.
* Stop relying on clk_min_rate
* Fetch info about dram clk parents from firmware instead of
hardcoding in driver. This can more easily support additional rates.
* Perform DRAM frequency inside devfreq instead of clk, mostly due to
objections to earlier RFCs for "imx8m-dram-clk"
* Link: https://patchwork.kernel.org/cover/11056779/
* Link: https://patchwork.kernel.org/patch/11049429/
Stephen: It would be very helpful if you could comment on the dram
frequency switching code. I moved it outside of clk but now I have to
use provider APIs outside of drivers/clk for parent manipulation. Few
other drivers do that so maybe it's OK?
Scaling buses can cause problems for devices with realtime bandwith
requirements such as display, the intention is to use the interconnect
framework to make DEV_PM_QOS_MIN_FREQUENCY to devfreq. There are
separate patches for that:
* https://patchwork.kernel.org/patch/11084279/
* https://patchwork.kernel.org/cover/11078671/
Leonard Crestez (7):
clk: imx8m: Set CLK_GET_RATE_NOCACHE on dram_alt/apb
dt-bindings: devfreq: Add bindings for generic imx buses
PM / devfreq: Add generic imx bus driver
dt-bindings: devfreq: Add bindings for imx ddr controller
PM / devfreq: Add dynamic scaling for imx ddr controller
PM / devfreq: imx-ddrc: Measure bandwidth with perf
arm64: dts: imx8mm: Add devfreq nodes
.../devicetree/bindings/devfreq/imx-ddrc.yaml | 53 ++
.../devicetree/bindings/devfreq/imx.yaml | 50 ++
arch/arm64/boot/dts/freescale/imx8mm.dtsi | 51 +-
drivers/clk/imx/clk-imx8mm.c | 6 +-
drivers/clk/imx/clk-imx8mn.c | 6 +-
drivers/clk/imx/clk-imx8mq.c | 7 +-
drivers/devfreq/Kconfig | 12 +
drivers/devfreq/Makefile | 1 +
drivers/devfreq/imx-ddrc.c | 511 ++++++++++++++++++
drivers/devfreq/imx-devfreq.c | 148 +++++
10 files changed, 837 insertions(+), 8 deletions(-)
create mode 100644 Documentation/devicetree/bindings/devfreq/imx-ddrc.yaml
create mode 100644 Documentation/devicetree/bindings/devfreq/imx.yaml
create mode 100644 drivers/devfreq/imx-ddrc.c
create mode 100644 drivers/devfreq/imx-devfreq.c
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Leonard Crestez <leonard.crestez@nxp.com>
To: Stephen Boyd <sboyd@kernel.org>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Rob Herring <robh+dt@kernel.org>
Cc: "Dong Aisheng" <aisheng.dong@nxp.com>,
"Artur Świgoń" <a.swigon@partner.samsung.com>,
"Abel Vesa" <abel.vesa@nxp.com>,
"Saravana Kannan" <saravanak@google.com>,
"Anson Huang" <Anson.Huang@nxp.com>,
linux-arm-kernel@lists.infradead.org,
"Viresh Kumar" <viresh.kumar@linaro.org>,
"Michael Turquette" <mturquette@baylibre.com>,
linux-pm@vger.kernel.org, linux-imx@nxp.com,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Chanwoo Choi" <cw00.choi@samsung.com>,
"Will Deacon" <will@kernel.org>,
"Alexandre Bailon" <abailon@baylibre.com>,
kernel@pengutronix.de, "Fabio Estevam" <fabio.estevam@nxp.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Shawn Guo" <shawnguo@kernel.org>,
"Georgi Djakov" <georgi.djakov@linaro.org>,
devicetree@vger.kernel.org, "Jacky Bai" <ping.bai@nxp.com>
Subject: [PATCH 0/7] PM / devfreq: Add initial imx support
Date: Mon, 12 Aug 2019 21:49:44 +0300 [thread overview]
Message-ID: <cover.1565633880.git.leonard.crestez@nxp.com> (raw)
This adds devfreq support for imx8mm, covering dynamic scaling of
internal NOC and DDR Controller
Scaling for simple busses (NIC/NOC) is done through the clk framework
while DRAM scaling is performed in firmware with an "imx-ddrc" wrapper
for devfreq.
Changes since RFCv3:
* Implement passive support and set NOC parent to DDRC
* Drop scaling AHB/AXI for now (NOC/DDRC use most power anyway)
* Split into two devreq drivers (and bindings) because the ddrc is
really a distinct piece of hardware.
* Stop relying on clk_min_rate
* Fetch info about dram clk parents from firmware instead of
hardcoding in driver. This can more easily support additional rates.
* Perform DRAM frequency inside devfreq instead of clk, mostly due to
objections to earlier RFCs for "imx8m-dram-clk"
* Link: https://patchwork.kernel.org/cover/11056779/
* Link: https://patchwork.kernel.org/patch/11049429/
Stephen: It would be very helpful if you could comment on the dram
frequency switching code. I moved it outside of clk but now I have to
use provider APIs outside of drivers/clk for parent manipulation. Few
other drivers do that so maybe it's OK?
Scaling buses can cause problems for devices with realtime bandwith
requirements such as display, the intention is to use the interconnect
framework to make DEV_PM_QOS_MIN_FREQUENCY to devfreq. There are
separate patches for that:
* https://patchwork.kernel.org/patch/11084279/
* https://patchwork.kernel.org/cover/11078671/
Leonard Crestez (7):
clk: imx8m: Set CLK_GET_RATE_NOCACHE on dram_alt/apb
dt-bindings: devfreq: Add bindings for generic imx buses
PM / devfreq: Add generic imx bus driver
dt-bindings: devfreq: Add bindings for imx ddr controller
PM / devfreq: Add dynamic scaling for imx ddr controller
PM / devfreq: imx-ddrc: Measure bandwidth with perf
arm64: dts: imx8mm: Add devfreq nodes
.../devicetree/bindings/devfreq/imx-ddrc.yaml | 53 ++
.../devicetree/bindings/devfreq/imx.yaml | 50 ++
arch/arm64/boot/dts/freescale/imx8mm.dtsi | 51 +-
drivers/clk/imx/clk-imx8mm.c | 6 +-
drivers/clk/imx/clk-imx8mn.c | 6 +-
drivers/clk/imx/clk-imx8mq.c | 7 +-
drivers/devfreq/Kconfig | 12 +
drivers/devfreq/Makefile | 1 +
drivers/devfreq/imx-ddrc.c | 511 ++++++++++++++++++
drivers/devfreq/imx-devfreq.c | 148 +++++
10 files changed, 837 insertions(+), 8 deletions(-)
create mode 100644 Documentation/devicetree/bindings/devfreq/imx-ddrc.yaml
create mode 100644 Documentation/devicetree/bindings/devfreq/imx.yaml
create mode 100644 drivers/devfreq/imx-ddrc.c
create mode 100644 drivers/devfreq/imx-devfreq.c
--
2.17.1
next reply other threads:[~2019-08-12 18:49 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 18:49 Leonard Crestez [this message]
2019-08-12 18:49 ` [PATCH 0/7] PM / devfreq: Add initial imx support Leonard Crestez
2019-08-12 18:49 ` Leonard Crestez
2019-08-12 18:49 ` [PATCH 1/7] clk: imx8m: Set CLK_GET_RATE_NOCACHE on dram_alt/apb Leonard Crestez
2019-08-12 18:49 ` Leonard Crestez
2019-08-12 18:49 ` Leonard Crestez
2019-08-12 18:49 ` [PATCH 2/7] dt-bindings: devfreq: Add bindings for generic imx buses Leonard Crestez
2019-08-12 18:49 ` Leonard Crestez
2019-08-12 18:49 ` Leonard Crestez
2019-08-12 19:46 ` Rob Herring
2019-08-12 19:46 ` Rob Herring
2019-08-12 19:46 ` Rob Herring
2019-08-13 1:32 ` Leonard Crestez
2019-08-13 1:32 ` Leonard Crestez
2019-08-13 1:32 ` Leonard Crestez
2019-08-13 14:06 ` Rob Herring
2019-08-13 14:06 ` Rob Herring
2019-08-13 14:06 ` Rob Herring
2019-08-13 14:59 ` Leonard Crestez
2019-08-13 14:59 ` Leonard Crestez
2019-08-13 14:59 ` Leonard Crestez
2019-08-13 2:25 ` MyungJoo Ham
2019-08-13 2:25 ` MyungJoo Ham
2019-08-13 2:25 ` MyungJoo Ham
2019-08-12 18:49 ` [PATCH 3/7] PM / devfreq: Add generic imx bus driver Leonard Crestez
2019-08-12 18:49 ` Leonard Crestez
2019-08-12 18:49 ` Leonard Crestez
2019-08-13 2:33 ` MyungJoo Ham
2019-08-13 2:33 ` MyungJoo Ham
2019-08-13 2:33 ` MyungJoo Ham
2019-08-13 3:02 ` Leonard Crestez
2019-08-13 3:02 ` Leonard Crestez
2019-08-13 3:02 ` Leonard Crestez
2019-08-12 18:49 ` [PATCH 4/7] dt-bindings: devfreq: Add bindings for imx ddr controller Leonard Crestez
2019-08-12 18:49 ` Leonard Crestez
2019-08-12 18:49 ` Leonard Crestez
2019-08-12 19:51 ` Rob Herring
2019-08-12 19:51 ` Rob Herring
2019-08-12 19:51 ` Rob Herring
2019-08-12 18:49 ` [PATCH 5/7] PM / devfreq: Add dynamic scaling " Leonard Crestez
2019-08-12 18:49 ` Leonard Crestez
2019-08-12 18:49 ` Leonard Crestez
2019-08-12 18:49 ` [PATCH 6/7] PM / devfreq: imx-ddrc: Measure bandwidth with perf Leonard Crestez
2019-08-12 18:49 ` Leonard Crestez
2019-08-12 18:49 ` Leonard Crestez
2019-08-12 18:49 ` [PATCH 7/7] arm64: dts: imx8mm: Add devfreq nodes Leonard Crestez
2019-08-12 18:49 ` Leonard Crestez
2019-08-12 18:49 ` Leonard Crestez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1565633880.git.leonard.crestez@nxp.com \
--to=leonard.crestez@nxp.com \
--cc=Anson.Huang@nxp.com \
--cc=a.swigon@partner.samsung.com \
--cc=abailon@baylibre.com \
--cc=abel.vesa@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=georgi.djakov@linaro.org \
--cc=kernel@pengutronix.de \
--cc=krzk@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=myungjoo.ham@samsung.com \
--cc=ping.bai@nxp.com \
--cc=robh+dt@kernel.org \
--cc=saravanak@google.com \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=viresh.kumar@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.