[MPTCP] [PATCH v2 0/2] mptcp: partial recvmsg() refactor

[MPTCP] [PATCH v2 0/2] mptcp: partial recvmsg() refactor

[Paolo Abeni]

[-- Attachment #1: Type: text/plain, Size: 813 bytes --]

This 2 patches start the recvmsg() refactor discussed in last mtg.
The explicit 'duplicate data' handling in 1/2 fix some stream corruption I
observe with re-injection, and the 2nd one fix another stream corruption at
the end of the stream, still triggered  by re-injection.

With the above 2 patches I still stream corruptions with re-injection, are
almost gone - even if I can still hit them with in at least a very rare corner
case.

Only minor changes since v1, to address Mat's feedback, details in the
individual changelog

Paolo Abeni (2):
  mptcp: refactor recvmsg()
  mptcp: recvmsg() should really try to deliver 'len' bytes to
    user-space

 net/mptcp/protocol.c | 120 +++++++++++++++++++------------------------
 1 file changed, 54 insertions(+), 66 deletions(-)

-- 
2.21.0

Re: [MPTCP] [PATCH v2 0/2] mptcp: partial recvmsg() refactor

[Mat Martineau]

[-- Attachment #1: Type: text/plain, Size: 964 bytes --]

On Wed, 18 Sep 2019, Paolo Abeni wrote:

> This 2 patches start the recvmsg() refactor discussed in last mtg.
> The explicit 'duplicate data' handling in 1/2 fix some stream corruption I
> observe with re-injection, and the 2nd one fix another stream corruption at
> the end of the stream, still triggered  by re-injection.
>
> With the above 2 patches I still stream corruptions with re-injection, are
> almost gone - even if I can still hit them with in at least a very rare corner
> case.
>
> Only minor changes since v1, to address Mat's feedback, details in the
> individual changelog
>
> Paolo Abeni (2):
>  mptcp: refactor recvmsg()
>  mptcp: recvmsg() should really try to deliver 'len' bytes to
>    user-space
>
> net/mptcp/protocol.c | 120 +++++++++++++++++++------------------------
> 1 file changed, 54 insertions(+), 66 deletions(-)
>
> -- 
> 2.21.0

Thanks for the v2. These look good to merge.

--
Mat Martineau
Intel

Re: [MPTCP] [PATCH v2 0/2] mptcp: partial recvmsg() refactor

[Matthieu Baerts]

[-- Attachment #1: Type: text/plain, Size: 1695 bytes --]

Hi Paolo, Mat,

On 19/09/2019 00:42, Mat Martineau wrote:
> On Wed, 18 Sep 2019, Paolo Abeni wrote:
> 
>> This 2 patches start the recvmsg() refactor discussed in last mtg.
>> The explicit 'duplicate data' handling in 1/2 fix some stream
>> corruption I
>> observe with re-injection, and the 2nd one fix another stream
>> corruption at
>> the end of the stream, still triggered  by re-injection.
>>
>> With the above 2 patches I still stream corruptions with re-injection,
>> are
>> almost gone - even if I can still hit them with in at least a very
>> rare corner
>> case.
>>
>> Only minor changes since v1, to address Mat's feedback, details in the
>> individual changelog
>>
>> Paolo Abeni (2):
>>  mptcp: refactor recvmsg()
>>  mptcp: recvmsg() should really try to deliver 'len' bytes to
>>    user-space
>>
>> net/mptcp/protocol.c | 120 +++++++++++++++++++------------------------
>> 1 file changed, 54 insertions(+), 66 deletions(-)
>>
>> -- 
>> 2.21.0
> 
> Thanks for the v2. These look good to merge.

Thank you for the patches and the reviews!

- ae3e015a67e3: "squashed" the first one in "mptcp: Implement MPTCP
receive path"
- signed off was already there
- eebee22fe45e: "squashed" the second one in "mptcp: Implement MPTCP
receive path" as well.
- 380876e851ad: conflict in
t/mptcp-Make-MPTCP-socket-block-wakeup-ignore-sk_receive_queue
- 782be479bf43..0341ab0068b3: result

This fixed all the previous failed tests, that's good :)

Cheers,
Matt
-- 
Matthieu Baerts | R&D Engineer
matthieu.baerts(a)tessares.net
Tessares SA | Hybrid Access Solutions
www.tessares.net
1 Avenue Jean Monnet, 1348 Louvain-la-Neuve, Belgium