From: Joe Perches <joe@perches.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
linux-sctp@vger.kernel.org
Cc: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
Kees Cook <keescook@chromium.org>, Borislav Petkov <bp@alien8.de>,
"H . Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>, Pavel Machek <pavel@ucw.cz>,
"Gustavo A . R . Silva" <gustavo@embeddedor.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Kan Liang <kan.liang@linux.intel.com>,
Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@redhat.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Shawn Landden <shawn@git.icu>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Nathan Chancellor <natechancellor@gmail.com>,
Nick Desaulniers <ndesaulniers@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
David Miller <davem@davemloft.net>,
clang-built-linux@googlegroups.com,
Jonathan Corbet <corbet@lwn.net>,
Vlad Yasevich <vyasevich@gmail.com>,
Neil Horman <nhorman@tuxdriver.com>,
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
linux-doc@vger.kernel.org, netdev@vger.kernel.org
Subject: [PATCH 0/4] treewide: Add 'fallthrough' pseudo-keyword
Date: Sat, 5 Oct 2019 09:46:40 -0700 [thread overview]
Message-ID: <cover.1570292505.git.joe@perches.com> (raw)
Add 'fallthrough' pseudo-keyword to enable the removal of comments
like '/* fallthrough */'.
Add a script to convert the fallthrough comments.
The script can be run over any single file or treewide.
For instance, a treewide conversion can be done using:
$ git ls-files -- '*.[ch]' | \
xargs scripts/cvt_style.pl -o --convert=fallthrough
This currently produces:
$ git diff --shortstat
1839 files changed, 4377 insertions(+), 4698 deletions(-)
Example fallthrough conversion produced by the script:
$ scripts/cvt_style.pl -o --convert=fallthrough arch/arm/mm/alignment.c
a/arch/arm/mm/alignment.c
b/arch/arm/mm/alignment.c
@@ -695,8 +695,7 @@ thumb2arm(u16 tinstr)
return subset[(L<<1) | ((tinstr & (1<<8)) >> 8)] |
(tinstr & 255); /* register_list */
}
- /* Else, fall through - for illegal instruction case */
-
+ fallthrough; /* for illegal instruction case */
default:
return BAD_INSTR;
}
@@ -751,8 +750,7 @@ do_alignment_t32_to_handler(unsigned long *pinstr, struct pt_regs *regs,
case 0xe8e0:
case 0xe9e0:
poffset->un = (tinst2 & 0xff) << 2;
- /* Fall through */
-
+ fallthrough;
case 0xe940:
case 0xe9c0:
return do_alignment_ldrdstrd;
Joe Perches (4):
net: sctp: Rename fallthrough label to unhandled
compiler_attributes.h: Add 'fallthrough' pseudo keyword for switch/case use
Documentation/process: Add fallthrough pseudo-keyword
scripts/cvt_style.pl: Tool to reformat sources in various ways
Documentation/process/coding-style.rst | 2 +-
Documentation/process/deprecated.rst | 33 +-
include/linux/compiler_attributes.h | 17 +
net/sctp/sm_make_chunk.c | 12 +-
scripts/cvt_style.pl | 808 +++++++++++++++++++++++++++++++++
5 files changed, 855 insertions(+), 17 deletions(-)
create mode 100755 scripts/cvt_style.pl
--
2.15.0
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
linux-sctp@vger.kernel.org
Cc: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
Kees Cook <keescook@chromium.org>, Borislav Petkov <bp@alien8.de>,
"H . Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>, Pavel Machek <pavel@ucw.cz>,
"Gustavo A . R . Silva" <gustavo@embeddedor.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Kan Liang <kan.liang@linux.intel.com>,
Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@redhat.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Shawn Landden <shawn@git.icu>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Nathan Chancellor <natechancellor@gmail.com>,
Nick Desaulniers <ndesaulniers@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
David Miller <davem@davemloft.net>,
clang-built-linux@googlegroups.com,
Jonathan Corbet <corbet@lwn.net>,
Vlad Yasevich <vyasevich@gmail.com>,
Neil Horman <nhorman@tuxdriver.com>,
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
linux-doc@vger.kernel.org, netdev@vger.kernel.org
Subject: [PATCH 0/4] treewide: Add 'fallthrough' pseudo-keyword
Date: Sat, 05 Oct 2019 16:46:40 +0000 [thread overview]
Message-ID: <cover.1570292505.git.joe@perches.com> (raw)
Add 'fallthrough' pseudo-keyword to enable the removal of comments
like '/* fallthrough */'.
Add a script to convert the fallthrough comments.
The script can be run over any single file or treewide.
For instance, a treewide conversion can be done using:
$ git ls-files -- '*.[ch]' | \
xargs scripts/cvt_style.pl -o --convertúllthrough
This currently produces:
$ git diff --shortstat
1839 files changed, 4377 insertions(+), 4698 deletions(-)
Example fallthrough conversion produced by the script:
$ scripts/cvt_style.pl -o --convertúllthrough arch/arm/mm/alignment.c
a/arch/arm/mm/alignment.c
b/arch/arm/mm/alignment.c
@@ -695,8 +695,7 @@ thumb2arm(u16 tinstr)
return subset[(L<<1) | ((tinstr & (1<<8)) >> 8)] |
(tinstr & 255); /* register_list */
}
- /* Else, fall through - for illegal instruction case */
-
+ fallthrough; /* for illegal instruction case */
default:
return BAD_INSTR;
}
@@ -751,8 +750,7 @@ do_alignment_t32_to_handler(unsigned long *pinstr, struct pt_regs *regs,
case 0xe8e0:
case 0xe9e0:
poffset->un = (tinst2 & 0xff) << 2;
- /* Fall through */
-
+ fallthrough;
case 0xe940:
case 0xe9c0:
return do_alignment_ldrdstrd;
Joe Perches (4):
net: sctp: Rename fallthrough label to unhandled
compiler_attributes.h: Add 'fallthrough' pseudo keyword for switch/case use
Documentation/process: Add fallthrough pseudo-keyword
scripts/cvt_style.pl: Tool to reformat sources in various ways
Documentation/process/coding-style.rst | 2 +-
Documentation/process/deprecated.rst | 33 +-
include/linux/compiler_attributes.h | 17 +
net/sctp/sm_make_chunk.c | 12 +-
scripts/cvt_style.pl | 808 +++++++++++++++++++++++++++++++++
5 files changed, 855 insertions(+), 17 deletions(-)
create mode 100755 scripts/cvt_style.pl
--
2.15.0
next reply other threads:[~2019-10-05 16:46 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-05 16:46 Joe Perches [this message]
2019-10-05 16:46 ` [PATCH 0/4] treewide: Add 'fallthrough' pseudo-keyword Joe Perches
2019-10-05 16:46 ` [PATCH 1/4] net: sctp: Rename fallthrough label to unhandled Joe Perches
2019-10-05 16:46 ` Joe Perches
2019-10-07 18:08 ` Nick Desaulniers
2019-10-07 18:08 ` Nick Desaulniers
2019-10-10 20:34 ` Kees Cook
2019-10-10 20:34 ` Kees Cook
2019-10-11 12:20 ` Neil Horman
2019-10-11 12:20 ` Neil Horman
2019-10-05 16:46 ` [PATCH 2/4] compiler_attributes.h: Add 'fallthrough' pseudo keyword for switch/case use Joe Perches
2019-10-05 17:17 ` Miguel Ojeda
2019-10-07 18:14 ` Nick Desaulniers
2019-10-07 18:28 ` Joe Perches
2019-10-10 20:37 ` Kees Cook
2019-10-11 22:25 ` Miguel Ojeda
2019-10-05 16:46 ` [PATCH 3/4] Documentation/process: Add fallthrough pseudo-keyword Joe Perches
2019-10-05 17:47 ` Miguel Ojeda
2019-10-09 21:51 ` Nick Desaulniers
2019-10-05 16:46 ` [PATCH 4/4] scripts/cvt_style.pl: Tool to reformat sources in various ways Joe Perches
2019-10-05 17:31 ` Miguel Ojeda
2019-10-06 6:35 ` Joe Perches
2019-10-10 20:39 ` Kees Cook
2019-10-10 20:48 ` Joe Perches
2019-10-09 22:37 ` Nick Desaulniers
2019-10-11 16:29 ` [PATCH 0/4] treewide: Add 'fallthrough' pseudo-keyword Linus Torvalds
2019-10-11 16:29 ` Linus Torvalds
2019-10-11 17:43 ` Joe Perches
2019-10-11 17:43 ` Joe Perches
2019-10-11 17:46 ` Linus Torvalds
2019-10-11 17:46 ` Linus Torvalds
2019-10-12 2:14 ` Joe Perches
2019-10-12 2:14 ` Joe Perches
2019-10-11 18:01 ` Miguel Ojeda
2019-10-11 18:01 ` Miguel Ojeda
2019-10-11 22:07 ` Kees Cook
2019-10-11 22:07 ` Kees Cook
2019-10-11 22:26 ` Miguel Ojeda
2019-10-11 22:26 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1570292505.git.joe@perches.com \
--to=joe@perches.com \
--cc=acme@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=bp@alien8.de \
--cc=clang-built-linux@googlegroups.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=gustavo@embeddedor.com \
--cc=hpa@zytor.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@linux.intel.com \
--cc=keescook@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=marcelo.leitner@gmail.com \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=namhyung@kernel.org \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=pavel@ucw.cz \
--cc=shawn@git.icu \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=vyasevich@gmail.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.