[PATCH 0/3] staging: rtl8723bs: Fix style issues in function call

All of lore.kernel.org
 help / color / mirror / Atom feed

* [PATCH 0/3] staging: rtl8723bs: Fix style issues in function call
@ 2019-10-09  0:23 Javier F. Arias
  2019-10-09  0:24 ` [PATCH 1/3] staging: rtl8723bs: Fix line over 80 characters Javier F. Arias
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Javier F. Arias @ 2019-10-09  0:23 UTC (permalink / raw)
  To: gregkh; +Cc: outreachy-kernel

This patchset fixes multiple style issues in the same function call.
Now this segment of code complies with the coding style guidelines.

Javier F. Arias (3):
  staging: rtl8723bs: Fix line over 80 characters
  staging: rtl8723bs: Fix function call wrapping style
  staging: rtl8723bs: Add space between elements

 drivers/staging/rtl8723bs/core/rtw_ap.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

-- 
2.20.1

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/3] staging: rtl8723bs: Fix line over 80 characters
  2019-10-09  0:23 [PATCH 0/3] staging: rtl8723bs: Fix style issues in function call Javier F. Arias
@ 2019-10-09  0:24 ` Javier F. Arias
  2019-10-09  0:25 ` [PATCH 2/3] staging: rtl8723bs: Fix function call wrapping style Javier F. Arias
  2019-10-09  0:25 ` [PATCH 3/3] staging: rtl8723bs: Add space between elements Javier F. Arias
  2 siblings, 0 replies; 4+ messages in thread
From: Javier F. Arias @ 2019-10-09  0:24 UTC (permalink / raw)
  To: gregkh; +Cc: outreachy-kernel

Break last two function call arguments into two separate lines.
Issue found by checkpatch.

Signed-off-by: Javier F. Arias <jarias.linux@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_ap.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
index 6d18d23acdc0..43af76b9fa49 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ap.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
@@ -217,7 +217,8 @@ void expire_timeout_chk(struct adapter *padapter)
 	#ifdef DBG_EXPIRATION_CHK
 	if (phead != plist) {
 		DBG_871X(FUNC_NDEV_FMT" auth_list, cnt:%u\n"
-			, FUNC_NDEV_ARG(padapter->pnetdev), pstapriv->auth_list_cnt);
+			, FUNC_NDEV_ARG(padapter->pnetdev)
+			, pstapriv->auth_list_cnt);
 	}
 	#endif
 	while (phead != plist) {
-- 
2.20.1



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/3] staging: rtl8723bs: Fix function call wrapping style
  2019-10-09  0:23 [PATCH 0/3] staging: rtl8723bs: Fix style issues in function call Javier F. Arias
  2019-10-09  0:24 ` [PATCH 1/3] staging: rtl8723bs: Fix line over 80 characters Javier F. Arias
@ 2019-10-09  0:25 ` Javier F. Arias
  2019-10-09  0:25 ` [PATCH 3/3] staging: rtl8723bs: Add space between elements Javier F. Arias
  2 siblings, 0 replies; 4+ messages in thread
From: Javier F. Arias @ 2019-10-09  0:25 UTC (permalink / raw)
  To: gregkh; +Cc: outreachy-kernel

Fix the wrapping style used for the function call.
Issue found by checkpatch.

Signed-off-by: Javier F. Arias <jarias.linux@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_ap.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
index 43af76b9fa49..ca84e4b00310 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ap.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
@@ -216,9 +216,9 @@ void expire_timeout_chk(struct adapter *padapter)
 	/* check auth_queue */
 	#ifdef DBG_EXPIRATION_CHK
 	if (phead != plist) {
-		DBG_871X(FUNC_NDEV_FMT" auth_list, cnt:%u\n"
-			, FUNC_NDEV_ARG(padapter->pnetdev)
-			, pstapriv->auth_list_cnt);
+		DBG_871X(FUNC_NDEV_FMT" auth_list, cnt:%u\n",
+			 FUNC_NDEV_ARG(padapter->pnetdev),
+			 pstapriv->auth_list_cnt);
 	}
 	#endif
 	while (phead != plist) {
-- 
2.20.1



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 3/3] staging: rtl8723bs: Add space between elements
  2019-10-09  0:23 [PATCH 0/3] staging: rtl8723bs: Fix style issues in function call Javier F. Arias
  2019-10-09  0:24 ` [PATCH 1/3] staging: rtl8723bs: Fix line over 80 characters Javier F. Arias
  2019-10-09  0:25 ` [PATCH 2/3] staging: rtl8723bs: Fix function call wrapping style Javier F. Arias
@ 2019-10-09  0:25 ` Javier F. Arias
  2 siblings, 0 replies; 4+ messages in thread
From: Javier F. Arias @ 2019-10-09  0:25 UTC (permalink / raw)
  To: gregkh; +Cc: outreachy-kernel

Concatenated strings should use spaces between elements.
Issue found by checkpatch.

Signed-off-by: Javier F. Arias <jarias.linux@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_ap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
index ca84e4b00310..33b4e1d7a520 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ap.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
@@ -216,7 +216,7 @@ void expire_timeout_chk(struct adapter *padapter)
 	/* check auth_queue */
 	#ifdef DBG_EXPIRATION_CHK
 	if (phead != plist) {
-		DBG_871X(FUNC_NDEV_FMT" auth_list, cnt:%u\n",
+		DBG_871X(FUNC_NDEV_FMT " auth_list, cnt:%u\n",
 			 FUNC_NDEV_ARG(padapter->pnetdev),
 			 pstapriv->auth_list_cnt);
 	}
-- 
2.20.1



^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-10-09  0:25 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-09  0:23 [PATCH 0/3] staging: rtl8723bs: Fix style issues in function call Javier F. Arias
2019-10-09  0:24 ` [PATCH 1/3] staging: rtl8723bs: Fix line over 80 characters Javier F. Arias
2019-10-09  0:25 ` [PATCH 2/3] staging: rtl8723bs: Fix function call wrapping style Javier F. Arias
2019-10-09  0:25 ` [PATCH 3/3] staging: rtl8723bs: Add space between elements Javier F. Arias

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.