* [PATCH v2 0/2] staging: exfat: Improve line continuation and alignment
@ 2019-11-02 4:05 Frank A. Cancio Bello
2019-11-02 4:06 ` [PATCH v2 1/2] staging: exfat: Fix parameter alignment issues Frank A. Cancio Bello
2019-11-02 4:06 ` [PATCH v2 2/2] staging: exfat: Fix logical operation continuation Frank A. Cancio Bello
0 siblings, 2 replies; 5+ messages in thread
From: Frank A. Cancio Bello @ 2019-11-02 4:05 UTC (permalink / raw)
To: gregkh; +Cc: outreachy-kernel, saiprakash.ranjan, joel, Valdis Kletnieks
Minor code cleanup consisting of putting the logical operator at the end
of the line instead of at the beginning. Besides there are some alignment
improvements include too.
The code now is more complying with the preferred coding style for the
linux kernel. Issues found by checkpatch.
Changes in v2 by Julia Lawall suggestion:
- Improves log messages on all of the patches.
- Avoid repeating checkpatch messages.
Frank A. Cancio Bello (2):
staging: exfat: Fix parameter alignment issues
staging: exfat: Fix logical operation continuation
drivers/staging/exfat/exfat_core.c | 5 +++--
drivers/staging/exfat/exfat_super.c | 8 ++++----
2 files changed, 7 insertions(+), 6 deletions(-)
--
2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2 1/2] staging: exfat: Fix parameter alignment issues
2019-11-02 4:05 [PATCH v2 0/2] staging: exfat: Improve line continuation and alignment Frank A. Cancio Bello
@ 2019-11-02 4:06 ` Frank A. Cancio Bello
2019-11-02 8:31 ` [Outreachy kernel] " Julia Lawall
2019-11-02 4:06 ` [PATCH v2 2/2] staging: exfat: Fix logical operation continuation Frank A. Cancio Bello
1 sibling, 1 reply; 5+ messages in thread
From: Frank A. Cancio Bello @ 2019-11-02 4:06 UTC (permalink / raw)
To: gregkh; +Cc: outreachy-kernel, saiprakash.ranjan, joel, Valdis Kletnieks
Fix alignment to match open parenthesis to comply in that way with
the preferred coding style for the linux kernel. Issue found by
checkpatch.
Suggested-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Frank A. Cancio Bello <frank@generalsoftwareinc.com>
---
drivers/staging/exfat/exfat_core.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/exfat/exfat_core.c b/drivers/staging/exfat/exfat_core.c
index f4f82aecc05d..b23fbf3ebaa5 100644
--- a/drivers/staging/exfat/exfat_core.c
+++ b/drivers/staging/exfat/exfat_core.c
@@ -1503,7 +1503,7 @@ void fat_delete_dir_entry(struct super_block *sb, struct chain_t *p_dir,
}
void exfat_delete_dir_entry(struct super_block *sb, struct chain_t *p_dir,
- s32 entry, s32 order, s32 num_entries)
+ s32 entry, s32 order, s32 num_entries)
{
int i;
sector_t sector;
@@ -1919,7 +1919,8 @@ s32 write_whole_entry_set(struct super_block *sb, struct entry_set_cache_t *es)
/* write back some entries in entry set */
s32 write_partial_entries_in_entry_set(struct super_block *sb,
- struct entry_set_cache_t *es, struct dentry_t *ep, u32 count)
+ struct entry_set_cache_t *es,
+ struct dentry_t *ep, u32 count)
{
s32 ret, byte_offset, off;
u32 clu = 0;
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v2 2/2] staging: exfat: Fix logical operation continuation
2019-11-02 4:05 [PATCH v2 0/2] staging: exfat: Improve line continuation and alignment Frank A. Cancio Bello
2019-11-02 4:06 ` [PATCH v2 1/2] staging: exfat: Fix parameter alignment issues Frank A. Cancio Bello
@ 2019-11-02 4:06 ` Frank A. Cancio Bello
2019-11-02 7:03 ` [Outreachy kernel] " Julia Lawall
1 sibling, 1 reply; 5+ messages in thread
From: Frank A. Cancio Bello @ 2019-11-02 4:06 UTC (permalink / raw)
To: gregkh; +Cc: outreachy-kernel, saiprakash.ranjan, joel, Valdis Kletnieks
Operators inside a multiline logical expression should be at the end
of the line not at the beginning. This patch fixes two of those cases
and remove an unnecessary parenthesis too, to comply in that way with
the preferred coding style for the linux kernel.
Suggested-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Frank A. Cancio Bello <frank@generalsoftwareinc.com>
---
drivers/staging/exfat/exfat_super.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/exfat/exfat_super.c b/drivers/staging/exfat/exfat_super.c
index 77984a73ba6e..5f972588669c 100644
--- a/drivers/staging/exfat/exfat_super.c
+++ b/drivers/staging/exfat/exfat_super.c
@@ -2980,8 +2980,8 @@ static int exfat_setattr(struct dentry *dentry, struct iattr *attr)
pr_debug("%s entered\n", __func__);
- if ((attr->ia_valid & ATTR_SIZE)
- && (attr->ia_size > i_size_read(inode))) {
+ if ((attr->ia_valid & ATTR_SIZE) &&
+ attr->ia_size > i_size_read(inode)) {
error = exfat_cont_expand(inode, attr->ia_size);
if (error || attr->ia_valid == ATTR_SIZE)
return error;
@@ -2990,8 +2990,8 @@ static int exfat_setattr(struct dentry *dentry, struct iattr *attr)
ia_valid = attr->ia_valid;
- if ((ia_valid & (ATTR_MTIME_SET | ATTR_ATIME_SET | ATTR_TIMES_SET))
- && exfat_allow_set_time(sbi, inode)) {
+ if ((ia_valid & (ATTR_MTIME_SET | ATTR_ATIME_SET | ATTR_TIMES_SET)) &&
+ exfat_allow_set_time(sbi, inode)) {
attr->ia_valid &= ~(ATTR_MTIME_SET |
ATTR_ATIME_SET |
ATTR_TIMES_SET);
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Outreachy kernel] [PATCH v2 2/2] staging: exfat: Fix logical operation continuation
2019-11-02 4:06 ` [PATCH v2 2/2] staging: exfat: Fix logical operation continuation Frank A. Cancio Bello
@ 2019-11-02 7:03 ` Julia Lawall
0 siblings, 0 replies; 5+ messages in thread
From: Julia Lawall @ 2019-11-02 7:03 UTC (permalink / raw)
To: Frank A. Cancio Bello
Cc: gregkh, outreachy-kernel, saiprakash.ranjan, joel,
Valdis Kletnieks
On Sat, 2 Nov 2019, Frank A. Cancio Bello wrote:
> Operators inside a multiline logical expression should be at the end
> of the line not at the beginning. This patch fixes two of those cases
> and remove an unnecessary parenthesis too, to comply in that way with
> the preferred coding style for the linux kernel.
>
> Suggested-by: Julia Lawall <Julia.Lawall@lip6.fr>
> Signed-off-by: Frank A. Cancio Bello <frank@generalsoftwareinc.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
> drivers/staging/exfat/exfat_super.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/exfat/exfat_super.c b/drivers/staging/exfat/exfat_super.c
> index 77984a73ba6e..5f972588669c 100644
> --- a/drivers/staging/exfat/exfat_super.c
> +++ b/drivers/staging/exfat/exfat_super.c
> @@ -2980,8 +2980,8 @@ static int exfat_setattr(struct dentry *dentry, struct iattr *attr)
>
> pr_debug("%s entered\n", __func__);
>
> - if ((attr->ia_valid & ATTR_SIZE)
> - && (attr->ia_size > i_size_read(inode))) {
> + if ((attr->ia_valid & ATTR_SIZE) &&
> + attr->ia_size > i_size_read(inode)) {
> error = exfat_cont_expand(inode, attr->ia_size);
> if (error || attr->ia_valid == ATTR_SIZE)
> return error;
> @@ -2990,8 +2990,8 @@ static int exfat_setattr(struct dentry *dentry, struct iattr *attr)
>
> ia_valid = attr->ia_valid;
>
> - if ((ia_valid & (ATTR_MTIME_SET | ATTR_ATIME_SET | ATTR_TIMES_SET))
> - && exfat_allow_set_time(sbi, inode)) {
> + if ((ia_valid & (ATTR_MTIME_SET | ATTR_ATIME_SET | ATTR_TIMES_SET)) &&
> + exfat_allow_set_time(sbi, inode)) {
> attr->ia_valid &= ~(ATTR_MTIME_SET |
> ATTR_ATIME_SET |
> ATTR_TIMES_SET);
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/ace2cbd5e4c03751fb522e7bbd60149e7ed969ae.1572666556.git.frank%40generalsoftwareinc.com.
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Outreachy kernel] [PATCH v2 1/2] staging: exfat: Fix parameter alignment issues
2019-11-02 4:06 ` [PATCH v2 1/2] staging: exfat: Fix parameter alignment issues Frank A. Cancio Bello
@ 2019-11-02 8:31 ` Julia Lawall
0 siblings, 0 replies; 5+ messages in thread
From: Julia Lawall @ 2019-11-02 8:31 UTC (permalink / raw)
To: Frank A. Cancio Bello
Cc: gregkh, outreachy-kernel, saiprakash.ranjan, joel,
Valdis Kletnieks
On Sat, 2 Nov 2019, Frank A. Cancio Bello wrote:
> Fix alignment to match open parenthesis to comply in that way with
> the preferred coding style for the linux kernel. Issue found by
> checkpatch.
>
> Suggested-by: Julia Lawall <Julia.Lawall@lip6.fr>
> Signed-off-by: Frank A. Cancio Bello <frank@generalsoftwareinc.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
> drivers/staging/exfat/exfat_core.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/exfat/exfat_core.c b/drivers/staging/exfat/exfat_core.c
> index f4f82aecc05d..b23fbf3ebaa5 100644
> --- a/drivers/staging/exfat/exfat_core.c
> +++ b/drivers/staging/exfat/exfat_core.c
> @@ -1503,7 +1503,7 @@ void fat_delete_dir_entry(struct super_block *sb, struct chain_t *p_dir,
> }
>
> void exfat_delete_dir_entry(struct super_block *sb, struct chain_t *p_dir,
> - s32 entry, s32 order, s32 num_entries)
> + s32 entry, s32 order, s32 num_entries)
> {
> int i;
> sector_t sector;
> @@ -1919,7 +1919,8 @@ s32 write_whole_entry_set(struct super_block *sb, struct entry_set_cache_t *es)
>
> /* write back some entries in entry set */
> s32 write_partial_entries_in_entry_set(struct super_block *sb,
> - struct entry_set_cache_t *es, struct dentry_t *ep, u32 count)
> + struct entry_set_cache_t *es,
> + struct dentry_t *ep, u32 count)
> {
> s32 ret, byte_offset, off;
> u32 clu = 0;
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/fe316e694ea9c4aa370d3a8166a3680feb342682.1572666556.git.frank%40generalsoftwareinc.com.
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-11-02 8:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-02 4:05 [PATCH v2 0/2] staging: exfat: Improve line continuation and alignment Frank A. Cancio Bello
2019-11-02 4:06 ` [PATCH v2 1/2] staging: exfat: Fix parameter alignment issues Frank A. Cancio Bello
2019-11-02 8:31 ` [Outreachy kernel] " Julia Lawall
2019-11-02 4:06 ` [PATCH v2 2/2] staging: exfat: Fix logical operation continuation Frank A. Cancio Bello
2019-11-02 7:03 ` [Outreachy kernel] " Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.