All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3 0/1] Fix bochs memory leak
@ 2019-12-12  8:30 Cameron Esfahani via
  2019-12-12  8:30 ` [PATCH v3 1/1] display/bochs-display: fix " Cameron Esfahani via
  2019-12-19 21:17 ` [PATCH v3 0/1] Fix bochs " Cameron Esfahani via
  0 siblings, 2 replies; 3+ messages in thread
From: Cameron Esfahani via @ 2019-12-12  8:30 UTC (permalink / raw)
  To: qemu-devel; +Cc: kraxel

Fix a small memory leak in the Bochs display driver.

Each frame would leak about 304 bytes.

v2: Add missing signed-off-by line.
v3: Add reviewed-by and fixes lines.

Cameron Esfahani (1):
  display/bochs-display: fix memory leak

 hw/display/bochs-display.c | 2 ++
 1 file changed, 2 insertions(+)

-- 
2.24.0



^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH v3 1/1] display/bochs-display: fix memory leak
  2019-12-12  8:30 [PATCH v3 0/1] Fix bochs memory leak Cameron Esfahani via
@ 2019-12-12  8:30 ` Cameron Esfahani via
  2019-12-19 21:17 ` [PATCH v3 0/1] Fix bochs " Cameron Esfahani via
  1 sibling, 0 replies; 3+ messages in thread
From: Cameron Esfahani via @ 2019-12-12  8:30 UTC (permalink / raw)
  To: qemu-devel; +Cc: kraxel, Philippe Mathieu-Daudé

Fix memory leak in bochs_display_update().  Leaks 304 bytes per frame.

Fixes: 33ebad54056
Signed-off-by: Cameron Esfahani <dirty@apple.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 hw/display/bochs-display.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/hw/display/bochs-display.c b/hw/display/bochs-display.c
index dc1bd1641d..215db9a231 100644
--- a/hw/display/bochs-display.c
+++ b/hw/display/bochs-display.c
@@ -252,6 +252,8 @@ static void bochs_display_update(void *opaque)
             dpy_gfx_update(s->con, 0, ys,
                            mode.width, y - ys);
         }
+
+        g_free(snap);
     }
 }
 
-- 
2.24.0



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v3 0/1] Fix bochs memory leak
  2019-12-12  8:30 [PATCH v3 0/1] Fix bochs memory leak Cameron Esfahani via
  2019-12-12  8:30 ` [PATCH v3 1/1] display/bochs-display: fix " Cameron Esfahani via
@ 2019-12-19 21:17 ` Cameron Esfahani via
  1 sibling, 0 replies; 3+ messages in thread
From: Cameron Esfahani via @ 2019-12-19 21:17 UTC (permalink / raw)
  To: Cameron Esfahani; +Cc: qemu-devel, kraxel, Paolo Bonzini

Ping.

Cameron Esfahani
dirty@apple.com

"Americans are very skilled at creating a custom meaning from something that's mass-produced."

Ann Powers


> On Dec 12, 2019, at 12:30 AM, Cameron Esfahani via <qemu-devel@nongnu.org> wrote:
> 
> Fix a small memory leak in the Bochs display driver.
> 
> Each frame would leak about 304 bytes.
> 
> v2: Add missing signed-off-by line.
> v3: Add reviewed-by and fixes lines.
> 
> Cameron Esfahani (1):
>  display/bochs-display: fix memory leak
> 
> hw/display/bochs-display.c | 2 ++
> 1 file changed, 2 insertions(+)
> 
> -- 
> 2.24.0
> 
> 



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-12-19 21:18 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-12  8:30 [PATCH v3 0/1] Fix bochs memory leak Cameron Esfahani via
2019-12-12  8:30 ` [PATCH v3 1/1] display/bochs-display: fix " Cameron Esfahani via
2019-12-19 21:17 ` [PATCH v3 0/1] Fix bochs " Cameron Esfahani via

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.