From: Jyri Sarha <jsarha@ti.com>
To: <dri-devel@lists.freedesktop.org>, <devicetree@vger.kernel.org>
Cc: <tomi.valkeinen@ti.com>, <laurent.pinchart@ideasonboard.com>,
<peter.ujfalusi@ti.com>, <bparrot@ti.com>, <praneeth@ti.com>,
<yamonkar@cadence.com>, <sjakhade@cadence.com>,
<sam@ravnborg.org>, <robh+dt@kernel.org>, <maxime@cerno.tech>
Subject: [PATCH v5 0/5] drm/tidss: New driver for TI Keystone platform Display SubSystem
Date: Fri, 20 Dec 2019 17:55:08 +0200 [thread overview]
Message-ID: <cover.1576857145.git.jsarha@ti.com> (raw)
Changes since v4:
- itemize named resource property descriptions in dt binding
- fix wp to wb in the ti,j721e-dss reg property description
- remove fifo underflow irq handling, it is not an error and
it should be used for debug purposes only
- memory tuning, prefetch plane fifo up to high-threshold value to
minimize possibility of underflows.
Changes since v3:
- Add descriptions some yaml binding properites
- Remove redundant minItems directives from yaml bindings
- Remove ports node from ti,k2g-dss yaml binding
- no change to MAINTAINERS or to the driver code
Changes since v2:
- Add version history to commit messages
- Fix yaml bindings now that got dt_binding_check dtbs_check working propery
- Move tidss entry in MAINTAINERS after omapdrm and add "T: git
git://anongit.freedesktop.org/drm/drm-misc"
- no change to driver code
Changes since the first version of the patch series [2]:
- "drm/tidss: New driver for TI Keystone platform Display SubSystem"
- rebased on top of drm-next-2019-11-27
- sort all include lines in all files
- remove all include <drm/drmP.h>
- remove select "select VIDEOMODE_HELPERS"
- call dispc_vp_setup() later in tidss_crtc_atomic_flush() (there is no
to call it in new modeset case as it is also called in vp_enable())
- change probe sequence and drm_device allocation (follow example in drm_drv.c)
- use __maybe_unused instead of #ifdef for pm functions
- remove "struct drm_fbdev_cma *fbdev;" from driver data
- check panel connector type before connecting it
- No change to binding or MAINTAINERS patches
There was couple of attempts upstream an earlier version of this
driver about a year ago [1]. Back then I needed to stop my efforts to
implement support for next Keystone DSS version, so now the driver
supports three different Keystone DSS version on three different SoCs.
I am starting the patch series versioning from the beginning because it
has been over a year since the previous patch set and the structure of
the driver has evolved quite a bit. However, all the earlier comments
should be addressed in this series.
[1] https://patchwork.freedesktop.org/series/44947/
[2] https://lists.freedesktop.org/archives/dri-devel/2019-November/246542.html
Jyri Sarha (5):
dt-bindings: display: ti,k2g-dss: Add dt-schema yaml binding
dt-bindings: display: ti,am65x-dss: Add dt-schema yaml binding
dt-bindings: display: ti,j721e-dss: Add dt-schema yaml binding
drm/tidss: New driver for TI Keystone platform Display SubSystem
MAINTAINERS: add entry for tidss
.../bindings/display/ti/ti,am65x-dss.yaml | 152 +
.../bindings/display/ti/ti,j721e-dss.yaml | 208 ++
.../bindings/display/ti/ti,k2g-dss.yaml | 109 +
MAINTAINERS | 11 +
drivers/gpu/drm/Kconfig | 2 +
drivers/gpu/drm/Makefile | 1 +
drivers/gpu/drm/tidss/Kconfig | 14 +
drivers/gpu/drm/tidss/Makefile | 12 +
drivers/gpu/drm/tidss/tidss_crtc.c | 376 +++
drivers/gpu/drm/tidss/tidss_crtc.h | 46 +
drivers/gpu/drm/tidss/tidss_dispc.c | 2647 +++++++++++++++++
drivers/gpu/drm/tidss/tidss_dispc.h | 132 +
drivers/gpu/drm/tidss/tidss_dispc_regs.h | 243 ++
drivers/gpu/drm/tidss/tidss_drv.c | 285 ++
drivers/gpu/drm/tidss/tidss_drv.h | 39 +
drivers/gpu/drm/tidss/tidss_encoder.c | 88 +
drivers/gpu/drm/tidss/tidss_encoder.h | 17 +
drivers/gpu/drm/tidss/tidss_irq.c | 146 +
drivers/gpu/drm/tidss/tidss_irq.h | 72 +
drivers/gpu/drm/tidss/tidss_kms.c | 248 ++
drivers/gpu/drm/tidss/tidss_kms.h | 15 +
drivers/gpu/drm/tidss/tidss_plane.c | 217 ++
drivers/gpu/drm/tidss/tidss_plane.h | 25 +
drivers/gpu/drm/tidss/tidss_scale_coefs.c | 202 ++
drivers/gpu/drm/tidss/tidss_scale_coefs.h | 22 +
25 files changed, 5329 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
create mode 100644 Documentation/devicetree/bindings/display/ti/ti,j721e-dss.yaml
create mode 100644 Documentation/devicetree/bindings/display/ti/ti,k2g-dss.yaml
create mode 100644 drivers/gpu/drm/tidss/Kconfig
create mode 100644 drivers/gpu/drm/tidss/Makefile
create mode 100644 drivers/gpu/drm/tidss/tidss_crtc.c
create mode 100644 drivers/gpu/drm/tidss/tidss_crtc.h
create mode 100644 drivers/gpu/drm/tidss/tidss_dispc.c
create mode 100644 drivers/gpu/drm/tidss/tidss_dispc.h
create mode 100644 drivers/gpu/drm/tidss/tidss_dispc_regs.h
create mode 100644 drivers/gpu/drm/tidss/tidss_drv.c
create mode 100644 drivers/gpu/drm/tidss/tidss_drv.h
create mode 100644 drivers/gpu/drm/tidss/tidss_encoder.c
create mode 100644 drivers/gpu/drm/tidss/tidss_encoder.h
create mode 100644 drivers/gpu/drm/tidss/tidss_irq.c
create mode 100644 drivers/gpu/drm/tidss/tidss_irq.h
create mode 100644 drivers/gpu/drm/tidss/tidss_kms.c
create mode 100644 drivers/gpu/drm/tidss/tidss_kms.h
create mode 100644 drivers/gpu/drm/tidss/tidss_plane.c
create mode 100644 drivers/gpu/drm/tidss/tidss_plane.h
create mode 100644 drivers/gpu/drm/tidss/tidss_scale_coefs.c
create mode 100644 drivers/gpu/drm/tidss/tidss_scale_coefs.h
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
WARNING: multiple messages have this Message-ID (diff)
From: Jyri Sarha <jsarha@ti.com>
To: <dri-devel@lists.freedesktop.org>, <devicetree@vger.kernel.org>
Cc: yamonkar@cadence.com, praneeth@ti.com, robh+dt@kernel.org,
peter.ujfalusi@ti.com, tomi.valkeinen@ti.com,
laurent.pinchart@ideasonboard.com, sjakhade@cadence.com,
sam@ravnborg.org, maxime@cerno.tech
Subject: [PATCH v5 0/5] drm/tidss: New driver for TI Keystone platform Display SubSystem
Date: Fri, 20 Dec 2019 17:55:08 +0200 [thread overview]
Message-ID: <cover.1576857145.git.jsarha@ti.com> (raw)
Changes since v4:
- itemize named resource property descriptions in dt binding
- fix wp to wb in the ti,j721e-dss reg property description
- remove fifo underflow irq handling, it is not an error and
it should be used for debug purposes only
- memory tuning, prefetch plane fifo up to high-threshold value to
minimize possibility of underflows.
Changes since v3:
- Add descriptions some yaml binding properites
- Remove redundant minItems directives from yaml bindings
- Remove ports node from ti,k2g-dss yaml binding
- no change to MAINTAINERS or to the driver code
Changes since v2:
- Add version history to commit messages
- Fix yaml bindings now that got dt_binding_check dtbs_check working propery
- Move tidss entry in MAINTAINERS after omapdrm and add "T: git
git://anongit.freedesktop.org/drm/drm-misc"
- no change to driver code
Changes since the first version of the patch series [2]:
- "drm/tidss: New driver for TI Keystone platform Display SubSystem"
- rebased on top of drm-next-2019-11-27
- sort all include lines in all files
- remove all include <drm/drmP.h>
- remove select "select VIDEOMODE_HELPERS"
- call dispc_vp_setup() later in tidss_crtc_atomic_flush() (there is no
to call it in new modeset case as it is also called in vp_enable())
- change probe sequence and drm_device allocation (follow example in drm_drv.c)
- use __maybe_unused instead of #ifdef for pm functions
- remove "struct drm_fbdev_cma *fbdev;" from driver data
- check panel connector type before connecting it
- No change to binding or MAINTAINERS patches
There was couple of attempts upstream an earlier version of this
driver about a year ago [1]. Back then I needed to stop my efforts to
implement support for next Keystone DSS version, so now the driver
supports three different Keystone DSS version on three different SoCs.
I am starting the patch series versioning from the beginning because it
has been over a year since the previous patch set and the structure of
the driver has evolved quite a bit. However, all the earlier comments
should be addressed in this series.
[1] https://patchwork.freedesktop.org/series/44947/
[2] https://lists.freedesktop.org/archives/dri-devel/2019-November/246542.html
Jyri Sarha (5):
dt-bindings: display: ti,k2g-dss: Add dt-schema yaml binding
dt-bindings: display: ti,am65x-dss: Add dt-schema yaml binding
dt-bindings: display: ti,j721e-dss: Add dt-schema yaml binding
drm/tidss: New driver for TI Keystone platform Display SubSystem
MAINTAINERS: add entry for tidss
.../bindings/display/ti/ti,am65x-dss.yaml | 152 +
.../bindings/display/ti/ti,j721e-dss.yaml | 208 ++
.../bindings/display/ti/ti,k2g-dss.yaml | 109 +
MAINTAINERS | 11 +
drivers/gpu/drm/Kconfig | 2 +
drivers/gpu/drm/Makefile | 1 +
drivers/gpu/drm/tidss/Kconfig | 14 +
drivers/gpu/drm/tidss/Makefile | 12 +
drivers/gpu/drm/tidss/tidss_crtc.c | 376 +++
drivers/gpu/drm/tidss/tidss_crtc.h | 46 +
drivers/gpu/drm/tidss/tidss_dispc.c | 2647 +++++++++++++++++
drivers/gpu/drm/tidss/tidss_dispc.h | 132 +
drivers/gpu/drm/tidss/tidss_dispc_regs.h | 243 ++
drivers/gpu/drm/tidss/tidss_drv.c | 285 ++
drivers/gpu/drm/tidss/tidss_drv.h | 39 +
drivers/gpu/drm/tidss/tidss_encoder.c | 88 +
drivers/gpu/drm/tidss/tidss_encoder.h | 17 +
drivers/gpu/drm/tidss/tidss_irq.c | 146 +
drivers/gpu/drm/tidss/tidss_irq.h | 72 +
drivers/gpu/drm/tidss/tidss_kms.c | 248 ++
drivers/gpu/drm/tidss/tidss_kms.h | 15 +
drivers/gpu/drm/tidss/tidss_plane.c | 217 ++
drivers/gpu/drm/tidss/tidss_plane.h | 25 +
drivers/gpu/drm/tidss/tidss_scale_coefs.c | 202 ++
drivers/gpu/drm/tidss/tidss_scale_coefs.h | 22 +
25 files changed, 5329 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
create mode 100644 Documentation/devicetree/bindings/display/ti/ti,j721e-dss.yaml
create mode 100644 Documentation/devicetree/bindings/display/ti/ti,k2g-dss.yaml
create mode 100644 drivers/gpu/drm/tidss/Kconfig
create mode 100644 drivers/gpu/drm/tidss/Makefile
create mode 100644 drivers/gpu/drm/tidss/tidss_crtc.c
create mode 100644 drivers/gpu/drm/tidss/tidss_crtc.h
create mode 100644 drivers/gpu/drm/tidss/tidss_dispc.c
create mode 100644 drivers/gpu/drm/tidss/tidss_dispc.h
create mode 100644 drivers/gpu/drm/tidss/tidss_dispc_regs.h
create mode 100644 drivers/gpu/drm/tidss/tidss_drv.c
create mode 100644 drivers/gpu/drm/tidss/tidss_drv.h
create mode 100644 drivers/gpu/drm/tidss/tidss_encoder.c
create mode 100644 drivers/gpu/drm/tidss/tidss_encoder.h
create mode 100644 drivers/gpu/drm/tidss/tidss_irq.c
create mode 100644 drivers/gpu/drm/tidss/tidss_irq.h
create mode 100644 drivers/gpu/drm/tidss/tidss_kms.c
create mode 100644 drivers/gpu/drm/tidss/tidss_kms.h
create mode 100644 drivers/gpu/drm/tidss/tidss_plane.c
create mode 100644 drivers/gpu/drm/tidss/tidss_plane.h
create mode 100644 drivers/gpu/drm/tidss/tidss_scale_coefs.c
create mode 100644 drivers/gpu/drm/tidss/tidss_scale_coefs.h
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next reply other threads:[~2019-12-20 15:55 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-20 15:55 Jyri Sarha [this message]
2019-12-20 15:55 ` [PATCH v5 0/5] drm/tidss: New driver for TI Keystone platform Display SubSystem Jyri Sarha
2019-12-20 15:55 ` [PATCH v5 1/5] dt-bindings: display: ti,k2g-dss: Add dt-schema yaml binding Jyri Sarha
2019-12-20 15:55 ` [PATCH v5 1/5] dt-bindings: display: ti, k2g-dss: " Jyri Sarha
2019-12-20 15:56 ` [PATCH v5 1/5] dt-bindings: display: ti,k2g-dss: " Maxime Ripard
2019-12-20 15:56 ` Maxime Ripard
2019-12-26 23:05 ` Rob Herring
2019-12-26 23:05 ` Rob Herring
2020-01-13 22:04 ` Benoit Parrot
2020-01-13 22:04 ` Benoit Parrot
2019-12-20 15:55 ` [PATCH v5 2/5] dt-bindings: display: ti,am65x-dss: " Jyri Sarha
2019-12-20 15:55 ` [PATCH v5 2/5] dt-bindings: display: ti, am65x-dss: " Jyri Sarha
2019-12-20 15:57 ` [PATCH v5 2/5] dt-bindings: display: ti,am65x-dss: " Maxime Ripard
2019-12-20 15:57 ` [PATCH v5 2/5] dt-bindings: display: ti, am65x-dss: " Maxime Ripard
2019-12-26 23:07 ` [PATCH v5 2/5] dt-bindings: display: ti,am65x-dss: " Rob Herring
2019-12-26 23:07 ` [PATCH v5 2/5] dt-bindings: display: ti, am65x-dss: " Rob Herring
2020-01-13 22:04 ` [PATCH v5 2/5] dt-bindings: display: ti,am65x-dss: " Benoit Parrot
2020-01-13 22:04 ` [PATCH v5 2/5] dt-bindings: display: ti, am65x-dss: " Benoit Parrot
2019-12-20 15:55 ` [PATCH v5 3/5] dt-bindings: display: ti,j721e-dss: " Jyri Sarha
2019-12-20 15:55 ` [PATCH v5 3/5] dt-bindings: display: ti, j721e-dss: " Jyri Sarha
2019-12-20 15:57 ` [PATCH v5 3/5] dt-bindings: display: ti,j721e-dss: " Maxime Ripard
2019-12-20 15:57 ` [PATCH v5 3/5] dt-bindings: display: ti, j721e-dss: " Maxime Ripard
2019-12-26 23:11 ` [PATCH v5 3/5] dt-bindings: display: ti,j721e-dss: " Rob Herring
2019-12-26 23:11 ` [PATCH v5 3/5] dt-bindings: display: ti, j721e-dss: " Rob Herring
2020-01-13 22:05 ` [PATCH v5 3/5] dt-bindings: display: ti,j721e-dss: " Benoit Parrot
2020-01-13 22:05 ` [PATCH v5 3/5] dt-bindings: display: ti, j721e-dss: " Benoit Parrot
2019-12-20 15:55 ` [PATCH v5 4/5] drm/tidss: New driver for TI Keystone platform Display SubSystem Jyri Sarha
2019-12-20 15:55 ` Jyri Sarha
2020-01-13 22:06 ` Benoit Parrot
2020-01-13 22:06 ` Benoit Parrot
2019-12-20 15:55 ` [PATCH v5 5/5] MAINTAINERS: add entry for tidss Jyri Sarha
2019-12-20 15:55 ` Jyri Sarha
2020-01-13 22:06 ` Benoit Parrot
2020-01-13 22:06 ` Benoit Parrot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1576857145.git.jsarha@ti.com \
--to=jsarha@ti.com \
--cc=bparrot@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=maxime@cerno.tech \
--cc=peter.ujfalusi@ti.com \
--cc=praneeth@ti.com \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=sjakhade@cadence.com \
--cc=tomi.valkeinen@ti.com \
--cc=yamonkar@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.