[PATCH 0/2] staging: vt6655: power.c: remove unused code and improve readability

[PATCH 0/2] staging: vt6655: power.c: remove unused code and improve readability

[Lourdes Pedrajas]

Here's a set of patches that performs code cleanup in the file
drivers/staging/vt6655/power.c

Lourdes Pedrajas (2):
  staging: vt6655: power.c: Remove setting ATIM Window in
    PSvEnablePowerSaving()
  staging: vt6655: power.c: code reformatting for improved readability

 drivers/staging/vt6655/power.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

-- 
2.17.1

[PATCH 1/2] staging: vt6655: power.c: Remove setting ATIM Window in PSvEnablePowerSaving()

[Lourdes Pedrajas]

Every time priv->op_mode is not NL80211_IFTYPE_ADHOC it sets ATIM Window, but
this feature it is marked TODO in 2014 and did go untouched since 2015.

Signed-off-by: Lourdes Pedrajas <lu@pplo.net>
---
 drivers/staging/vt6655/power.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/staging/vt6655/power.c b/drivers/staging/vt6655/power.c
index bfd598a93b04..a68ec527679a 100644
--- a/drivers/staging/vt6655/power.c
+++ b/drivers/staging/vt6655/power.c
@@ -58,11 +58,6 @@ void PSvEnablePowerSaving(struct vnt_private *priv,
 	if (priv->op_mode != NL80211_IFTYPE_ADHOC) {
 		/* set AID */
 		VNSvOutPortW(priv->PortOffset + MAC_REG_AIDATIM, wAID);
-	} else {
-		/* set ATIM Window */
-#if 0 /* TODO atim window */
-		MACvWriteATIMW(priv->PortOffset, pMgmt->wCurrATIMWindow);
-#endif
 	}
 	/* Set AutoSleep */
 	MACvRegBitsOn(priv->PortOffset, MAC_REG_PSCFG, PSCFG_AUTOSLEEP);
-- 
2.17.1

[PATCH 2/2] staging: vt6655: power.c: code reformatting for improved readability

[Lourdes Pedrajas]

Improve line grouping for better understanding the course of action and where
every comment belongs to.

Signed-off-by: Lourdes Pedrajas <lu@pplo.net>
---
 drivers/staging/vt6655/power.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/staging/vt6655/power.c b/drivers/staging/vt6655/power.c
index a68ec527679a..6b0407694e54 100644
--- a/drivers/staging/vt6655/power.c
+++ b/drivers/staging/vt6655/power.c
@@ -59,8 +59,10 @@ void PSvEnablePowerSaving(struct vnt_private *priv,
 		/* set AID */
 		VNSvOutPortW(priv->PortOffset + MAC_REG_AIDATIM, wAID);
 	}
+
 	/* Set AutoSleep */
 	MACvRegBitsOn(priv->PortOffset, MAC_REG_PSCFG, PSCFG_AUTOSLEEP);
+
 	/* Set HWUTSF */
 	MACvRegBitsOn(priv->PortOffset, MAC_REG_TFTCTL, TFTCTL_HWUTSF);
 
@@ -96,10 +98,13 @@ void PSvDisablePowerSaving(struct vnt_private *priv)
 {
 	/* disable power saving hw function */
 	MACbPSWakeup(priv);
+
 	/* clear AutoSleep */
 	MACvRegBitsOff(priv->PortOffset, MAC_REG_PSCFG, PSCFG_AUTOSLEEP);
+
 	/* clear HWUTSF */
 	MACvRegBitsOff(priv->PortOffset, MAC_REG_TFTCTL, TFTCTL_HWUTSF);
+
 	/* set always listen beacon */
 	MACvRegBitsOn(priv->PortOffset, MAC_REG_PSCTL, PSCTL_ALBCN);
 
-- 
2.17.1

Re: [Outreachy kernel] [PATCH 0/2] staging: vt6655: power.c: remove unused code and improve readability

[Stefano Brivio]

On Tue, 10 Mar 2020 15:09:06 +0100
Lourdes Pedrajas <lu@pplo.net> wrote:

> Here's a set of patches that performs code cleanup in the file
> drivers/staging/vt6655/power.c
> 
> Lourdes Pedrajas (2):
>   staging: vt6655: power.c: Remove setting ATIM Window in
>     PSvEnablePowerSaving()
>   staging: vt6655: power.c: code reformatting for improved readability

For the series,

Reviewed-by: Stefano Brivio <sbrivio@redhat.com>

-- 
Stefano