From: Briana Oursler <briana.oursler@gmail.com>
To: sbrivio@redhat.com, julia.lawall@inria.fr,
gregkh@linuxfoundation.org, forest@alittletooquiet.net,
outreachy-kernel@googlegroups.com
Cc: Briana Oursler <briana.oursler@gmail.com>
Subject: [Patch v3 0/4] Staging: vt6655: Simplify statement logic.
Date: Wed, 1 Apr 2020 11:03:38 -0700 [thread overview]
Message-ID: <cover.1585763457.git.briana.oursler@gmail.com> (raw)
Reduce code duplication and complexity within switch case statement. The
goal is to improve the readability of the statement so that the outcome
of the statement is more clear. Checkpatch identified long lines and
other formatting issues within some nested logic. The last commit in this
patch series addresses checkpatch warnings that were not fixed by other
means within the series. Some long lines were left under the rationale
that removing them rendered the output more confusing.
Briana Oursler (4):
Staging: vt6655: Limit return statements.
Staging: vt6655: Move rate determination logic.
Staging: vt6655: Eliminate nested if else
Staging: vt6655: Format long lines.
Changes in v3:
- Patch 1/4 - 3/4:
- Substance unchanged, add Reviewed-by tag from Stefano
Brivio.
- Patch 4/4:
- Add curly brackets per recommendation of Stefano
Brivio.
Changes in v2:
- Patch 1/4:
- Per Stefano Brivio's recommendation, remove curly
braces and unnecessary else clause.
- Remove unrelated newline.
- Patch 2/4:
- Remove unrelated newline.
- Change to a clearer patch subject and description per
Stefano Brivio.
- Patch 3/4:
- Avoid beginning commit description with solution, per
Stefano Brivio's advice.
- Move declaration of len to the same line as other
unsigned ints declared in the same scope, change
recommended by Stefano Brivio.
- Remove unrelated newlines.
- Patch 4/4:
- Change patch subject and description to better
describe change, per Stefano Brivio.
drivers/staging/vt6655/rxtx.c | 119 +++++++++++++++-------------------
1 file changed, 54 insertions(+), 65 deletions(-)
--
2.24.1
next reply other threads:[~2020-04-01 18:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-01 18:03 Briana Oursler [this message]
2020-04-01 18:03 ` [Patch v3 1/4] Staging: vt6655: Limit return statements Briana Oursler
2020-04-01 18:03 ` [Patch v3 2/4] Staging: vt6655: Move rate determination logic Briana Oursler
2020-04-01 18:03 ` [Patch v3 3/4] Staging: vt6655: Eliminate nested if else Briana Oursler
2020-04-01 18:03 ` [Patch v3 4/4] Staging: vt6655: Format long lines Briana Oursler
2020-04-01 21:10 ` [Outreachy kernel] [Patch v3 0/4] Staging: vt6655: Simplify statement logic Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1585763457.git.briana.oursler@gmail.com \
--to=briana.oursler@gmail.com \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@inria.fr \
--cc=outreachy-kernel@googlegroups.com \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.