All of lore.kernel.org
 help / color / mirror / Atom feed
* [Patch v3 0/4] Staging: vt6655: Simplify statement logic.
@ 2020-04-01 18:03 Briana Oursler
  2020-04-01 18:03 ` [Patch v3 1/4] Staging: vt6655: Limit return statements Briana Oursler
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Briana Oursler @ 2020-04-01 18:03 UTC (permalink / raw)
  To: sbrivio, julia.lawall, gregkh, forest, outreachy-kernel; +Cc: Briana Oursler

Reduce code duplication and complexity within switch case statement. The
goal is to improve the readability of the statement so that the outcome
of the statement is more clear. Checkpatch identified long lines and
other formatting issues within some nested logic. The last commit in this
patch series addresses checkpatch warnings that were not fixed by other
means within the series. Some long lines were left under the rationale
that removing them rendered the output more confusing.

Briana Oursler (4):
  Staging: vt6655: Limit return statements.
  Staging: vt6655: Move rate determination logic.
  Staging: vt6655: Eliminate nested if else
  Staging: vt6655: Format long lines.

Changes in v3:
	- Patch 1/4 - 3/4:
		- Substance unchanged, add Reviewed-by tag from Stefano
		  Brivio.
	- Patch 4/4:
		- Add curly brackets per recommendation of Stefano
		  Brivio.

Changes in v2:
        - Patch 1/4:
                - Per Stefano Brivio's recommendation, remove curly
                  braces and unnecessary else clause.
                - Remove unrelated newline.
        - Patch 2/4:
                - Remove unrelated newline.
                - Change to a clearer patch subject and description per
                  Stefano Brivio.
        - Patch 3/4:
                - Avoid beginning commit description with solution, per
                  Stefano Brivio's advice.
                - Move declaration of len to the same line as other
                  unsigned ints declared in the same scope, change
                  recommended by Stefano Brivio.
                - Remove unrelated newlines.
        - Patch 4/4:
                - Change patch subject and description to better
                  describe change, per Stefano Brivio.

 drivers/staging/vt6655/rxtx.c | 119 +++++++++++++++-------------------
 1 file changed, 54 insertions(+), 65 deletions(-)

-- 
2.24.1



^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-04-01 21:10 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-01 18:03 [Patch v3 0/4] Staging: vt6655: Simplify statement logic Briana Oursler
2020-04-01 18:03 ` [Patch v3 1/4] Staging: vt6655: Limit return statements Briana Oursler
2020-04-01 18:03 ` [Patch v3 2/4] Staging: vt6655: Move rate determination logic Briana Oursler
2020-04-01 18:03 ` [Patch v3 3/4] Staging: vt6655: Eliminate nested if else Briana Oursler
2020-04-01 18:03 ` [Patch v3 4/4] Staging: vt6655: Format long lines Briana Oursler
2020-04-01 21:10 ` [Outreachy kernel] [Patch v3 0/4] Staging: vt6655: Simplify statement logic Stefano Brivio

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.