From: Paolo Abeni <pabeni at redhat.com>
To: mptcp at lists.01.org
Subject: [MPTCP] [PATCH net v2 0/5] mptcp: fix incoming options parsing
Date: Thu, 30 Apr 2020 15:01:50 +0200 [thread overview]
Message-ID: <cover.1588243786.git.pabeni@redhat.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1172 bytes --]
This series addresses a serious issue in MPTCP option parsing.
This is bigger than the usual -net change, but I was unable to find a
working, sane, smaller fix.
The core change is inside patch 2/5 which moved MPTCP options parsing from
the TCP code inside existing MPTCP hooks and clean MPTCP options status on
each processed packet.
The patch 1/5 is a needed pre-requisite, and patches 3,4,5 are smaller,
related fixes.
v1 -> v2:
- cleaned-up patch 1/5
- rebased on top of current -net
Paolo Abeni (5):
mptcp: consolidate synack processing.
mptcp: move option parsing into mptcp_incoming_options()
mptcp: avoid a WARN on bad input.
mptcp: fix 'use_ack' option access.
mptcp: initialize the data_fin field for mpc packets
include/linux/tcp.h | 51 ------------------------
include/net/mptcp.h | 3 --
net/ipv4/tcp_input.c | 7 ----
net/mptcp/options.c | 95 +++++++++++++++++++-------------------------
net/mptcp/protocol.c | 6 +--
net/mptcp/protocol.h | 43 +++++++++++++++++++-
net/mptcp/subflow.c | 82 ++++++++++++++++++++++++--------------
7 files changed, 138 insertions(+), 149 deletions(-)
--
2.21.1
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Abeni <pabeni@redhat.com>
To: netdev@vger.kernel.org
Cc: Eric Dumazet <edumazet@google.com>,
Mat Martineau <mathew.j.martineau@linux.intel.com>,
Matthieu Baerts <matthieu.baerts@tessares.net>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Christoph Paasch <cpaasch@apple.com>,
mptcp@lists.01.org
Subject: [PATCH net v2 0/5] mptcp: fix incoming options parsing
Date: Thu, 30 Apr 2020 15:01:50 +0200 [thread overview]
Message-ID: <cover.1588243786.git.pabeni@redhat.com> (raw)
This series addresses a serious issue in MPTCP option parsing.
This is bigger than the usual -net change, but I was unable to find a
working, sane, smaller fix.
The core change is inside patch 2/5 which moved MPTCP options parsing from
the TCP code inside existing MPTCP hooks and clean MPTCP options status on
each processed packet.
The patch 1/5 is a needed pre-requisite, and patches 3,4,5 are smaller,
related fixes.
v1 -> v2:
- cleaned-up patch 1/5
- rebased on top of current -net
Paolo Abeni (5):
mptcp: consolidate synack processing.
mptcp: move option parsing into mptcp_incoming_options()
mptcp: avoid a WARN on bad input.
mptcp: fix 'use_ack' option access.
mptcp: initialize the data_fin field for mpc packets
include/linux/tcp.h | 51 ------------------------
include/net/mptcp.h | 3 --
net/ipv4/tcp_input.c | 7 ----
net/mptcp/options.c | 95 +++++++++++++++++++-------------------------
net/mptcp/protocol.c | 6 +--
net/mptcp/protocol.h | 43 +++++++++++++++++++-
net/mptcp/subflow.c | 82 ++++++++++++++++++++++++--------------
7 files changed, 138 insertions(+), 149 deletions(-)
--
2.21.1
next reply other threads:[~2020-04-30 13:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 13:01 Paolo Abeni [this message]
2020-04-30 13:01 ` [PATCH net v2 0/5] mptcp: fix incoming options parsing Paolo Abeni
-- strict thread matches above, loose matches on Subject: below --
2020-04-30 13:01 [MPTCP] [PATCH net v2 1/5] mptcp: consolidate synack processing Paolo Abeni
2020-04-30 13:01 ` Paolo Abeni
2020-04-30 13:01 [MPTCP] [PATCH net v2 2/5] mptcp: move option parsing into mptcp_incoming_options() Paolo Abeni
2020-04-30 13:01 ` Paolo Abeni
2020-04-30 13:01 [MPTCP] [PATCH net v2 3/5] mptcp: avoid a WARN on bad input Paolo Abeni
2020-04-30 13:01 ` Paolo Abeni
2020-04-30 13:01 [MPTCP] [PATCH net v2 4/5] mptcp: fix 'use_ack' option access Paolo Abeni
2020-04-30 13:01 ` Paolo Abeni
2020-04-30 13:01 [MPTCP] [PATCH net v2 5/5] mptcp: initialize the data_fin field for mpc packets Paolo Abeni
2020-04-30 13:01 ` Paolo Abeni
2020-04-30 19:23 [MPTCP] Re: [PATCH net v2 0/5] mptcp: fix incoming options parsing David Miller
2020-04-30 19:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1588243786.git.pabeni@redhat.com \
--to=unknown@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.