From: Paolo Abeni <pabeni at redhat.com>
To: mptcp at lists.01.org
Subject: [MPTCP] [PATCH 0/2] mptcp: fix some mp_join error paths
Date: Thu, 11 Jun 2020 19:20:55 +0200 [thread overview]
Message-ID: <cover.1591895765.git.pabeni@redhat.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 782 bytes --]
Currently we do not handle correctly MP_JOIN + syncookie and MP_JOIN
failure due to passive socket being already closed.
First patch place the infrastructure needed, the 2nd one addresses the issues.
Note: in such error path, we will end-up creating the child socket just to
reset the connection. I don't see an easy way to avoid such allocation and
doing differently (reset on syn) could be dangerous (attacker can use the mptcp
server to target a victim using spoofed bogus mp_join syn)
Paolo Abeni (2):
mptcp: cache msk on MP_JOIN init_req
mptcp: drop MP_JOIN request sock on syn cookies
net/mptcp/protocol.h | 1 +
net/mptcp/subflow.c | 56 ++++++++++++++++++++------------------------
2 files changed, 27 insertions(+), 30 deletions(-)
--
2.21.3
reply other threads:[~2020-06-11 17:20 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1591895765.git.pabeni@redhat.com \
--to=unknown@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.