* [MPTCP] [PATCH 0/2] mptcp: fix some mp_join error paths
@ 2020-06-11 17:20 Paolo Abeni
0 siblings, 0 replies; only message in thread
From: Paolo Abeni @ 2020-06-11 17:20 UTC (permalink / raw)
To: mptcp
[-- Attachment #1: Type: text/plain, Size: 782 bytes --]
Currently we do not handle correctly MP_JOIN + syncookie and MP_JOIN
failure due to passive socket being already closed.
First patch place the infrastructure needed, the 2nd one addresses the issues.
Note: in such error path, we will end-up creating the child socket just to
reset the connection. I don't see an easy way to avoid such allocation and
doing differently (reset on syn) could be dangerous (attacker can use the mptcp
server to target a victim using spoofed bogus mp_join syn)
Paolo Abeni (2):
mptcp: cache msk on MP_JOIN init_req
mptcp: drop MP_JOIN request sock on syn cookies
net/mptcp/protocol.h | 1 +
net/mptcp/subflow.c | 56 ++++++++++++++++++++------------------------
2 files changed, 27 insertions(+), 30 deletions(-)
--
2.21.3
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-06-11 17:20 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-11 17:20 [MPTCP] [PATCH 0/2] mptcp: fix some mp_join error paths Paolo Abeni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.