* [PATCH 0/2] drm/tilcdc: Couple of minor feature improvements
@ 2020-09-14 8:34 Jyri Sarha
2020-09-14 8:34 ` [PATCH 1/2] drm/tilcdc: Do not keep vblank interrupts enabled all the time Jyri Sarha
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Jyri Sarha @ 2020-09-14 8:34 UTC (permalink / raw)
To: dri-devel; +Cc: tomi.valkeinen, laurent.pinchart
The vblank interrupts have been always on when the display is on for a
very long time, so I decided that it is about time to fix it. Then the
following patch is just a cleanup.
BR,
Jyri
Jyri Sarha (2):
drm/tilcdc: Do not keep vblank interrupts enabled all the time
drm/tilcdc: Remove tilcdc_crtc_max_width(), use private data
drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 52 ++++++++++++++++++----------
drivers/gpu/drm/tilcdc/tilcdc_drv.c | 38 +++++++++++---------
drivers/gpu/drm/tilcdc/tilcdc_drv.h | 7 ++--
3 files changed, 59 insertions(+), 38 deletions(-)
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 1/2] drm/tilcdc: Do not keep vblank interrupts enabled all the time 2020-09-14 8:34 [PATCH 0/2] drm/tilcdc: Couple of minor feature improvements Jyri Sarha @ 2020-09-14 8:34 ` Jyri Sarha 2020-09-14 23:50 ` Laurent Pinchart 2020-09-14 8:34 ` [PATCH 2/2] drm/tilcdc: Remove tilcdc_crtc_max_width(), use private data Jyri Sarha 2020-09-14 8:53 ` [PATCH 0/2] drm/tilcdc: Couple of minor feature improvements Tomi Valkeinen 2 siblings, 1 reply; 6+ messages in thread From: Jyri Sarha @ 2020-09-14 8:34 UTC (permalink / raw) To: dri-devel; +Cc: tomi.valkeinen, laurent.pinchart END_OF_FRAME interrupts have been enabled all the time since the beginning of this driver. It is about time to add this feature. Signed-off-by: Jyri Sarha <jsarha@ti.com> --- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 36 +++++++++++++++++++++++++--- 1 file changed, 33 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c index 1856962411c7..29f263e1975a 100644 --- a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c +++ b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c @@ -147,12 +147,9 @@ static void tilcdc_crtc_enable_irqs(struct drm_device *dev) tilcdc_set(dev, LCDC_RASTER_CTRL_REG, LCDC_V1_SYNC_LOST_INT_ENA | LCDC_V1_FRAME_DONE_INT_ENA | LCDC_V1_UNDERFLOW_INT_ENA); - tilcdc_set(dev, LCDC_DMA_CTRL_REG, - LCDC_V1_END_OF_FRAME_INT_ENA); } else { tilcdc_write(dev, LCDC_INT_ENABLE_SET_REG, LCDC_V2_UNDERFLOW_INT_ENA | - LCDC_V2_END_OF_FRAME0_INT_ENA | LCDC_FRAME_DONE | LCDC_SYNC_LOST); } } @@ -678,11 +675,44 @@ static int tilcdc_crtc_atomic_check(struct drm_crtc *crtc, static int tilcdc_crtc_enable_vblank(struct drm_crtc *crtc) { + struct tilcdc_crtc *tilcdc_crtc = to_tilcdc_crtc(crtc); + struct drm_device *dev = crtc->dev; + struct tilcdc_drm_private *priv = dev->dev_private; + unsigned long flags; + + spin_lock_irqsave(&tilcdc_crtc->irq_lock, flags); + + tilcdc_clear_irqstatus(dev, LCDC_END_OF_FRAME0); + + if (priv->rev == 1) + tilcdc_set(dev, LCDC_DMA_CTRL_REG, + LCDC_V1_END_OF_FRAME_INT_ENA); + else + tilcdc_set(dev, LCDC_INT_ENABLE_SET_REG, + LCDC_V2_END_OF_FRAME0_INT_ENA); + + spin_unlock_irqrestore(&tilcdc_crtc->irq_lock, flags); + return 0; } static void tilcdc_crtc_disable_vblank(struct drm_crtc *crtc) { + struct tilcdc_crtc *tilcdc_crtc = to_tilcdc_crtc(crtc); + struct drm_device *dev = crtc->dev; + struct tilcdc_drm_private *priv = dev->dev_private; + unsigned long flags; + + spin_lock_irqsave(&tilcdc_crtc->irq_lock, flags); + + if (priv->rev == 1) + tilcdc_clear(dev, LCDC_DMA_CTRL_REG, + LCDC_V1_END_OF_FRAME_INT_ENA); + else + tilcdc_clear(dev, LCDC_INT_ENABLE_SET_REG, + LCDC_V2_END_OF_FRAME0_INT_ENA); + + spin_unlock_irqrestore(&tilcdc_crtc->irq_lock, flags); } static void tilcdc_crtc_reset(struct drm_crtc *crtc) -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] drm/tilcdc: Do not keep vblank interrupts enabled all the time 2020-09-14 8:34 ` [PATCH 1/2] drm/tilcdc: Do not keep vblank interrupts enabled all the time Jyri Sarha @ 2020-09-14 23:50 ` Laurent Pinchart 0 siblings, 0 replies; 6+ messages in thread From: Laurent Pinchart @ 2020-09-14 23:50 UTC (permalink / raw) To: Jyri Sarha; +Cc: tomi.valkeinen, dri-devel Hi Jyri, Thank you for the patch. On Mon, Sep 14, 2020 at 11:34:49AM +0300, Jyri Sarha wrote: > END_OF_FRAME interrupts have been enabled all the time since the > beginning of this driver. It is about time to add this feature. > > Signed-off-by: Jyri Sarha <jsarha@ti.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 36 +++++++++++++++++++++++++--- > 1 file changed, 33 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c > index 1856962411c7..29f263e1975a 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c > +++ b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c > @@ -147,12 +147,9 @@ static void tilcdc_crtc_enable_irqs(struct drm_device *dev) > tilcdc_set(dev, LCDC_RASTER_CTRL_REG, > LCDC_V1_SYNC_LOST_INT_ENA | LCDC_V1_FRAME_DONE_INT_ENA | > LCDC_V1_UNDERFLOW_INT_ENA); > - tilcdc_set(dev, LCDC_DMA_CTRL_REG, > - LCDC_V1_END_OF_FRAME_INT_ENA); > } else { > tilcdc_write(dev, LCDC_INT_ENABLE_SET_REG, > LCDC_V2_UNDERFLOW_INT_ENA | > - LCDC_V2_END_OF_FRAME0_INT_ENA | > LCDC_FRAME_DONE | LCDC_SYNC_LOST); > } > } > @@ -678,11 +675,44 @@ static int tilcdc_crtc_atomic_check(struct drm_crtc *crtc, > > static int tilcdc_crtc_enable_vblank(struct drm_crtc *crtc) > { > + struct tilcdc_crtc *tilcdc_crtc = to_tilcdc_crtc(crtc); > + struct drm_device *dev = crtc->dev; > + struct tilcdc_drm_private *priv = dev->dev_private; > + unsigned long flags; > + > + spin_lock_irqsave(&tilcdc_crtc->irq_lock, flags); > + > + tilcdc_clear_irqstatus(dev, LCDC_END_OF_FRAME0); > + > + if (priv->rev == 1) > + tilcdc_set(dev, LCDC_DMA_CTRL_REG, > + LCDC_V1_END_OF_FRAME_INT_ENA); > + else > + tilcdc_set(dev, LCDC_INT_ENABLE_SET_REG, > + LCDC_V2_END_OF_FRAME0_INT_ENA); > + > + spin_unlock_irqrestore(&tilcdc_crtc->irq_lock, flags); > + > return 0; > } > > static void tilcdc_crtc_disable_vblank(struct drm_crtc *crtc) > { > + struct tilcdc_crtc *tilcdc_crtc = to_tilcdc_crtc(crtc); > + struct drm_device *dev = crtc->dev; > + struct tilcdc_drm_private *priv = dev->dev_private; > + unsigned long flags; > + > + spin_lock_irqsave(&tilcdc_crtc->irq_lock, flags); > + > + if (priv->rev == 1) > + tilcdc_clear(dev, LCDC_DMA_CTRL_REG, > + LCDC_V1_END_OF_FRAME_INT_ENA); > + else > + tilcdc_clear(dev, LCDC_INT_ENABLE_SET_REG, > + LCDC_V2_END_OF_FRAME0_INT_ENA); > + > + spin_unlock_irqrestore(&tilcdc_crtc->irq_lock, flags); > } > > static void tilcdc_crtc_reset(struct drm_crtc *crtc) -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] drm/tilcdc: Remove tilcdc_crtc_max_width(), use private data 2020-09-14 8:34 [PATCH 0/2] drm/tilcdc: Couple of minor feature improvements Jyri Sarha 2020-09-14 8:34 ` [PATCH 1/2] drm/tilcdc: Do not keep vblank interrupts enabled all the time Jyri Sarha @ 2020-09-14 8:34 ` Jyri Sarha 2020-09-14 23:53 ` Laurent Pinchart 2020-09-14 8:53 ` [PATCH 0/2] drm/tilcdc: Couple of minor feature improvements Tomi Valkeinen 2 siblings, 1 reply; 6+ messages in thread From: Jyri Sarha @ 2020-09-14 8:34 UTC (permalink / raw) To: dri-devel; +Cc: tomi.valkeinen, laurent.pinchart We already have a private data member for maximum display width so let's use it and get rid of the redundant tilcdc_crtc_max_width(). Signed-off-by: Jyri Sarha <jsarha@ti.com> --- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 16 +----------- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 38 +++++++++++++++------------- drivers/gpu/drm/tilcdc/tilcdc_drv.h | 7 ++--- 3 files changed, 26 insertions(+), 35 deletions(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c index 29f263e1975a..27ea529d74b8 100644 --- a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c +++ b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c @@ -754,20 +754,6 @@ static const struct drm_crtc_funcs tilcdc_crtc_funcs = { .disable_vblank = tilcdc_crtc_disable_vblank, }; -int tilcdc_crtc_max_width(struct drm_crtc *crtc) -{ - struct drm_device *dev = crtc->dev; - struct tilcdc_drm_private *priv = dev->dev_private; - int max_width = 0; - - if (priv->rev == 1) - max_width = 1024; - else if (priv->rev == 2) - max_width = 2048; - - return max_width; -} - static enum drm_mode_status tilcdc_crtc_mode_valid(struct drm_crtc *crtc, const struct drm_display_mode *mode) @@ -780,7 +766,7 @@ tilcdc_crtc_mode_valid(struct drm_crtc *crtc, * check to see if the width is within the range that * the LCD Controller physically supports */ - if (mode->hdisplay > tilcdc_crtc_max_width(crtc)) + if (mode->hdisplay > priv->max_width) return MODE_VIRTUAL_X; /* width must be multiple of 16 */ diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c index 4f5fc3e87383..866b33b40eff 100644 --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c @@ -105,7 +105,7 @@ static void modeset_init(struct drm_device *dev) dev->mode_config.min_width = 0; dev->mode_config.min_height = 0; - dev->mode_config.max_width = tilcdc_crtc_max_width(priv->crtc); + dev->mode_config.max_width = priv->max_width; dev->mode_config.max_height = 2048; dev->mode_config.funcs = &mode_config_funcs; } @@ -218,22 +218,6 @@ static int tilcdc_init(struct drm_driver *ddrv, struct device *dev) goto init_failed; } - if (of_property_read_u32(node, "max-bandwidth", &priv->max_bandwidth)) - priv->max_bandwidth = TILCDC_DEFAULT_MAX_BANDWIDTH; - - DBG("Maximum Bandwidth Value %d", priv->max_bandwidth); - - if (of_property_read_u32(node, "max-width", &priv->max_width)) - priv->max_width = TILCDC_DEFAULT_MAX_WIDTH; - - DBG("Maximum Horizontal Pixel Width Value %dpixels", priv->max_width); - - if (of_property_read_u32(node, "max-pixelclock", - &priv->max_pixelclock)) - priv->max_pixelclock = TILCDC_DEFAULT_MAX_PIXELCLOCK; - - DBG("Maximum Pixel Clock Value %dKHz", priv->max_pixelclock); - pm_runtime_enable(dev); /* Determine LCD IP Version */ @@ -287,6 +271,26 @@ static int tilcdc_init(struct drm_driver *ddrv, struct device *dev) } } + if (of_property_read_u32(node, "max-bandwidth", &priv->max_bandwidth)) + priv->max_bandwidth = TILCDC_DEFAULT_MAX_BANDWIDTH; + + DBG("Maximum Bandwidth Value %d", priv->max_bandwidth); + + if (of_property_read_u32(node, "max-width", &priv->max_width)) { + if (priv->rev == 1) + priv->max_width = TILCDC_DEFAULT_MAX_WIDTH_V1; + else + priv->max_width = TILCDC_DEFAULT_MAX_WIDTH_V2; + } + + DBG("Maximum Horizontal Pixel Width Value %dpixels", priv->max_width); + + if (of_property_read_u32(node, "max-pixelclock", + &priv->max_pixelclock)) + priv->max_pixelclock = TILCDC_DEFAULT_MAX_PIXELCLOCK; + + DBG("Maximum Pixel Clock Value %dKHz", priv->max_pixelclock); + ret = tilcdc_crtc_create(ddev); if (ret < 0) { dev_err(dev, "failed to create crtc\n"); diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.h b/drivers/gpu/drm/tilcdc/tilcdc_drv.h index 18815e75ca4f..76adf87fec4e 100644 --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.h +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.h @@ -28,8 +28,10 @@ struct drm_plane; /* Defaulting to pixel clock defined on AM335x */ #define TILCDC_DEFAULT_MAX_PIXELCLOCK 126000 -/* Defaulting to max width as defined on AM335x */ -#define TILCDC_DEFAULT_MAX_WIDTH 2048 +/* Maximum width as defined on AM335x */ +#define TILCDC_DEFAULT_MAX_WIDTH_V2 2048 +/* ... and for V1 LCDC: */ +#define TILCDC_DEFAULT_MAX_WIDTH_V1 1024 /* * This may need some tweaking, but want to allow at least 1280x1024@60 * with optimized DDR & EMIF settings tweaked 1920x1080@24 appears to @@ -158,7 +160,6 @@ void tilcdc_crtc_set_panel_info(struct drm_crtc *crtc, const struct tilcdc_panel_info *info); void tilcdc_crtc_set_simulate_vesa_sync(struct drm_crtc *crtc, bool simulate_vesa_sync); -int tilcdc_crtc_max_width(struct drm_crtc *crtc); void tilcdc_crtc_shutdown(struct drm_crtc *crtc); int tilcdc_crtc_update_fb(struct drm_crtc *crtc, struct drm_framebuffer *fb, -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] drm/tilcdc: Remove tilcdc_crtc_max_width(), use private data 2020-09-14 8:34 ` [PATCH 2/2] drm/tilcdc: Remove tilcdc_crtc_max_width(), use private data Jyri Sarha @ 2020-09-14 23:53 ` Laurent Pinchart 0 siblings, 0 replies; 6+ messages in thread From: Laurent Pinchart @ 2020-09-14 23:53 UTC (permalink / raw) To: Jyri Sarha; +Cc: tomi.valkeinen, dri-devel Hi Jyri, Thank you for the patch. On Mon, Sep 14, 2020 at 11:34:50AM +0300, Jyri Sarha wrote: > We already have a private data member for maximum display width so > let's use it and get rid of the redundant tilcdc_crtc_max_width(). You may want to add a sentence to explain why OF parsing is moved. > Signed-off-by: Jyri Sarha <jsarha@ti.com> > --- > drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 16 +----------- > drivers/gpu/drm/tilcdc/tilcdc_drv.c | 38 +++++++++++++++------------- > drivers/gpu/drm/tilcdc/tilcdc_drv.h | 7 ++--- > 3 files changed, 26 insertions(+), 35 deletions(-) > > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c > index 29f263e1975a..27ea529d74b8 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c > +++ b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c > @@ -754,20 +754,6 @@ static const struct drm_crtc_funcs tilcdc_crtc_funcs = { > .disable_vblank = tilcdc_crtc_disable_vblank, > }; > > -int tilcdc_crtc_max_width(struct drm_crtc *crtc) > -{ > - struct drm_device *dev = crtc->dev; > - struct tilcdc_drm_private *priv = dev->dev_private; > - int max_width = 0; > - > - if (priv->rev == 1) > - max_width = 1024; > - else if (priv->rev == 2) > - max_width = 2048; > - > - return max_width; > -} > - > static enum drm_mode_status > tilcdc_crtc_mode_valid(struct drm_crtc *crtc, > const struct drm_display_mode *mode) > @@ -780,7 +766,7 @@ tilcdc_crtc_mode_valid(struct drm_crtc *crtc, > * check to see if the width is within the range that > * the LCD Controller physically supports > */ > - if (mode->hdisplay > tilcdc_crtc_max_width(crtc)) > + if (mode->hdisplay > priv->max_width) > return MODE_VIRTUAL_X; > > /* width must be multiple of 16 */ > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c > index 4f5fc3e87383..866b33b40eff 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c > +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c > @@ -105,7 +105,7 @@ static void modeset_init(struct drm_device *dev) > > dev->mode_config.min_width = 0; > dev->mode_config.min_height = 0; > - dev->mode_config.max_width = tilcdc_crtc_max_width(priv->crtc); > + dev->mode_config.max_width = priv->max_width; > dev->mode_config.max_height = 2048; > dev->mode_config.funcs = &mode_config_funcs; > } > @@ -218,22 +218,6 @@ static int tilcdc_init(struct drm_driver *ddrv, struct device *dev) > goto init_failed; > } > > - if (of_property_read_u32(node, "max-bandwidth", &priv->max_bandwidth)) > - priv->max_bandwidth = TILCDC_DEFAULT_MAX_BANDWIDTH; > - > - DBG("Maximum Bandwidth Value %d", priv->max_bandwidth); > - > - if (of_property_read_u32(node, "max-width", &priv->max_width)) > - priv->max_width = TILCDC_DEFAULT_MAX_WIDTH; > - > - DBG("Maximum Horizontal Pixel Width Value %dpixels", priv->max_width); > - > - if (of_property_read_u32(node, "max-pixelclock", > - &priv->max_pixelclock)) > - priv->max_pixelclock = TILCDC_DEFAULT_MAX_PIXELCLOCK; > - > - DBG("Maximum Pixel Clock Value %dKHz", priv->max_pixelclock); > - > pm_runtime_enable(dev); > > /* Determine LCD IP Version */ > @@ -287,6 +271,26 @@ static int tilcdc_init(struct drm_driver *ddrv, struct device *dev) > } > } > > + if (of_property_read_u32(node, "max-bandwidth", &priv->max_bandwidth)) > + priv->max_bandwidth = TILCDC_DEFAULT_MAX_BANDWIDTH; > + > + DBG("Maximum Bandwidth Value %d", priv->max_bandwidth); > + > + if (of_property_read_u32(node, "max-width", &priv->max_width)) { > + if (priv->rev == 1) > + priv->max_width = TILCDC_DEFAULT_MAX_WIDTH_V1; > + else > + priv->max_width = TILCDC_DEFAULT_MAX_WIDTH_V2; > + } > + > + DBG("Maximum Horizontal Pixel Width Value %dpixels", priv->max_width); > + > + if (of_property_read_u32(node, "max-pixelclock", > + &priv->max_pixelclock)) > + priv->max_pixelclock = TILCDC_DEFAULT_MAX_PIXELCLOCK; > + > + DBG("Maximum Pixel Clock Value %dKHz", priv->max_pixelclock); > + > ret = tilcdc_crtc_create(ddev); > if (ret < 0) { > dev_err(dev, "failed to create crtc\n"); > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.h b/drivers/gpu/drm/tilcdc/tilcdc_drv.h > index 18815e75ca4f..76adf87fec4e 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.h > +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.h > @@ -28,8 +28,10 @@ struct drm_plane; > > /* Defaulting to pixel clock defined on AM335x */ > #define TILCDC_DEFAULT_MAX_PIXELCLOCK 126000 > -/* Defaulting to max width as defined on AM335x */ > -#define TILCDC_DEFAULT_MAX_WIDTH 2048 > +/* Maximum width as defined on AM335x */ > +#define TILCDC_DEFAULT_MAX_WIDTH_V2 2048 > +/* ... and for V1 LCDC: */ > +#define TILCDC_DEFAULT_MAX_WIDTH_V1 1024 Nitpicking, I'd define V1 before V2 :-) Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > /* > * This may need some tweaking, but want to allow at least 1280x1024@60 > * with optimized DDR & EMIF settings tweaked 1920x1080@24 appears to > @@ -158,7 +160,6 @@ void tilcdc_crtc_set_panel_info(struct drm_crtc *crtc, > const struct tilcdc_panel_info *info); > void tilcdc_crtc_set_simulate_vesa_sync(struct drm_crtc *crtc, > bool simulate_vesa_sync); > -int tilcdc_crtc_max_width(struct drm_crtc *crtc); > void tilcdc_crtc_shutdown(struct drm_crtc *crtc); > int tilcdc_crtc_update_fb(struct drm_crtc *crtc, > struct drm_framebuffer *fb, -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] drm/tilcdc: Couple of minor feature improvements 2020-09-14 8:34 [PATCH 0/2] drm/tilcdc: Couple of minor feature improvements Jyri Sarha 2020-09-14 8:34 ` [PATCH 1/2] drm/tilcdc: Do not keep vblank interrupts enabled all the time Jyri Sarha 2020-09-14 8:34 ` [PATCH 2/2] drm/tilcdc: Remove tilcdc_crtc_max_width(), use private data Jyri Sarha @ 2020-09-14 8:53 ` Tomi Valkeinen 2 siblings, 0 replies; 6+ messages in thread From: Tomi Valkeinen @ 2020-09-14 8:53 UTC (permalink / raw) To: Jyri Sarha, dri-devel; +Cc: laurent.pinchart On 14/09/2020 11:34, Jyri Sarha wrote: > The vblank interrupts have been always on when the display is on for a > very long time, so I decided that it is about time to fix it. Then the > following patch is just a cleanup. > > BR, > Jyri > > Jyri Sarha (2): > drm/tilcdc: Do not keep vblank interrupts enabled all the time > drm/tilcdc: Remove tilcdc_crtc_max_width(), use private data > > drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 52 ++++++++++++++++++---------- > drivers/gpu/drm/tilcdc/tilcdc_drv.c | 38 +++++++++++--------- > drivers/gpu/drm/tilcdc/tilcdc_drv.h | 7 ++-- > 3 files changed, 59 insertions(+), 38 deletions(-) > For both patches: Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com> Tomi -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-09-14 23:53 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-09-14 8:34 [PATCH 0/2] drm/tilcdc: Couple of minor feature improvements Jyri Sarha 2020-09-14 8:34 ` [PATCH 1/2] drm/tilcdc: Do not keep vblank interrupts enabled all the time Jyri Sarha 2020-09-14 23:50 ` Laurent Pinchart 2020-09-14 8:34 ` [PATCH 2/2] drm/tilcdc: Remove tilcdc_crtc_max_width(), use private data Jyri Sarha 2020-09-14 23:53 ` Laurent Pinchart 2020-09-14 8:53 ` [PATCH 0/2] drm/tilcdc: Couple of minor feature improvements Tomi Valkeinen
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.