From: Anand Jain <anand.jain@oracle.com>
To: linux-btrfs@vger.kernel.org
Cc: nborisov@suse.com, wqu@suse.com, dsterba@suse.com,
Anand Jain <anand.jain@oracle.com>
Subject: [PATCH 0/2] fix verify_one_dev_extent and btrfs_find_device
Date: Thu, 24 Sep 2020 18:11:22 +0800 [thread overview]
Message-ID: <cover.1600940809.git.anand.jain@oracle.com> (raw)
btrfs_find_device()'s last arg %seed is unused, which the commit
343694eee8d8 (btrfs: switch seed device to list api) ignored purposely
or missed.
But there isn't any regression due to that. And this series makes
it official that btrfs_find_device() doesn't need the last arg.
To achieve that patch 1/2 critically reviews the need for the check
disk_total_bytes == 0 in the function verify_one_dev_extent() and finds
that, the condition is never met and so deletes the same. Which also
drops one of the parents of btrfs_find_device() with the last arg false.
So only device_list_add() is using btrfs_find_device() with the last arg as
false, which the patch 2/2 finds is not required as well. So
this patch drops the last arg in btrfs_find_device() altogether.
Anand Jain (2):
btrfs: drop never met condition of disk_total_bytes == 0
btrfs: fix btrfs_find_device unused arg seed
fs/btrfs/dev-replace.c | 4 ++--
fs/btrfs/ioctl.c | 4 ++--
fs/btrfs/scrub.c | 4 ++--
fs/btrfs/volumes.c | 37 ++++++++++---------------------------
fs/btrfs/volumes.h | 2 +-
5 files changed, 17 insertions(+), 34 deletions(-)
--
2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Anand Jain <anand.jain@oracle.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH RESEND 0/2] fix verify_one_dev_extent and btrfs_find_device
Date: Wed, 21 Oct 2020 12:16:07 +0800 [thread overview]
Message-ID: <cover.1600940809.git.anand.jain@oracle.com> (raw)
Message-ID: <20201021041607.N6zGVbH23NYs59PXHWC0Uoc_t-H0glRpAUAHePQTJxs@z> (raw)
btrfs_find_device()'s last arg %seed is unused, which the commit
343694eee8d8 (btrfs: switch seed device to list api) ignored purposely
or missed.
But there isn't any regression due to that. And this series makes
it official that btrfs_find_device() doesn't need the last arg.
To achieve that patch 1/2 critically reviews the need for the check
disk_total_bytes == 0 in the function verify_one_dev_extent() and finds
that, the condition is never met and so deletes the same. Which also
drops one of the parents of btrfs_find_device() with the last arg false.
So only device_list_add() is using btrfs_find_device() with the last arg as
false, which the patch 2/2 finds is not required as well. So
this patch drops the last arg in btrfs_find_device() altogether.
Anand Jain (2):
btrfs: drop never met condition of disk_total_bytes == 0
btrfs: fix btrfs_find_device unused arg seed
fs/btrfs/dev-replace.c | 4 ++--
fs/btrfs/ioctl.c | 4 ++--
fs/btrfs/scrub.c | 4 ++--
fs/btrfs/volumes.c | 37 ++++++++++---------------------------
fs/btrfs/volumes.h | 2 +-
5 files changed, 17 insertions(+), 34 deletions(-)
--
2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Anand Jain <anand.jain@oracle.com>
To: linux-btrfs@vger.kernel.org
Cc: dsterba@suse.com, Anand Jain <anand.jain@oracle.com>
Subject: [PATCH RESEND 0/2] fix verify_one_dev_extent and btrfs_find_device
Date: Fri, 30 Oct 2020 05:30:24 +0800 [thread overview]
Message-ID: <cover.1600940809.git.anand.jain@oracle.com> (raw)
Message-ID: <20201029213024.y0MNbKfWGL7aBCMIw9VfQztBMKvpJNFov2oQrtxJ8dM@z> (raw)
(Resend: I am marking all the patches as v2, not just 1/2).
v2: as in 1/2, 2/2 no change.
btrfs_find_device()'s last arg %seed is unused, which the commit
343694eee8d8 (btrfs: switch seed device to list api) ignored purposely
or missed.
But there isn't any regression due to that. And this series makes
it official that btrfs_find_device() doesn't need the last arg.
To achieve that patch 1/2 critically reviews the need for the check
disk_total_bytes == 0 in the function verify_one_dev_extent() and finds
that, the condition is never met and so deletes the same. Which also
drops one of the parents of btrfs_find_device() with the last arg false.
So only device_list_add() is using btrfs_find_device() with the last arg as
false, which the patch 2/2 finds is not required as well. So
this patch drops the last arg in btrfs_find_device() altogether.
Anand Jain (2):
btrfs: drop never met condition of disk_total_bytes == 0
btrfs: fix btrfs_find_device unused arg seed
fs/btrfs/dev-replace.c | 4 ++--
fs/btrfs/ioctl.c | 4 ++--
fs/btrfs/scrub.c | 4 ++--
fs/btrfs/volumes.c | 37 ++++++++++---------------------------
fs/btrfs/volumes.h | 2 +-
5 files changed, 17 insertions(+), 34 deletions(-)
--
2.25.1
next reply other threads:[~2020-09-24 10:11 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-24 10:11 Anand Jain [this message]
2020-10-29 21:30 ` [PATCH RESEND 0/2] fix verify_one_dev_extent and btrfs_find_device Anand Jain
2020-10-21 4:16 ` Anand Jain
2020-09-24 10:11 ` [PATCH 1/2] btrfs: drop never met condition of disk_total_bytes == 0 Anand Jain
2020-09-24 11:48 ` Nikolay Borisov
2020-09-24 11:58 ` Qu Wenruo
2020-09-24 12:19 ` Qu Wenruo
2020-09-25 4:17 ` Anand Jain
2020-09-25 6:19 ` Nikolay Borisov
2020-09-25 7:33 ` Anand Jain
2020-09-25 7:56 ` Nikolay Borisov
2020-09-25 8:12 ` Anand Jain
2020-10-05 13:22 ` Josef Bacik
2020-10-06 12:53 ` Anand Jain
2020-10-06 12:54 ` [PATCH v2 " Anand Jain
2020-10-29 21:30 ` [PATCH RESEND " Anand Jain
2020-10-21 4:16 ` Anand Jain
2020-10-21 14:35 ` Josef Bacik
2020-10-22 9:40 ` Anand Jain
2020-09-24 10:11 ` [PATCH 2/2] btrfs: fix btrfs_find_device unused arg seed Anand Jain
2020-10-29 21:30 ` [PATCH RESEND v2 " Anand Jain
2020-10-21 4:16 ` [PATCH RESEND " Anand Jain
2020-09-24 10:21 ` [PATCH " Nikolay Borisov
2020-09-25 8:22 ` Nikolay Borisov
2020-09-25 8:42 ` Anand Jain
2020-10-05 13:23 ` Josef Bacik
2020-10-02 3:14 ` [PATCH 0/2] fix verify_one_dev_extent and btrfs_find_device Anand Jain
2020-10-29 21:02 ` [PATCH RESEND " David Sterba
2020-10-29 21:14 ` Anand Jain
2020-11-11 15:49 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1600940809.git.anand.jain@oracle.com \
--to=anand.jain@oracle.com \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.