[dpdk-dev] [PATCH 0/2] doc update for rte flow shared action

[dpdk-dev] [PATCH 0/2] doc update for rte flow shared action

[Jack Min]

This series update documents as following:

1. Add more information about shared action in rte_flow.rst.
2. Group all supported shared actions in mlx5.rst

Xiaoyu Min (2):
  doc: more info of rte flow shared action
  doc: group mlx5 shared actions

 doc/guides/nics/mlx5.rst           | 30 +++++++++++++++++++++---------
 doc/guides/prog_guide/rte_flow.rst |  7 +++++++
 2 files changed, 28 insertions(+), 9 deletions(-)

-- 
2.30.0

[dpdk-dev] [PATCH 1/2] doc: more info of rte flow shared action

[Jack Min]

Added more information of shared action on
how to update, query, and the benefits.

Signed-off-by: Xiaoyu Min <jackmin@nvidia.com>
---
 doc/guides/prog_guide/rte_flow.rst | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst
index 0b8c243fe1..62a57919eb 100644
--- a/doc/guides/prog_guide/rte_flow.rst
+++ b/doc/guides/prog_guide/rte_flow.rst
@@ -2756,6 +2756,13 @@ Flow utilize shared action by handle as returned from
 The behaviour of the shared action defined by ``action`` argument of type
 ``struct rte_flow_action`` passed to ``rte_flow_shared_action_create()``.
 
+Multiple flows can use the same shared action.
+The shared action can be in-place updated by ``rte_flow_shared_action_update()``
+without destroying flow and creating flow again.
+
+The shared action specified data (e.g. counter) can be queried by
+``rte_flow_shared_action_query()``.
+
 .. _table_rte_flow_shared_action:
 
 .. table:: SHARED
-- 
2.30.0

Re: [dpdk-dev] [PATCH 1/2] doc: more info of rte flow shared action

[Ori Kam]

Hi Jack,

> -----Original Message-----
> From: Jack Min <jackmin@nvidia.com>
> Subject: [PATCH 1/2] doc: more info of rte flow shared action
> 
> Added more information of shared action on
> how to update, query, and the benefits.
> 
> Signed-off-by: Xiaoyu Min <jackmin@nvidia.com>
> ---
>  doc/guides/prog_guide/rte_flow.rst | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/doc/guides/prog_guide/rte_flow.rst
> b/doc/guides/prog_guide/rte_flow.rst
> index 0b8c243fe1..62a57919eb 100644
> --- a/doc/guides/prog_guide/rte_flow.rst
> +++ b/doc/guides/prog_guide/rte_flow.rst
> @@ -2756,6 +2756,13 @@ Flow utilize shared action by handle as returned
> from
>  The behaviour of the shared action defined by ``action`` argument of type
>  ``struct rte_flow_action`` passed to ``rte_flow_shared_action_create()``.
> 
> +Multiple flows can use the same shared action.
> +The shared action can be in-place updated by
> ``rte_flow_shared_action_update()``
> +without destroying flow and creating flow again.
> +
> +The shared action specified data (e.g. counter) can be queried by
> +``rte_flow_shared_action_query()``.
> +
>  .. _table_rte_flow_shared_action:
> 
>  .. table:: SHARED
> --
> 2.30.0

Acked-by: Ori Kam <orika@nvidia.com>
Best,
Ori

Re: [dpdk-dev] [PATCH 1/2] doc: more info of rte flow shared action

[Asaf Penso]

Hi Jack,

>-----Original Message-----
>From: dev <dev-bounces@dpdk.org> On Behalf Of Ori Kam
>Sent: Wednesday, February 3, 2021 9:51 AM
>To: Jack Min <jackmin@nvidia.com>
>Cc: dev@dpdk.org
>Subject: Re: [dpdk-dev] [PATCH 1/2] doc: more info of rte flow shared action
>
>Hi Jack,
>
>> -----Original Message-----
>> From: Jack Min <jackmin@nvidia.com>
>> Subject: [PATCH 1/2] doc: more info of rte flow shared action
>>
>> Added more information of shared action on how to update, query, and
>> the benefits.
>>
>> Signed-off-by: Xiaoyu Min <jackmin@nvidia.com>
>> ---
>>  doc/guides/prog_guide/rte_flow.rst | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/doc/guides/prog_guide/rte_flow.rst
>> b/doc/guides/prog_guide/rte_flow.rst
>> index 0b8c243fe1..62a57919eb 100644
>> --- a/doc/guides/prog_guide/rte_flow.rst
>> +++ b/doc/guides/prog_guide/rte_flow.rst
>> @@ -2756,6 +2756,13 @@ Flow utilize shared action by handle as
>> returned from  The behaviour of the shared action defined by
>> ``action`` argument of type  ``struct rte_flow_action`` passed to
>> ``rte_flow_shared_action_create()``.
>>
>> +Multiple flows can use the same shared action.
>> +The shared action can be in-place updated by
>> ``rte_flow_shared_action_update()``
>> +without destroying flow and creating flow again.
>> +
>> +The shared action specified data (e.g. counter) can be queried by
>> +``rte_flow_shared_action_query()``.
>> +
>>  .. _table_rte_flow_shared_action:
>>
>>  .. table:: SHARED
>> --
>> 2.30.0
>
>Acked-by: Ori Kam <orika@nvidia.com>
>Best,
>Ori

Reviewed-by: Asaf Penso <asafp@nvidia.com>

Re: [dpdk-dev] [PATCH 1/2] doc: more info of rte flow shared action

[Ferruh Yigit]

On 2/3/2021 9:02 AM, Asaf Penso wrote:
> Hi Jack,
> 
>> -----Original Message-----
>> From: dev <dev-bounces@dpdk.org> On Behalf Of Ori Kam
>> Sent: Wednesday, February 3, 2021 9:51 AM
>> To: Jack Min <jackmin@nvidia.com>
>> Cc: dev@dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH 1/2] doc: more info of rte flow shared action
>>
>> Hi Jack,
>>
>>> -----Original Message-----
>>> From: Jack Min <jackmin@nvidia.com>
>>> Subject: [PATCH 1/2] doc: more info of rte flow shared action
>>>
>>> Added more information of shared action on how to update, query, and
>>> the benefits.
>>>
>>> Signed-off-by: Xiaoyu Min <jackmin@nvidia.com>
>>
>> Acked-by: Ori Kam <orika@nvidia.com>
>> Best,
>> Ori
> 
> Reviewed-by: Asaf Penso <asafp@nvidia.com>
> 

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

[dpdk-dev] [PATCH 2/2] doc: group mlx5 shared actions

[Jack Min]

Put all supported shared actions in one new table

Signed-off-by: Xiaoyu Min <jackmin@nvidia.com>
---
 doc/guides/nics/mlx5.rst | 30 +++++++++++++++++++++---------
 1 file changed, 21 insertions(+), 9 deletions(-)

diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst
index e99fea4342..dbd7ae1bb9 100644
--- a/doc/guides/nics/mlx5.rst
+++ b/doc/guides/nics/mlx5.rst
@@ -1497,10 +1497,10 @@ Supported hardware offloads
    |                       | |               | | rdma-core 23  |
    |                       | |               | | ConnectX-4    |
    +-----------------------+-----------------+-----------------+
-   | RSS shared action     | |               | | DPDK 20.11    |
-   |                       | |     N/A       | | OFED 5.2      |
-   |                       | |               | | rdma-core 33  |
-   |                       | |               | | ConnectX-5    |
+   | Shared action         | |               | |               |
+   |                       | | :numref:`sact`| | :numref:`sact`|
+   |                       | |               | |               |
+   |                       | |               | |               |
    +-----------------------+-----------------+-----------------+
    | | VLAN                | | DPDK 19.11    | | DPDK 19.11    |
    | | (of_pop_vlan /      | | OFED 4.7-1    | | OFED 4.7-1    |
@@ -1580,11 +1580,6 @@ Supported hardware offloads
    |                       | |  rdma-core 32 | | N/A           |
    |                       | |  ConnectX-5   | | ConnectX-5    |
    +-----------------------+-----------------+-----------------+
-   | Age shared action     | |  DPDK 20.11   | | DPDK 20.11    |
-   |                       | |  OFED 5.2     | | OFED 5.2      |
-   |                       | |  rdma-core 32 | | rdma-core 32  |
-   |                       | |  ConnectX-6 Dx| | ConnectX-6 Dx |
-   +-----------------------+-----------------+-----------------+
    | Encapsulation         | |  DPDK 21.02   | | DPDK 21.02    |
    | GTP PSC               | |  OFED 5.2     | | OFED 5.2      |
    |                       | |  rdma-core 35 | | rdma-core 35  |
@@ -1601,6 +1596,23 @@ Supported hardware offloads
    |                       | | ConnectX-5    | | ConnectX-5    |
    +-----------------------+-----------------+-----------------+
 
+.. table:: Minimal SW/HW versions for shared action offload
+   :name: sact
+
+   +-----------------------+-----------------+-----------------+
+   | Shared Action         | with E-Switch   | with NIC        |
+   +=======================+=================+=================+
+   | RSS                   | |               | | DPDK 20.11    |
+   |                       | |     N/A       | | OFED 5.2      |
+   |                       | |               | | rdma-core 33  |
+   |                       | |               | | ConnectX-5    |
+   +-----------------------+-----------------+-----------------+
+   | Age                   | |  DPDK 20.11   | | DPDK 20.11    |
+   |                       | |  OFED 5.2     | | OFED 5.2      |
+   |                       | |  rdma-core 32 | | rdma-core 32  |
+   |                       | |  ConnectX-6 Dx| | ConnectX-6 Dx |
+   +-----------------------+-----------------+-----------------+
+
 Notes for metadata
 ------------------
 
-- 
2.30.0

Re: [dpdk-dev] [PATCH 2/2] doc: group mlx5 shared actions

[Asaf Penso]

Hi Jack,

Regards,
Asaf Penso

>-----Original Message-----
>From: dev <dev-bounces@dpdk.org> On Behalf Of Jack Min
>Sent: Tuesday, February 2, 2021 2:24 PM
>To: Matan Azrad <matan@nvidia.com>; Shahaf Shuler
><shahafs@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>
>Cc: dev@dpdk.org
>Subject: [dpdk-dev] [PATCH 2/2] doc: group mlx5 shared actions
>
>Put all supported shared actions in one new table
>
>Signed-off-by: Xiaoyu Min <jackmin@nvidia.com>
>---
> doc/guides/nics/mlx5.rst | 30 +++++++++++++++++++++---------
> 1 file changed, 21 insertions(+), 9 deletions(-)
>
>diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index
>e99fea4342..dbd7ae1bb9 100644
>--- a/doc/guides/nics/mlx5.rst
>+++ b/doc/guides/nics/mlx5.rst
>@@ -1497,10 +1497,10 @@ Supported hardware offloads
>    |                       | |               | | rdma-core 23  |
>    |                       | |               | | ConnectX-4    |
>    +-----------------------+-----------------+-----------------+
>-   | RSS shared action     | |               | | DPDK 20.11    |
>-   |                       | |     N/A       | | OFED 5.2      |
>-   |                       | |               | | rdma-core 33  |
>-   |                       | |               | | ConnectX-5    |
>+   | Shared action         | |               | |               |
>+   |                       | | :numref:`sact`| | :numref:`sact`|
>+   |                       | |               | |               |
>+   |                       | |               | |               |
>    +-----------------------+-----------------+-----------------+
>    | | VLAN                | | DPDK 19.11    | | DPDK 19.11    |
>    | | (of_pop_vlan /      | | OFED 4.7-1    | | OFED 4.7-1    |
>@@ -1580,11 +1580,6 @@ Supported hardware offloads
>    |                       | |  rdma-core 32 | | N/A           |
>    |                       | |  ConnectX-5   | | ConnectX-5    |
>    +-----------------------+-----------------+-----------------+
>-   | Age shared action     | |  DPDK 20.11   | | DPDK 20.11    |
>-   |                       | |  OFED 5.2     | | OFED 5.2      |
>-   |                       | |  rdma-core 32 | | rdma-core 32  |
>-   |                       | |  ConnectX-6 Dx| | ConnectX-6 Dx |
>-   +-----------------------+-----------------+-----------------+
>    | Encapsulation         | |  DPDK 21.02   | | DPDK 21.02    |
>    | GTP PSC               | |  OFED 5.2     | | OFED 5.2      |
>    |                       | |  rdma-core 35 | | rdma-core 35  |
>@@ -1601,6 +1596,23 @@ Supported hardware offloads
>    |                       | | ConnectX-5    | | ConnectX-5    |
>    +-----------------------+-----------------+-----------------+
>
>+.. table:: Minimal SW/HW versions for shared action offload
>+   :name: sact
>+
>+   +-----------------------+-----------------+-----------------+
>+   | Shared Action         | with E-Switch   | with NIC        |
>+
>+=======================+=================+================
>=+
>+   | RSS                   | |               | | DPDK 20.11    |
>+   |                       | |     N/A       | | OFED 5.2      |
>+   |                       | |               | | rdma-core 33  |
>+   |                       | |               | | ConnectX-5    |
>+   +-----------------------+-----------------+-----------------+
>+   | Age                   | |  DPDK 20.11   | | DPDK 20.11    |
>+   |                       | |  OFED 5.2     | | OFED 5.2      |
>+   |                       | |  rdma-core 32 | | rdma-core 32  |
>+   |                       | |  ConnectX-6 Dx| | ConnectX-6 Dx |
>+   +-----------------------+-----------------+-----------------+
>+
> Notes for metadata
> ------------------
>
>--
>2.30.0

Reviewed-by: Asaf Penso <asafp@nvidia.com>

Re: [dpdk-dev] [PATCH 0/2] doc update for rte flow shared action

[Ferruh Yigit]

On 2/2/2021 12:23 PM, Jack Min wrote:
> This series update documents as following:
> 
> 1. Add more information about shared action in rte_flow.rst.
> 2. Group all supported shared actions in mlx5.rst
> 
> Xiaoyu Min (2):
>    doc: more info of rte flow shared action
>    doc: group mlx5 shared actions
> 

Series applied to dpdk-next-net/main, thanks.