From: Shuah Khan <skhan@linuxfoundation.org>
To: peterz@infradead.org, mingo@redhat.com, will@kernel.org,
kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org
Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org, ath10k@lists.infradead.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: [PATCH 0/2] Add lockdep_assert_not_held()
Date: Fri, 12 Feb 2021 16:28:41 -0700 [thread overview]
Message-ID: <cover.1613171185.git.skhan@linuxfoundation.org> (raw)
Some kernel functions must not be called holding a specific lock. Doing
so could lead to locking problems. Currently these routines call
lock_is_held() to check for lock hold followed by WARN_ON.
Adding a common lockdep interface will help reduce the duplication of this
logic in the rest of the kernel.
Add lockdep_assert_not_held() to be used in these functions to detect
incorrect calls while holding a lock.
lockdep_assert_not_held() provides the opposite functionality of
lockdep_assert_held() which is used to assert calls that require
holding a specific lock.
The need for lockdep_assert_not_held() came up in a discussion on
ath10k patch. ath10k_drain_tx() and i915_vma_pin_ww() are examples
of functions that can use lockdep_assert_not_held().
Link: https://lore.kernel.org/linux-wireless/871rdmu9z9.fsf@codeaurora.org/
This patch series adds lockdep_assert_not_held() and uses it in the
second patch in ath10k_drain_tx() function.
Shuah Khan (2):
lockdep: add lockdep_assert_not_held()
ath10k: detect conf_mutex held ath10k_drain_tx() calls
drivers/net/wireless/ath/ath10k/mac.c | 2 ++
include/linux/lockdep.h | 7 ++++++-
2 files changed, 8 insertions(+), 1 deletion(-)
--
2.27.0
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Shuah Khan <skhan@linuxfoundation.org>
To: peterz@infradead.org, mingo@redhat.com, will@kernel.org,
kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org
Cc: Shuah Khan <skhan@linuxfoundation.org>,
ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/2] Add lockdep_assert_not_held()
Date: Fri, 12 Feb 2021 16:28:41 -0700 [thread overview]
Message-ID: <cover.1613171185.git.skhan@linuxfoundation.org> (raw)
Some kernel functions must not be called holding a specific lock. Doing
so could lead to locking problems. Currently these routines call
lock_is_held() to check for lock hold followed by WARN_ON.
Adding a common lockdep interface will help reduce the duplication of this
logic in the rest of the kernel.
Add lockdep_assert_not_held() to be used in these functions to detect
incorrect calls while holding a lock.
lockdep_assert_not_held() provides the opposite functionality of
lockdep_assert_held() which is used to assert calls that require
holding a specific lock.
The need for lockdep_assert_not_held() came up in a discussion on
ath10k patch. ath10k_drain_tx() and i915_vma_pin_ww() are examples
of functions that can use lockdep_assert_not_held().
Link: https://lore.kernel.org/linux-wireless/871rdmu9z9.fsf@codeaurora.org/
This patch series adds lockdep_assert_not_held() and uses it in the
second patch in ath10k_drain_tx() function.
Shuah Khan (2):
lockdep: add lockdep_assert_not_held()
ath10k: detect conf_mutex held ath10k_drain_tx() calls
drivers/net/wireless/ath/ath10k/mac.c | 2 ++
include/linux/lockdep.h | 7 ++++++-
2 files changed, 8 insertions(+), 1 deletion(-)
--
2.27.0
next reply other threads:[~2021-02-12 23:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-12 23:28 Shuah Khan [this message]
2021-02-12 23:28 ` [PATCH 0/2] Add lockdep_assert_not_held() Shuah Khan
2021-02-12 23:28 ` [PATCH 1/2] lockdep: add lockdep_assert_not_held() Shuah Khan
2021-02-12 23:28 ` Shuah Khan
2021-02-14 17:53 ` Peter Zijlstra
2021-02-14 17:53 ` Peter Zijlstra
2021-02-15 10:44 ` Peter Zijlstra
2021-02-15 10:44 ` Peter Zijlstra
2021-02-15 13:12 ` Johannes Berg
2021-02-15 13:12 ` Johannes Berg
2021-02-15 16:04 ` Peter Zijlstra
2021-02-15 16:04 ` Peter Zijlstra
2021-02-15 16:10 ` Johannes Berg
2021-02-15 16:10 ` Johannes Berg
2021-02-22 20:51 ` Shuah Khan
2021-02-22 20:51 ` Shuah Khan
2021-02-12 23:28 ` [PATCH 2/2] ath10k: detect conf_mutex held ath10k_drain_tx() calls Shuah Khan
2021-02-12 23:28 ` Shuah Khan
2021-02-14 6:08 ` Kalle Valo
2021-02-14 6:08 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1613171185.git.skhan@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=ath10k@lists.infradead.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.