* [PATCH 1/5] mmc: core: rewrite mmc_fixup_device()
2021-11-09 10:59 [PATCH 0/5] mmc: core: extend mmc_fixup_device and transplant ti,wl1251 quirks from to be retired omap_hsmmc H. Nikolaus Schaller
@ 2021-11-09 10:59 ` H. Nikolaus Schaller
2021-11-09 10:59 ` [PATCH 2/5] mmc: core: allow to match the device tree to apply quirks H. Nikolaus Schaller
` (3 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: H. Nikolaus Schaller @ 2021-11-09 10:59 UTC (permalink / raw)
To: Ulf Hansson, Jérôme Pouiller, Avri Altman, Shawn Lin,
Linus Walleij, Tony Lindgren, Bean Huo, H. Nikolaus Schaller,
Kiwoong Kim, Tian Tao, Andreas Kemnade, Yang Li
Cc: notasas, linux-mmc, linux-kernel, letux-kernel, kernel,
linux-omap
From: Jérôme Pouiller <jerome.pouiller@silabs.com>
Currently, mmc_fixup_device() is a bit difficult to read because of
particularly long condition.
Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
---
drivers/mmc/core/quirks.h | 41 +++++++++++++++++++++++----------------
1 file changed, 24 insertions(+), 17 deletions(-)
diff --git a/drivers/mmc/core/quirks.h b/drivers/mmc/core/quirks.h
index d68e6e513a4f4..c7ef2d14b359f 100644
--- a/drivers/mmc/core/quirks.h
+++ b/drivers/mmc/core/quirks.h
@@ -152,22 +152,29 @@ static inline void mmc_fixup_device(struct mmc_card *card,
u64 rev = cid_rev_card(card);
for (f = table; f->vendor_fixup; f++) {
- if ((f->manfid == CID_MANFID_ANY ||
- f->manfid == card->cid.manfid) &&
- (f->oemid == CID_OEMID_ANY ||
- f->oemid == card->cid.oemid) &&
- (f->name == CID_NAME_ANY ||
- !strncmp(f->name, card->cid.prod_name,
- sizeof(card->cid.prod_name))) &&
- (f->cis_vendor == card->cis.vendor ||
- f->cis_vendor == (u16) SDIO_ANY_ID) &&
- (f->cis_device == card->cis.device ||
- f->cis_device == (u16) SDIO_ANY_ID) &&
- (f->ext_csd_rev == EXT_CSD_REV_ANY ||
- f->ext_csd_rev == card->ext_csd.rev) &&
- rev >= f->rev_start && rev <= f->rev_end) {
- dev_dbg(&card->dev, "calling %ps\n", f->vendor_fixup);
- f->vendor_fixup(card, f->data);
- }
+ if (f->manfid != CID_MANFID_ANY &&
+ f->manfid != card->cid.manfid)
+ continue;
+ if (f->oemid != CID_OEMID_ANY &&
+ f->oemid != card->cid.oemid)
+ continue;
+ if (f->name != CID_NAME_ANY &&
+ strncmp(f->name, card->cid.prod_name,
+ sizeof(card->cid.prod_name)))
+ continue;
+ if (f->cis_vendor != (u16)SDIO_ANY_ID &&
+ f->cis_vendor != card->cis.vendor)
+ continue;
+ if (f->cis_device != (u16)SDIO_ANY_ID &&
+ f->cis_device != card->cis.device)
+ continue;
+ if (f->ext_csd_rev != EXT_CSD_REV_ANY &&
+ f->ext_csd_rev != card->ext_csd.rev)
+ continue;
+ if (rev < f->rev_start || rev > f->rev_end)
+ continue;
+
+ dev_dbg(&card->dev, "calling %ps\n", f->vendor_fixup);
+ f->vendor_fixup(card, f->data);
}
}
--
2.33.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 2/5] mmc: core: allow to match the device tree to apply quirks
2021-11-09 10:59 [PATCH 0/5] mmc: core: extend mmc_fixup_device and transplant ti,wl1251 quirks from to be retired omap_hsmmc H. Nikolaus Schaller
2021-11-09 10:59 ` [PATCH 1/5] mmc: core: rewrite mmc_fixup_device() H. Nikolaus Schaller
@ 2021-11-09 10:59 ` H. Nikolaus Schaller
2021-11-09 11:20 ` Jérôme Pouiller
2021-11-09 10:59 ` [PATCH 3/5] mmc: core: provide macro and table " H. Nikolaus Schaller
` (2 subsequent siblings)
4 siblings, 1 reply; 8+ messages in thread
From: H. Nikolaus Schaller @ 2021-11-09 10:59 UTC (permalink / raw)
To: Ulf Hansson, Jérôme Pouiller, Avri Altman, Shawn Lin,
Linus Walleij, Tony Lindgren, Bean Huo, H. Nikolaus Schaller,
Kiwoong Kim, Tian Tao, Andreas Kemnade, Yang Li
Cc: notasas, linux-mmc, linux-kernel, letux-kernel, kernel,
linux-omap
From: Jérôme Pouiller <jerome.pouiller@silabs.com>
MMC subsystem provides a way to apply quirks when a device match some
properties (VID, PID, etc...) Unfortunately, some SDIO devices do not
comply with the SDIO specification and does not provide reliable VID/PID
(eg. Silabs WF200).
So, the drivers for these devices rely on device tree to identify the
device.
This patch allows the MMC to also rely on the device tree to apply a
quirk.
Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
---
drivers/mmc/core/card.h | 3 +++
drivers/mmc/core/quirks.h | 17 +++++++++++++++++
2 files changed, 20 insertions(+)
diff --git a/drivers/mmc/core/card.h b/drivers/mmc/core/card.h
index 7bd392d55cfa5..483e7f2f1039e 100644
--- a/drivers/mmc/core/card.h
+++ b/drivers/mmc/core/card.h
@@ -59,6 +59,9 @@ struct mmc_fixup {
/* for MMC cards */
unsigned int ext_csd_rev;
+ /* Match against functions declared in device tree */
+ const char *of_compatible;
+
void (*vendor_fixup)(struct mmc_card *card, int data);
int data;
};
diff --git a/drivers/mmc/core/quirks.h b/drivers/mmc/core/quirks.h
index c7ef2d14b359f..4a767f2fbaaaa 100644
--- a/drivers/mmc/core/quirks.h
+++ b/drivers/mmc/core/quirks.h
@@ -10,6 +10,7 @@
*
*/
+#include <linux/of.h>
#include <linux/mmc/sdio_ids.h>
#include "card.h"
@@ -145,6 +146,19 @@ static const struct mmc_fixup __maybe_unused sdio_fixup_methods[] = {
END_FIXUP
};
+static inline bool mmc_fixup_of_compatible_match(struct mmc_card *card,
+ const char *compatible)
+{
+ struct device_node *np;
+
+ for_each_child_of_node(mmc_dev(card->host)->of_node, np) {
+ if (of_device_is_compatible(np, compatible))
+ return true;
+ }
+
+ return false;
+}
+
static inline void mmc_fixup_device(struct mmc_card *card,
const struct mmc_fixup *table)
{
@@ -173,6 +187,9 @@ static inline void mmc_fixup_device(struct mmc_card *card,
continue;
if (rev < f->rev_start || rev > f->rev_end)
continue;
+ if (f->of_compatible &&
+ !mmc_fixup_of_compatible_match(card, f->of_compatible))
+ continue;
dev_dbg(&card->dev, "calling %ps\n", f->vendor_fixup);
f->vendor_fixup(card, f->data);
--
2.33.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 2/5] mmc: core: allow to match the device tree to apply quirks
2021-11-09 10:59 ` [PATCH 2/5] mmc: core: allow to match the device tree to apply quirks H. Nikolaus Schaller
@ 2021-11-09 11:20 ` Jérôme Pouiller
0 siblings, 0 replies; 8+ messages in thread
From: Jérôme Pouiller @ 2021-11-09 11:20 UTC (permalink / raw)
To: Ulf Hansson, Avri Altman, Shawn Lin, Linus Walleij, Tony Lindgren,
Bean Huo, H. Nikolaus Schaller, Kiwoong Kim, Tian Tao,
Andreas Kemnade, Yang Li, H. Nikolaus Schaller
Cc: notasas, linux-mmc, linux-kernel, letux-kernel, kernel,
linux-omap
On Tuesday 9 November 2021 11:59:05 CET H. Nikolaus Schaller wrote:
> From: Jérôme Pouiller <jerome.pouiller@silabs.com>
>
> MMC subsystem provides a way to apply quirks when a device match some
> properties (VID, PID, etc...) Unfortunately, some SDIO devices do not
> comply with the SDIO specification and does not provide reliable VID/PID
> (eg. Silabs WF200).
>
> So, the drivers for these devices rely on device tree to identify the
> device.
>
> This patch allows the MMC to also rely on the device tree to apply a
> quirk.
>
> Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> ---
> drivers/mmc/core/card.h | 3 +++
> drivers/mmc/core/quirks.h | 17 +++++++++++++++++
> 2 files changed, 20 insertions(+)
Reviewed-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
--
Jérôme Pouiller
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 3/5] mmc: core: provide macro and table to match the device tree to apply quirks
2021-11-09 10:59 [PATCH 0/5] mmc: core: extend mmc_fixup_device and transplant ti,wl1251 quirks from to be retired omap_hsmmc H. Nikolaus Schaller
2021-11-09 10:59 ` [PATCH 1/5] mmc: core: rewrite mmc_fixup_device() H. Nikolaus Schaller
2021-11-09 10:59 ` [PATCH 2/5] mmc: core: allow to match the device tree to apply quirks H. Nikolaus Schaller
@ 2021-11-09 10:59 ` H. Nikolaus Schaller
2021-11-09 11:21 ` Jérôme Pouiller
2021-11-09 10:59 ` [PATCH 4/5] mmc: core: transplant ti,wl1251 quirks from to be retired omap_hsmmc H. Nikolaus Schaller
2021-11-09 10:59 ` [PATCH 5/5] mmc: host: omap_hsmmc: revert special init for wl1251 H. Nikolaus Schaller
4 siblings, 1 reply; 8+ messages in thread
From: H. Nikolaus Schaller @ 2021-11-09 10:59 UTC (permalink / raw)
To: Ulf Hansson, Jérôme Pouiller, Avri Altman, Shawn Lin,
Linus Walleij, Tony Lindgren, Bean Huo, H. Nikolaus Schaller,
Kiwoong Kim, Tian Tao, Andreas Kemnade, Yang Li
Cc: notasas, linux-mmc, linux-kernel, letux-kernel, kernel,
linux-omap
This (initially empty) table allows to match quirks early based
on .compatible of the child node of some mmc/sdio interface.
This allows to add quirks based on device tree instead of having
card specific code in the host ops.
A new macro SDIO_FIXUP_COMPATIBLE makes the definition readable.
And we call mmc_fixup_device(sdio_card_init_methods) just after
where host->ops->init_card() can be optionally called.
Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
---
drivers/mmc/core/card.h | 15 +++++++++++++++
drivers/mmc/core/quirks.h | 4 ++++
drivers/mmc/core/sdio.c | 1 +
3 files changed, 20 insertions(+)
diff --git a/drivers/mmc/core/card.h b/drivers/mmc/core/card.h
index 483e7f2f1039e..216faf5ad1021 100644
--- a/drivers/mmc/core/card.h
+++ b/drivers/mmc/core/card.h
@@ -122,6 +122,21 @@ struct mmc_fixup {
_vendor, _device, \
_fixup, _data, EXT_CSD_REV_ANY) \
+#define SDIO_FIXUP_COMPATIBLE(_compatible, _fixup, _data) \
+ { \
+ .name = CID_NAME_ANY, \
+ .manfid = CID_MANFID_ANY, \
+ .oemid = CID_OEMID_ANY, \
+ .rev_start = 0, \
+ .rev_end = -1ull, \
+ .cis_vendor = SDIO_ANY_ID, \
+ .cis_device = SDIO_ANY_ID, \
+ .vendor_fixup = (_fixup), \
+ .data = (_data), \
+ .ext_csd_rev = EXT_CSD_REV_ANY, \
+ .of_compatible = _compatible, \
+ }
+
#define cid_rev(hwrev, fwrev, year, month) \
(((u64) hwrev) << 40 | \
((u64) fwrev) << 32 | \
diff --git a/drivers/mmc/core/quirks.h b/drivers/mmc/core/quirks.h
index 4a767f2fbaaaa..a23df65332cdf 100644
--- a/drivers/mmc/core/quirks.h
+++ b/drivers/mmc/core/quirks.h
@@ -146,6 +146,10 @@ static const struct mmc_fixup __maybe_unused sdio_fixup_methods[] = {
END_FIXUP
};
+static const struct mmc_fixup __maybe_unused sdio_card_init_methods[] = {
+ END_FIXUP
+};
+
static inline bool mmc_fixup_of_compatible_match(struct mmc_card *card,
const char *compatible)
{
diff --git a/drivers/mmc/core/sdio.c b/drivers/mmc/core/sdio.c
index 68edf7a615be5..cf8ee66990508 100644
--- a/drivers/mmc/core/sdio.c
+++ b/drivers/mmc/core/sdio.c
@@ -707,6 +707,7 @@ static int mmc_sdio_init_card(struct mmc_host *host, u32 ocr,
*/
if (host->ops->init_card)
host->ops->init_card(host, card);
+ mmc_fixup_device(card, sdio_card_init_methods);
/*
* If the host and card support UHS-I mode request the card
--
2.33.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 3/5] mmc: core: provide macro and table to match the device tree to apply quirks
2021-11-09 10:59 ` [PATCH 3/5] mmc: core: provide macro and table " H. Nikolaus Schaller
@ 2021-11-09 11:21 ` Jérôme Pouiller
0 siblings, 0 replies; 8+ messages in thread
From: Jérôme Pouiller @ 2021-11-09 11:21 UTC (permalink / raw)
To: Ulf Hansson, Avri Altman, Shawn Lin, Linus Walleij, Tony Lindgren,
Bean Huo, H. Nikolaus Schaller, Kiwoong Kim, Tian Tao,
Andreas Kemnade, Yang Li, H. Nikolaus Schaller
Cc: notasas, linux-mmc, linux-kernel, letux-kernel, kernel,
linux-omap
On Tuesday 9 November 2021 11:59:06 CET H. Nikolaus Schaller wrote:
> This (initially empty) table allows to match quirks early based
> on .compatible of the child node of some mmc/sdio interface.
>
> This allows to add quirks based on device tree instead of having
> card specific code in the host ops.
>
> A new macro SDIO_FIXUP_COMPATIBLE makes the definition readable.
>
> And we call mmc_fixup_device(sdio_card_init_methods) just after
> where host->ops->init_card() can be optionally called.
>
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> ---
> drivers/mmc/core/card.h | 15 +++++++++++++++
> drivers/mmc/core/quirks.h | 4 ++++
> drivers/mmc/core/sdio.c | 1 +
> 3 files changed, 20 insertions(+)
Reviewed-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
--
Jérôme Pouiller
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 4/5] mmc: core: transplant ti,wl1251 quirks from to be retired omap_hsmmc
2021-11-09 10:59 [PATCH 0/5] mmc: core: extend mmc_fixup_device and transplant ti,wl1251 quirks from to be retired omap_hsmmc H. Nikolaus Schaller
` (2 preceding siblings ...)
2021-11-09 10:59 ` [PATCH 3/5] mmc: core: provide macro and table " H. Nikolaus Schaller
@ 2021-11-09 10:59 ` H. Nikolaus Schaller
2021-11-09 10:59 ` [PATCH 5/5] mmc: host: omap_hsmmc: revert special init for wl1251 H. Nikolaus Schaller
4 siblings, 0 replies; 8+ messages in thread
From: H. Nikolaus Schaller @ 2021-11-09 10:59 UTC (permalink / raw)
To: Ulf Hansson, Jérôme Pouiller, Avri Altman, Shawn Lin,
Linus Walleij, Tony Lindgren, Bean Huo, H. Nikolaus Schaller,
Kiwoong Kim, Tian Tao, Andreas Kemnade, Yang Li
Cc: notasas, linux-mmc, linux-kernel, letux-kernel, kernel,
linux-omap
The TiWi WL1251 WiFi chip needs special setup of the sdio
interface before it can be probed.
So far, this is done in omap_hsmmc_init_card() in omap_hsmmc.c
which makes it useable only if connected to omap devices
which use the omap_hsmmc. The OpenPandora is the most promient
example.
There are plans to switch to a newer sdhci-omap driver and
retire omap_hsmmc. Hence this quirk must be reworked or moved
somewhere else. Ideally to some location that is not dependent
on the specific SoC mmc host driver.
This is achieved by the new mmc_fixup_device() option introduced
by ("mmc: allow to match the device tree to apply quirks") to match
through device tree compatible string.
This quirk will be called early right after where host->ops->init_card()
and thus omap_hsmmc_init_card() was previously called.
Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
---
drivers/mmc/core/card.h | 19 +++++++++++++++++++
drivers/mmc/core/quirks.h | 2 ++
2 files changed, 21 insertions(+)
diff --git a/drivers/mmc/core/card.h b/drivers/mmc/core/card.h
index 216faf5ad1021..1695ce827d512 100644
--- a/drivers/mmc/core/card.h
+++ b/drivers/mmc/core/card.h
@@ -168,6 +168,25 @@ static inline void __maybe_unused add_limit_rate_quirk(struct mmc_card *card,
card->quirk_max_rate = data;
}
+static inline void __maybe_unused wl1251_quirk(struct mmc_card *card,
+ int data)
+{
+ /*
+ * We have TI wl1251 attached to this mmc. Pass this
+ * information to the SDIO core because it can't be
+ * probed by normal methods.
+ */
+
+ dev_info(card->host->parent, "found wl1251\n");
+ card->quirks |= MMC_QUIRK_NONSTD_SDIO;
+ card->cccr.wide_bus = 1;
+ card->cis.vendor = 0x104c;
+ card->cis.device = 0x9066;
+ card->cis.blksize = 512;
+ card->cis.max_dtr = 24000000;
+ card->ocr = 0x80;
+}
+
/*
* Quirk add/remove for MMC products.
*/
diff --git a/drivers/mmc/core/quirks.h b/drivers/mmc/core/quirks.h
index a23df65332cdf..20f5687272778 100644
--- a/drivers/mmc/core/quirks.h
+++ b/drivers/mmc/core/quirks.h
@@ -147,6 +147,8 @@ static const struct mmc_fixup __maybe_unused sdio_fixup_methods[] = {
};
static const struct mmc_fixup __maybe_unused sdio_card_init_methods[] = {
+ SDIO_FIXUP_COMPATIBLE("ti,wl1251", wl1251_quirk, 0),
+
END_FIXUP
};
--
2.33.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 5/5] mmc: host: omap_hsmmc: revert special init for wl1251
2021-11-09 10:59 [PATCH 0/5] mmc: core: extend mmc_fixup_device and transplant ti,wl1251 quirks from to be retired omap_hsmmc H. Nikolaus Schaller
` (3 preceding siblings ...)
2021-11-09 10:59 ` [PATCH 4/5] mmc: core: transplant ti,wl1251 quirks from to be retired omap_hsmmc H. Nikolaus Schaller
@ 2021-11-09 10:59 ` H. Nikolaus Schaller
4 siblings, 0 replies; 8+ messages in thread
From: H. Nikolaus Schaller @ 2021-11-09 10:59 UTC (permalink / raw)
To: Ulf Hansson, Jérôme Pouiller, Avri Altman, Shawn Lin,
Linus Walleij, Tony Lindgren, Bean Huo, H. Nikolaus Schaller,
Kiwoong Kim, Tian Tao, Andreas Kemnade, Yang Li
Cc: notasas, linux-mmc, linux-kernel, letux-kernel, kernel,
linux-omap
Replaces: commit f6498b922e57 ("mmc: host: omap_hsmmc: add code for special init of wl1251 to get rid of pandora_wl1251_init_card")
Requires: commit ("mmc: core: transplant ti,wl1251 quirks from to be retired omap_hsmmc")
After moving the wl1251 quirks from omap_hsmmc_init_card() to wl1251_quirk()
and sdio_card_init_methods[] we can remove omap_hsmmc_init_card() completely.
This also removes the specialization on the combination of omap_hsmmc and wl1251.
Related-to: commit f6498b922e57 ("mmc: host: omap_hsmmc: add code for special init of wl1251 to get rid of pandora_wl1251_init_card")
Related-to: commit 2398c41d6432 ("omap: pdata-quirks: remove openpandora quirks for mmc3 and wl1251")
Related-to: commit f9d50fef4b64 ("ARM: OMAP2+: omap3-pandora: add wifi support")
Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
---
drivers/mmc/host/omap_hsmmc.c | 36 -----------------------------------
1 file changed, 36 deletions(-)
diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
index 6960e305e0a39..9749639ea8977 100644
--- a/drivers/mmc/host/omap_hsmmc.c
+++ b/drivers/mmc/host/omap_hsmmc.c
@@ -1504,41 +1504,6 @@ static void omap_hsmmc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
omap_hsmmc_set_bus_mode(host);
}
-static void omap_hsmmc_init_card(struct mmc_host *mmc, struct mmc_card *card)
-{
- struct omap_hsmmc_host *host = mmc_priv(mmc);
-
- if (card->type == MMC_TYPE_SDIO || card->type == MMC_TYPE_SD_COMBO) {
- struct device_node *np = mmc_dev(mmc)->of_node;
-
- /*
- * REVISIT: should be moved to sdio core and made more
- * general e.g. by expanding the DT bindings of child nodes
- * to provide a mechanism to provide this information:
- * Documentation/devicetree/bindings/mmc/mmc-card.txt
- */
-
- np = of_get_compatible_child(np, "ti,wl1251");
- if (np) {
- /*
- * We have TI wl1251 attached to MMC3. Pass this
- * information to the SDIO core because it can't be
- * probed by normal methods.
- */
-
- dev_info(host->dev, "found wl1251\n");
- card->quirks |= MMC_QUIRK_NONSTD_SDIO;
- card->cccr.wide_bus = 1;
- card->cis.vendor = 0x104c;
- card->cis.device = 0x9066;
- card->cis.blksize = 512;
- card->cis.max_dtr = 24000000;
- card->ocr = 0x80;
- of_node_put(np);
- }
- }
-}
-
static void omap_hsmmc_enable_sdio_irq(struct mmc_host *mmc, int enable)
{
struct omap_hsmmc_host *host = mmc_priv(mmc);
@@ -1667,7 +1632,6 @@ static struct mmc_host_ops omap_hsmmc_ops = {
.set_ios = omap_hsmmc_set_ios,
.get_cd = mmc_gpio_get_cd,
.get_ro = mmc_gpio_get_ro,
- .init_card = omap_hsmmc_init_card,
.enable_sdio_irq = omap_hsmmc_enable_sdio_irq,
};
--
2.33.0
^ permalink raw reply related [flat|nested] 8+ messages in thread