* [PATCH 0/3] 3 fixes for deterministic build
@ 2022-03-02 7:12 Robert Yang
2022-03-02 7:12 ` [PATCH 1/3] quilt: Disable external sendmail " Robert Yang
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Robert Yang @ 2022-03-02 7:12 UTC (permalink / raw)
To: openembedded-core
The following changes since commit 7f7eb82ce47ede6ec6f50cbcb56cbfbe10e8d20c:
insane.bbclass: Update insane.bbclass to work on FIPS enabled hosts (2022-03-01 23:44:29 +0000)
are available in the Git repository at:
git://git.openembedded.org/openembedded-core-contrib rbt/deterministic
http://cgit.openembedded.org/openembedded-core-contrib/log/?h=rbt/deterministic
Robert Yang (3):
quilt: Disable external sendmail for deterministic build
perl: Makefile.PL: Fix _PATH_LOG for deterministic build
cups: Add --with-dbusdir to EXTRA_OECONF for deterministic build
...Makefile.PL-Fix-_PATH_LOG-for-determ.patch | 34 +++++++++++++++++++
meta/recipes-devtools/perl/perl_5.34.0.bb | 1 +
meta/recipes-devtools/quilt/quilt.inc | 3 +-
meta/recipes-extended/cups/cups.inc | 1 +
4 files changed, 38 insertions(+), 1 deletion(-)
create mode 100644 meta/recipes-devtools/perl/files/0001-cpan-Sys-Syslog-Makefile.PL-Fix-_PATH_LOG-for-determ.patch
--
2.31.1
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH 1/3] quilt: Disable external sendmail for deterministic build 2022-03-02 7:12 [PATCH 0/3] 3 fixes for deterministic build Robert Yang @ 2022-03-02 7:12 ` Robert Yang 2022-03-02 7:12 ` [PATCH 2/3] perl: Makefile.PL: Fix _PATH_LOG " Robert Yang 2022-03-02 7:12 ` [PATCH 3/3] cups: Add --with-dbusdir to EXTRA_OECONF " Robert Yang 2 siblings, 0 replies; 8+ messages in thread From: Robert Yang @ 2022-03-02 7:12 UTC (permalink / raw) To: openembedded-core Otherwise, the build results would be different w/o host's /usr/sbin/sendmail: 1) The /usr/share/quilt/compat/sendmail will be genrated if no /usr/sbin/sendmail on host 2) No /usr/share/quilt/compat/sendmail if host's has /usr/sbin/sendmail Use --without-sendmail to make it always generate /usr/share/quilt/compat/sendmail. Signed-off-by: Robert Yang <liezhi.yang@windriver.com> --- meta/recipes-devtools/quilt/quilt.inc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/meta/recipes-devtools/quilt/quilt.inc b/meta/recipes-devtools/quilt/quilt.inc index 19532051cda..07611e6d853 100644 --- a/meta/recipes-devtools/quilt/quilt.inc +++ b/meta/recipes-devtools/quilt/quilt.inc @@ -25,8 +25,9 @@ PATCHTOOL:class-native = "patch" CLEANBROKEN = "1" -EXTRA_OECONF = "--with-perl='${USRBINPATH}/env perl' --with-patch=patch" +EXTRA_OECONF = "--with-perl='${USRBINPATH}/env perl' --with-patch=patch --without-sendmail" EXTRA_OECONF:append:class-native = " --disable-nls" + EXTRA_AUTORECONF += "--exclude=aclocal" CACHED_CONFIGUREVARS += "ac_cv_path_BASH=/bin/bash ac_cv_path_COLUMN=column" -- 2.31.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/3] perl: Makefile.PL: Fix _PATH_LOG for deterministic build 2022-03-02 7:12 [PATCH 0/3] 3 fixes for deterministic build Robert Yang 2022-03-02 7:12 ` [PATCH 1/3] quilt: Disable external sendmail " Robert Yang @ 2022-03-02 7:12 ` Robert Yang 2022-03-02 8:42 ` [OE-core] " Alexander Kanavin 2022-03-02 7:12 ` [PATCH 3/3] cups: Add --with-dbusdir to EXTRA_OECONF " Robert Yang 2 siblings, 1 reply; 8+ messages in thread From: Robert Yang @ 2022-03-02 7:12 UTC (permalink / raw) To: openembedded-core It checks host's path such as /dev/log and uses it, this doesn't make sense for cross build, and it causes undeterministic, for example, the contianer os usually doesn't have /dev/log which leads to a different build result since other host usually has /dev/log, so make it always use the default value to fix the issue. Signed-off-by: Robert Yang <liezhi.yang@windriver.com> --- ...Makefile.PL-Fix-_PATH_LOG-for-determ.patch | 34 +++++++++++++++++++ meta/recipes-devtools/perl/perl_5.34.0.bb | 1 + 2 files changed, 35 insertions(+) create mode 100644 meta/recipes-devtools/perl/files/0001-cpan-Sys-Syslog-Makefile.PL-Fix-_PATH_LOG-for-determ.patch diff --git a/meta/recipes-devtools/perl/files/0001-cpan-Sys-Syslog-Makefile.PL-Fix-_PATH_LOG-for-determ.patch b/meta/recipes-devtools/perl/files/0001-cpan-Sys-Syslog-Makefile.PL-Fix-_PATH_LOG-for-determ.patch new file mode 100644 index 00000000000..f6bcbce6856 --- /dev/null +++ b/meta/recipes-devtools/perl/files/0001-cpan-Sys-Syslog-Makefile.PL-Fix-_PATH_LOG-for-determ.patch @@ -0,0 +1,34 @@ +From a73fff1fcf0def4ce93964f1b63fe3ad0967259d Mon Sep 17 00:00:00 2001 +From: Robert Yang <liezhi.yang@windriver.com> +Date: Fri, 18 Feb 2022 09:44:26 +0000 +Subject: [PATCH] cpan/Sys-Syslog/Makefile.PL: Fix _PATH_LOG for deterministic + +It checks host's path such as /dev/log and uses it, this doesn't make sense for +cross build, and it causes undeterministic, for example, the contianer os +usually doesn't have /dev/log which leads to a different build result since +other host usually has /dev/log, so make it always use the default value to fix +the issue. + +Upstream-Status:Inappropriate [OE specific] + +Signed-off-by: Robert Yang <liezhi.yang@windriver.com> +--- + cpan/Sys-Syslog/Makefile.PL | 2 ++ + 1 file changed, 2 insertions(+) + +diff --git a/cpan/Sys-Syslog/Makefile.PL b/cpan/Sys-Syslog/Makefile.PL +index d09ba69..d44e58c 100644 +--- a/cpan/Sys-Syslog/Makefile.PL ++++ b/cpan/Sys-Syslog/Makefile.PL +@@ -130,6 +130,8 @@ else { + $_PATH_LOG = ""; + } + ++# OE specific ++$_PATH_LOG = ""; + + # if possible, generate the code that handles the constants with + # ExtUtils::Constant, otherwise use cached copy in fallback/ +-- +2.31.1 + diff --git a/meta/recipes-devtools/perl/perl_5.34.0.bb b/meta/recipes-devtools/perl/perl_5.34.0.bb index a97da872032..8a1db7ed359 100644 --- a/meta/recipes-devtools/perl/perl_5.34.0.bb +++ b/meta/recipes-devtools/perl/perl_5.34.0.bb @@ -20,6 +20,7 @@ SRC_URI = "https://www.cpan.org/src/5.0/perl-${PV}.tar.gz;name=perl \ file://aacd2398e766500cb5d83c4d76b642fcf31d997a.patch \ file://ea57297a58b8f10ab885c19eec48ea076116cc1f.patch \ file://5bc1e5fdd87aa205011512cd1e6cc655bcf677fd.patch \ + file://0001-cpan-Sys-Syslog-Makefile.PL-Fix-_PATH_LOG-for-determ.patch \ " SRC_URI:append:class-native = " \ file://perl-configpm-switch.patch \ -- 2.31.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [OE-core] [PATCH 2/3] perl: Makefile.PL: Fix _PATH_LOG for deterministic build 2022-03-02 7:12 ` [PATCH 2/3] perl: Makefile.PL: Fix _PATH_LOG " Robert Yang @ 2022-03-02 8:42 ` Alexander Kanavin 2022-03-02 8:47 ` Robert Yang 0 siblings, 1 reply; 8+ messages in thread From: Alexander Kanavin @ 2022-03-02 8:42 UTC (permalink / raw) To: Robert Yang; +Cc: OE-core Can you file a ticket upstream for this please, and include the link in the patch? Alex On Wed, 2 Mar 2022 at 08:13, Robert Yang <liezhi.yang@windriver.com> wrote: > > It checks host's path such as /dev/log and uses it, this doesn't make sense for > cross build, and it causes undeterministic, for example, the contianer os > usually doesn't have /dev/log which leads to a different build result since > other host usually has /dev/log, so make it always use the default value to fix > the issue. > > Signed-off-by: Robert Yang <liezhi.yang@windriver.com> > --- > ...Makefile.PL-Fix-_PATH_LOG-for-determ.patch | 34 +++++++++++++++++++ > meta/recipes-devtools/perl/perl_5.34.0.bb | 1 + > 2 files changed, 35 insertions(+) > create mode 100644 meta/recipes-devtools/perl/files/0001-cpan-Sys-Syslog-Makefile.PL-Fix-_PATH_LOG-for-determ.patch > > diff --git a/meta/recipes-devtools/perl/files/0001-cpan-Sys-Syslog-Makefile.PL-Fix-_PATH_LOG-for-determ.patch b/meta/recipes-devtools/perl/files/0001-cpan-Sys-Syslog-Makefile.PL-Fix-_PATH_LOG-for-determ.patch > new file mode 100644 > index 00000000000..f6bcbce6856 > --- /dev/null > +++ b/meta/recipes-devtools/perl/files/0001-cpan-Sys-Syslog-Makefile.PL-Fix-_PATH_LOG-for-determ.patch > @@ -0,0 +1,34 @@ > +From a73fff1fcf0def4ce93964f1b63fe3ad0967259d Mon Sep 17 00:00:00 2001 > +From: Robert Yang <liezhi.yang@windriver.com> > +Date: Fri, 18 Feb 2022 09:44:26 +0000 > +Subject: [PATCH] cpan/Sys-Syslog/Makefile.PL: Fix _PATH_LOG for deterministic > + > +It checks host's path such as /dev/log and uses it, this doesn't make sense for > +cross build, and it causes undeterministic, for example, the contianer os > +usually doesn't have /dev/log which leads to a different build result since > +other host usually has /dev/log, so make it always use the default value to fix > +the issue. > + > +Upstream-Status:Inappropriate [OE specific] > + > +Signed-off-by: Robert Yang <liezhi.yang@windriver.com> > +--- > + cpan/Sys-Syslog/Makefile.PL | 2 ++ > + 1 file changed, 2 insertions(+) > + > +diff --git a/cpan/Sys-Syslog/Makefile.PL b/cpan/Sys-Syslog/Makefile.PL > +index d09ba69..d44e58c 100644 > +--- a/cpan/Sys-Syslog/Makefile.PL > ++++ b/cpan/Sys-Syslog/Makefile.PL > +@@ -130,6 +130,8 @@ else { > + $_PATH_LOG = ""; > + } > + > ++# OE specific > ++$_PATH_LOG = ""; > + > + # if possible, generate the code that handles the constants with > + # ExtUtils::Constant, otherwise use cached copy in fallback/ > +-- > +2.31.1 > + > diff --git a/meta/recipes-devtools/perl/perl_5.34.0.bb b/meta/recipes-devtools/perl/perl_5.34.0.bb > index a97da872032..8a1db7ed359 100644 > --- a/meta/recipes-devtools/perl/perl_5.34.0.bb > +++ b/meta/recipes-devtools/perl/perl_5.34.0.bb > @@ -20,6 +20,7 @@ SRC_URI = "https://www.cpan.org/src/5.0/perl-${PV}.tar.gz;name=perl \ > file://aacd2398e766500cb5d83c4d76b642fcf31d997a.patch \ > file://ea57297a58b8f10ab885c19eec48ea076116cc1f.patch \ > file://5bc1e5fdd87aa205011512cd1e6cc655bcf677fd.patch \ > + file://0001-cpan-Sys-Syslog-Makefile.PL-Fix-_PATH_LOG-for-determ.patch \ > " > SRC_URI:append:class-native = " \ > file://perl-configpm-switch.patch \ > -- > 2.31.1 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#162590): https://lists.openembedded.org/g/openembedded-core/message/162590 > Mute This Topic: https://lists.openembedded.org/mt/89496472/1686489 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [OE-core] [PATCH 2/3] perl: Makefile.PL: Fix _PATH_LOG for deterministic build 2022-03-02 8:42 ` [OE-core] " Alexander Kanavin @ 2022-03-02 8:47 ` Robert Yang 2022-03-02 8:48 ` Alexander Kanavin 0 siblings, 1 reply; 8+ messages in thread From: Robert Yang @ 2022-03-02 8:47 UTC (permalink / raw) To: Alexander Kanavin; +Cc: OE-core Hi On 3/2/22 4:42 PM, Alexander Kanavin wrote: > Can you file a ticket upstream for this please, and include the link > in the patch? > This patch won't work for upstream, only work by cross building, let me check on how to make it work for all cases. // Robert > Alex > > On Wed, 2 Mar 2022 at 08:13, Robert Yang <liezhi.yang@windriver.com> wrote: >> >> It checks host's path such as /dev/log and uses it, this doesn't make sense for >> cross build, and it causes undeterministic, for example, the contianer os >> usually doesn't have /dev/log which leads to a different build result since >> other host usually has /dev/log, so make it always use the default value to fix >> the issue. >> >> Signed-off-by: Robert Yang <liezhi.yang@windriver.com> >> --- >> ...Makefile.PL-Fix-_PATH_LOG-for-determ.patch | 34 +++++++++++++++++++ >> meta/recipes-devtools/perl/perl_5.34.0.bb | 1 + >> 2 files changed, 35 insertions(+) >> create mode 100644 meta/recipes-devtools/perl/files/0001-cpan-Sys-Syslog-Makefile.PL-Fix-_PATH_LOG-for-determ.patch >> >> diff --git a/meta/recipes-devtools/perl/files/0001-cpan-Sys-Syslog-Makefile.PL-Fix-_PATH_LOG-for-determ.patch b/meta/recipes-devtools/perl/files/0001-cpan-Sys-Syslog-Makefile.PL-Fix-_PATH_LOG-for-determ.patch >> new file mode 100644 >> index 00000000000..f6bcbce6856 >> --- /dev/null >> +++ b/meta/recipes-devtools/perl/files/0001-cpan-Sys-Syslog-Makefile.PL-Fix-_PATH_LOG-for-determ.patch >> @@ -0,0 +1,34 @@ >> +From a73fff1fcf0def4ce93964f1b63fe3ad0967259d Mon Sep 17 00:00:00 2001 >> +From: Robert Yang <liezhi.yang@windriver.com> >> +Date: Fri, 18 Feb 2022 09:44:26 +0000 >> +Subject: [PATCH] cpan/Sys-Syslog/Makefile.PL: Fix _PATH_LOG for deterministic >> + >> +It checks host's path such as /dev/log and uses it, this doesn't make sense for >> +cross build, and it causes undeterministic, for example, the contianer os >> +usually doesn't have /dev/log which leads to a different build result since >> +other host usually has /dev/log, so make it always use the default value to fix >> +the issue. >> + >> +Upstream-Status:Inappropriate [OE specific] >> + >> +Signed-off-by: Robert Yang <liezhi.yang@windriver.com> >> +--- >> + cpan/Sys-Syslog/Makefile.PL | 2 ++ >> + 1 file changed, 2 insertions(+) >> + >> +diff --git a/cpan/Sys-Syslog/Makefile.PL b/cpan/Sys-Syslog/Makefile.PL >> +index d09ba69..d44e58c 100644 >> +--- a/cpan/Sys-Syslog/Makefile.PL >> ++++ b/cpan/Sys-Syslog/Makefile.PL >> +@@ -130,6 +130,8 @@ else { >> + $_PATH_LOG = ""; >> + } >> + >> ++# OE specific >> ++$_PATH_LOG = ""; >> + >> + # if possible, generate the code that handles the constants with >> + # ExtUtils::Constant, otherwise use cached copy in fallback/ >> +-- >> +2.31.1 >> + >> diff --git a/meta/recipes-devtools/perl/perl_5.34.0.bb b/meta/recipes-devtools/perl/perl_5.34.0.bb >> index a97da872032..8a1db7ed359 100644 >> --- a/meta/recipes-devtools/perl/perl_5.34.0.bb >> +++ b/meta/recipes-devtools/perl/perl_5.34.0.bb >> @@ -20,6 +20,7 @@ SRC_URI = "https://www.cpan.org/src/5.0/perl-${PV}.tar.gz;name=perl \ >> file://aacd2398e766500cb5d83c4d76b642fcf31d997a.patch \ >> file://ea57297a58b8f10ab885c19eec48ea076116cc1f.patch \ >> file://5bc1e5fdd87aa205011512cd1e6cc655bcf677fd.patch \ >> + file://0001-cpan-Sys-Syslog-Makefile.PL-Fix-_PATH_LOG-for-determ.patch \ >> " >> SRC_URI:append:class-native = " \ >> file://perl-configpm-switch.patch \ >> -- >> 2.31.1 >> >> >> -=-=-=-=-=-=-=-=-=-=-=- >> Links: You receive all messages sent to this group. >> View/Reply Online (#162590): https://lists.openembedded.org/g/openembedded-core/message/162590 >> Mute This Topic: https://lists.openembedded.org/mt/89496472/1686489 >> Group Owner: openembedded-core+owner@lists.openembedded.org >> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com] >> -=-=-=-=-=-=-=-=-=-=-=- >> ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [OE-core] [PATCH 2/3] perl: Makefile.PL: Fix _PATH_LOG for deterministic build 2022-03-02 8:47 ` Robert Yang @ 2022-03-02 8:48 ` Alexander Kanavin 2022-03-02 9:49 ` Robert Yang 0 siblings, 1 reply; 8+ messages in thread From: Alexander Kanavin @ 2022-03-02 8:48 UTC (permalink / raw) To: Robert Yang; +Cc: OE-core Yes, but you do not need to submit the patch for inclusion, only to file a ticket, and ask upstream what can be done about the issue. Alex On Wed, 2 Mar 2022 at 09:47, Robert Yang <liezhi.yang@windriver.com> wrote: > > Hi > > On 3/2/22 4:42 PM, Alexander Kanavin wrote: > > Can you file a ticket upstream for this please, and include the link > > in the patch? > > > > This patch won't work for upstream, only work by cross building, let me check on > how to make it work for all cases. > > // Robert > > > > Alex > > > > On Wed, 2 Mar 2022 at 08:13, Robert Yang <liezhi.yang@windriver.com> wrote: > >> > >> It checks host's path such as /dev/log and uses it, this doesn't make sense for > >> cross build, and it causes undeterministic, for example, the contianer os > >> usually doesn't have /dev/log which leads to a different build result since > >> other host usually has /dev/log, so make it always use the default value to fix > >> the issue. > >> > >> Signed-off-by: Robert Yang <liezhi.yang@windriver.com> > >> --- > >> ...Makefile.PL-Fix-_PATH_LOG-for-determ.patch | 34 +++++++++++++++++++ > >> meta/recipes-devtools/perl/perl_5.34.0.bb | 1 + > >> 2 files changed, 35 insertions(+) > >> create mode 100644 meta/recipes-devtools/perl/files/0001-cpan-Sys-Syslog-Makefile.PL-Fix-_PATH_LOG-for-determ.patch > >> > >> diff --git a/meta/recipes-devtools/perl/files/0001-cpan-Sys-Syslog-Makefile.PL-Fix-_PATH_LOG-for-determ.patch b/meta/recipes-devtools/perl/files/0001-cpan-Sys-Syslog-Makefile.PL-Fix-_PATH_LOG-for-determ.patch > >> new file mode 100644 > >> index 00000000000..f6bcbce6856 > >> --- /dev/null > >> +++ b/meta/recipes-devtools/perl/files/0001-cpan-Sys-Syslog-Makefile.PL-Fix-_PATH_LOG-for-determ.patch > >> @@ -0,0 +1,34 @@ > >> +From a73fff1fcf0def4ce93964f1b63fe3ad0967259d Mon Sep 17 00:00:00 2001 > >> +From: Robert Yang <liezhi.yang@windriver.com> > >> +Date: Fri, 18 Feb 2022 09:44:26 +0000 > >> +Subject: [PATCH] cpan/Sys-Syslog/Makefile.PL: Fix _PATH_LOG for deterministic > >> + > >> +It checks host's path such as /dev/log and uses it, this doesn't make sense for > >> +cross build, and it causes undeterministic, for example, the contianer os > >> +usually doesn't have /dev/log which leads to a different build result since > >> +other host usually has /dev/log, so make it always use the default value to fix > >> +the issue. > >> + > >> +Upstream-Status:Inappropriate [OE specific] > >> + > >> +Signed-off-by: Robert Yang <liezhi.yang@windriver.com> > >> +--- > >> + cpan/Sys-Syslog/Makefile.PL | 2 ++ > >> + 1 file changed, 2 insertions(+) > >> + > >> +diff --git a/cpan/Sys-Syslog/Makefile.PL b/cpan/Sys-Syslog/Makefile.PL > >> +index d09ba69..d44e58c 100644 > >> +--- a/cpan/Sys-Syslog/Makefile.PL > >> ++++ b/cpan/Sys-Syslog/Makefile.PL > >> +@@ -130,6 +130,8 @@ else { > >> + $_PATH_LOG = ""; > >> + } > >> + > >> ++# OE specific > >> ++$_PATH_LOG = ""; > >> + > >> + # if possible, generate the code that handles the constants with > >> + # ExtUtils::Constant, otherwise use cached copy in fallback/ > >> +-- > >> +2.31.1 > >> + > >> diff --git a/meta/recipes-devtools/perl/perl_5.34.0.bb b/meta/recipes-devtools/perl/perl_5.34.0.bb > >> index a97da872032..8a1db7ed359 100644 > >> --- a/meta/recipes-devtools/perl/perl_5.34.0.bb > >> +++ b/meta/recipes-devtools/perl/perl_5.34.0.bb > >> @@ -20,6 +20,7 @@ SRC_URI = "https://www.cpan.org/src/5.0/perl-${PV}.tar.gz;name=perl \ > >> file://aacd2398e766500cb5d83c4d76b642fcf31d997a.patch \ > >> file://ea57297a58b8f10ab885c19eec48ea076116cc1f.patch \ > >> file://5bc1e5fdd87aa205011512cd1e6cc655bcf677fd.patch \ > >> + file://0001-cpan-Sys-Syslog-Makefile.PL-Fix-_PATH_LOG-for-determ.patch \ > >> " > >> SRC_URI:append:class-native = " \ > >> file://perl-configpm-switch.patch \ > >> -- > >> 2.31.1 > >> > >> > >> -=-=-=-=-=-=-=-=-=-=-=- > >> Links: You receive all messages sent to this group. > >> View/Reply Online (#162590): https://lists.openembedded.org/g/openembedded-core/message/162590 > >> Mute This Topic: https://lists.openembedded.org/mt/89496472/1686489 > >> Group Owner: openembedded-core+owner@lists.openembedded.org > >> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com] > >> -=-=-=-=-=-=-=-=-=-=-=- > >> ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [OE-core] [PATCH 2/3] perl: Makefile.PL: Fix _PATH_LOG for deterministic build 2022-03-02 8:48 ` Alexander Kanavin @ 2022-03-02 9:49 ` Robert Yang 0 siblings, 0 replies; 8+ messages in thread From: Robert Yang @ 2022-03-02 9:49 UTC (permalink / raw) To: Alexander Kanavin; +Cc: OE-core On 3/2/22 4:48 PM, Alexander Kanavin wrote: > Yes, but you do not need to submit the patch for inclusion, only to > file a ticket, and ask upstream what can be done about the issue. Thanks, submitted a ticket to upstream and add the url in the patch: Submitted a ticket to upstream: https://rt.cpan.org/Ticket/Display.html?id=141612 Upstream-Status: Inappropriate [OE specific] Signed-off-by: Robert Yang <liezhi.yang@windriver.com> And updated the patch in the PULL: git://git.openembedded.org/openembedded-core-contrib rbt/deterministic http://cgit.openembedded.org/openembedded-core-contrib/log/?h=rbt/deterministic // Robert > > Alex > > On Wed, 2 Mar 2022 at 09:47, Robert Yang <liezhi.yang@windriver.com> wrote: >> >> Hi >> >> On 3/2/22 4:42 PM, Alexander Kanavin wrote: >>> Can you file a ticket upstream for this please, and include the link >>> in the patch? >>> >> >> This patch won't work for upstream, only work by cross building, let me check on >> how to make it work for all cases. >> >> // Robert >> >> >>> Alex >>> >>> On Wed, 2 Mar 2022 at 08:13, Robert Yang <liezhi.yang@windriver.com> wrote: >>>> >>>> It checks host's path such as /dev/log and uses it, this doesn't make sense for >>>> cross build, and it causes undeterministic, for example, the contianer os >>>> usually doesn't have /dev/log which leads to a different build result since >>>> other host usually has /dev/log, so make it always use the default value to fix >>>> the issue. >>>> >>>> Signed-off-by: Robert Yang <liezhi.yang@windriver.com> >>>> --- >>>> ...Makefile.PL-Fix-_PATH_LOG-for-determ.patch | 34 +++++++++++++++++++ >>>> meta/recipes-devtools/perl/perl_5.34.0.bb | 1 + >>>> 2 files changed, 35 insertions(+) >>>> create mode 100644 meta/recipes-devtools/perl/files/0001-cpan-Sys-Syslog-Makefile.PL-Fix-_PATH_LOG-for-determ.patch >>>> >>>> diff --git a/meta/recipes-devtools/perl/files/0001-cpan-Sys-Syslog-Makefile.PL-Fix-_PATH_LOG-for-determ.patch b/meta/recipes-devtools/perl/files/0001-cpan-Sys-Syslog-Makefile.PL-Fix-_PATH_LOG-for-determ.patch >>>> new file mode 100644 >>>> index 00000000000..f6bcbce6856 >>>> --- /dev/null >>>> +++ b/meta/recipes-devtools/perl/files/0001-cpan-Sys-Syslog-Makefile.PL-Fix-_PATH_LOG-for-determ.patch >>>> @@ -0,0 +1,34 @@ >>>> +From a73fff1fcf0def4ce93964f1b63fe3ad0967259d Mon Sep 17 00:00:00 2001 >>>> +From: Robert Yang <liezhi.yang@windriver.com> >>>> +Date: Fri, 18 Feb 2022 09:44:26 +0000 >>>> +Subject: [PATCH] cpan/Sys-Syslog/Makefile.PL: Fix _PATH_LOG for deterministic >>>> + >>>> +It checks host's path such as /dev/log and uses it, this doesn't make sense for >>>> +cross build, and it causes undeterministic, for example, the contianer os >>>> +usually doesn't have /dev/log which leads to a different build result since >>>> +other host usually has /dev/log, so make it always use the default value to fix >>>> +the issue. >>>> + >>>> +Upstream-Status:Inappropriate [OE specific] >>>> + >>>> +Signed-off-by: Robert Yang <liezhi.yang@windriver.com> >>>> +--- >>>> + cpan/Sys-Syslog/Makefile.PL | 2 ++ >>>> + 1 file changed, 2 insertions(+) >>>> + >>>> +diff --git a/cpan/Sys-Syslog/Makefile.PL b/cpan/Sys-Syslog/Makefile.PL >>>> +index d09ba69..d44e58c 100644 >>>> +--- a/cpan/Sys-Syslog/Makefile.PL >>>> ++++ b/cpan/Sys-Syslog/Makefile.PL >>>> +@@ -130,6 +130,8 @@ else { >>>> + $_PATH_LOG = ""; >>>> + } >>>> + >>>> ++# OE specific >>>> ++$_PATH_LOG = ""; >>>> + >>>> + # if possible, generate the code that handles the constants with >>>> + # ExtUtils::Constant, otherwise use cached copy in fallback/ >>>> +-- >>>> +2.31.1 >>>> + >>>> diff --git a/meta/recipes-devtools/perl/perl_5.34.0.bb b/meta/recipes-devtools/perl/perl_5.34.0.bb >>>> index a97da872032..8a1db7ed359 100644 >>>> --- a/meta/recipes-devtools/perl/perl_5.34.0.bb >>>> +++ b/meta/recipes-devtools/perl/perl_5.34.0.bb >>>> @@ -20,6 +20,7 @@ SRC_URI = "https://www.cpan.org/src/5.0/perl-${PV}.tar.gz;name=perl \ >>>> file://aacd2398e766500cb5d83c4d76b642fcf31d997a.patch \ >>>> file://ea57297a58b8f10ab885c19eec48ea076116cc1f.patch \ >>>> file://5bc1e5fdd87aa205011512cd1e6cc655bcf677fd.patch \ >>>> + file://0001-cpan-Sys-Syslog-Makefile.PL-Fix-_PATH_LOG-for-determ.patch \ >>>> " >>>> SRC_URI:append:class-native = " \ >>>> file://perl-configpm-switch.patch \ >>>> -- >>>> 2.31.1 >>>> >>>> >>>> -=-=-=-=-=-=-=-=-=-=-=- >>>> Links: You receive all messages sent to this group. >>>> View/Reply Online (#162590): https://lists.openembedded.org/g/openembedded-core/message/162590 >>>> Mute This Topic: https://lists.openembedded.org/mt/89496472/1686489 >>>> Group Owner: openembedded-core+owner@lists.openembedded.org >>>> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com] >>>> -=-=-=-=-=-=-=-=-=-=-=- >>>> ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 3/3] cups: Add --with-dbusdir to EXTRA_OECONF for deterministic build 2022-03-02 7:12 [PATCH 0/3] 3 fixes for deterministic build Robert Yang 2022-03-02 7:12 ` [PATCH 1/3] quilt: Disable external sendmail " Robert Yang 2022-03-02 7:12 ` [PATCH 2/3] perl: Makefile.PL: Fix _PATH_LOG " Robert Yang @ 2022-03-02 7:12 ` Robert Yang 2 siblings, 0 replies; 8+ messages in thread From: Robert Yang @ 2022-03-02 7:12 UTC (permalink / raw) To: openembedded-core The configure checks /etc/dbus-1 and set DBUSDIR is null: if test -d /etc/dbus-1 -a "x$DBUSDIR" = x; then DBUSDIR="/etc/dbus-1" fi So that the build resutl would be different w/o /etc/dbus-1: /etc/dbus-1/system.d/cups.conf (Only exists when DBUSDIR is set) Add --with-dbusdir to EXTRA_OECONF to fix the issue Signed-off-by: Robert Yang <liezhi.yang@windriver.com> --- meta/recipes-extended/cups/cups.inc | 1 + 1 file changed, 1 insertion(+) diff --git a/meta/recipes-extended/cups/cups.inc b/meta/recipes-extended/cups/cups.inc index 6f28dc30d03..8f2ad8a0098 100644 --- a/meta/recipes-extended/cups/cups.inc +++ b/meta/recipes-extended/cups/cups.inc @@ -49,6 +49,7 @@ PACKAGECONFIG[xinetd] = "--with-xinetd=${sysconfdir}/xinetd.d,--without-xinetd,x EXTRA_OECONF = " \ --enable-dbus \ + --with-dbusdir=${sysconfdir}/dbus-1 \ --enable-browsing \ --disable-gssapi \ --enable-debug \ -- 2.31.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-03-02 9:49 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-03-02 7:12 [PATCH 0/3] 3 fixes for deterministic build Robert Yang 2022-03-02 7:12 ` [PATCH 1/3] quilt: Disable external sendmail " Robert Yang 2022-03-02 7:12 ` [PATCH 2/3] perl: Makefile.PL: Fix _PATH_LOG " Robert Yang 2022-03-02 8:42 ` [OE-core] " Alexander Kanavin 2022-03-02 8:47 ` Robert Yang 2022-03-02 8:48 ` Alexander Kanavin 2022-03-02 9:49 ` Robert Yang 2022-03-02 7:12 ` [PATCH 3/3] cups: Add --with-dbusdir to EXTRA_OECONF " Robert Yang
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.