[bitbake][dunfell][1.46][PATCH 0/1] Patch review

[bitbake][dunfell][1.46][PATCH 0/1] Patch review

[Steve Sakoman]

Passed a-full on autobuilder:

https://autobuilder.yoctoproject.org/typhoon/#/builders/83/builds/3445

The following changes since commit 41bf1fa85a540232dcf92fe473c3b3c4cd7259dd:

  tinfoil: Allow run_command not to wait on events (2022-03-28 13:30:40 +0100)

are available in the Git repository at:

  git://git.openembedded.org/bitbake-contrib stable/1.46-nut
  http://cgit.openembedded.org/bitbake-contrib/log/?h=stable/1.46-nut

Scott Weaver (1):
  fetch2: add check for empty SRC_URI hash string

 lib/bb/fetch2/__init__.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

-- 
2.25.1

[bitbake][dunfell][1.46][PATCH 1/1] fetch2: add check for empty SRC_URI hash string

[Steve Sakoman]

From: Scott Weaver <weaverjs@gmail.com>

No error was being reported when the hash string was set to empty.
For example: SRC_URI[md5sum] = ""

On a related note (not a bug):
Because whitespace in the string will result in a checksum mismatch, the error
message was updated to make it a little clearer why the error was thrown.
For example: SRC_URI[md5sum] = " " or
SRC_URI[md5sum] = " 209f8326f5137d8817a6276d9577a2f1"

Now creates a message like this:
File: '/home/scott/yocto-cache/downloads/rsync-3.2.3.tar.gz' has md5
checksum '209f8326f5137d8817a6276d9577a2f1' when ' 209f8326f5137d8817a6276d9577a2f1' was expected

[YOCTO #14232]

Signed-off-by: Scott Weaver <weaverjs@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
(cherry picked from commit a13510d0028e234ea2f4744b0d0c38558395c70f)
Signed-off-by: Steve Sakoman <steve@sakoman.com>
---
 lib/bb/fetch2/__init__.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/lib/bb/fetch2/__init__.py b/lib/bb/fetch2/__init__.py
index dc99914c..3e6555bd 100644
--- a/lib/bb/fetch2/__init__.py
+++ b/lib/bb/fetch2/__init__.py
@@ -562,6 +562,9 @@ def verify_checksum(ud, d, precomputed={}):
 
         checksum_expected = getattr(ud, "%s_expected" % checksum_id)
 
+        if checksum_expected == '':
+            checksum_expected = None
+
         return {
             "id": checksum_id,
             "name": checksum_name,
@@ -612,7 +615,7 @@ def verify_checksum(ud, d, precomputed={}):
 
     for ci in checksum_infos:
         if ci["expected"] and ci["expected"] != ci["data"]:
-            messages.append("File: '%s' has %s checksum %s when %s was " \
+            messages.append("File: '%s' has %s checksum '%s' when '%s' was " \
                             "expected" % (ud.localpath, ci["id"], ci["data"], ci["expected"]))
             bad_checksum = ci["data"]
 
-- 
2.25.1

Re: [bitbake-devel] [bitbake][dunfell][1.46][PATCH 1/1] fetch2: add check for empty SRC_URI hash string

[Jose Quaresma]

[-- Attachment #1: Type: text/plain, Size: 2753 bytes --]

Hi Steve,

Thanks for that, this will improve some errors reporting on the fetch.

Acked-by: Jose Quaresma <quaresma.jose@gmail.com>

Jose

Steve Sakoman <steve@sakoman.com> escreveu no dia quarta, 30/03/2022 à(s)
17:39:

> From: Scott Weaver <weaverjs@gmail.com>
>
> No error was being reported when the hash string was set to empty.
> For example: SRC_URI[md5sum] = ""
>
> On a related note (not a bug):
> Because whitespace in the string will result in a checksum mismatch, the
> error
> message was updated to make it a little clearer why the error was thrown.
> For example: SRC_URI[md5sum] = " " or
> SRC_URI[md5sum] = " 209f8326f5137d8817a6276d9577a2f1"
>
> Now creates a message like this:
> File: '/home/scott/yocto-cache/downloads/rsync-3.2.3.tar.gz' has md5
> checksum '209f8326f5137d8817a6276d9577a2f1' when '
> 209f8326f5137d8817a6276d9577a2f1' was expected
>
> [YOCTO #14232]
>
> Signed-off-by: Scott Weaver <weaverjs@gmail.com>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> (cherry picked from commit a13510d0028e234ea2f4744b0d0c38558395c70f)
> Signed-off-by: Steve Sakoman <steve@sakoman.com>
> ---
>  lib/bb/fetch2/__init__.py | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/lib/bb/fetch2/__init__.py b/lib/bb/fetch2/__init__.py
> index dc99914c..3e6555bd 100644
> --- a/lib/bb/fetch2/__init__.py
> +++ b/lib/bb/fetch2/__init__.py
> @@ -562,6 +562,9 @@ def verify_checksum(ud, d, precomputed={}):
>
>          checksum_expected = getattr(ud, "%s_expected" % checksum_id)
>
> +        if checksum_expected == '':
> +            checksum_expected = None
> +
>          return {
>              "id": checksum_id,
>              "name": checksum_name,
> @@ -612,7 +615,7 @@ def verify_checksum(ud, d, precomputed={}):
>
>      for ci in checksum_infos:
>          if ci["expected"] and ci["expected"] != ci["data"]:
> -            messages.append("File: '%s' has %s checksum %s when %s was " \
> +            messages.append("File: '%s' has %s checksum '%s' when '%s'
> was " \
>                              "expected" % (ud.localpath, ci["id"],
> ci["data"], ci["expected"]))
>              bad_checksum = ci["data"]
>
> --
> 2.25.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#13552):
> https://lists.openembedded.org/g/bitbake-devel/message/13552
> Mute This Topic: https://lists.openembedded.org/mt/90135601/5052612
> Group Owner: bitbake-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/bitbake-devel/unsub [
> quaresma.jose@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>

-- 
Best regards,

José Quaresma

[-- Attachment #2: Type: text/html, Size: 4388 bytes --]

[bitbake][dunfell][1.46][PATCH 0/1] Patch review

[Steve Sakoman]

Please review this patch for the upcoming dunfell 3.1.19 release.

Passed a-full on autobuilder:

https://autobuilder.yoctoproject.org/typhoon/#/builders/83/builds/4098

The following changes since commit 7fc4cffebf5dcc1d050416c0b7f7d58c765c1d69:

  fetch/wget: Move files into place atomically (2022-07-08 06:48:38 -1000)

are available in the Git repository at:

  git://git.openembedded.org/bitbake-contrib stable/1.46-nut
  http://cgit.openembedded.org/bitbake-contrib/log/?h=stable/1.46-nut

Christophe Priouzeau (1):
  fetch2/wget: Update user-agent

 lib/bb/fetch2/wget.py | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

-- 
2.25.1

[bitbake][dunfell][1.46][PATCH 0/1] Patch review

[Steve Sakoman]

Just a single patch this time, please have any comments back by end of
day Monday.

Passed a-full on autobuilder:

https://autobuilder.yoctoproject.org/typhoon/#/builders/83/builds/3880

The following changes since commit a496a8952d8542ce814b13f460811d8849d25a3c:

  knotty: reduce keep-alive timeout from 5000s (83 minutes) to 10 minutes (2022-06-16 07:15:39 -1000)

are available in the Git repository at:

  git://git.openembedded.org/bitbake-contrib stable/1.46-nut
  http://cgit.openembedded.org/bitbake-contrib/log/?h=stable/1.46-nut

Joey Degges (1):
  fetch/git: Fix usehead for non-default names

 lib/bb/fetch2/git.py  |  7 +++++-
 lib/bb/tests/fetch.py | 52 +++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 58 insertions(+), 1 deletion(-)

-- 
2.25.1

[bitbake][dunfell][1.46][PATCH 0/1] Patch review

[Steve Sakoman]

This patch fixes the bitbake timeout errors seen in distros still using python 3.5

Verified with oe-selftest-ubuntu on autobuilder worker ubuntu1604-ty-1:

https://autobuilder.yoctoproject.org/typhoon/#/builders/87/builds/3088

As well as a-full on other distros:

https://autobuilder.yoctoproject.org/typhoon/#/builders/83/builds/3141

The following changes since commit e6d75e0beb95aa0cdf82bbc0a6b767c7f6cfcfc0:

  tests/fetch: Drop gnu urls from wget connectivity test (2022-01-17 21:53:02 +0000)

are available in the Git repository at:

  git://git.openembedded.org/bitbake-contrib stable/1.46-nut
  http://cgit.openembedded.org/bitbake-contrib/log/?h=stable/1.46-nut

Jate Sujjavanich (1):
  hashserv: specify loop for asyncio in python < 3.7

 lib/hashserv/server.py | 23 +++++++++++++++++------
 1 file changed, 17 insertions(+), 6 deletions(-)

-- 
2.25.1

[bitbake][dunfell][1.46][PATCH 0/1] Patch review

[Steve Sakoman]

This patch is associated with the python3targetconfig patches currently being
reviewed for oe-core.

Passed a-full when tested with those patches on autobuilder:

https://autobuilder.yoctoproject.org/typhoon/#/builders/83/builds/1852

The following changes since commit 2351b496bb63b96920d4ae67bec816f00d510df2:

  fetch/git: download LFS content too during do_fetch (2021-02-05 12:18:26 +0000)

are available in the Git repository at:

  git://git.openembedded.org/bitbake-contrib stable/1.46-nut
  http://cgit.openembedded.org/bitbake-contrib/log/?h=stable/1.46-nut

Alexander Kanavin (1):
  lib/bb/fetch2/__init__.py: drop _PYTHON_SYSCONFIGDATA_NAME unsetting

 lib/bb/fetch2/__init__.py | 5 -----
 1 file changed, 5 deletions(-)

-- 
2.25.1