[meta-perl][PATCH 0/3] libio-compress/libcompress fixes

[meta-perl][PATCH 0/3] libio-compress/libcompress fixes

[Tim Orling]

There are a number of issues with these recipes that have been lingering
for a long time: 

* The compress-raw-*-perl recipes should never have been merged as is,
  they break Debian naming (should be libcompress-raw-*-perl).
* There are issues with the HOMEPAGE fields in all the
  compress-raw-*-perl and libio-compress-*-perl recipes.
* The SRC_URI for all these recipes was hardcoded to PV, which breaks
  the auto-upgrade-helper (AUH).
* A number of RDEPENDS were missing (this is a systemic problem with our
  perl rdeps--see https://bugzilla.yoctoproject.org/show_bug.cgi?id=13376)

There are probably more changes to come with the upgrades, including
enabling ptest, but for now these patches improve the situation.

(Based on current master-next)

The following changes since commit fc176683e6f0efaa789c30b5a6cdc4b5ed1570f5:

  libmime-types-perl: upgrade 2.17 -> 2.22 (2022-10-30 17:49:08 -0700)

are available in the Git repository at:

  https://git.openembedded.org/meta-openembedded-contrib timo/libcompress_libio-compress_fixes
  http://cgit.openembedded.org/meta-openembedded-contrib/log/?h=timo/libcompress_libio-compress_fixes

Tim Orling (3):
  libcompress-raw*-perl: move from libio/compress-*
  libio-compress*-perl: cleanup; fixes
  libcompress-raw-*-perl: cleanup; fixes

 .../libcompress-raw-bzip2-perl_2.096.bb}      | 11 ++----
 .../libcompress-raw-lzma-perl_2.096.bb}       | 19 ++++-----
 .../libcompress-raw-zlib-perl_2.096.bb}       | 16 ++++----
 .../libio/libio-compress-lzma-perl_2.096.bb   | 23 +++++------
 .../libio/libio-compress-perl_2.096.bb        | 39 +++++++++++++------
 5 files changed, 61 insertions(+), 47 deletions(-)
 rename meta-perl/recipes-perl/{libio/compress-raw-bzip2-perl_2.096.bb => libcompress/libcompress-raw-bzip2-perl_2.096.bb} (63%)
 rename meta-perl/recipes-perl/{libio/compress-raw-lzma-perl_2.096.bb => libcompress/libcompress-raw-lzma-perl_2.096.bb} (50%)
 rename meta-perl/recipes-perl/{libio/compress-raw-zlib-perl_2.096.bb => libcompress/libcompress-raw-zlib-perl_2.096.bb} (45%)

-- 
2.34.1

[meta-perl][PATCH 1/3] libcompress-raw*-perl: move from libio/compress-*

[Tim Orling]

These modules do not follow our Debian naming and should never have been
allowed to be added as libio/compress-raw*.bb.

Signed-off-by: Tim Orling <tim.orling@konsulko.com>
---
 .../libcompress-raw-bzip2-perl_2.096.bb}                          | 0
 .../libcompress-raw-lzma-perl_2.096.bb}                           | 0
 .../libcompress-raw-zlib-perl_2.096.bb}                           | 0
 3 files changed, 0 insertions(+), 0 deletions(-)
 rename meta-perl/recipes-perl/{libio/compress-raw-bzip2-perl_2.096.bb => libcompress/libcompress-raw-bzip2-perl_2.096.bb} (100%)
 rename meta-perl/recipes-perl/{libio/compress-raw-lzma-perl_2.096.bb => libcompress/libcompress-raw-lzma-perl_2.096.bb} (100%)
 rename meta-perl/recipes-perl/{libio/compress-raw-zlib-perl_2.096.bb => libcompress/libcompress-raw-zlib-perl_2.096.bb} (100%)

diff --git a/meta-perl/recipes-perl/libio/compress-raw-bzip2-perl_2.096.bb b/meta-perl/recipes-perl/libcompress/libcompress-raw-bzip2-perl_2.096.bb
similarity index 100%
rename from meta-perl/recipes-perl/libio/compress-raw-bzip2-perl_2.096.bb
rename to meta-perl/recipes-perl/libcompress/libcompress-raw-bzip2-perl_2.096.bb
diff --git a/meta-perl/recipes-perl/libio/compress-raw-lzma-perl_2.096.bb b/meta-perl/recipes-perl/libcompress/libcompress-raw-lzma-perl_2.096.bb
similarity index 100%
rename from meta-perl/recipes-perl/libio/compress-raw-lzma-perl_2.096.bb
rename to meta-perl/recipes-perl/libcompress/libcompress-raw-lzma-perl_2.096.bb
diff --git a/meta-perl/recipes-perl/libio/compress-raw-zlib-perl_2.096.bb b/meta-perl/recipes-perl/libcompress/libcompress-raw-zlib-perl_2.096.bb
similarity index 100%
rename from meta-perl/recipes-perl/libio/compress-raw-zlib-perl_2.096.bb
rename to meta-perl/recipes-perl/libcompress/libcompress-raw-zlib-perl_2.096.bb
-- 
2.34.1

[meta-perl][PATCH 2/3] libio-compress*-perl: cleanup; fixes

[Tim Orling]

* Fix hardcoded PV in SRC_URI
* Use README for LIC_FILES_CHKSUM
* Fix HOMEPAGE
* Add SUMMARY
* Use upstream README for DESCRIPTION
* Correct libcompression-*-perl RDEPENDS
* Fix RDEPENDS

Handy on-target check for dependencies:
for path in $(find /usr/lib/perl5/vendor_perl/5.36.0/IO -name *.pm | sed
-e 's~/usr/lib/perl5/vendor_perl/5.36.0/~~' -e 's~/~::~g' -e 's~.pm~~');
do perl -M${path} -e'print'; done

Signed-off-by: Tim Orling <tim.orling@konsulko.com>
---
 .../libio/libio-compress-lzma-perl_2.096.bb   | 23 +++++------
 .../libio/libio-compress-perl_2.096.bb        | 39 +++++++++++++------
 2 files changed, 40 insertions(+), 22 deletions(-)

diff --git a/meta-perl/recipes-perl/libio/libio-compress-lzma-perl_2.096.bb b/meta-perl/recipes-perl/libio/libio-compress-lzma-perl_2.096.bb
index 15952f17e6..09ed161d2e 100644
--- a/meta-perl/recipes-perl/libio/libio-compress-lzma-perl_2.096.bb
+++ b/meta-perl/recipes-perl/libio/libio-compress-lzma-perl_2.096.bb
@@ -1,24 +1,25 @@
-DESCRIPTION = "This module provides a Perl interface that allows writing lzma compressed \
-data to files or buffer."
-
+SUMMARY = "Perl interface to allow reading and writing of lzma files/buffers."
+DESCRIPTION = "This module provides a Perl interface to allow reading and \
+writing of lzma files/buffers."
+HOMEPAGE = "https://metacpan.org/release/IO-Compress-Lzma"
 SECTION = "libs"
 LICENSE = "Artistic-1.0 | GPL-1.0-or-later"
 
-MAINTAINER=	"Poky <poky@yoctoproject.org>"
-HOMEPAGE=	"https://metacpan.org/release/IO-Compress-Lzma"
-
-LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/Artistic-1.0;md5=cda03bbdc3c1951996392b872397b798 \
-file://${COMMON_LICENSE_DIR}/GPL-1.0-only;md5=e9e36a9de734199567a4d769498f743d"
+LIC_FILES_CHKSUM = "file://README;beginline=8;endline=10;md5=2d411393b876fe63f9f1d546363f1a47"
 
-SRC_URI = "https://cpan.metacpan.org/authors/id/P/PM/PMQS/IO-Compress-Lzma-2.096.tar.gz"
+SRC_URI = "${CPAN_MIRROR}/authors/id/P/PM/PMQS/IO-Compress-Lzma-${PV}.tar.gz"
 
 SRC_URI[md5sum] = "6c1b70740605b8073e4fbb5ba1e7bbdb"
 SRC_URI[sha256sum] = "2f29125f19bb41d29c4b5a2467e3560b7bce5d428176a046b7c8a51609dce6e8"
-RDEPENDS:${PN} += "compress-raw-lzma-perl"
-RDEPENDS:${PN} += "libio-compress-perl"
 
 S = "${WORKDIR}/IO-Compress-Lzma-${PV}"
 
 inherit cpan
 
+RDEPENDS:${PN} += "\
+    perl-module-autoloader \
+    libcompress-raw-lzma-perl \
+    libio-compress-perl \
+"
+
 BBCLASSEXTEND = "native"
diff --git a/meta-perl/recipes-perl/libio/libio-compress-perl_2.096.bb b/meta-perl/recipes-perl/libio/libio-compress-perl_2.096.bb
index c00d8945b7..ea120b8246 100644
--- a/meta-perl/recipes-perl/libio/libio-compress-perl_2.096.bb
+++ b/meta-perl/recipes-perl/libio/libio-compress-perl_2.096.bb
@@ -1,24 +1,41 @@
-DESCRIPTION = "This module is not intended for direct use in application code. Its sole \
-purpose is to be sub-classed by IO::Compress modules."
-
+SUMMARY = "Perl interface to allow reading and writing of compressed data."
+DESCRIPTION = "This distribution provides a Perl interface to allow reading \
+and writing of compressed data created with the zlib and bzip2. \
+\ 
+IO-Compress supports reading and writing of the following compressed data \
+formats \
+  * bzip2 \
+  * RFC 1950 \
+  * RFC 1951 \
+  * RFC 1952 (i.e. gzip) \
+  * zip \
+"
+HOMEPAGE = "https://metacpan.org/release/IO-Compress"
 SECTION = "libs"
 LICENSE = "Artistic-1.0 | GPL-1.0-or-later"
 
-MAINTAINER=	"Poky <poky@yoctoproject.org>"
-HOMEPAGE=	"https://metacpan.org/release/IO-Compress"
-
-LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/Artistic-1.0;md5=cda03bbdc3c1951996392b872397b798 \
-file://${COMMON_LICENSE_DIR}/GPL-1.0-only;md5=e9e36a9de734199567a4d769498f743d"
+LIC_FILES_CHKSUM = "file://README;beginline=8;endline=10;md5=36e282c4a4078cf2650d656cdda23210"
 
-SRC_URI = "https://cpan.metacpan.org/authors/id/P/PM/PMQS/IO-Compress-2.096.tar.gz"
+SRC_URI = "${CPAN_MIRROR}/authors/id/P/PM/PMQS/IO-Compress-${PV}.tar.gz"
 
 SRC_URI[md5sum] = "18ad197cad5ca87bc3a7d2538998e017"
 SRC_URI[sha256sum] = "9d219fd5df4b490b5d2f847921e3cb1c3392758fa0bae9b05a8992b3620ba572"
-RDEPENDS:${PN} += "compress-raw-bzip2-perl"
-RDEPENDS:${PN} += "compress-raw-zlib-perl"
 
 S = "${WORKDIR}/IO-Compress-${PV}"
 
 inherit cpan
 
+RDEPENDS:${PN} += "\
+    perl-module-bytes \
+    perl-module-cwd \
+    perl-module-encode \
+    perl-module-file-glob \
+    perl-module-file-spec \
+    perl-module-posix \
+    perl-module-scalar-util \
+    perl-module-utf8 \
+    libcompress-raw-bzip2-perl \
+    libcompress-raw-zlib-perl \
+"
+
 BBCLASSEXTEND = "native"
-- 
2.34.1

[meta-perl][PATCH 3/3] libcompress-raw-*-perl: cleanup; fixes

[Tim Orling]

* Add SUMMARY
* Fix HOMEPAGE
* Fix RDEPENDS
* Use README for LIC_FILES_CHKSUM

Signed-off-by: Tim Orling <tim.orling@konsulko.com>
---
 .../libcompress-raw-bzip2-perl_2.096.bb       | 11 ++++-------
 .../libcompress-raw-lzma-perl_2.096.bb        | 19 ++++++++++---------
 .../libcompress-raw-zlib-perl_2.096.bb        | 16 +++++++---------
 3 files changed, 21 insertions(+), 25 deletions(-)

diff --git a/meta-perl/recipes-perl/libcompress/libcompress-raw-bzip2-perl_2.096.bb b/meta-perl/recipes-perl/libcompress/libcompress-raw-bzip2-perl_2.096.bb
index ef69987ea3..238c988850 100644
--- a/meta-perl/recipes-perl/libcompress/libcompress-raw-bzip2-perl_2.096.bb
+++ b/meta-perl/recipes-perl/libcompress/libcompress-raw-bzip2-perl_2.096.bb
@@ -1,16 +1,13 @@
+SUMMARY = "Low-Level Interface to bzip2 compression library"
 DESCRIPTION = ""Compress::Raw::Bzip2" provides an interface to the in-memory \
 compression/uncompression functions from the bzip2 compression library."
-
+HOMEPAGE = "https://metacpan.org/release/Compress-Raw-Bzip2"
 SECTION = "libs"
 LICENSE = "Artistic-1.0 | GPL-1.0-or-later"
 
-MAINTAINER=	"Poky <poky@yoctoproject.org>"
-HOMEPAGE=	"https://metacpan.org/release/Compress-Raw-Bzip2"
-
-LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/Artistic-1.0;md5=cda03bbdc3c1951996392b872397b798 \
-file://${COMMON_LICENSE_DIR}/GPL-1.0-only;md5=e9e36a9de734199567a4d769498f743d"
+LIC_FILES_CHKSUM = "file://README;beginline=8;endline=10;md5=33084b7f607ba5d38a64b22f8e332f87"
 
-SRC_URI = "https://cpan.metacpan.org/authors/id/P/PM/PMQS/Compress-Raw-Bzip2-2.096.tar.gz"
+SRC_URI = "${CPAN_MIRROR}/authors/id/P/PM/PMQS/Compress-Raw-Bzip2-${PV}.tar.gz"
 
 SRC_URI[md5sum] = "4fdb7ea5071e4b774c52c37331386355"
 SRC_URI[sha256sum] = "a564e7634eca7740c5487d01effe1461e9e51b8909e69b3d8f5be98997958cbe"
diff --git a/meta-perl/recipes-perl/libcompress/libcompress-raw-lzma-perl_2.096.bb b/meta-perl/recipes-perl/libcompress/libcompress-raw-lzma-perl_2.096.bb
index 04295cd3c6..0cd876be45 100644
--- a/meta-perl/recipes-perl/libcompress/libcompress-raw-lzma-perl_2.096.bb
+++ b/meta-perl/recipes-perl/libcompress/libcompress-raw-lzma-perl_2.096.bb
@@ -1,16 +1,13 @@
-DESCRIPTION = ""Compress::Raw::Lzma" provides an interface to the in-memory \
-compression/uncompression functions from the lzma compression library."
-
+SUMMARY = "Low-Level Interface to lzma compresion library."
+DESCRIPTION = "This module provides a Perl interface to allow reading and \
+wrting of lzma, lzip and xz files/buffers."
+HOMEPAGE = "https://metacpan.org/release/Compress-Raw-Lzma"
 SECTION = "libs"
 LICENSE = "Artistic-1.0 | GPL-1.0-or-later"
 
-MAINTAINER=	"Poky <poky@yoctoproject.org>"
-HOMEPAGE=	"https://metacpan.org/release/Compress-Raw-Lzma"
-
-LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/Artistic-1.0;md5=cda03bbdc3c1951996392b872397b798 \
-file://${COMMON_LICENSE_DIR}/GPL-1.0-only;md5=e9e36a9de734199567a4d769498f743d"
+LIC_FILES_CHKSUM = "file://README;beginline=8;endline=10;md5=2d411393b876fe63f9f1d546363f1a47"
 
-SRC_URI = "https://cpan.metacpan.org/authors/id/P/PM/PMQS/Compress-Raw-Lzma-2.096.tar.gz"
+SRC_URI = "${CPAN_MIRROR}/authors/id/P/PM/PMQS/Compress-Raw-Lzma-${PV}.tar.gz"
 
 SRC_URI[md5sum] = "b5079bb43712fcd1e74b80777fa376ed"
 SRC_URI[sha256sum] = "f3afb267b1303b0f125976e9e4a70c6a4a205e35e7c99b408911f5e5c6578217"
@@ -21,6 +18,10 @@ S = "${WORKDIR}/Compress-Raw-Lzma-${PV}"
 
 inherit cpan
 
+RDEPENDS:${PN} += "\
+    perl-module-universal \
+"
+
 export LIBLZMA_INCLUDE="-I${STAGING_DIR_HOST}${includedir}"
 export LIBLZMA_LIB="-I${STAGING_DIR_HOST}${libdir}"
 
diff --git a/meta-perl/recipes-perl/libcompress/libcompress-raw-zlib-perl_2.096.bb b/meta-perl/recipes-perl/libcompress/libcompress-raw-zlib-perl_2.096.bb
index 81c370df2a..dcd5badab9 100644
--- a/meta-perl/recipes-perl/libcompress/libcompress-raw-zlib-perl_2.096.bb
+++ b/meta-perl/recipes-perl/libcompress/libcompress-raw-zlib-perl_2.096.bb
@@ -1,16 +1,14 @@
-DESCRIPTION = "The *Compress::Raw::Zlib* module provides a Perl interface to the *zlib* \
-compression library (see "AUTHOR" for details about where to get *zlib*)."
-
+SUMMARY = "Perl interface to the zlib compression library."
+DESCRIPTION = "The Compress::Raw::Zlib module provides a Perl interface \
+to the zlib compression library (see 'AUTHOR' for details about where to \
+get zlib)."
+HOMEPAGE = "https://metacpan.org/release/Compress-Raw-Zlib"
 SECTION = "libs"
 LICENSE = "Artistic-1.0 | GPL-1.0-or-later"
 
-MAINTAINER=	"Poky <poky@yoctoproject.org>"
-HOMEPAGE=	"https://metacpan.org/release/Compress-Raw-Zlib"
-
-LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/Artistic-1.0;md5=cda03bbdc3c1951996392b872397b798 \
-file://${COMMON_LICENSE_DIR}/GPL-1.0-only;md5=e9e36a9de734199567a4d769498f743d"
+LIC_FILES_CHKSUM = "file://README;beginline=8;endline=17;md5=603fa463887aed6bb3f6f2a999aca775"
 
-SRC_URI = "https://cpan.metacpan.org/authors/id/P/PM/PMQS/Compress-Raw-Zlib-2.096.tar.gz"
+SRC_URI = "${CPAN_MIRROR}/authors/id/P/PM/PMQS/Compress-Raw-Zlib-${PV}.tar.gz"
 
 SRC_URI[md5sum] = "4144ecdd901231553447998cf8035e4a"
 SRC_URI[sha256sum] = "cd4cba20c159a7748b8bc91278524a7da70573d9531fde62298609a5f1c65912"
-- 
2.34.1