All of lore.kernel.org
 help / color / mirror / Atom feed
From: Glenn Washburn <development@efficientek.com>
To: Jan Kiszka <jan.kiszka@siemens.com>,
	Kieran Bingham <kbingham@kernel.org>
Cc: linux-um <linux-um@lists.infradead.org>,
	Richard Weinberger <richard@nod.at>,
	Johannes Berg <johannes@sipsolutions.net>,
	Anton Ivanov <anton.ivanov@kot-begemot.co.uk>,
	linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Glenn Washburn <development@efficientek.com>
Subject: [PATCH v3 0/2] GDB: Support getting current task struct in UML
Date: Sun, 26 Feb 2023 22:05:58 -0600	[thread overview]
Message-ID: <cover.1677469905.git.development@efficientek.com> (raw)

Changes in v3:
  - Rebase onto tip.

Changes in v2:
  - Use cpu_tasks symbols instead of uml_kmalloc when determining if the
    kernel is a UML kernel.
  - Improve formatting.

Glenn

Glenn Washburn (2):
  scripts/gdb: Correct indentation in get_current_task
  scripts/gdb: Support getting current task struct in UML

 scripts/gdb/linux/cpus.py | 24 +++++++++++++++---------
 1 file changed, 15 insertions(+), 9 deletions(-)

Range-diff against v2:
1:  918bc1299bdb ! 1:  2e117b82240d scripts/gdb: Correct indentation in get_current_task
    @@ scripts/gdb/linux/cpus.py: def get_current_task(cpu):
          task_ptr_type = task_type.get_type().pointer()
      
          if utils.is_target_arch("x86"):
    --         var_ptr = gdb.parse_and_eval("&current_task")
    +-         var_ptr = gdb.parse_and_eval("&pcpu_hot.current_task")
     -         return per_cpu(var_ptr, cpu).dereference()
    -+        var_ptr = gdb.parse_and_eval("&current_task")
    ++        var_ptr = gdb.parse_and_eval("&pcpu_hot.current_task")
     +        return per_cpu(var_ptr, cpu).dereference()
          elif utils.is_target_arch("aarch64"):
     -         current_task_addr = gdb.parse_and_eval("$SP_EL0")
2:  93fc6584ea16 ! 2:  b839d611e290 scripts/gdb: Support getting current task struct in UML
    @@ scripts/gdb/linux/cpus.py: def get_current_task(cpu):
          task_ptr_type = task_type.get_type().pointer()
      
          if utils.is_target_arch("x86"):
    --        var_ptr = gdb.parse_and_eval("&current_task")
    +-        var_ptr = gdb.parse_and_eval("&pcpu_hot.current_task")
     -        return per_cpu(var_ptr, cpu).dereference()
     +        if gdb.lookup_global_symbol("cpu_tasks"):
     +            # This is a UML kernel, which stores the current task
    @@ scripts/gdb/linux/cpus.py: def get_current_task(cpu):
     +            var_ptr = gdb.parse_and_eval("(struct task_struct *)cpu_tasks[0].task")
     +            return var_ptr.dereference()
     +        else:
    -+            var_ptr = gdb.parse_and_eval("&current_task")
    ++            var_ptr = gdb.parse_and_eval("&pcpu_hot.current_task")
     +            return per_cpu(var_ptr, cpu).dereference()
          elif utils.is_target_arch("aarch64"):
              current_task_addr = gdb.parse_and_eval("$SP_EL0")
-- 
2.30.2


_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um

WARNING: multiple messages have this Message-ID (diff)
From: Glenn Washburn <development@efficientek.com>
To: Jan Kiszka <jan.kiszka@siemens.com>,
	Kieran Bingham <kbingham@kernel.org>
Cc: linux-um <linux-um@lists.infradead.org>,
	Richard Weinberger <richard@nod.at>,
	Johannes Berg <johannes@sipsolutions.net>,
	Anton Ivanov <anton.ivanov@kot-begemot.co.uk>,
	linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Glenn Washburn <development@efficientek.com>
Subject: [PATCH v3 0/2] GDB: Support getting current task struct in UML
Date: Sun, 26 Feb 2023 22:05:58 -0600	[thread overview]
Message-ID: <cover.1677469905.git.development@efficientek.com> (raw)

Changes in v3:
  - Rebase onto tip.

Changes in v2:
  - Use cpu_tasks symbols instead of uml_kmalloc when determining if the
    kernel is a UML kernel.
  - Improve formatting.

Glenn

Glenn Washburn (2):
  scripts/gdb: Correct indentation in get_current_task
  scripts/gdb: Support getting current task struct in UML

 scripts/gdb/linux/cpus.py | 24 +++++++++++++++---------
 1 file changed, 15 insertions(+), 9 deletions(-)

Range-diff against v2:
1:  918bc1299bdb ! 1:  2e117b82240d scripts/gdb: Correct indentation in get_current_task
    @@ scripts/gdb/linux/cpus.py: def get_current_task(cpu):
          task_ptr_type = task_type.get_type().pointer()
      
          if utils.is_target_arch("x86"):
    --         var_ptr = gdb.parse_and_eval("&current_task")
    +-         var_ptr = gdb.parse_and_eval("&pcpu_hot.current_task")
     -         return per_cpu(var_ptr, cpu).dereference()
    -+        var_ptr = gdb.parse_and_eval("&current_task")
    ++        var_ptr = gdb.parse_and_eval("&pcpu_hot.current_task")
     +        return per_cpu(var_ptr, cpu).dereference()
          elif utils.is_target_arch("aarch64"):
     -         current_task_addr = gdb.parse_and_eval("$SP_EL0")
2:  93fc6584ea16 ! 2:  b839d611e290 scripts/gdb: Support getting current task struct in UML
    @@ scripts/gdb/linux/cpus.py: def get_current_task(cpu):
          task_ptr_type = task_type.get_type().pointer()
      
          if utils.is_target_arch("x86"):
    --        var_ptr = gdb.parse_and_eval("&current_task")
    +-        var_ptr = gdb.parse_and_eval("&pcpu_hot.current_task")
     -        return per_cpu(var_ptr, cpu).dereference()
     +        if gdb.lookup_global_symbol("cpu_tasks"):
     +            # This is a UML kernel, which stores the current task
    @@ scripts/gdb/linux/cpus.py: def get_current_task(cpu):
     +            var_ptr = gdb.parse_and_eval("(struct task_struct *)cpu_tasks[0].task")
     +            return var_ptr.dereference()
     +        else:
    -+            var_ptr = gdb.parse_and_eval("&current_task")
    ++            var_ptr = gdb.parse_and_eval("&pcpu_hot.current_task")
     +            return per_cpu(var_ptr, cpu).dereference()
          elif utils.is_target_arch("aarch64"):
              current_task_addr = gdb.parse_and_eval("$SP_EL0")
-- 
2.30.2


             reply	other threads:[~2023-02-27  4:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-27  4:05 Glenn Washburn [this message]
2023-02-27  4:05 ` [PATCH v3 0/2] GDB: Support getting current task struct in UML Glenn Washburn
2023-02-27  4:05 ` [PATCH v3 1/2] scripts/gdb: Correct indentation in get_current_task Glenn Washburn
2023-02-27  4:05   ` Glenn Washburn
2023-02-27  4:06 ` [PATCH v3 2/2] scripts/gdb: Support getting current task struct in UML Glenn Washburn
2023-02-27  4:06   ` Glenn Washburn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1677469905.git.development@efficientek.com \
    --to=development@efficientek.com \
    --cc=akpm@linux-foundation.org \
    --cc=anton.ivanov@kot-begemot.co.uk \
    --cc=jan.kiszka@siemens.com \
    --cc=johannes@sipsolutions.net \
    --cc=kbingham@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-um@lists.infradead.org \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.