All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: dri-devel@lists.freedesktop.org
Cc: jani.nikula@intel.com, intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH 0/6] drm/edid: split out drm_eld.[ch], add some SAD helpers
Date: Thu,  7 Sep 2023 12:28:18 +0300	[thread overview]
Message-ID: <cover.1694078430.git.jani.nikula@intel.com> (raw)

Split out drm_eld.[ch] from drm_edid.h, add some helpers to convert and
modify SADs.

This should make it easier and more robust to implement things like [1],
with ELD parsing details hidden in drm_eld.[ch].

	for (i = 0; i < drm_eld_sad_count(eld); i++) {
		struct cea_sad sad;

		drm_eld_sad_get(eld, i, &sad);
		/* do stuff with sad */
		drm_eld_sad_set(eld, i, &sad);
	}

struct cea_sad provides an easier way to manipulate CTA SADs.

** UNTESTED ***

Cc: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>

[1] https://patchwork.freedesktop.org/patch/msgid/20230821160004.2821445-4-mitulkumar.ajitkumar.golani@intel.com


Jani Nikula (6):
  drm/edid: split out drm_eld.h from drm_edid.h
  drm/eld: replace uint8_t with u8
  drm/edid: include drm_eld.h only where required
  drm/edid: use a temp variable for sads to drop one level of
    dereferences
  drm/edid: add helpers to get/set struct cea_sad from/to 3-byte sad
  drm/eld: add helpers to modify the SADs of an ELD

 Documentation/gpu/drm-kms-helpers.rst         |   6 +
 drivers/gpu/drm/Makefile                      |   1 +
 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |   1 +
 drivers/gpu/drm/drm_edid.c                    |  42 +++--
 drivers/gpu/drm/drm_eld.c                     |  55 ++++++
 drivers/gpu/drm/drm_internal.h                |   6 +
 drivers/gpu/drm/i915/display/intel_audio.c    |   1 +
 .../drm/i915/display/intel_crtc_state_dump.c  |   1 +
 drivers/gpu/drm/i915/display/intel_sdvo.c     |   1 +
 drivers/gpu/drm/nouveau/dispnv50/disp.c       |   1 +
 drivers/gpu/drm/radeon/radeon_audio.c         |   1 +
 drivers/gpu/drm/tegra/hdmi.c                  |   1 +
 drivers/gpu/drm/tegra/sor.c                   |   1 +
 include/drm/drm_edid.h                        | 148 ----------------
 include/drm/drm_eld.h                         | 164 ++++++++++++++++++
 sound/core/pcm_drm_eld.c                      |   1 +
 sound/soc/codecs/hdac_hdmi.c                  |   1 +
 sound/soc/codecs/hdmi-codec.c                 |   1 +
 sound/x86/intel_hdmi_audio.c                  |   1 +
 19 files changed, 274 insertions(+), 160 deletions(-)
 create mode 100644 drivers/gpu/drm/drm_eld.c
 create mode 100644 include/drm/drm_eld.h

-- 
2.39.2


WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@intel.com>
To: dri-devel@lists.freedesktop.org
Cc: jani.nikula@intel.com, intel-gfx@lists.freedesktop.org,
	Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
Subject: [PATCH 0/6] drm/edid: split out drm_eld.[ch], add some SAD helpers
Date: Thu,  7 Sep 2023 12:28:18 +0300	[thread overview]
Message-ID: <cover.1694078430.git.jani.nikula@intel.com> (raw)

Split out drm_eld.[ch] from drm_edid.h, add some helpers to convert and
modify SADs.

This should make it easier and more robust to implement things like [1],
with ELD parsing details hidden in drm_eld.[ch].

	for (i = 0; i < drm_eld_sad_count(eld); i++) {
		struct cea_sad sad;

		drm_eld_sad_get(eld, i, &sad);
		/* do stuff with sad */
		drm_eld_sad_set(eld, i, &sad);
	}

struct cea_sad provides an easier way to manipulate CTA SADs.

** UNTESTED ***

Cc: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>

[1] https://patchwork.freedesktop.org/patch/msgid/20230821160004.2821445-4-mitulkumar.ajitkumar.golani@intel.com


Jani Nikula (6):
  drm/edid: split out drm_eld.h from drm_edid.h
  drm/eld: replace uint8_t with u8
  drm/edid: include drm_eld.h only where required
  drm/edid: use a temp variable for sads to drop one level of
    dereferences
  drm/edid: add helpers to get/set struct cea_sad from/to 3-byte sad
  drm/eld: add helpers to modify the SADs of an ELD

 Documentation/gpu/drm-kms-helpers.rst         |   6 +
 drivers/gpu/drm/Makefile                      |   1 +
 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |   1 +
 drivers/gpu/drm/drm_edid.c                    |  42 +++--
 drivers/gpu/drm/drm_eld.c                     |  55 ++++++
 drivers/gpu/drm/drm_internal.h                |   6 +
 drivers/gpu/drm/i915/display/intel_audio.c    |   1 +
 .../drm/i915/display/intel_crtc_state_dump.c  |   1 +
 drivers/gpu/drm/i915/display/intel_sdvo.c     |   1 +
 drivers/gpu/drm/nouveau/dispnv50/disp.c       |   1 +
 drivers/gpu/drm/radeon/radeon_audio.c         |   1 +
 drivers/gpu/drm/tegra/hdmi.c                  |   1 +
 drivers/gpu/drm/tegra/sor.c                   |   1 +
 include/drm/drm_edid.h                        | 148 ----------------
 include/drm/drm_eld.h                         | 164 ++++++++++++++++++
 sound/core/pcm_drm_eld.c                      |   1 +
 sound/soc/codecs/hdac_hdmi.c                  |   1 +
 sound/soc/codecs/hdmi-codec.c                 |   1 +
 sound/x86/intel_hdmi_audio.c                  |   1 +
 19 files changed, 274 insertions(+), 160 deletions(-)
 create mode 100644 drivers/gpu/drm/drm_eld.c
 create mode 100644 include/drm/drm_eld.h

-- 
2.39.2


             reply	other threads:[~2023-09-07  9:28 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-07  9:28 Jani Nikula [this message]
2023-09-07  9:28 ` [PATCH 0/6] drm/edid: split out drm_eld.[ch], add some SAD helpers Jani Nikula
2023-09-07  9:28 ` [Intel-gfx] [PATCH 1/6] drm/edid: split out drm_eld.h from drm_edid.h Jani Nikula
2023-09-07  9:28   ` Jani Nikula
2023-09-25 15:52   ` [Intel-gfx] " Golani, Mitulkumar Ajitkumar
2023-09-25 15:52     ` Golani, Mitulkumar Ajitkumar
2023-09-07  9:28 ` [Intel-gfx] [PATCH 2/6] drm/eld: replace uint8_t with u8 Jani Nikula
2023-09-07  9:28   ` Jani Nikula
2023-09-08  5:25   ` [Intel-gfx] " Borah, Chaitanya Kumar
2023-09-08  5:25     ` Borah, Chaitanya Kumar
2023-09-25 16:32   ` Golani, Mitulkumar Ajitkumar
2023-09-25 16:32     ` Golani, Mitulkumar Ajitkumar
2023-09-07  9:28 ` [Intel-gfx] [PATCH 3/6] drm/edid: include drm_eld.h only where required Jani Nikula
2023-09-07  9:28   ` Jani Nikula
2023-09-25 16:59   ` [Intel-gfx] " Golani, Mitulkumar Ajitkumar
2023-09-25 16:59     ` Golani, Mitulkumar Ajitkumar
2023-09-07  9:28 ` [Intel-gfx] [PATCH 4/6] drm/edid: use a temp variable for sads to drop one level of dereferences Jani Nikula
2023-09-07  9:28   ` Jani Nikula
2023-09-25 17:46   ` [Intel-gfx] " Golani, Mitulkumar Ajitkumar
2023-09-25 17:46     ` Golani, Mitulkumar Ajitkumar
2023-09-26  7:44     ` [Intel-gfx] " Jani Nikula
2023-09-26  7:44       ` Jani Nikula
2023-09-26 16:14       ` [Intel-gfx] " Golani, Mitulkumar Ajitkumar
2023-09-26 16:14         ` Golani, Mitulkumar Ajitkumar
2023-09-07  9:28 ` [Intel-gfx] [PATCH 5/6] drm/edid: add helpers to get/set struct cea_sad from/to 3-byte sad Jani Nikula
2023-09-07  9:28   ` Jani Nikula
2023-09-07 11:49   ` [Intel-gfx] " kernel test robot
2023-09-07 11:49     ` kernel test robot
2023-09-07 11:49     ` kernel test robot
2023-09-07 13:37   ` [Intel-gfx] " kernel test robot
2023-09-07 13:37     ` kernel test robot
2023-09-07 13:37     ` kernel test robot
2023-09-26 18:13   ` [Intel-gfx] " Golani, Mitulkumar Ajitkumar
2023-09-26 18:13     ` Golani, Mitulkumar Ajitkumar
2023-09-07  9:28 ` [Intel-gfx] [PATCH 6/6] drm/eld: add helpers to modify the SADs of an ELD Jani Nikula
2023-09-07  9:28   ` Jani Nikula
2023-09-26 18:04   ` [Intel-gfx] " Golani, Mitulkumar Ajitkumar
2023-09-26 18:04     ` Golani, Mitulkumar Ajitkumar
2023-09-07 12:14 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/edid: split out drm_eld.[ch], add some SAD helpers Patchwork
2023-09-07 12:14 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-09-07 12:31 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1694078430.git.jani.nikula@intel.com \
    --to=jani.nikula@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.