* [meta-oe][PATCH 0/3] Introduce crash-cross-canadian and update crash version
@ 2023-12-17 7:39 frederic.martinsons
2023-12-17 7:39 ` [meta-oe][PATCH 1/3] crash: factorize recipe with inc file to prepare cross-canadian version frederic.martinsons
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: frederic.martinsons @ 2023-12-17 7:39 UTC (permalink / raw)
To: openembedded-devel; +Cc: Frederic Martinsons
From: Frederic Martinsons <frederic.martinsons@gmail.com>
This series brings a cross canadian recipe for crash utility.
This is particularly usefull for using crash in an sdk to analyze
a vmcore file generated on target.
The following changes since commit 0a0ea87b8dda01a2887a525cef78eb6c3f4c2c32:
pgpool2: use autotools-brokensep instead of setting B (2023-12-12 14:40:59 -0800)
are available in the Git repository at:
https://gitlab.com/fmartinsons/meta-openembedded master
Frederic Martinsons (3):
crash: factorize recipe with inc file to prepare cross-canadian
version
crash: add cross canadian version
crash: update to 8.0.4
.../crash/crash-cross-canadian_8.0.4.bb | 53 ++++++++++++++
.../crash/{crash_8.0.2.bb => crash.inc} | 29 +-------
...001-make-src-string-const-in-strlcpy.patch | 69 -------------------
.../crash/crash/config-site.crash-7.0.9 | 1 -
meta-oe/recipes-kernel/crash/crash_8.0.4.bb | 29 ++++++++
5 files changed, 85 insertions(+), 96 deletions(-)
create mode 100644 meta-oe/recipes-kernel/crash/crash-cross-canadian_8.0.4.bb
rename meta-oe/recipes-kernel/crash/{crash_8.0.2.bb => crash.inc} (82%)
delete mode 100644 meta-oe/recipes-kernel/crash/crash/0001-make-src-string-const-in-strlcpy.patch
delete mode 100644 meta-oe/recipes-kernel/crash/crash/config-site.crash-7.0.9
create mode 100644 meta-oe/recipes-kernel/crash/crash_8.0.4.bb
--
2.34.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [meta-oe][PATCH 1/3] crash: factorize recipe with inc file to prepare cross-canadian version
2023-12-17 7:39 [meta-oe][PATCH 0/3] Introduce crash-cross-canadian and update crash version frederic.martinsons
@ 2023-12-17 7:39 ` frederic.martinsons
2023-12-17 7:39 ` [meta-oe][PATCH 2/3] crash: add cross canadian version frederic.martinsons
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: frederic.martinsons @ 2023-12-17 7:39 UTC (permalink / raw)
To: openembedded-devel; +Cc: Frederic Martinsons
From: Frederic Martinsons <frederic.martinsons@gmail.com>
Suppress unused config-site.crash-7.0.9
Signed-off-by: Frederic Martinsons <frederic.martinsons@gmail.com>
---
meta-oe/recipes-kernel/crash/crash.inc | 92 +++++++++++++++++++
.../crash/crash/config-site.crash-7.0.9 | 1 -
meta-oe/recipes-kernel/crash/crash_8.0.2.bb | 89 +-----------------
3 files changed, 94 insertions(+), 88 deletions(-)
create mode 100644 meta-oe/recipes-kernel/crash/crash.inc
delete mode 100644 meta-oe/recipes-kernel/crash/crash/config-site.crash-7.0.9
diff --git a/meta-oe/recipes-kernel/crash/crash.inc b/meta-oe/recipes-kernel/crash/crash.inc
new file mode 100644
index 000000000..8d700ed48
--- /dev/null
+++ b/meta-oe/recipes-kernel/crash/crash.inc
@@ -0,0 +1,92 @@
+SUMMARY = "Kernel analysis utility for live systems, netdump, diskdump, kdump, LKCD or mcore dumpfiles"
+DESCRIPTION = "The core analysis suite is a self-contained tool that can be used to\
+investigate either live systems, kernel core dumps created from the\
+netdump, diskdump and kdump packages from Red Hat Linux, the mcore kernel patch\
+offered by Mission Critical Linux, or the LKCD kernel patch."
+
+HOMEPAGE = "http://people.redhat.com/anderson"
+SECTION = "devel"
+
+LICENSE = "GPL-3.0-only"
+LIC_FILES_CHKSUM = "file://COPYING3;md5=d32239bcb673463ab874e80d47fae504"
+
+DEPENDS = "zlib readline coreutils-native ncurses-native"
+
+INC_PR = "r1"
+
+S = "${WORKDIR}/git"
+SRC_URI = "git://github.com/crash-utility/${BPN}.git;branch=master;protocol=https \
+ ${GNU_MIRROR}/gdb/gdb-10.2.tar.gz;name=gdb;subdir=git \
+ file://7001force_define_architecture.patch \
+ file://7003cross_ranlib.patch \
+ file://0001-cross_add_configure_option.patch \
+ file://donnot-extract-gdb-during-do-compile.patch \
+ file://gdb_build_jobs_and_not_write_crash_target.patch \
+ file://0001-make-src-string-const-in-strlcpy.patch \
+ "
+SRCREV = "f1cd581d1c4afa5b8ffdfaa6a3ea9f545fe4ec91"
+
+SRC_URI[gdb.sha256sum] = "b33ad58d687487a821ec8d878daab0f716be60d0936f2e3ac5cf08419ce70350"
+
+UPSTREAM_CHECK_URI = "https://github.com/crash-utility/crash/releases"
+
+inherit gettext
+
+TARGET_CC_ARCH:append = " ${SELECTED_OPTIMIZATION}"
+
+# crash 7.1.3 and before don't support mips64/riscv64
+COMPATIBLE_HOST:riscv64 = "null"
+COMPATIBLE_HOST:riscv32 = "null"
+COMPATIBLE_HOST:mipsarchn64 = "null"
+COMPATIBLE_HOST:mipsarchn32 = "null"
+
+
+EXTRA_OEMAKE = 'RPMPKG="${PV}" \
+ GDB_TARGET="${TARGET_SYS}" \
+ GDB_HOST="${BUILD_SYS}" \
+ GDB_MAKE_JOBS="${PARALLEL_MAKE}" \
+ LDFLAGS="${LDFLAGS}" \
+ '
+
+do_configure() {
+ :
+}
+
+do_compile:prepend() {
+ case ${TARGET_ARCH} in
+ aarch64*) ARCH=ARM64 ;;
+ arm*) ARCH=ARM ;;
+ i*86*) ARCH=X86 ;;
+ x86_64*) ARCH=X86_64 ;;
+ powerpc64*) ARCH=PPC64 ;;
+ powerpc*) ARCH=PPC ;;
+ mips*) ARCH=MIPS ;;
+ esac
+
+ sed -i s/FORCE_DEFINE_ARCH/"${ARCH}"/g ${S}/configure.c
+ sed -i -e 's/#define TARGET_CFLAGS_ARM_ON_X86_64.*/#define TARGET_CFLAGS_ARM_ON_X86_64\t\"TARGET_CFLAGS=-D_FILE_OFFSET_BITS=64\"/g' ${S}/configure.c
+ sed -i -e 's/#define TARGET_CFLAGS_MIPS_ON_X86_64.*/#define TARGET_CFLAGS_MIPS_ON_X86_64\t\"TARGET_CFLAGS=-D_FILE_OFFSET_BITS=64\"/g' ${S}/configure.c
+ sed -i 's/>/>/g' ${S}/Makefile
+}
+
+do_compile() {
+ oe_runmake ${EXTRA_OEMAKE} RECIPE_SYSROOT=${RECIPE_SYSROOT}
+}
+
+do_install:prepend () {
+ install -d ${D}${bindir}
+ install -d ${D}/${mandir}/man8
+ install -d ${D}${includedir}/crash
+
+ install -m 0644 ${S}/crash.8 ${D}/${mandir}/man8/
+ install -m 0644 ${S}/defs.h ${D}${includedir}/crash
+}
+
+RDEPENDS:${PN} += "liblzma"
+
+# Causes gcc to get stuck and eat all available memory in qemuarm builds
+# jenkins 15161 100 12.5 10389596 10321284 ? R 11:40 28:17 /home/jenkins/oe/world/shr-core/tmp-glibc/sysroots/x86_64-linux/usr/libexec/arm-oe-linux-gnueabi/gcc/arm-oe-linux-gnueabi/4.9.2/cc1 -quiet -I . -I . -I ./common -I ./config -I ./../include/opcode -I ./../opcodes/.. -I ./../readline/.. -I ../bfd -I ./../bfd -I ./../include -I ../libdecnumber -I ./../libdecnumber -I ./gnulib/import -I build-gnulib/import -isysroot /home/jenkins/oe/world/shr-core/tmp-glibc/sysroots/qemuarm -MMD eval.d -MF .deps/eval.Tpo -MP -MT eval.o -D LOCALEDIR="/usr/local/share/locale" -D CRASH_MERGE -D HAVE_CONFIG_H -D TUI=1 eval.c -quiet -dumpbase eval.c -march=armv5te -mthumb -mthumb-interwork -mtls-dialect=gnu -auxbase-strip eval.o -g -O2 -Wall -Wpointer-arith -Wformat-nonliteral -Wno-pointer-sign -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wmissing-prototypes -Wdeclaration-after-statement -Wempty-body -feliminate-unused-debug-types -o -
+ARM_INSTRUCTION_SET = "arm"
+
+# http://errors.yoctoproject.org/Errors/Details/186964/
+COMPATIBLE_HOST:libc-musl = 'null'
diff --git a/meta-oe/recipes-kernel/crash/crash/config-site.crash-7.0.9 b/meta-oe/recipes-kernel/crash/crash/config-site.crash-7.0.9
deleted file mode 100644
index d6fc22fb3..000000000
--- a/meta-oe/recipes-kernel/crash/crash/config-site.crash-7.0.9
+++ /dev/null
@@ -1 +0,0 @@
-bash_cv_have_mbstate_t=yes
diff --git a/meta-oe/recipes-kernel/crash/crash_8.0.2.bb b/meta-oe/recipes-kernel/crash/crash_8.0.2.bb
index f8a460b8c..cc46ab9ea 100644
--- a/meta-oe/recipes-kernel/crash/crash_8.0.2.bb
+++ b/meta-oe/recipes-kernel/crash/crash_8.0.2.bb
@@ -1,51 +1,8 @@
-SUMMARY = "Kernel analysis utility for live systems, netdump, diskdump, kdump, LKCD or mcore dumpfiles"
-DESCRIPTION = "The core analysis suite is a self-contained tool that can be used to\
-investigate either live systems, kernel core dumps created from the\
-netdump, diskdump and kdump packages from Red Hat Linux, the mcore kernel patch\
-offered by Mission Critical Linux, or the LKCD kernel patch."
+require crash.inc
-HOMEPAGE = "http://people.redhat.com/anderson"
-SECTION = "devel"
-
-LICENSE = "GPL-3.0-only"
-LIC_FILES_CHKSUM = "file://COPYING3;md5=d32239bcb673463ab874e80d47fae504"
-
-DEPENDS = "zlib readline coreutils-native ncurses-native"
-
-S = "${WORKDIR}/git"
-SRC_URI = "git://github.com/crash-utility/${BPN}.git;branch=master;protocol=https \
- ${GNU_MIRROR}/gdb/gdb-10.2.tar.gz;name=gdb;subdir=git \
- file://7001force_define_architecture.patch \
- file://7003cross_ranlib.patch \
- file://0001-cross_add_configure_option.patch \
- file://donnot-extract-gdb-during-do-compile.patch \
- file://gdb_build_jobs_and_not_write_crash_target.patch \
- file://0001-make-src-string-const-in-strlcpy.patch \
- "
-SRCREV = "f1cd581d1c4afa5b8ffdfaa6a3ea9f545fe4ec91"
-
-SRC_URI[gdb.sha256sum] = "b33ad58d687487a821ec8d878daab0f716be60d0936f2e3ac5cf08419ce70350"
-
-UPSTREAM_CHECK_URI = "https://github.com/crash-utility/crash/releases"
-
-inherit gettext
+PR = "${INC_PR}.0"
BBCLASSEXTEND = "native cross"
-TARGET_CC_ARCH:append = " ${SELECTED_OPTIMIZATION}"
-
-# crash 7.1.3 and before don't support mips64/riscv64
-COMPATIBLE_HOST:riscv64 = "null"
-COMPATIBLE_HOST:riscv32 = "null"
-COMPATIBLE_HOST:mipsarchn64 = "null"
-COMPATIBLE_HOST:mipsarchn32 = "null"
-
-
-EXTRA_OEMAKE = 'RPMPKG="${PV}" \
- GDB_TARGET="${TARGET_SYS}" \
- GDB_HOST="${BUILD_SYS}" \
- GDB_MAKE_JOBS="${PARALLEL_MAKE}" \
- LDFLAGS="${LDFLAGS}" \
- '
EXTRA_OEMAKE:class-cross = 'RPMPKG="${PV}" \
GDB_TARGET="${BUILD_SYS} --target=${TARGET_SYS}" \
@@ -56,40 +13,6 @@ EXTRA_OEMAKE:class-cross = 'RPMPKG="${PV}" \
EXTRA_OEMAKE:append:class-native = " LDFLAGS='${BUILD_LDFLAGS}'"
EXTRA_OEMAKE:append:class-cross = " LDFLAGS='${BUILD_LDFLAGS}'"
-do_configure() {
- :
-}
-
-do_compile:prepend() {
- case ${TARGET_ARCH} in
- aarch64*) ARCH=ARM64 ;;
- arm*) ARCH=ARM ;;
- i*86*) ARCH=X86 ;;
- x86_64*) ARCH=X86_64 ;;
- powerpc64*) ARCH=PPC64 ;;
- powerpc*) ARCH=PPC ;;
- mips*) ARCH=MIPS ;;
- esac
-
- sed -i s/FORCE_DEFINE_ARCH/"${ARCH}"/g ${S}/configure.c
- sed -i -e 's/#define TARGET_CFLAGS_ARM_ON_X86_64.*/#define TARGET_CFLAGS_ARM_ON_X86_64\t\"TARGET_CFLAGS=-D_FILE_OFFSET_BITS=64\"/g' ${S}/configure.c
- sed -i -e 's/#define TARGET_CFLAGS_MIPS_ON_X86_64.*/#define TARGET_CFLAGS_MIPS_ON_X86_64\t\"TARGET_CFLAGS=-D_FILE_OFFSET_BITS=64\"/g' ${S}/configure.c
- sed -i 's/>/>/g' ${S}/Makefile
-}
-
-do_compile() {
- oe_runmake ${EXTRA_OEMAKE} RECIPE_SYSROOT=${RECIPE_SYSROOT}
-}
-
-do_install:prepend () {
- install -d ${D}${bindir}
- install -d ${D}/${mandir}/man8
- install -d ${D}${includedir}/crash
-
- install -m 0644 ${S}/crash.8 ${D}/${mandir}/man8/
- install -m 0644 ${S}/defs.h ${D}${includedir}/crash
-}
-
do_install:class-target () {
oe_runmake DESTDIR=${D} install
}
@@ -102,13 +25,5 @@ do_install:class-cross () {
install -m 0755 ${S}/crash ${D}/${bindir}
}
-RDEPENDS:${PN} += "liblzma"
RDEPENDS:${PN}:class-native = ""
RDEPENDS:${PN}:class-cross = ""
-
-# Causes gcc to get stuck and eat all available memory in qemuarm builds
-# jenkins 15161 100 12.5 10389596 10321284 ? R 11:40 28:17 /home/jenkins/oe/world/shr-core/tmp-glibc/sysroots/x86_64-linux/usr/libexec/arm-oe-linux-gnueabi/gcc/arm-oe-linux-gnueabi/4.9.2/cc1 -quiet -I . -I . -I ./common -I ./config -I ./../include/opcode -I ./../opcodes/.. -I ./../readline/.. -I ../bfd -I ./../bfd -I ./../include -I ../libdecnumber -I ./../libdecnumber -I ./gnulib/import -I build-gnulib/import -isysroot /home/jenkins/oe/world/shr-core/tmp-glibc/sysroots/qemuarm -MMD eval.d -MF .deps/eval.Tpo -MP -MT eval.o -D LOCALEDIR="/usr/local/share/locale" -D CRASH_MERGE -D HAVE_CONFIG_H -D TUI=1 eval.c -quiet -dumpbase eval.c -march=armv5te -mthumb -mthumb-interwork -mtls-dialect=gnu -auxbase-strip eval.o -g -O2 -Wall -Wpointer-arith -Wformat-nonliteral -Wno-pointer-sign -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wmissing-prototypes -Wdeclaration-after-statement -Wempty-body -feliminate-unused-debug-types -o -
-ARM_INSTRUCTION_SET = "arm"
-
-# http://errors.yoctoproject.org/Errors/Details/186964/
-COMPATIBLE_HOST:libc-musl = 'null'
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [meta-oe][PATCH 2/3] crash: add cross canadian version
2023-12-17 7:39 [meta-oe][PATCH 0/3] Introduce crash-cross-canadian and update crash version frederic.martinsons
2023-12-17 7:39 ` [meta-oe][PATCH 1/3] crash: factorize recipe with inc file to prepare cross-canadian version frederic.martinsons
@ 2023-12-17 7:39 ` frederic.martinsons
2023-12-17 7:39 ` [meta-oe][PATCH 3/3] crash: update to 8.0.4 frederic.martinsons
2023-12-19 6:27 ` [meta-oe][PATCH 0/3] Introduce crash-cross-canadian and update crash version Khem Raj
3 siblings, 0 replies; 5+ messages in thread
From: frederic.martinsons @ 2023-12-17 7:39 UTC (permalink / raw)
To: openembedded-devel; +Cc: Frederic Martinsons
From: Frederic Martinsons <frederic.martinsons@gmail.com>
Signed-off-by: Frederic Martinsons <frederic.martinsons@gmail.com>
---
.../crash/crash-cross-canadian_8.0.2.bb | 53 +++++++++++++++++++
1 file changed, 53 insertions(+)
create mode 100644 meta-oe/recipes-kernel/crash/crash-cross-canadian_8.0.2.bb
diff --git a/meta-oe/recipes-kernel/crash/crash-cross-canadian_8.0.2.bb b/meta-oe/recipes-kernel/crash/crash-cross-canadian_8.0.2.bb
new file mode 100644
index 000000000..04be12602
--- /dev/null
+++ b/meta-oe/recipes-kernel/crash/crash-cross-canadian_8.0.2.bb
@@ -0,0 +1,53 @@
+inherit cross-canadian
+
+SUMMARY = "crash utility (cross-canadian crash for ${TARGET_ARCH} target)"
+PN = "crash-cross-canadian-${TRANSLATED_TARGET_ARCH}"
+BPN = "crash"
+
+require crash.inc
+
+PR = "${INC_PR}.0"
+
+DEPENDS = "\
+ nativesdk-ncurses \
+ nativesdk-expat \
+ nativesdk-gettext \
+ nativesdk-gmp \
+ nativesdk-mpfr \
+ nativesdk-readline \
+ nativesdk-zlib \
+ virtual/${HOST_PREFIX}gcc \
+ virtual/${HOST_PREFIX}binutils \
+ virtual/nativesdk-${HOST_PREFIX}compilerlibs \
+ virtual/nativesdk-libc"
+
+RDEPENDS:${PN} = "nativesdk-liblzma"
+
+EXTRA_OEMAKE:class-cross-canadian = 'RPMPKG="${PV}" \
+ GDB_TARGET="${BUILD_SYS} --target=${TARGET_SYS}" \
+ GDB_HOST="${HOST_SYS}" \
+ GDB_MAKE_JOBS="${PARALLEL_MAKE}" \
+ LDFLAGS="${LDFLAGS}" \
+ '
+
+# To ship crash into your sdk, you should create/update a packagegroup-cross-canadian.bbappend and
+# add the following
+# CRASH = "crash-cross-canadian-${TRANSLATED_TARGET_ARCH}"
+# RDEPENDS:${PN} += "${@all_multilib_tune_values(d, 'CRASH')}"
+#
+# You should also add some kernel packages in your sdk, add the followng in your conf/local.conf:
+#
+# TOOLCHAIN_TARGET_TASK += "\
+# kernel-vmlinux \
+# kernel-dbg \
+# kernel-dev \
+# "
+#
+# After sourcing the sdk environment script, you can analyze a kernel panic dump with
+#
+# crash $OECORE_TARGET_SYSROOT/boot/<vmlinux file> $OECORE_TARGET_SYSROOT/boot/<System.map file> <your vmcore>
+
+do_install:class-cross-canadian () {
+ install -m 0755 ${S}/crash ${D}/${bindir}
+ cross_canadian_bindirlinks
+}
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [meta-oe][PATCH 3/3] crash: update to 8.0.4
2023-12-17 7:39 [meta-oe][PATCH 0/3] Introduce crash-cross-canadian and update crash version frederic.martinsons
2023-12-17 7:39 ` [meta-oe][PATCH 1/3] crash: factorize recipe with inc file to prepare cross-canadian version frederic.martinsons
2023-12-17 7:39 ` [meta-oe][PATCH 2/3] crash: add cross canadian version frederic.martinsons
@ 2023-12-17 7:39 ` frederic.martinsons
2023-12-19 6:27 ` [meta-oe][PATCH 0/3] Introduce crash-cross-canadian and update crash version Khem Raj
3 siblings, 0 replies; 5+ messages in thread
From: frederic.martinsons @ 2023-12-17 7:39 UTC (permalink / raw)
To: openembedded-devel; +Cc: Frederic Martinsons
From: Frederic Martinsons <frederic.martinsons@gmail.com>
Remove backported commit.
Signed-off-by: Frederic Martinsons <frederic.martinsons@gmail.com>
---
...8.0.2.bb => crash-cross-canadian_8.0.4.bb} | 0
meta-oe/recipes-kernel/crash/crash.inc | 3 +-
...001-make-src-string-const-in-strlcpy.patch | 69 -------------------
.../crash/{crash_8.0.2.bb => crash_8.0.4.bb} | 0
4 files changed, 1 insertion(+), 71 deletions(-)
rename meta-oe/recipes-kernel/crash/{crash-cross-canadian_8.0.2.bb => crash-cross-canadian_8.0.4.bb} (100%)
delete mode 100644 meta-oe/recipes-kernel/crash/crash/0001-make-src-string-const-in-strlcpy.patch
rename meta-oe/recipes-kernel/crash/{crash_8.0.2.bb => crash_8.0.4.bb} (100%)
diff --git a/meta-oe/recipes-kernel/crash/crash-cross-canadian_8.0.2.bb b/meta-oe/recipes-kernel/crash/crash-cross-canadian_8.0.4.bb
similarity index 100%
rename from meta-oe/recipes-kernel/crash/crash-cross-canadian_8.0.2.bb
rename to meta-oe/recipes-kernel/crash/crash-cross-canadian_8.0.4.bb
diff --git a/meta-oe/recipes-kernel/crash/crash.inc b/meta-oe/recipes-kernel/crash/crash.inc
index 8d700ed48..04318b150 100644
--- a/meta-oe/recipes-kernel/crash/crash.inc
+++ b/meta-oe/recipes-kernel/crash/crash.inc
@@ -22,9 +22,8 @@ SRC_URI = "git://github.com/crash-utility/${BPN}.git;branch=master;protocol=http
file://0001-cross_add_configure_option.patch \
file://donnot-extract-gdb-during-do-compile.patch \
file://gdb_build_jobs_and_not_write_crash_target.patch \
- file://0001-make-src-string-const-in-strlcpy.patch \
"
-SRCREV = "f1cd581d1c4afa5b8ffdfaa6a3ea9f545fe4ec91"
+SRCREV = "a6832f608cb5d473739cf33bbf84ab1df8d98fd5"
SRC_URI[gdb.sha256sum] = "b33ad58d687487a821ec8d878daab0f716be60d0936f2e3ac5cf08419ce70350"
diff --git a/meta-oe/recipes-kernel/crash/crash/0001-make-src-string-const-in-strlcpy.patch b/meta-oe/recipes-kernel/crash/crash/0001-make-src-string-const-in-strlcpy.patch
deleted file mode 100644
index 546973e0a..000000000
--- a/meta-oe/recipes-kernel/crash/crash/0001-make-src-string-const-in-strlcpy.patch
+++ /dev/null
@@ -1,69 +0,0 @@
-From 4ee56105881d7bb1da1e668ac5bb47a4e0846676 Mon Sep 17 00:00:00 2001
-From: Lianbo Jiang <lijiang@redhat.com>
-Date: Wed, 5 Jul 2023 10:02:59 +0800
-Subject: [PATCH] Fix compilation error due to new strlcpy function that glibc
- added
-MIME-Version: 1.0
-Content-Type: text/plain; charset=UTF-8
-Content-Transfer-Encoding: 8bit
-
-The crash-utility has its own strlcpy(), but recently the latest glibc
-has also implemented the strlcpy function, which is derived from
-OpenBSD. Eventually this caused the following compilation error:
-
- # make -j8 lzo
- ...
- In file included from global_data.c:18:
- defs.h:5556:8: error: conflicting types for ‘strlcpy’; have ‘size_t(char *, char *, size_t)’ {aka ‘long unsigned int(char *, char *, long unsigned int)’}
- 5556 | size_t strlcpy(char *, char *, size_t);
- | ^~~~~~~
- In file included from memory.c:19:
- defs.h:5556:8: error: conflicting types for ‘strlcpy’; have ‘size_t(char *, char *, size_t)’ {aka ‘long unsigned int(char *, char *, long unsigned int)’}
- 5556 | size_t strlcpy(char *, char *, size_t);
- | ^~~~~~~
- ...
-
-To fix the issue, let's declare the strlcpy() as a weak function and
-keep the same parameter types as the glibc function has.
-
-Related glibc commits:
-454a20c8756c ("Implement strlcpy and strlcat [BZ #178]")
-d2fda60e7c40 ("manual: Manual update for strlcat, strlcpy, wcslcat, wclscpy")
-388ae538ddcb ("hurd: Add strlcpy, strlcat, wcslcpy, wcslcat to libc.abilist")
-
-Upstream-Status: Backport [https://github.com/kraj/crash/commit/4ee56105881d7bb1da1e668ac5bb47a4e0846676]
-Signed-off-by: Lianbo Jiang <lijiang@redhat.com>
----
- defs.h | 2 +-
- tools.c | 2 +-
- 2 files changed, 2 insertions(+), 2 deletions(-)
-
-diff --git a/defs.h b/defs.h
-index 8f7d1fa..26afe23 100644
---- a/defs.h
-+++ b/defs.h
-@@ -5553,7 +5553,7 @@ uint32_t swap32(uint32_t, int);
- uint64_t swap64(uint64_t, int);
- ulong *get_cpumask_buf(void);
- int make_cpumask(char *, ulong *, int, int *);
--size_t strlcpy(char *, char *, size_t);
-+size_t strlcpy(char *, const char *, size_t) __attribute__ ((__weak__));
- struct rb_node *rb_first(struct rb_root *);
- struct rb_node *rb_parent(struct rb_node *, struct rb_node *);
- struct rb_node *rb_right(struct rb_node *, struct rb_node *);
-diff --git a/tools.c b/tools.c
-index 392a797..0f2db10 100644
---- a/tools.c
-+++ b/tools.c
-@@ -6795,7 +6795,7 @@ make_cpumask_error:
- * always be NULL-terminated.
- */
- size_t
--strlcpy(char *dest, char *src, size_t size)
-+strlcpy(char *dest, const char *src, size_t size)
- {
- size_t ret = strlen(src);
-
---
-2.41.0
-
diff --git a/meta-oe/recipes-kernel/crash/crash_8.0.2.bb b/meta-oe/recipes-kernel/crash/crash_8.0.4.bb
similarity index 100%
rename from meta-oe/recipes-kernel/crash/crash_8.0.2.bb
rename to meta-oe/recipes-kernel/crash/crash_8.0.4.bb
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [meta-oe][PATCH 0/3] Introduce crash-cross-canadian and update crash version
2023-12-17 7:39 [meta-oe][PATCH 0/3] Introduce crash-cross-canadian and update crash version frederic.martinsons
` (2 preceding siblings ...)
2023-12-17 7:39 ` [meta-oe][PATCH 3/3] crash: update to 8.0.4 frederic.martinsons
@ 2023-12-19 6:27 ` Khem Raj
3 siblings, 0 replies; 5+ messages in thread
From: Khem Raj @ 2023-12-19 6:27 UTC (permalink / raw)
To: openembedded-devel, frederic.martinsons
On Sun, 17 Dec 2023 08:39:27 +0100, frederic.martinsons@gmail.com wrote:
> From: Frederic Martinsons <frederic.martinsons@gmail.com>
>
> This series brings a cross canadian recipe for crash utility.
> This is particularly usefull for using crash in an sdk to analyze
> a vmcore file generated on target.
>
> The following changes since commit 0a0ea87b8dda01a2887a525cef78eb6c3f4c2c32:
>
> [...]
Applied, thanks!
[1/3] crash: factorize recipe with inc file to prepare cross-canadian version
commit: 058f22ac2747693a32ea2a14edaa11471d67fd0a
[2/3] crash: add cross canadian version
commit: 1f9ad22b28c24a289636b1eb049c491e4529337d
[3/3] crash: update to 8.0.4
commit: a4031df72d4b2dfc87d270221c339a50c7fc0d6e
Best regards,
--
Khem Raj <raj.khem@gmail.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-12-19 6:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-17 7:39 [meta-oe][PATCH 0/3] Introduce crash-cross-canadian and update crash version frederic.martinsons
2023-12-17 7:39 ` [meta-oe][PATCH 1/3] crash: factorize recipe with inc file to prepare cross-canadian version frederic.martinsons
2023-12-17 7:39 ` [meta-oe][PATCH 2/3] crash: add cross canadian version frederic.martinsons
2023-12-17 7:39 ` [meta-oe][PATCH 3/3] crash: update to 8.0.4 frederic.martinsons
2023-12-19 6:27 ` [meta-oe][PATCH 0/3] Introduce crash-cross-canadian and update crash version Khem Raj
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.