From: Nicola Vetrini <nicola.vetrini@bugseng.com>
To: nicola.vetrini@bugseng.com, xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, michal.orzel@amd.com,
xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com,
consulting@bugseng.com, jbeulich@suse.com,
andrew.cooper3@citrix.com, roger.pau@citrix.com,
bertrand.marquis@arm.com, julien@xen.org,
George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
Rahul Singh <rahul.singh@arm.com>
Subject: [XEN PATCH 00/10] address some violations of MISRA C Rule 20.7
Date: Thu, 29 Feb 2024 16:27:52 +0100 [thread overview]
Message-ID: <cover.1709219010.git.nicola.vetrini@bugseng.com> (raw)
Hi all,
this series aims to refactor some macros that cause violations of MISRA C Rule
20.7 ("Expressions resulting from the expansion of macro parameters shall be
enclosed in parentheses"). All the macros touched by these patches are in some
way involved in violations, and the strategy adopted to bring them into
compliance is to add parentheses around macro arguments where needed.
Given that the community has previously requested a deviation from the rule, as
stated in docs/misra/deviations.rst, and reported below for convenience [1],
some macro parameters do not need any adjusting (e.g., when used as lhs to
an assignment in statement expressions).
This series fixes a significant portion of the violations on Arm
(from ~14000 to ~2500). On x86, though there is one patch touching it, there are
still many more; they will be part of a later series.
[1] - Code violating Rule 20.7 is safe when macro parameters are used:
(1) as function arguments;
(2) as macro arguments;
(3) as array indices;
(4) as lhs in assignments.
Nicola Vetrini (10):
xen/include: address violations of MISRA C Rule 20.7
xen/arm: address some violations of MISRA C Rule 20.7
x86: address some violations of MISRA C Rule 20.7
xen/public: address violations of MISRA C Rule 20.7
xen/perfc: address violations of MISRA C Rule 20.7
arm/smmu: address some violations of MISRA C Rule 20.7
xen/arm: smmuv3: address violations of MISRA C Rule 20.7
xen/errno: address violations of MISRA C Rule 20.7
xen/include: tasklet: address violations of MISRA C Rule 20.7
xen/keyhandler: address violations of MISRA C Rule 20.7
xen/arch/arm/arm64/cpufeature.c | 14 +++---
xen/arch/arm/cpuerrata.c | 4 +-
xen/arch/arm/include/asm/arm64/sysregs.h | 2 +-
xen/arch/arm/include/asm/guest_atomics.h | 4 +-
xen/arch/arm/include/asm/mm.h | 2 +-
xen/arch/arm/include/asm/smccc.h | 8 ++--
xen/arch/arm/include/asm/vgic-emul.h | 8 ++--
xen/arch/arm/vcpreg.c | 5 +-
xen/arch/x86/include/asm/irq.h | 6 +--
xen/arch/x86/usercopy.c | 2 +-
xen/common/keyhandler.c | 4 +-
xen/common/perfc.c | 8 ++--
xen/drivers/passthrough/arm/smmu-v3.c | 2 +-
xen/drivers/passthrough/arm/smmu.c | 4 +-
xen/include/public/xen.h | 2 +-
xen/include/xen/bug.h | 2 +-
xen/include/xen/errno.h | 2 +-
xen/include/xen/init.h | 4 +-
xen/include/xen/kconfig.h | 2 +-
xen/include/xen/list.h | 59 ++++++++++++------------
xen/include/xen/param.h | 22 ++++-----
xen/include/xen/spinlock.h | 2 +-
xen/include/xen/tasklet.h | 2 +-
23 files changed, 85 insertions(+), 85 deletions(-)
--
2.34.1
next reply other threads:[~2024-02-29 15:28 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 15:27 Nicola Vetrini [this message]
2024-02-29 15:27 ` [XEN PATCH 01/10] xen/include: address violations of MISRA C Rule 20.7 Nicola Vetrini
2024-02-29 16:10 ` Andrew Cooper
2024-02-29 16:21 ` Nicola Vetrini
2024-02-29 16:47 ` Andrew Cooper
2024-02-29 16:53 ` Nicola Vetrini
2024-02-29 16:25 ` Jan Beulich
2024-02-29 16:40 ` Nicola Vetrini
2024-02-29 16:47 ` Jan Beulich
2024-02-29 15:27 ` [XEN PATCH 02/10] xen/arm: address some " Nicola Vetrini
2024-02-29 16:34 ` Jan Beulich
2024-03-01 15:30 ` Nicola Vetrini
2024-03-04 18:17 ` Nicola Vetrini
2024-03-05 1:43 ` Stefano Stabellini
2024-03-05 10:25 ` Nicola Vetrini
2024-02-29 15:27 ` [XEN PATCH 03/10] x86: " Nicola Vetrini
2024-02-29 16:37 ` Jan Beulich
2024-02-29 16:45 ` Nicola Vetrini
2024-02-29 17:05 ` Jan Beulich
2024-03-05 10:26 ` Nicola Vetrini
2024-02-29 15:27 ` [XEN PATCH 04/10] xen/public: address " Nicola Vetrini
2024-02-29 16:40 ` Jan Beulich
2024-02-29 16:49 ` Nicola Vetrini
2024-02-29 22:49 ` Stefano Stabellini
2024-03-05 10:21 ` Nicola Vetrini
2024-03-05 10:26 ` Jan Beulich
2024-03-05 16:17 ` Nicola Vetrini
2024-03-01 7:54 ` Jan Beulich
2024-02-29 15:27 ` [XEN PATCH 05/10] xen/perfc: " Nicola Vetrini
2024-02-29 16:42 ` Jan Beulich
2024-02-29 16:50 ` Nicola Vetrini
2024-02-29 15:27 ` [XEN PATCH 06/10] arm/smmu: address some " Nicola Vetrini
2024-02-29 22:53 ` Stefano Stabellini
2024-03-05 10:23 ` Nicola Vetrini
2024-03-07 1:31 ` Stefano Stabellini
2024-02-29 15:27 ` [XEN PATCH 07/10] xen/arm: smmuv3: address " Nicola Vetrini
2024-02-29 22:54 ` Stefano Stabellini
2024-02-29 15:28 ` [XEN PATCH 08/10] xen/errno: " Nicola Vetrini
2024-02-29 22:55 ` Stefano Stabellini
2024-03-01 8:10 ` Nicola Vetrini
2024-03-04 9:39 ` Jan Beulich
2024-02-29 15:28 ` [XEN PATCH 09/10] xen/include: tasklet: " Nicola Vetrini
2024-02-29 22:56 ` Stefano Stabellini
2024-02-29 15:28 ` [XEN PATCH 10/10] xen/keyhandler: " Nicola Vetrini
2024-02-29 22:57 ` Stefano Stabellini
2024-03-01 8:00 ` Jan Beulich
2024-03-02 1:37 ` Stefano Stabellini
2024-03-04 8:00 ` Jan Beulich
2024-03-05 2:03 ` Stefano Stabellini
2024-03-05 7:00 ` Jan Beulich
2024-03-07 1:39 ` Stefano Stabellini
2024-03-07 7:42 ` Jan Beulich
2024-03-07 13:52 ` Nicola Vetrini
-- strict thread matches above, loose matches on Subject: below --
2024-03-18 11:53 [XEN PATCH 00/10] address some " Nicola Vetrini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1709219010.git.nicola.vetrini@bugseng.com \
--to=nicola.vetrini@bugseng.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=andrew.cooper3@citrix.com \
--cc=ayan.kumar.halder@amd.com \
--cc=bertrand.marquis@arm.com \
--cc=consulting@bugseng.com \
--cc=george.dunlap@citrix.com \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=rahul.singh@arm.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
--cc=xenia.ragiadakou@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.