* [PATCH v2 0/3] Trivial code cleanup patches
@ 2024-03-18 19:54 ` Ayush Tiwari
0 siblings, 0 replies; 11+ messages in thread
From: Ayush Tiwari @ 2024-03-18 19:54 UTC (permalink / raw)
To: Larry.Finger, florian.c.schilhabel, gregkh, linux-kernel,
linux-staging
Cc: outreachy
Address different kinds of checkpatch complains for the rtl8712 module
to ensure adherence to coding style guidelines.
Changes in v2: Checked any possible reuse of backup_PMKID_list
manually and rebuilt, rebooted the kernel and loaded the driver
with modprobe.
Ayush Tiwari (3):
staging: rtl8712: rename backupPMKIDList to backup_PMKID_list
staging: rtl8712: rename backupPMKIDIndex to backup_PMKID_index
staging: rtl8712: rename backupTKIPCountermeasure to
backup_TKIP_countermeasure
drivers/staging/rtl8712/mlme_linux.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
--
2.40.1
^ permalink raw reply [flat|nested] 11+ messages in thread* [PATCH 1/3] staging: rtl8712: rename backupPMKIDList to backup_PMKID_list
@ 2024-03-18 19:55 ` Ayush Tiwari
0 siblings, 0 replies; 11+ messages in thread
From: Ayush Tiwari @ 2024-03-17 19:26 UTC (permalink / raw)
To: Larry.Finger, florian.c.schilhabel, gregkh, linux-kernel,
linux-staging
Cc: outreachy
Rename backupPMKIDList to backup_PMKID_list and remove extra spaces
between RT_PMKID_LIST and backupPMKIDList to address checkpatch
warnings and match the common kernel coding style.
Signed-off-by: Ayush Tiwari <ayushtiw0110@gmail.com>
---
drivers/staging/rtl8712/mlme_linux.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8712/mlme_linux.c b/drivers/staging/rtl8712/mlme_linux.c
index b9f5104f3bf7..a8cda81f4240 100644
--- a/drivers/staging/rtl8712/mlme_linux.c
+++ b/drivers/staging/rtl8712/mlme_linux.c
@@ -84,7 +84,7 @@ void r8712_os_indicate_connect(struct _adapter *adapter)
netif_carrier_on(adapter->pnetdev);
}
-static struct RT_PMKID_LIST backupPMKIDList[NUM_PMKID_CACHE];
+static struct RT_PMKID_LIST backup_PMKID_list[NUM_PMKID_CACHE];
void r8712_os_indicate_disconnect(struct _adapter *adapter)
{
u8 backupPMKIDIndex = 0;
--
2.40.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH v2 1/3] staging: rtl8712: rename backupPMKIDList to backup_PMKID_list
@ 2024-03-18 19:55 ` Ayush Tiwari
0 siblings, 0 replies; 11+ messages in thread
From: Ayush Tiwari @ 2024-03-18 19:55 UTC (permalink / raw)
To: Larry.Finger, florian.c.schilhabel, gregkh, linux-kernel,
linux-staging
Cc: outreachy
Rename backupPMKIDList to backup_PMKID_list and remove extra spaces
between RT_PMKID_LIST and backupPMKIDList to address checkpatch
warnings and match the common kernel coding style.
Signed-off-by: Ayush Tiwari <ayushtiw0110@gmail.com>
---
Changes in v2: Checked any possible reuse of backup_PMKID_list
manually and rebuilt, rebooted the kernel and loaded the driver
with modprobe.
drivers/staging/rtl8712/mlme_linux.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8712/mlme_linux.c b/drivers/staging/rtl8712/mlme_linux.c
index b9f5104f3bf7..a8cda81f4240 100644
--- a/drivers/staging/rtl8712/mlme_linux.c
+++ b/drivers/staging/rtl8712/mlme_linux.c
@@ -84,7 +84,7 @@ void r8712_os_indicate_connect(struct _adapter *adapter)
netif_carrier_on(adapter->pnetdev);
}
-static struct RT_PMKID_LIST backupPMKIDList[NUM_PMKID_CACHE];
+static struct RT_PMKID_LIST backup_PMKID_list[NUM_PMKID_CACHE];
void r8712_os_indicate_disconnect(struct _adapter *adapter)
{
u8 backupPMKIDIndex = 0;
--
2.40.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH 1/3] staging: rtl8712: rename backupPMKIDList to backup_PMKID_list
2024-03-18 19:55 ` [PATCH v2 " Ayush Tiwari
(?)
@ 2024-03-18 7:39 ` Julia Lawall
-1 siblings, 0 replies; 11+ messages in thread
From: Julia Lawall @ 2024-03-18 7:39 UTC (permalink / raw)
To: Ayush Tiwari
Cc: Larry.Finger, florian.c.schilhabel, gregkh, linux-kernel,
linux-staging, outreachy
On Mon, 18 Mar 2024, Ayush Tiwari wrote:
> Rename backupPMKIDList to backup_PMKID_list and remove extra spaces
> between RT_PMKID_LIST and backupPMKIDList to address checkpatch
> warnings and match the common kernel coding style.
>
> Signed-off-by: Ayush Tiwari <ayushtiw0110@gmail.com>
> ---
> drivers/staging/rtl8712/mlme_linux.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8712/mlme_linux.c b/drivers/staging/rtl8712/mlme_linux.c
> index b9f5104f3bf7..a8cda81f4240 100644
> --- a/drivers/staging/rtl8712/mlme_linux.c
> +++ b/drivers/staging/rtl8712/mlme_linux.c
> @@ -84,7 +84,7 @@ void r8712_os_indicate_connect(struct _adapter *adapter)
> netif_carrier_on(adapter->pnetdev);
> }
>
> -static struct RT_PMKID_LIST backupPMKIDList[NUM_PMKID_CACHE];
> +static struct RT_PMKID_LIST backup_PMKID_list[NUM_PMKID_CACHE];
This one looks suspicious, because you have changed the definition but no
uses. Is it not used?
julia
> void r8712_os_indicate_disconnect(struct _adapter *adapter)
> {
> u8 backupPMKIDIndex = 0;
> --
> 2.40.1
>
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 2/3] staging: rtl8712: rename backupPMKIDIndex to backup_PMKID_index
@ 2024-03-18 19:57 ` Ayush Tiwari
0 siblings, 0 replies; 11+ messages in thread
From: Ayush Tiwari @ 2024-03-17 19:26 UTC (permalink / raw)
To: Larry.Finger, florian.c.schilhabel, gregkh, linux-kernel,
linux-staging
Cc: outreachy
Rename variable backupPMKIDIndex to backup_PMKID_index to address
checkpatch warning 'Avoid Camelcase' and to ensure adherence to
coding style guidelines.
Signed-off-by: Ayush Tiwari <ayushtiw0110@gmail.com>
---
drivers/staging/rtl8712/mlme_linux.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8712/mlme_linux.c b/drivers/staging/rtl8712/mlme_linux.c
index a8cda81f4240..ac8196d24ce0 100644
--- a/drivers/staging/rtl8712/mlme_linux.c
+++ b/drivers/staging/rtl8712/mlme_linux.c
@@ -87,7 +87,7 @@ void r8712_os_indicate_connect(struct _adapter *adapter)
static struct RT_PMKID_LIST backup_PMKID_list[NUM_PMKID_CACHE];
void r8712_os_indicate_disconnect(struct _adapter *adapter)
{
- u8 backupPMKIDIndex = 0;
+ u8 backup_PMKID_index = 0;
u8 backupTKIPCountermeasure = 0x00;
r8712_indicate_wx_disassoc_event(adapter);
@@ -99,10 +99,10 @@ void r8712_os_indicate_disconnect(struct _adapter *adapter)
* disconnect with AP for 60 seconds.
*/
- memcpy(&backupPMKIDList[0],
+ memcpy(&backup_PMKID_list[0],
&adapter->securitypriv.PMKIDList[0],
sizeof(struct RT_PMKID_LIST) * NUM_PMKID_CACHE);
- backupPMKIDIndex = adapter->securitypriv.PMKIDIndex;
+ backup_PMKID_index = adapter->securitypriv.PMKIDIndex;
backupTKIPCountermeasure =
adapter->securitypriv.btkip_countermeasure;
memset((unsigned char *)&adapter->securitypriv, 0,
@@ -113,9 +113,9 @@ void r8712_os_indicate_disconnect(struct _adapter *adapter)
* for the following connection.
*/
memcpy(&adapter->securitypriv.PMKIDList[0],
- &backupPMKIDList[0],
+ &backup_PMKID_list[0],
sizeof(struct RT_PMKID_LIST) * NUM_PMKID_CACHE);
- adapter->securitypriv.PMKIDIndex = backupPMKIDIndex;
+ adapter->securitypriv.PMKIDIndex = backup_PMKID_index;
adapter->securitypriv.btkip_countermeasure =
backupTKIPCountermeasure;
} else { /*reset values in securitypriv*/
--
2.40.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH v2 2/3] staging: rtl8712: rename backupPMKIDIndex to backup_PMKID_index
@ 2024-03-18 19:57 ` Ayush Tiwari
0 siblings, 0 replies; 11+ messages in thread
From: Ayush Tiwari @ 2024-03-18 19:57 UTC (permalink / raw)
To: Larry.Finger, florian.c.schilhabel, gregkh, linux-kernel,
linux-staging
Cc: outreachy
Rename variable backupPMKIDIndex to backup_PMKID_index to address
checkpatch warning 'Avoid Camelcase' and to ensure adherence to
coding style guidelines.
Signed-off-by: Ayush Tiwari <ayushtiw0110@gmail.com>
---
Change in v2: No change.
drivers/staging/rtl8712/mlme_linux.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8712/mlme_linux.c b/drivers/staging/rtl8712/mlme_linux.c
index a8cda81f4240..ac8196d24ce0 100644
--- a/drivers/staging/rtl8712/mlme_linux.c
+++ b/drivers/staging/rtl8712/mlme_linux.c
@@ -87,7 +87,7 @@ void r8712_os_indicate_connect(struct _adapter *adapter)
static struct RT_PMKID_LIST backup_PMKID_list[NUM_PMKID_CACHE];
void r8712_os_indicate_disconnect(struct _adapter *adapter)
{
- u8 backupPMKIDIndex = 0;
+ u8 backup_PMKID_index = 0;
u8 backupTKIPCountermeasure = 0x00;
r8712_indicate_wx_disassoc_event(adapter);
@@ -99,10 +99,10 @@ void r8712_os_indicate_disconnect(struct _adapter *adapter)
* disconnect with AP for 60 seconds.
*/
- memcpy(&backupPMKIDList[0],
+ memcpy(&backup_PMKID_list[0],
&adapter->securitypriv.PMKIDList[0],
sizeof(struct RT_PMKID_LIST) * NUM_PMKID_CACHE);
- backupPMKIDIndex = adapter->securitypriv.PMKIDIndex;
+ backup_PMKID_index = adapter->securitypriv.PMKIDIndex;
backupTKIPCountermeasure =
adapter->securitypriv.btkip_countermeasure;
memset((unsigned char *)&adapter->securitypriv, 0,
@@ -113,9 +113,9 @@ void r8712_os_indicate_disconnect(struct _adapter *adapter)
* for the following connection.
*/
memcpy(&adapter->securitypriv.PMKIDList[0],
- &backupPMKIDList[0],
+ &backup_PMKID_list[0],
sizeof(struct RT_PMKID_LIST) * NUM_PMKID_CACHE);
- adapter->securitypriv.PMKIDIndex = backupPMKIDIndex;
+ adapter->securitypriv.PMKIDIndex = backup_PMKID_index;
adapter->securitypriv.btkip_countermeasure =
backupTKIPCountermeasure;
} else { /*reset values in securitypriv*/
--
2.40.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 3/3] staging: rtl8712: rename backupTKIPCountermeasure to backup_TKIP_countermeasure
@ 2024-03-18 19:58 ` Ayush Tiwari
0 siblings, 0 replies; 11+ messages in thread
From: Ayush Tiwari @ 2024-03-17 19:27 UTC (permalink / raw)
To: Larry.Finger, florian.c.schilhabel, gregkh, linux-kernel,
linux-staging
Cc: outreachy
Rename variable backupTKIPCountermeasure to backup_TKIP_countermeasure
to address checkpatch warning 'Avoid Camelcase' and to ensure
adherence to coding style guidelines.
Signed-off-by: Ayush Tiwari <ayushtiw0110@gmail.com>
---
drivers/staging/rtl8712/mlme_linux.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8712/mlme_linux.c b/drivers/staging/rtl8712/mlme_linux.c
index ac8196d24ce0..436816d14cdf 100644
--- a/drivers/staging/rtl8712/mlme_linux.c
+++ b/drivers/staging/rtl8712/mlme_linux.c
@@ -88,7 +88,7 @@ static struct RT_PMKID_LIST backup_PMKID_list[NUM_PMKID_CACHE];
void r8712_os_indicate_disconnect(struct _adapter *adapter)
{
u8 backup_PMKID_index = 0;
- u8 backupTKIPCountermeasure = 0x00;
+ u8 backup_TKIP_countermeasure = 0x00;
r8712_indicate_wx_disassoc_event(adapter);
netif_carrier_off(adapter->pnetdev);
@@ -103,7 +103,7 @@ void r8712_os_indicate_disconnect(struct _adapter *adapter)
&adapter->securitypriv.PMKIDList[0],
sizeof(struct RT_PMKID_LIST) * NUM_PMKID_CACHE);
backup_PMKID_index = adapter->securitypriv.PMKIDIndex;
- backupTKIPCountermeasure =
+ backup_TKIP_countermeasure =
adapter->securitypriv.btkip_countermeasure;
memset((unsigned char *)&adapter->securitypriv, 0,
sizeof(struct security_priv));
@@ -117,7 +117,7 @@ void r8712_os_indicate_disconnect(struct _adapter *adapter)
sizeof(struct RT_PMKID_LIST) * NUM_PMKID_CACHE);
adapter->securitypriv.PMKIDIndex = backup_PMKID_index;
adapter->securitypriv.btkip_countermeasure =
- backupTKIPCountermeasure;
+ backup_TKIP_countermeasure;
} else { /*reset values in securitypriv*/
struct security_priv *sec_priv = &adapter->securitypriv;
--
2.40.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH v2 3/3] staging: rtl8712: rename backupTKIPCountermeasure to backup_TKIP_countermeasure
@ 2024-03-18 19:58 ` Ayush Tiwari
0 siblings, 0 replies; 11+ messages in thread
From: Ayush Tiwari @ 2024-03-18 19:58 UTC (permalink / raw)
To: Larry.Finger, florian.c.schilhabel, gregkh, linux-kernel,
linux-staging
Cc: outreachy
Rename variable backupTKIPCountermeasure to backup_TKIP_countermeasure
to address checkpatch warning 'Avoid Camelcase' and to ensure
adherence to coding style guidelines.
Signed-off-by: Ayush Tiwari <ayushtiw0110@gmail.com>
---
Change in v2: No change.
drivers/staging/rtl8712/mlme_linux.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8712/mlme_linux.c b/drivers/staging/rtl8712/mlme_linux.c
index ac8196d24ce0..436816d14cdf 100644
--- a/drivers/staging/rtl8712/mlme_linux.c
+++ b/drivers/staging/rtl8712/mlme_linux.c
@@ -88,7 +88,7 @@ static struct RT_PMKID_LIST backup_PMKID_list[NUM_PMKID_CACHE];
void r8712_os_indicate_disconnect(struct _adapter *adapter)
{
u8 backup_PMKID_index = 0;
- u8 backupTKIPCountermeasure = 0x00;
+ u8 backup_TKIP_countermeasure = 0x00;
r8712_indicate_wx_disassoc_event(adapter);
netif_carrier_off(adapter->pnetdev);
@@ -103,7 +103,7 @@ void r8712_os_indicate_disconnect(struct _adapter *adapter)
&adapter->securitypriv.PMKIDList[0],
sizeof(struct RT_PMKID_LIST) * NUM_PMKID_CACHE);
backup_PMKID_index = adapter->securitypriv.PMKIDIndex;
- backupTKIPCountermeasure =
+ backup_TKIP_countermeasure =
adapter->securitypriv.btkip_countermeasure;
memset((unsigned char *)&adapter->securitypriv, 0,
sizeof(struct security_priv));
@@ -117,7 +117,7 @@ void r8712_os_indicate_disconnect(struct _adapter *adapter)
sizeof(struct RT_PMKID_LIST) * NUM_PMKID_CACHE);
adapter->securitypriv.PMKIDIndex = backup_PMKID_index;
adapter->securitypriv.btkip_countermeasure =
- backupTKIPCountermeasure;
+ backup_TKIP_countermeasure;
} else { /*reset values in securitypriv*/
struct security_priv *sec_priv = &adapter->securitypriv;
--
2.40.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH v2 0/3] Trivial code cleanup patches
2024-03-18 19:54 ` [PATCH v2 " Ayush Tiwari
` (3 preceding siblings ...)
(?)
@ 2024-03-19 6:04 ` Fabio M. De Francesco
2024-03-20 19:50 ` Fabio M. De Francesco
-1 siblings, 1 reply; 11+ messages in thread
From: Fabio M. De Francesco @ 2024-03-19 6:04 UTC (permalink / raw)
To: Ayush Tiwari
Cc: Larry.Finger, florian.c.schilhabel, gregkh, linux-kernel,
linux-staging, outreachy
On Monday, 18 March 2024 20:54:09 CET Ayush Tiwari wrote:
> Address different kinds of checkpatch complains for the rtl8712 module
> to ensure adherence to coding style guidelines.
>
> Changes in v2: Checked any possible reuse of backup_PMKID_list
> manually and rebuilt, rebooted the kernel and loaded the driver
> with modprobe.
You have not made any changes to any of the three patches in this series.
No changes in commit messages and no changes in code. Am I missing
something?
So why did you submit a v2 of this series?
Fabio
> Ayush Tiwari (3):
> staging: rtl8712: rename backupPMKIDList to backup_PMKID_list
> staging: rtl8712: rename backupPMKIDIndex to backup_PMKID_index
> staging: rtl8712: rename backupTKIPCountermeasure to
> backup_TKIP_countermeasure
>
> drivers/staging/rtl8712/mlme_linux.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v2 0/3] Trivial code cleanup patches
2024-03-19 6:04 ` [PATCH v2 0/3] Trivial code cleanup patches Fabio M. De Francesco
@ 2024-03-20 19:50 ` Fabio M. De Francesco
0 siblings, 0 replies; 11+ messages in thread
From: Fabio M. De Francesco @ 2024-03-20 19:50 UTC (permalink / raw)
To: Ayush Tiwari
Cc: Larry.Finger, florian.c.schilhabel, gregkh, linux-kernel,
linux-staging, outreachy
On Tuesday, 19 March 2024 07:04:34 CET Fabio M. De Francesco wrote:
> On Monday, 18 March 2024 20:54:09 CET Ayush Tiwari wrote:
> > Address different kinds of checkpatch complains for the rtl8712 module
> > to ensure adherence to coding style guidelines.
> >
> > Changes in v2: Checked any possible reuse of backup_PMKID_list
> > manually and rebuilt,
No you didn't do what you are saying.
> rebooted the kernel and loaded the driver
> > with modprobe.
>
> You have not made any changes to any of the three patches in this series.
> No changes in commit messages and no changes in code. Am I missing
> something?
>
> So why did you submit a v2 of this series?
>
> Fabio
Julia commented on patch 1/3. You should either reply that everything is
correct (if it is) or fix your patch. Please don't send new versions that
don't change anything and don't ignore comments (mine included).
> > Ayush Tiwari (3):
> > staging: rtl8712: rename backupPMKIDList to backup_PMKID_list
This patch introduces errors. You haven't compiled this module, otherwise
you would have noticed that. Always compile your changes (preferably with
CONFIG_WERROR set).
Please read the output of git-grep:
[fabio@linux]$ git grep backupPMKIDList drivers/staging/rtl8712
drivers/staging/rtl8712/mlme_linux.c: static struct RT_PMKID_LIST
backupPMKIDList[NUM_PMKID_CACHE];
drivers/staging/rtl8712/mlme_linux.c: memcpy(&backupPMKIDList[0],
drivers/staging/rtl8712/mlme_linux.c: &backupPMKIDList[0],
Can you see how patch 1/3 introduces errors?
Fabio
> > staging: rtl8712: rename backupPMKIDIndex to backup_PMKID_index
> > staging: rtl8712: rename backupTKIPCountermeasure to
> >
> > backup_TKIP_countermeasure
> >
> > drivers/staging/rtl8712/mlme_linux.c | 18 +++++++++---------
> > 1 file changed, 9 insertions(+), 9 deletions(-)
^ permalink raw reply [flat|nested] 11+ messages in thread