* [PATCH i-g-t v5 0/2] Update compression check based on platform
@ 2024-04-17 4:25 Akshata Jahagirdar
2024-04-16 17:16 ` ✗ Fi.CI.BUILD: failure for Update compression check based on platform (rev5) Patchwork
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Akshata Jahagirdar @ 2024-04-17 4:25 UTC (permalink / raw)
Cc: igt-dev, zbigniew.kempczynski, Akshata Jahagirdar
In Xe2+ platforms, we need to run the xe_ccs test regardless of the status of
flat-ccs.
Check if the platform supports compression and has flat ccs enabled,
and if it doesn't, then update the check on compression
and proceed with the test.
Akshata Jahagirdar (2):
lib/intel_blt: Add helper function to ensure platform has flat-ccs
enabled
tests/xe_ccs: Update compression check based on flat-ccs enablement
lib/intel_blt.c | 14 ++++++++++++++
lib/intel_blt.h | 1 +
tests/intel/xe_ccs.c | 26 ++++++++++++++++++++++----
3 files changed, 37 insertions(+), 4 deletions(-)
--
2.34.1
^ permalink raw reply [flat|nested] 6+ messages in thread* ✗ Fi.CI.BUILD: failure for Update compression check based on platform (rev5) 2024-04-17 4:25 [PATCH i-g-t v5 0/2] Update compression check based on platform Akshata Jahagirdar @ 2024-04-16 17:16 ` Patchwork 2024-04-16 17:21 ` ✗ GitLab.Pipeline: warning " Patchwork ` (2 subsequent siblings) 3 siblings, 0 replies; 6+ messages in thread From: Patchwork @ 2024-04-16 17:16 UTC (permalink / raw) To: Akshata Jahagirdar; +Cc: igt-dev == Series Details == Series: Update compression check based on platform (rev5) URL : https://patchwork.freedesktop.org/series/132014/ State : failure == Summary == IGT patchset build failed on latest successful build 3a71f659700859cab49b8e05a198ba18a5cbd24a tools/gputop: Fix engine columns with amdgpu Tail of build.log: [658/1676] Compiling C object 'tests/vc4/e4667e8@@vc4_dmabuf_poll@exe/vc4_dmabuf_poll.c.o'. [659/1676] Compiling C object 'tests/59830eb@@kms_chamelium_frames@exe/chamelium_kms_chamelium_helper.c.o'. [660/1676] Compiling C object 'tests/vc4/e4667e8@@vc4_mmap@exe/vc4_mmap.c.o'. [661/1676] Compiling C object 'tests/vc4/e4667e8@@vc4_lookup_fail@exe/vc4_lookup_fail.c.o'. [662/1676] Compiling C object 'tests/vc4/e4667e8@@vc4_perfmon@exe/vc4_perfmon.c.o'. [663/1676] Compiling C object 'tests/v3d/cad21b8@@v3d_wait_bo@exe/v3d_wait_bo.c.o'. [664/1676] Compiling C object 'tests/vc4/e4667e8@@vc4_label_bo@exe/vc4_label_bo.c.o'. [665/1676] Compiling C object 'tests/59830eb@@xe_evict@exe/intel_xe_evict.c.o'. [666/1676] Compiling C object 'tests/vc4/e4667e8@@vc4_purgeable_bo@exe/vc4_purgeable_bo.c.o'. [667/1676] Compiling C object 'tests/vc4/e4667e8@@vc4_wait_seqno@exe/vc4_wait_seqno.c.o'. [668/1676] Compiling C object 'tests/59830eb@@xe_pm@exe/intel_xe_pm.c.o'. [669/1676] Compiling C object 'tests/59830eb@@xe_exec_reset@exe/intel_xe_exec_reset.c.o'. [670/1676] Compiling C object 'tests/vc4/e4667e8@@vc4_tiling@exe/vc4_tiling.c.o'. [671/1676] Compiling C object 'tests/v3d/cad21b8@@v3d_job_submission@exe/v3d_job_submission.c.o'. [672/1676] Compiling C object 'benchmarks/cb1d2fd@@gem_busy@exe/gem_busy.c.o'. [673/1676] Compiling C object 'tests/59830eb@@kms_chamelium_edid@exe/chamelium_kms_chamelium_edid.c.o'. [674/1676] Compiling C object 'tests/vc4/e4667e8@@vc4_wait_bo@exe/vc4_wait_bo.c.o'. [675/1676] Compiling C object 'tests/59830eb@@kms_chamelium_audio@exe/chamelium_kms_chamelium_audio.c.o'. [676/1676] Compiling C object 'benchmarks/cb1d2fd@@gem_exec_ctx@exe/gem_exec_ctx.c.o'. [677/1676] Compiling C object 'benchmarks/cb1d2fd@@gem_create@exe/gem_create.c.o'. [678/1676] Compiling C object 'tests/vmwgfx/776e741@@vmw_mob_stress@exe/vmw_mob_stress.c.o'. [679/1676] Compiling C object 'tests/v3d/cad21b8@@v3d_submit_csd@exe/v3d_submit_csd.c.o'. [680/1676] Compiling C object 'tests/vmwgfx/776e741@@vmw_tri@exe/vmw_tri.c.o'. [681/1676] Compiling C object 'tests/59830eb@@kms_chamelium_color@exe/chamelium_kms_chamelium_color.c.o'. [682/1676] Compiling C object 'tests/59830eb@@xe_query@exe/intel_xe_query.c.o'. [683/1676] Compiling C object 'tests/59830eb@@xe_pat@exe/intel_xe_pat.c.o'. [684/1676] Compiling C object 'tests/vmwgfx/776e741@@vmw_ref_count@exe/vmw_ref_count.c.o'. [685/1676] Compiling C object 'tests/vmwgfx/776e741@@vmw_surface_copy@exe/vmw_surface_copy.c.o'. [686/1676] Compiling C object 'tests/59830eb@@i915_query@exe/intel_i915_query.c.o'. [687/1676] Compiling C object 'tests/59830eb@@kms_psr2_sf@exe/intel_kms_psr2_sf.c.o'. [688/1676] Compiling C object 'tests/vmwgfx/776e741@@vmw_execution_buffer@exe/vmw_execution_buffer.c.o'. [689/1676] Compiling C object 'tests/v3d/cad21b8@@v3d_submit_cl@exe/v3d_submit_cl.c.o'. [690/1676] Compiling C object 'tests/59830eb@@xe_intel_bb@exe/intel_xe_intel_bb.c.o'. [691/1676] Compiling C object 'tests/59830eb@@gem_exec_balancer@exe/intel_gem_exec_balancer.c.o'. [692/1676] Compiling C object 'tests/59830eb@@kms_pm_rpm@exe/intel_kms_pm_rpm.c.o'. [693/1676] Compiling C object 'tests/59830eb@@kms_chamelium_hpd@exe/chamelium_kms_chamelium_hpd.c.o'. [694/1676] Compiling C object 'tests/59830eb@@xe_exec_threads@exe/intel_xe_exec_threads.c.o'. [695/1676] Compiling C object 'tests/59830eb@@kms_chamelium_frames@exe/chamelium_kms_chamelium_frames.c.o'. [696/1676] Compiling C object 'tests/59830eb@@gem_stress@exe/intel_gem_stress.c.o'. [697/1676] Generating i915-perf-equations with a custom command. [698/1676] Compiling C object 'tests/59830eb@@gem_exec_fence@exe/intel_gem_exec_fence.c.o'. [699/1676] Compiling C object 'tests/59830eb@@gem_userptr_blits@exe/intel_gem_userptr_blits.c.o'. [700/1676] Compiling C object 'tests/59830eb@@xe_vm@exe/intel_xe_vm.c.o'. [701/1676] Compiling C object 'tests/59830eb@@gem_concurrent_all@exe/intel_gem_concurrent_all.c.o'. [702/1676] Compiling C object 'tests/59830eb@@kms_frontbuffer_tracking@exe/intel_kms_frontbuffer_tracking.c.o'. [703/1676] Compiling C object 'tests/59830eb@@perf_pmu@exe/intel_perf_pmu.c.o'. [704/1676] Compiling C object 'tests/59830eb@@perf@exe/intel_perf.c.o'. [705/1676] Compiling C object 'tests/59830eb@@gem_exec_schedule@exe/intel_gem_exec_schedule.c.o'. [706/1676] Linking target lib/libigt.so.0. ninja: build stopped: subcommand failed. ^ permalink raw reply [flat|nested] 6+ messages in thread
* ✗ GitLab.Pipeline: warning for Update compression check based on platform (rev5) 2024-04-17 4:25 [PATCH i-g-t v5 0/2] Update compression check based on platform Akshata Jahagirdar 2024-04-16 17:16 ` ✗ Fi.CI.BUILD: failure for Update compression check based on platform (rev5) Patchwork @ 2024-04-16 17:21 ` Patchwork 2024-04-17 4:25 ` [PATCH i-g-t v5 1/2] lib/intel_blt: Add helper function to ensure platform has flat-ccs enabled Akshata Jahagirdar 2024-04-17 4:25 ` [PATCH i-g-t v5 2/2] tests/xe_ccs: Update compression check based on flat-ccs enablement Akshata Jahagirdar 3 siblings, 0 replies; 6+ messages in thread From: Patchwork @ 2024-04-16 17:21 UTC (permalink / raw) To: Akshata Jahagirdar; +Cc: igt-dev == Series Details == Series: Update compression check based on platform (rev5) URL : https://patchwork.freedesktop.org/series/132014/ State : warning == Summary == Pipeline status: FAILED. see https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/1155838 for the overview. build:tests-debian-meson has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/57689570): [2/527] Generating kms_psr2_sf.testlist with a meson_exe.py custom command. [3/527] Compiling C object 'tests/59830eb@@xe_ccs@exe/intel_xe_ccs.c.o'. FAILED: tests/59830eb@@xe_ccs@exe/intel_xe_ccs.c.o cc -Itests/59830eb@@xe_ccs@exe -Itests -I../tests -I../include -I../include/drm-uapi -I../include/linux-uapi -Ilib -I../lib -I../lib/stubs/syscalls -I. -I../ -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/uuid -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libdrm -I/usr/include/libdrm/nouveau -I/usr/include/x86_64-linux-gnu -I/usr/include/valgrind -I/usr/include/alsa -I/usr/include -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O2 -g -D_GNU_SOURCE -include config.h -D_FORTIFY_SOURCE=2 -Wbad-function-cast -Wdeclaration-after-statement -Wformat=2 -Wimplicit-fallthrough=0 -Wlogical-op -Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wuninitialized -Wunused -Wno-clobbered -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-pointer-arith -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-result -Werror=address -Werror=array-bounds -Werror=implicit -Werror=init-self -Werror=int-to-pointer-cast -Werror=main -Werror=missing-braces -Werror=nonnull -Werror=pointer-to-int-cast -Werror=return-type -Werror=sequence-point -Werror=trigraphs -Werror=write-strings -fno-builtin-malloc -fno-builtin-calloc -pthread -MD -MQ 'tests/59830eb@@xe_ccs@exe/intel_xe_ccs.c.o' -MF 'tests/59830eb@@xe_ccs@exe/intel_xe_ccs.c.o.d' -o 'tests/59830eb@@xe_ccs@exe/intel_xe_ccs.c.o' -c ../tests/intel/xe_ccs.c ../tests/intel/xe_ccs.c: In function ‘surf_copy’: ../tests/intel/xe_ccs.c:170:9: error: implicit declaration of function ‘is_dgfx’ [-Werror=implicit-function-declaration] if (is_dgfx(xe)) { ^~~~~~~ ../tests/intel/xe_ccs.c:170:9: warning: nested extern declaration of ‘is_dgfx’ [-Wnested-externs] ../tests/intel/xe_ccs.c:165:6: warning: suggest explicit braces to avoid ambiguous ‘else’ [-Wdangling-else] if (blt_platform_has_flat_ccs_enabled(xe)) ^ cc1: some warnings being treated as errors ninja: build stopped: subcommand failed. section_end:1713287886:step_script section_start:1713287886:cleanup_file_variables Cleaning up project directory and file based variables section_end:1713287887:cleanup_file_variables ERROR: Job failed: exit code 1 build:tests-debian-meson-arm64 has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/57689573): [4/426] Linking target tests/kms_psr2_sf. [5/426] Compiling C object 'tests/59830eb@@xe_ccs@exe/intel_xe_ccs.c.o'. FAILED: tests/59830eb@@xe_ccs@exe/intel_xe_ccs.c.o /usr/bin/aarch64-linux-gnu-gcc -Itests/59830eb@@xe_ccs@exe -Itests -I../tests -I../include -I../include/drm-uapi -I../include/linux-uapi -Ilib -I../lib -I../lib/stubs/syscalls -I. -I../ -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib/aarch64-linux-gnu/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/uuid -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libdrm -I/usr/include/libdrm/nouveau -I/usr/include/aarch64-linux-gnu -I/usr/include/valgrind -I/usr/include/alsa -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O2 -g -D_GNU_SOURCE -include config.h -D_FORTIFY_SOURCE=2 -Wbad-function-cast -Wdeclaration-after-statement -Wformat=2 -Wimplicit-fallthrough=0 -Wlogical-op -Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wuninitialized -Wunused -Wno-clobbered -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-pointer-arith -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-result -Werror=address -Werror=array-bounds -Werror=implicit -Werror=init-self -Werror=int-to-pointer-cast -Werror=main -Werror=missing-braces -Werror=nonnull -Werror=pointer-to-int-cast -Werror=return-type -Werror=sequence-point -Werror=trigraphs -Werror=write-strings -fno-builtin-malloc -fno-builtin-calloc -pthread -MD -MQ 'tests/59830eb@@xe_ccs@exe/intel_xe_ccs.c.o' -MF 'tests/59830eb@@xe_ccs@exe/intel_xe_ccs.c.o.d' -o 'tests/59830eb@@xe_ccs@exe/intel_xe_ccs.c.o' -c ../tests/intel/xe_ccs.c ../tests/intel/xe_ccs.c: In function ‘surf_copy’: ../tests/intel/xe_ccs.c:170:9: error: implicit declaration of function ‘is_dgfx’ [-Werror=implicit-function-declaration] if (is_dgfx(xe)) { ^~~~~~~ ../tests/intel/xe_ccs.c:170:9: warning: nested extern declaration of ‘is_dgfx’ [-Wnested-externs] ../tests/intel/xe_ccs.c:165:6: warning: suggest explicit braces to avoid ambiguous ‘else’ [-Wdangling-else] if (blt_platform_has_flat_ccs_enabled(xe)) ^ cc1: some warnings being treated as errors ninja: build stopped: subcommand failed. section_end:1713287929:step_script section_start:1713287929:cleanup_file_variables Cleaning up project directory and file based variables section_end:1713287930:cleanup_file_variables ERROR: Job failed: exit code 1 build:tests-debian-meson-armhf has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/57689572): [3/425] Linking target tests/kms_psr2_sf. [4/425] Compiling C object 'tests/59830eb@@xe_ccs@exe/intel_xe_ccs.c.o'. FAILED: tests/59830eb@@xe_ccs@exe/intel_xe_ccs.c.o /usr/bin/arm-linux-gnueabihf-gcc -Itests/59830eb@@xe_ccs@exe -Itests -I../tests -I../include -I../include/drm-uapi -I../include/linux-uapi -Ilib -I../lib -I../lib/stubs/syscalls -I. -I../ -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib/arm-linux-gnueabihf/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/uuid -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libdrm -I/usr/include/libdrm/nouveau -I/usr/include/arm-linux-gnueabihf -I/usr/include/valgrind -I/usr/include/alsa -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O2 -g -D_GNU_SOURCE -include config.h -D_FORTIFY_SOURCE=2 -Wbad-function-cast -Wdeclaration-after-statement -Wformat=2 -Wimplicit-fallthrough=0 -Wlogical-op -Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wuninitialized -Wunused -Wno-clobbered -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-pointer-arith -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-result -Werror=address -Werror=array-bounds -Werror=implicit -Werror=init-self -Werror=int-to-pointer-cast -Werror=main -Werror=missing-braces -Werror=nonnull -Werror=pointer-to-int-cast -Werror=return-type -Werror=sequence-point -Werror=trigraphs -Werror=write-strings -fno-builtin-malloc -fno-builtin-calloc -pthread -MD -MQ 'tests/59830eb@@xe_ccs@exe/intel_xe_ccs.c.o' -MF 'tests/59830eb@@xe_ccs@exe/intel_xe_ccs.c.o.d' -o 'tests/59830eb@@xe_ccs@exe/intel_xe_ccs.c.o' -c ../tests/intel/xe_ccs.c ../tests/intel/xe_ccs.c: In function ‘surf_copy’: ../tests/intel/xe_ccs.c:170:9: error: implicit declaration of function ‘is_dgfx’ [-Werror=implicit-function-declaration] if (is_dgfx(xe)) { ^~~~~~~ ../tests/intel/xe_ccs.c:170:9: warning: nested extern declaration of ‘is_dgfx’ [-Wnested-externs] ../tests/intel/xe_ccs.c:165:6: warning: suggest explicit braces to avoid ambiguous ‘else’ [-Wdangling-else] if (blt_platform_has_flat_ccs_enabled(xe)) ^ cc1: some warnings being treated as errors ninja: build stopped: subcommand failed. section_end:1713287896:step_script section_start:1713287896:cleanup_file_variables Cleaning up project directory and file based variables section_end:1713287897:cleanup_file_variables ERROR: Job failed: exit code 1 build:tests-debian-meson-mips has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/57689574): [9/428] Linking target tests/kms_psr2_sf. [10/428] Compiling C object 'tests/59830eb@@xe_ccs@exe/intel_xe_ccs.c.o'. FAILED: tests/59830eb@@xe_ccs@exe/intel_xe_ccs.c.o /usr/bin/mips-linux-gnu-gcc -Itests/59830eb@@xe_ccs@exe -Itests -I../tests -I../include -I../include/drm-uapi -I../include/linux-uapi -Ilib -I../lib -I../lib/stubs/syscalls -I. -I../ -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib/mips-linux-gnu/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/uuid -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libdrm -I/usr/include/libdrm/nouveau -I/usr/include/mips-linux-gnu -I/usr/include/valgrind -I/usr/include/alsa -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O2 -g -D_GNU_SOURCE -include config.h -D_FORTIFY_SOURCE=2 -Wbad-function-cast -Wdeclaration-after-statement -Wformat=2 -Wimplicit-fallthrough=0 -Wlogical-op -Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wuninitialized -Wunused -Wno-clobbered -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-pointer-arith -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-result -Werror=address -Werror=array-bounds -Werror=implicit -Werror=init-self -Werror=int-to-pointer-cast -Werror=main -Werror=missing-braces -Werror=nonnull -Werror=pointer-to-int-cast -Werror=return-type -Werror=sequence-point -Werror=trigraphs -Werror=write-strings -fno-builtin-malloc -fno-builtin-calloc -pthread -MD -MQ 'tests/59830eb@@xe_ccs@exe/intel_xe_ccs.c.o' -MF 'tests/59830eb@@xe_ccs@exe/intel_xe_ccs.c.o.d' -o 'tests/59830eb@@xe_ccs@exe/intel_xe_ccs.c.o' -c ../tests/intel/xe_ccs.c ../tests/intel/xe_ccs.c: In function ‘surf_copy’: ../tests/intel/xe_ccs.c:170:9: error: implicit declaration of function ‘is_dgfx’ [-Werror=implicit-function-declaration] if (is_dgfx(xe)) { ^~~~~~~ ../tests/intel/xe_ccs.c:170:9: warning: nested extern declaration of ‘is_dgfx’ [-Wnested-externs] ../tests/intel/xe_ccs.c:165:6: warning: suggest explicit braces to avoid ambiguous ‘else’ [-Wdangling-else] if (blt_platform_has_flat_ccs_enabled(xe)) ^ cc1: some warnings being treated as errors ninja: build stopped: subcommand failed. section_end:1713287920:step_script section_start:1713287920:cleanup_file_variables Cleaning up project directory and file based variables section_end:1713287921:cleanup_file_variables ERROR: Job failed: exit code 1 build:tests-fedora has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/57689565): [1/1104] Generating version.h with a custom command. [2/535] Compiling C object 'tests/59830eb@@xe_ccs@exe/intel_xe_ccs.c.o'. FAILED: tests/59830eb@@xe_ccs@exe/intel_xe_ccs.c.o cc -Itests/59830eb@@xe_ccs@exe -Itests -I../tests -I../include -I../include/drm-uapi -I../include/linux-uapi -Ilib -I../lib -I../lib/stubs/syscalls -I. -I../ -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libdrm -I/usr/include/libdrm/nouveau -I/usr/include/valgrind -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O2 -g -D_GNU_SOURCE -include config.h -D_FORTIFY_SOURCE=2 -Wbad-function-cast -Wdeclaration-after-statement -Wformat=2 -Wimplicit-fallthrough=0 -Wlogical-op -Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wuninitialized -Wunused -Wno-clobbered -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-pointer-arith -Wno-address-of-packed-member -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-result -Werror=address -Werror=array-bounds -Werror=implicit -Werror=init-self -Werror=int-to-pointer-cast -Werror=main -Werror=missing-braces -Werror=nonnull -Werror=pointer-to-int-cast -Werror=return-type -Werror=sequence-point -Werror=trigraphs -Werror=write-strings -fno-builtin-malloc -fno-builtin-calloc -pthread -MD -MQ 'tests/59830eb@@xe_ccs@exe/intel_xe_ccs.c.o' -MF 'tests/59830eb@@xe_ccs@exe/intel_xe_ccs.c.o.d' -o 'tests/59830eb@@xe_ccs@exe/intel_xe_ccs.c.o' -c ../tests/intel/xe_ccs.c ../tests/intel/xe_ccs.c: In function ‘surf_copy’: ../tests/intel/xe_ccs.c:170:9: error: implicit declaration of function ‘is_dgfx’ [-Werror=implicit-function-declaration] 170 | if (is_dgfx(xe)) { | ^~~~~~~ ../tests/intel/xe_ccs.c:170:9: warning: nested extern declaration of ‘is_dgfx’ [-Wnested-externs] ../tests/intel/xe_ccs.c:165:6: warning: suggest explicit braces to avoid ambiguous ‘else’ [-Wdangling-else] 165 | if (blt_platform_has_flat_ccs_enabled(xe)) | ^ cc1: some warnings being treated as errors ninja: build stopped: subcommand failed. section_end:1713287805:step_script section_start:1713287805:cleanup_file_variables Cleaning up project directory and file based variables section_end:1713287805:cleanup_file_variables ERROR: Job failed: exit code 1 build:tests-fedora-clang has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/57689569): if (is_dgfx(xe)) { ^ ../tests/intel/xe_ccs.c:169:6: warning: add explicit braces to avoid dangling else [-Wdangling-else] } else if (AT_LEAST_GEN(xe, 20)) { ^ ../tests/intel/xe_ccs.c:314:9: warning: variable 'ret' is uninitialized when used here [-Wuninitialized] return ret; ^~~ ../tests/intel/xe_ccs.c:267:9: note: initialize the variable 'ret' to silence this warning int ret; ^ = 0 2 warnings and 1 error generated. ninja: build stopped: subcommand failed. section_end:1713287910:step_script section_start:1713287910:cleanup_file_variables Cleaning up project directory and file based variables section_end:1713287910:cleanup_file_variables ERROR: Job failed: exit code 1 build:tests-fedora-no-libdrm-nouveau has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/57689568): [3/410] Generating kms_psr2_sf.testlist with a meson_exe.py custom command. [4/410] Compiling C object 'tests/59830eb@@xe_ccs@exe/intel_xe_ccs.c.o'. FAILED: tests/59830eb@@xe_ccs@exe/intel_xe_ccs.c.o cc -Itests/59830eb@@xe_ccs@exe -Itests -I../tests -I../include -I../include/drm-uapi -I../include/linux-uapi -Ilib -I../lib -I../lib/stubs/syscalls -I. -I../ -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libdrm -I/usr/include/valgrind -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O2 -g -D_GNU_SOURCE -include config.h -D_FORTIFY_SOURCE=2 -Wbad-function-cast -Wdeclaration-after-statement -Wformat=2 -Wimplicit-fallthrough=0 -Wlogical-op -Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wuninitialized -Wunused -Wno-clobbered -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-pointer-arith -Wno-address-of-packed-member -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-result -Werror=address -Werror=array-bounds -Werror=implicit -Werror=init-self -Werror=int-to-pointer-cast -Werror=main -Werror=missing-braces -Werror=nonnull -Werror=pointer-to-int-cast -Werror=return-type -Werror=sequence-point -Werror=trigraphs -Werror=write-strings -fno-builtin-malloc -fno-builtin-calloc -pthread -MD -MQ 'tests/59830eb@@xe_ccs@exe/intel_xe_ccs.c.o' -MF 'tests/59830eb@@xe_ccs@exe/intel_xe_ccs.c.o.d' -o 'tests/59830eb@@xe_ccs@exe/intel_xe_ccs.c.o' -c ../tests/intel/xe_ccs.c ../tests/intel/xe_ccs.c: In function ‘surf_copy’: ../tests/intel/xe_ccs.c:170:9: error: implicit declaration of function ‘is_dgfx’ [-Werror=implicit-function-declaration] 170 | if (is_dgfx(xe)) { | ^~~~~~~ ../tests/intel/xe_ccs.c:170:9: warning: nested extern declaration of ‘is_dgfx’ [-Wnested-externs] ../tests/intel/xe_ccs.c:165:6: warning: suggest explicit braces to avoid ambiguous ‘else’ [-Wdangling-else] 165 | if (blt_platform_has_flat_ccs_enabled(xe)) | ^ cc1: some warnings being treated as errors ninja: build stopped: subcommand failed. section_end:1713287853:step_script section_start:1713287853:cleanup_file_variables Cleaning up project directory and file based variables section_end:1713287854:cleanup_file_variables ERROR: Job failed: exit code 1 build:tests-fedora-no-libunwind has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/57689566): [2/536] Generating kms_psr2_sf.testlist with a meson_exe.py custom command. [3/536] Compiling C object 'tests/59830eb@@xe_ccs@exe/intel_xe_ccs.c.o'. FAILED: tests/59830eb@@xe_ccs@exe/intel_xe_ccs.c.o cc -Itests/59830eb@@xe_ccs@exe -Itests -I../tests -I../include -I../include/drm-uapi -I../include/linux-uapi -Ilib -I../lib -I../lib/stubs/syscalls -I. -I../ -I../lib/stubs/libunwind -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libdrm -I/usr/include/libdrm/nouveau -I/usr/include/valgrind -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O2 -g -D_GNU_SOURCE -include config.h -D_FORTIFY_SOURCE=2 -Wbad-function-cast -Wdeclaration-after-statement -Wformat=2 -Wimplicit-fallthrough=0 -Wlogical-op -Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wuninitialized -Wunused -Wno-clobbered -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-pointer-arith -Wno-address-of-packed-member -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-result -Werror=address -Werror=array-bounds -Werror=implicit -Werror=init-self -Werror=int-to-pointer-cast -Werror=main -Werror=missing-braces -Werror=nonnull -Werror=pointer-to-int-cast -Werror=return-type -Werror=sequence-point -Werror=trigraphs -Werror=write-strings -fno-builtin-malloc -fno-builtin-calloc -pthread -MD -MQ 'tests/59830eb@@xe_ccs@exe/intel_xe_ccs.c.o' -MF 'tests/59830eb@@xe_ccs@exe/intel_xe_ccs.c.o.d' -o 'tests/59830eb@@xe_ccs@exe/intel_xe_ccs.c.o' -c ../tests/intel/xe_ccs.c ../tests/intel/xe_ccs.c: In function ‘surf_copy’: ../tests/intel/xe_ccs.c:170:9: error: implicit declaration of function ‘is_dgfx’ [-Werror=implicit-function-declaration] 170 | if (is_dgfx(xe)) { | ^~~~~~~ ../tests/intel/xe_ccs.c:170:9: warning: nested extern declaration of ‘is_dgfx’ [-Wnested-externs] ../tests/intel/xe_ccs.c:165:6: warning: suggest explicit braces to avoid ambiguous ‘else’ [-Wdangling-else] 165 | if (blt_platform_has_flat_ccs_enabled(xe)) | ^ cc1: some warnings being treated as errors ninja: build stopped: subcommand failed. section_end:1713287797:step_script section_start:1713287797:cleanup_file_variables Cleaning up project directory and file based variables section_end:1713287797:cleanup_file_variables ERROR: Job failed: exit code 1 build:tests-fedora-oldest-meson has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/57689567): [2/535] Generating kms_psr2_sf.testlist with a meson_exe.py custom command. [3/535] Compiling C object 'tests/tests@@xe_ccs@exe/intel_xe_ccs.c.o'. FAILED: tests/tests@@xe_ccs@exe/intel_xe_ccs.c.o cc -Itests/tests@@xe_ccs@exe -Itests -I../tests -I../include -I../include/drm-uapi -I../include/linux-uapi -Ilib -I../lib -I../lib/stubs/syscalls -I. -I../ -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libdrm -I/usr/include/libdrm/nouveau -I/usr/include/valgrind -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O2 -g -D_GNU_SOURCE -include config.h -D_FORTIFY_SOURCE=2 -Wbad-function-cast -Wdeclaration-after-statement -Wformat=2 -Wimplicit-fallthrough=0 -Wlogical-op -Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wuninitialized -Wunused -Wno-clobbered -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-pointer-arith -Wno-address-of-packed-member -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-result -Werror=address -Werror=array-bounds -Werror=implicit -Werror=init-self -Werror=int-to-pointer-cast -Werror=main -Werror=missing-braces -Werror=nonnull -Werror=pointer-to-int-cast -Werror=return-type -Werror=sequence-point -Werror=trigraphs -Werror=write-strings -fno-builtin-malloc -fno-builtin-calloc -pthread -MD -MQ 'tests/tests@@xe_ccs@exe/intel_xe_ccs.c.o' -MF 'tests/tests@@xe_ccs@exe/intel_xe_ccs.c.o.d' -o 'tests/tests@@xe_ccs@exe/intel_xe_ccs.c.o' -c ../tests/intel/xe_ccs.c ../tests/intel/xe_ccs.c: In function ‘surf_copy’: ../tests/intel/xe_ccs.c:170:9: error: implicit declaration of function ‘is_dgfx’ [-Werror=implicit-function-declaration] 170 | if (is_dgfx(xe)) { | ^~~~~~~ ../tests/intel/xe_ccs.c:170:9: warning: nested extern declaration of ‘is_dgfx’ [-Wnested-externs] ../tests/intel/xe_ccs.c:165:6: warning: suggest explicit braces to avoid ambiguous ‘else’ [-Wdangling-else] 165 | if (blt_platform_has_flat_ccs_enabled(xe)) | ^ cc1: some warnings being treated as errors ninja: build stopped: subcommand failed. section_end:1713287836:step_script section_start:1713287836:cleanup_file_variables Cleaning up project directory and file based variables section_end:1713287837:cleanup_file_variables ERROR: Job failed: exit code 1 == Logs == For more details see: https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/1155838 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH i-g-t v5 1/2] lib/intel_blt: Add helper function to ensure platform has flat-ccs enabled 2024-04-17 4:25 [PATCH i-g-t v5 0/2] Update compression check based on platform Akshata Jahagirdar 2024-04-16 17:16 ` ✗ Fi.CI.BUILD: failure for Update compression check based on platform (rev5) Patchwork 2024-04-16 17:21 ` ✗ GitLab.Pipeline: warning " Patchwork @ 2024-04-17 4:25 ` Akshata Jahagirdar 2024-04-17 4:25 ` [PATCH i-g-t v5 2/2] tests/xe_ccs: Update compression check based on flat-ccs enablement Akshata Jahagirdar 3 siblings, 0 replies; 6+ messages in thread From: Akshata Jahagirdar @ 2024-04-17 4:25 UTC (permalink / raw) Cc: igt-dev, zbigniew.kempczynski, Akshata Jahagirdar, Jonathan Cavitt Add helper function to check if platform has flat-ccs enabled by reading from debugfs entry. Signed-off-by: Akshata Jahagirdar <akshata.jahagirdar@intel.com> Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com> Acked-by: Jonathan Cavitt <jonathan.cavitt@intel.com> --- lib/intel_blt.c | 14 ++++++++++++++ lib/intel_blt.h | 1 + 2 files changed, 15 insertions(+) diff --git a/lib/intel_blt.c b/lib/intel_blt.c index dc6669889..4da5cc855 100644 --- a/lib/intel_blt.c +++ b/lib/intel_blt.c @@ -464,6 +464,20 @@ bool blt_block_copy_supports_compression(int fd) BLT_CMD_SUPPORTS_COMPRESSION); } +/** + * blt_platform_has_flat_ccs_enabled + * @fd: drm fd + * + * Check if platform provided by @fd device has flat-ccs enabled. + * + * Returns: + * true if it does, false otherwise. + */ +bool blt_platform_has_flat_ccs_enabled(int fd) +{ + return igt_debugfs_search(fd, "info", "has_flat_ccs yes"); +} + /** * blt_uses_extended_block_copy * @fd: drm fd diff --git a/lib/intel_blt.h b/lib/intel_blt.h index d9c4d107f..cc5966686 100644 --- a/lib/intel_blt.h +++ b/lib/intel_blt.h @@ -209,6 +209,7 @@ bool blt_fast_copy_supports_tiling(int fd, enum blt_tiling_type tiling); bool blt_block_copy_supports_tiling(int fd, enum blt_tiling_type tiling); bool blt_xy_src_copy_supports_tiling(int fd, enum blt_tiling_type tiling); bool blt_block_copy_supports_compression(int fd); +bool blt_platform_has_flat_ccs_enabled(int fd); bool blt_uses_extended_block_copy(int fd); const char *blt_tiling_name(enum blt_tiling_type tiling); -- 2.34.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH i-g-t v5 2/2] tests/xe_ccs: Update compression check based on flat-ccs enablement 2024-04-17 4:25 [PATCH i-g-t v5 0/2] Update compression check based on platform Akshata Jahagirdar ` (2 preceding siblings ...) 2024-04-17 4:25 ` [PATCH i-g-t v5 1/2] lib/intel_blt: Add helper function to ensure platform has flat-ccs enabled Akshata Jahagirdar @ 2024-04-17 4:25 ` Akshata Jahagirdar 3 siblings, 0 replies; 6+ messages in thread From: Akshata Jahagirdar @ 2024-04-17 4:25 UTC (permalink / raw) Cc: igt-dev, zbigniew.kempczynski, Akshata Jahagirdar, Jonathan Cavitt In Xe2+ platforms,we need to run this test regardless of the status of flat-ccs. Check if the platform supports compression and has flat ccs enabled, and if it doesn't, then update the checks accordingly and proceed with the test. Additionally, On Xe2 dGPU, compression is only supported with VRAM. When copying from VRAM -> sysmem the KMD uses mapping with uncompressed PAT so the copy in system memory is guaranteed to be uncompressed. When restoring such buffers from sysmem -> VRAM the KMD can't easily know which pages were originally compressed, so we always use uncompressed -> uncompressed here. so this means there's no need for extra CCS storage on such platforms. Thats why we shouldn't need to run suspend-resume on xe2 dgpu. Signed-off-by: Akshata Jahagirdar <akshata.jahagirdar@intel.com> Acked-by: Jonathan Cavitt <jonathan.cavitt@intel.com> --- tests/intel/xe_ccs.c | 26 ++++++++++++++++++++++---- 1 file changed, 22 insertions(+), 4 deletions(-) diff --git a/tests/intel/xe_ccs.c b/tests/intel/xe_ccs.c index b3bf97af7..d61644884 100644 --- a/tests/intel/xe_ccs.c +++ b/tests/intel/xe_ccs.c @@ -162,8 +162,24 @@ static void surf_copy(int xe, (void *)mid->ptr, mid->size); munmap(ccsmap2, ccssize); - igt_assert(!strcmp(orig, newsum)); - igt_assert(!strcmp(orig2, newsum2)); + if (blt_platform_has_flat_ccs_enabled(xe)) + if (IS_GEN(xe, 12) && is_intel_dgfx(xe)) { + igt_assert(!strcmp(orig, newsum)); + igt_assert(!strcmp(orig2, newsum2)); + } else if (AT_LEAST_GEN(xe, 20)) { + if (is_dgfx(xe)) { + /* buffer object would become + * uncompressed in xe2+ dgfx + */ + igt_assert(!blt_surface_is_compressed(xe, ctx, + NULL, ahnd, mid)); + } else { + /* ccs should be present in xe2+ igfx */ + igt_assert(blt_surface_is_compressed(xe, ctx, + NULL, ahnd, mid)); + } + } + g_free(orig); g_free(orig2); g_free(newsum); @@ -193,7 +209,8 @@ static void surf_copy(int xe, intel_ctx_xe_sync(ctx, true); WRITE_PNG(xe, run_id, "corrupted", &blt.dst, dst->x2, dst->y2, bpp); result = memcmp(src->ptr, dst->ptr, src->size); - igt_assert(result != 0); + if (!blt_platform_has_flat_ccs_enabled(xe)) + igt_assert(result != 0); /* retrieve back ccs */ memcpy(ccsmap, ccscopy, ccssize); @@ -365,7 +382,8 @@ static void block_copy(int xe, * occurs and ctrl surface will be filled with some not-zeroed values. */ if (mid->compression && FROM_EXP_WH(width, height)) - igt_assert(blt_surface_is_compressed(xe, ctx, NULL, ahnd, mid)); + if (!blt_platform_has_flat_ccs_enabled(xe)) + igt_assert(blt_surface_is_compressed(xe, ctx, NULL, ahnd, mid)); WRITE_PNG(xe, run_id, "mid", &blt.dst, width, height, bpp); -- 2.34.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH i-g-t v5 0/2] Update compression check based on platform
@ 2024-04-17 3:52 Akshata Jahagirdar
0 siblings, 0 replies; 6+ messages in thread
From: Akshata Jahagirdar @ 2024-04-17 3:52 UTC (permalink / raw)
Cc: igt-dev, zbigniew.kempczynski, Akshata Jahagirdar
In Xe2+ platforms, we need to run the xe_ccs test regardless of the status of
flat-ccs.
Check if the platform supports compression and has flat ccs enabled,
and if it doesn't, then update the check on compression
and proceed with the test.
Akshata Jahagirdar (2):
lib/intel_blt: Add helper function to ensure platform has flat-ccs
enabled
tests/xe_ccs: Update compression check based on flat-ccs enablement
lib/intel_blt.c | 14 ++++++++++++++
lib/intel_blt.h | 1 +
tests/intel/xe_ccs.c | 20 ++++++++++++++++----
3 files changed, 31 insertions(+), 4 deletions(-)
--
2.34.1
^ permalink raw reply [flat|nested] 6+ messages in threadend of thread, other threads:[~2024-04-16 17:21 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-04-17 4:25 [PATCH i-g-t v5 0/2] Update compression check based on platform Akshata Jahagirdar 2024-04-16 17:16 ` ✗ Fi.CI.BUILD: failure for Update compression check based on platform (rev5) Patchwork 2024-04-16 17:21 ` ✗ GitLab.Pipeline: warning " Patchwork 2024-04-17 4:25 ` [PATCH i-g-t v5 1/2] lib/intel_blt: Add helper function to ensure platform has flat-ccs enabled Akshata Jahagirdar 2024-04-17 4:25 ` [PATCH i-g-t v5 2/2] tests/xe_ccs: Update compression check based on flat-ccs enablement Akshata Jahagirdar -- strict thread matches above, loose matches on Subject: below -- 2024-04-17 3:52 [PATCH i-g-t v5 0/2] Update compression check based on platform Akshata Jahagirdar
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.