From: Paolo Abeni <pabeni@redhat.com>
To: netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
David Ahern <dsahern@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH net-next 0/3] dst_cache: cope with device removal
Date: Thu, 30 May 2024 19:18:08 +0200 [thread overview]
Message-ID: <cover.1717087015.git.pabeni@redhat.com> (raw)
Eric reported a net device refcount leak and diagnosed the root cause
as the dst_cache not coping well with the underlying device removal.
To address such issue, this series introduces the infrastructure to let
the existing uncached list handle the relevant cleanup.
Patch 1 and 2 are preparation changes to make the uncached list infra
more flexible for the new use-case, and patch 3 addresses the issue.
---
Targeting net-next as the addressed problem is quite ancient and I fear
some unexpected side effects for patch 2.
Paolo Abeni (3):
ipv6: use a new flag to indicate elevated refcount.
ipv4: obsolete routes moved out of per cpu cache
dst_cache: let rt_uncached cope with dst_cache cleanup
include/net/ip6_fib.h | 3 +++
net/core/dst_cache.c | 8 ++++++++
net/ipv4/route.c | 2 +-
net/ipv6/route.c | 4 ++--
4 files changed, 14 insertions(+), 3 deletions(-)
--
2.43.2
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Abeni <pabeni@redhat.com>
To: netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
David Ahern <dsahern@kernel.org>,
Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH net-next 0/3] dst_cache: cope with device removal
Date: Thu, 30 May 2024 19:21:00 +0200 [thread overview]
Message-ID: <cover.1717087015.git.pabeni@redhat.com> (raw)
Message-ID: <20240530172100._Nhvy0Oh5jF6D1CWr2q5XSIo4_i0jG5OYDJ-UuaLNsk@z> (raw)
Eric reported a net device refcount leak and diagnosed the root cause
as the dst_cache not coping well with the underlying device removal.
To address such issue, this series introduces the infrastructure to let
the existing uncached list handle the relevant cleanup.
Patch 1 and 2 are preparation changes to make the uncached list infra
more flexible for the new use-case, and patch 3 addresses the issue.
---
Targeting net-next as the addressed problem is quite ancient and I fear
some unexpected side effects for patch 2.
Paolo Abeni (3):
ipv6: use a new flag to indicate elevated refcount.
ipv4: obsolete routes moved out of per cpu cache
dst_cache: let rt_uncached cope with dst_cache cleanup
include/net/ip6_fib.h | 3 +++
net/core/dst_cache.c | 8 ++++++++
net/ipv4/route.c | 2 +-
net/ipv6/route.c | 4 ++--
4 files changed, 14 insertions(+), 3 deletions(-)
--
2.43.2
next reply other threads:[~2024-05-30 17:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-30 17:18 Paolo Abeni [this message]
2024-05-30 17:21 ` [PATCH net-next 0/3] dst_cache: cope with device removal Paolo Abeni
2024-05-30 17:21 ` [PATCH net-next 1/3] ipv6: use a new flag to indicate elevated refcount Paolo Abeni
2024-05-30 17:21 ` [PATCH net-next 2/3] ipv4: obsolete routes moved out of per cpu cache Paolo Abeni
2024-05-30 17:21 ` [PATCH net-next 3/3] dst_cache: let rt_uncached cope with dst_cache cleanup Paolo Abeni
2024-05-30 17:46 ` Eric Dumazet
2024-05-31 10:53 ` kernel test robot
2024-05-31 17:32 ` kernel test robot
2024-05-30 17:38 ` [PATCH net-next 0/3] dst_cache: cope with device removal Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1717087015.git.pabeni@redhat.com \
--to=pabeni@redhat.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.