All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v5 0/1] linux-user: add openat2 support in linux-user
@ 2024-09-19 19:46 Michael Vogt
  0 siblings, 0 replies; only message in thread
From: Michael Vogt @ 2024-09-19 19:46 UTC (permalink / raw)
  To: qemu-devel; +Cc: Richard Henderson, Laurent Vivier, Michael Vogt

Hi,

This is v5 of the openat2 support in linux-user. Thanks for the
excellent feedback from Laurent Vivier on v4.

This version is very close to v4 and only tweaks/simplifies based
on the code review comments from Laurent, see the below changes
for details.

Thanks again,
 Michael

v4 -> v5
- drop "*use_returned_fd" from maybe_do_fake_open() and use return value
  -2 to signal to the caller to continue
- keep "pathname" in parameter to do_guest_openat() for a cleaner diff
- fix two missing get_errno(fd)

v3 -> v4:
- fix typos in the commit message

v2 -> v3:
- fix coding style (braches)
- improve argument args/naming in do_openat2()
- merge do_openat2/do_guest_openat2
- do size checks first in do_openat2
- add "copy_struct_from_user" and use in "do_openat2()"
- drop using openat2.h and create "struct open_how_v0"
- log if open_how guest struct is bigger than our supported struct

v1 -> v2:
- do not include <sys/syscall.h>
- drop do_guest_openat2 from qemu.h and make static
- drop "safe" from do_guest_openat2
- ensure maybe_do_fake_open() is correct about when the result should
  be used or not
- Extract do_openat2() helper from do_syscall1()
- Call user_unlock* if a lock call fails
- Fix silly incorrect use of "target_open_how" when "open_how" is required
- Fix coding style comments
- Fix validation of arg4 in openat2
- Fix missing zero initialization of open_how
- Define target_open_how with abi_* types
- Warn about unimplemented size if "size" of openat2 is bigger than
  target_open_how

Michael Vogt (1):
  linux-user: add openat2 support in linux-user

 linux-user/syscall.c      | 107 +++++++++++++++++++++++++++++++++++++-
 linux-user/syscall_defs.h |   7 +++
 2 files changed, 112 insertions(+), 2 deletions(-)

-- 
2.45.2



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2024-09-19 19:50 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-19 19:46 [PATCH v5 0/1] linux-user: add openat2 support in linux-user Michael Vogt

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.