[OE-core][kirkstone 0/2] Patch review

[OE-core][kirkstone 0/2] Patch review

[Steve Sakoman]

Please review this set of changes for kirkstone and have comments back by
end of day Friday, October 11

Passed a-full on autobuilder:

https://valkyrie.yoctoproject.org/#/builders/29/builds/246

The following changes since commit 4ef9b4d947b6e8ed7637cdd9e722c3f0c83990dd:

  zstd: fix LICENSE statement (2024-10-08 11:49:12 -0700)

are available in the Git repository at:

  https://git.openembedded.org/openembedded-core-contrib stable/kirkstone-nut
  https://git.openembedded.org/openembedded-core-contrib/log/?h=stable/kirkstone-nut

Steve Sakoman (2):
  valgrind: disable avx_estimate_insn.vgtest
  selftest/runtime_test/virgl: Disable for all fedora

 meta/lib/oeqa/selftest/cases/runtime_test.py      | 2 +-
 meta/recipes-devtools/valgrind/valgrind_3.18.1.bb | 8 ++++++++
 2 files changed, 9 insertions(+), 1 deletion(-)

-- 
2.34.1

[OE-core][kirkstone 1/2] valgrind: disable avx_estimate_insn.vgtest

[Steve Sakoman]

This test fails consistently on the new valkyrie autobuilder cluster

The estimate instructions (rcpss, rcpps, rsqrtps, rsqrtss) are, as the
name suggests, not expected to give a fully accurate result. They may
produce slighly different results on different CPU families because
their results are not defined by the IEEE standard.

Signed-off-by: Steve Sakoman <steve@sakoman.com>
---
 meta/recipes-devtools/valgrind/valgrind_3.18.1.bb | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/meta/recipes-devtools/valgrind/valgrind_3.18.1.bb b/meta/recipes-devtools/valgrind/valgrind_3.18.1.bb
index 0c297ad6b9..2a1bf19da5 100644
--- a/meta/recipes-devtools/valgrind/valgrind_3.18.1.bb
+++ b/meta/recipes-devtools/valgrind/valgrind_3.18.1.bb
@@ -237,6 +237,14 @@ do_install_ptest() {
     # This is known failure see https://bugs.kde.org/show_bug.cgi?id=435732
     rm ${D}${PTEST_PATH}/memcheck/tests/leak_cpp_interior.vgtest
 
+    # This test fails consistently on the new valkyrie autobuilder cluster
+    # It tests the avx estimate instructions
+    # The estimate instructions (rcpss, rcpps, rsqrtps, rsqrtss) are, as the
+    # name suggests, not expected to give a fully accurate result. They may
+    # produce slighly different results on different CPU families because
+    # their results are not defined by the IEEE standard
+    rm ${D}${PTEST_PATH}/none/tests/amd64/avx_estimate_insn.vgtest
+
     # As the binary isn't stripped or debug-splitted, the source file isn't fetched
     # via dwarfsrcfiles either, so it needs to be installed manually.
     mkdir -p ${D}/usr/src/debug/${PN}/${EXTENDPE}${PV}-${PR}/${BP}/none/tests/
-- 
2.34.1

[OE-core][kirkstone 2/2] selftest/runtime_test/virgl: Disable for all fedora

[Steve Sakoman]

We can't support vgem on RHEL derived distros so disable this test for
all fedora hosts rather than specific versions.

Signed-off-by: Steve Sakoman <steve@sakoman.com>
---
 meta/lib/oeqa/selftest/cases/runtime_test.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/lib/oeqa/selftest/cases/runtime_test.py b/meta/lib/oeqa/selftest/cases/runtime_test.py
index 7dcdfd0ab2..93c6da1889 100644
--- a/meta/lib/oeqa/selftest/cases/runtime_test.py
+++ b/meta/lib/oeqa/selftest/cases/runtime_test.py
@@ -258,7 +258,7 @@ class TestImage(OESelftestTestCase):
 
         distro = oe.lsb.distro_identifier()
         if distro and (distro in ['debian-9', 'debian-10', 'centos-7', 'centos-8', 'ubuntu-16.04', 'ubuntu-18.04'] or
-            distro.startswith('almalinux') or distro.startswith('rocky')):
+            distro.startswith('almalinux') or distro.startswith('fedora') or distro.startswith('rocky')):
             self.skipTest('virgl headless cannot be tested with %s' %(distro))
 
         render_hint = """If /dev/dri/renderD* is absent due to lack of suitable GPU, 'modprobe vgem' will create one suitable for mesa llvmpipe software renderer."""
-- 
2.34.1

Re: [OE-core][kirkstone 2/2] selftest/runtime_test/virgl: Disable for all fedora

[Alexander Kanavin]

On Thu, 10 Oct 2024 at 20:44, Steve Sakoman via lists.openembedded.org
<steve=sakoman.com@lists.openembedded.org> wrote:

> We can't support vgem on RHEL derived distros so disable this test for
> all fedora hosts rather than specific versions.
>          render_hint = """If /dev/dri/renderD* is absent due to lack of suitable GPU, 'modprobe vgem' will create one suitable for mesa llvmpipe software renderer."""

I don't think this is accurate. It's the other way around: RHEL is
derived from Fedora. Also, vgem module can be installed in Fedora, but
not on RHEL or rocky/alma (which are derived from RHEL). We do this on
all fedora build hosts, and virgl tests run fine on Fedora workers
then, at least on the master branch.

What prompted this patch specifically?

Alex

Re: [OE-core][kirkstone 2/2] selftest/runtime_test/virgl: Disable for all fedora

[Steve Sakoman]

On Thu, Oct 17, 2024 at 2:05 AM Alexander Kanavin
<alex.kanavin@gmail.com> wrote:
>
> On Thu, 10 Oct 2024 at 20:44, Steve Sakoman via lists.openembedded.org
> <steve=sakoman.com@lists.openembedded.org> wrote:
>
> > We can't support vgem on RHEL derived distros so disable this test for
> > all fedora hosts rather than specific versions.
> >          render_hint = """If /dev/dri/renderD* is absent due to lack of suitable GPU, 'modprobe vgem' will create one suitable for mesa llvmpipe software renderer."""
>
> I don't think this is accurate. It's the other way around: RHEL is
> derived from Fedora. Also, vgem module can be installed in Fedora, but
> not on RHEL or rocky/alma (which are derived from RHEL). We do this on
> all fedora build hosts, and virgl tests run fine on Fedora workers
> then, at least on the master branch.
>
> What prompted this patch specifically?

When we moved to the new autobuilder cluster the kirkstone supported
versions of fedora were no longer available, only fedora 39/40.

The kirkstone virgl headless tests failed 100% of the time with the
new fedora 39/40 workers.  I discussed this with Richard on irc and he
recommended that we disable the test for kirkstone on those workers.

Steve

Re: [OE-core][kirkstone 2/2] selftest/runtime_test/virgl: Disable for all fedora

[Alexander Kanavin]

On Thu, 17 Oct 2024 at 14:10, Steve Sakoman <steve@sakoman.com> wrote:
> When we moved to the new autobuilder cluster the kirkstone supported
> versions of fedora were no longer available, only fedora 39/40.
>
> The kirkstone virgl headless tests failed 100% of the time with the
> new fedora 39/40 workers.  I discussed this with Richard on irc and he
> recommended that we disable the test for kirkstone on those workers.

Right, I'm ok with that then.

Alex

Re: [OE-core][kirkstone 2/2] selftest/runtime_test/virgl: Disable for all fedora

[Alexander Kanavin]

On Thu, 10 Oct 2024 at 20:44, Steve Sakoman via lists.openembedded.org
<steve=sakoman.com@lists.openembedded.org> wrote:
>
> We can't support vgem on RHEL derived distros so disable this test for
> all fedora hosts rather than specific versions.
>
> Signed-off-by: Steve Sakoman <steve@sakoman.com>
> ---
>  meta/lib/oeqa/selftest/cases/runtime_test.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/lib/oeqa/selftest/cases/runtime_test.py b/meta/lib/oeqa/selftest/cases/runtime_test.py
> index 7dcdfd0ab2..93c6da1889 100644
> --- a/meta/lib/oeqa/selftest/cases/runtime_test.py
> +++ b/meta/lib/oeqa/selftest/cases/runtime_test.py
> @@ -258,7 +258,7 @@ class TestImage(OESelftestTestCase):
>
>          distro = oe.lsb.distro_identifier()
>          if distro and (distro in ['debian-9', 'debian-10', 'centos-7', 'centos-8', 'ubuntu-16.04', 'ubuntu-18.04'] or
> -            distro.startswith('almalinux') or distro.startswith('rocky')):
> +            distro.startswith('almalinux') or distro.startswith('fedora') or distro.startswith('rocky')):

Wait, was fedora confused with centos maybe? Centos 9 is not on the
list, but perhaps should be.

Alex