From: Jakob Hauser <jahau@rocketmail.com>
To: Neil Armstrong <neil.armstrong@linaro.org>,
Jessica Zhang <quic_jesszhan@quicinc.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
Jakob Hauser <jahau@rocketmail.com>
Subject: [PATCH v4 0/5] Add new panel driver Samsung S6E88A0-AMS427AP24
Date: Mon, 28 Oct 2024 00:42:01 +0100 [thread overview]
Message-ID: <cover.1730070570.git.jahau@rocketmail.com> (raw)
In-Reply-To: <cover.1730070570.git.jahau@rocketmail.com>
The patchset adds a new driver for Samsung AMS427AP24 panel with S6E88A0
controller. Patches are based on current branch drm-misc-next.
The discussion in v3 was not finished. I send v4 nonetheless as a new base to
continue the discussion. I hope that's ok.
Changes in v4:
Patch 3
- Removed include <linux/of.h>, it's not needed.
- Added comments to the mipi_dsi_dcs_write_seq_multi() lines in function
s6e88a0_ams427ap24_on().
Patch 4
- New defines for payload data length, thereof a fixed and a variable part.
- In the array s6e88a0_ams427ap24_br_to_cd[] made the comment about the
columns more clear and added an additional column "brightness from".
- Array s6e88a0_ams427ap24_aid[] reduced from five to two columns and
s6e88a0_ams427ap24_elvss[] from two to one column. Now they hold the
variable data only. I kept s6e88a0_ams427ap24_elvss[] as a two-dimensional
array to allow using the same memcopy procedure for all three buffers aid,
elvss and gamma in function s6e88a0_ams427ap24_set_brightness().
- In function s6e88a0_ams427ap24_set_brightness() initialized prototype
payload array for b2 and b6 commands. And in the memcpy commands below
used the new defines for the fixed and variable data length.
Patch 5
- Added a comment to the mipi_dsi_dcs_write_seq_multi() line, according to the
other lines before and after.
v1: https://lore.kernel.org/dri-devel/cover.1728582727.git.jahau@rocketmail.com/T/#t
v2: https://lore.kernel.org/dri-devel/cover.1729630039.git.jahau@rocketmail.com/T/#t
v3: https://lore.kernel.org/dri-devel/cover.1729738189.git.jahau@rocketmail.com/T/#t
Jakob Hauser (5):
dt-bindings: display: panel: Move flip properties to panel-common
dt-bindings: display: panel: Add Samsung S6E88A0-AMS427AP24
drm/panel: samsung-s6e88a0-ams427ap24: Add initial driver
drm/panel: samsung-s6e88a0-ams427ap24: Add brightness control
drm/panel: samsung-s6e88a0-ams427ap24: Add flip option
.../bindings/display/panel/panel-common.yaml | 8 +
.../panel/samsung,s6e88a0-ams427ap24.yaml | 65 ++
.../display/panel/samsung,s6e8aa0.yaml | 10 +-
drivers/gpu/drm/panel/Kconfig | 10 +
drivers/gpu/drm/panel/Makefile | 1 +
.../panel/panel-samsung-s6e88a0-ams427ap24.c | 766 ++++++++++++++++++
6 files changed, 852 insertions(+), 8 deletions(-)
create mode 100644 Documentation/devicetree/bindings/display/panel/samsung,s6e88a0-ams427ap24.yaml
create mode 100644 drivers/gpu/drm/panel/panel-samsung-s6e88a0-ams427ap24.c
--
2.39.5
next parent reply other threads:[~2024-10-27 23:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-27 23:42 Jakob Hauser [this message]
2024-10-27 23:42 ` [PATCH v4 1/5] dt-bindings: display: panel: Move flip properties to panel-common Jakob Hauser
2024-10-27 23:42 ` [PATCH v4 2/5] dt-bindings: display: panel: Add Samsung S6E88A0-AMS427AP24 Jakob Hauser
2024-10-27 23:42 ` [PATCH v4 3/5] drm/panel: samsung-s6e88a0-ams427ap24: Add initial driver Jakob Hauser
2024-10-28 12:46 ` Linus Walleij
2024-10-27 23:42 ` [PATCH v4 4/5] drm/panel: samsung-s6e88a0-ams427ap24: Add brightness control Jakob Hauser
2024-10-28 12:47 ` Linus Walleij
2024-10-27 23:42 ` [PATCH v4 5/5] drm/panel: samsung-s6e88a0-ams427ap24: Add flip option Jakob Hauser
2024-10-28 12:47 ` Linus Walleij
2024-10-31 10:18 ` [PATCH v4 0/5] Add new panel driver Samsung S6E88A0-AMS427AP24 Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1730070570.git.jahau@rocketmail.com \
--to=jahau@rocketmail.com \
--cc=andrzej.hajda@intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_jesszhan@quicinc.com \
--cc=robh@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.