[PATCH 0/3] check errors in early init

[PATCH 0/3] check errors in early init

[Pavel Begunkov]

Do the diligence of checking if any of the (inicall) io_uring_init()
fail and if so return an error.

Pavel Begunkov (3):
  io_uring: propagate req cache creation errors
  io_uring: propagate io_buffer creation errors
  io_uring: check for iowq alloc_workqueue errors

 io_uring/io_uring.c | 7 +++++++
 1 file changed, 7 insertions(+)

-- 
2.47.1

[PATCH 1/3] io_uring: propagate req cache creation errors

[Pavel Begunkov]

It's very unlikely, but in theory cache creation can fail during
initcall, so don't forget to return errors back if something goes wrong.

Fixes: 2b188cc1bb857 ("Add io_uring IO interface")
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
---
 io_uring/io_uring.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c
index 263e504be4a8b..9335144495299 100644
--- a/io_uring/io_uring.c
+++ b/io_uring/io_uring.c
@@ -3916,6 +3916,9 @@ static int __init io_uring_init(void)
 	req_cachep = kmem_cache_create("io_kiocb", sizeof(struct io_kiocb), &kmem_args,
 				SLAB_HWCACHE_ALIGN | SLAB_PANIC | SLAB_ACCOUNT |
 				SLAB_TYPESAFE_BY_RCU);
+	if (!req_cachep)
+		return -ENOMEM;
+
 	io_buf_cachep = KMEM_CACHE(io_buffer,
 					  SLAB_HWCACHE_ALIGN | SLAB_PANIC | SLAB_ACCOUNT);
 
-- 
2.47.1

Re: [PATCH 1/3] io_uring: propagate req cache creation errors

[Jens Axboe]

On 1/31/25 9:24 AM, Pavel Begunkov wrote:
> It's very unlikely, but in theory cache creation can fail during
> initcall, so don't forget to return errors back if something goes wrong.

This is why SLAB_PANIC is used, it'll panic if this fails. That's
commonly used for setup/init time kind of setups, where we never
expect any failure to occur. Hence this can never return NULL.

-- 
Jens Axboe

Re: [PATCH 1/3] io_uring: propagate req cache creation errors

[Pavel Begunkov]

On 1/31/25 16:26, Jens Axboe wrote:
> On 1/31/25 9:24 AM, Pavel Begunkov wrote:
>> It's very unlikely, but in theory cache creation can fail during
>> initcall, so don't forget to return errors back if something goes wrong.
> 
> This is why SLAB_PANIC is used, it'll panic if this fails. That's
> commonly used for setup/init time kind of setups, where we never
> expect any failure to occur. Hence this can never return NULL.

Yeah, missed it, thanks

-- 
Pavel Begunkov

[PATCH 2/3] io_uring: propagate io_buffer creation errors

[Pavel Begunkov]

It's very unlikely, but in theory cache creation can fail during
initcall, so don't forget to return errors back if something goes wrong.

Fixes: b3a4dbc89d402 ("io_uring/kbuf: Use slab for struct io_buffer objects")
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
---
 io_uring/io_uring.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c
index 9335144495299..b05580c1a6424 100644
--- a/io_uring/io_uring.c
+++ b/io_uring/io_uring.c
@@ -3921,6 +3921,8 @@ static int __init io_uring_init(void)
 
 	io_buf_cachep = KMEM_CACHE(io_buffer,
 					  SLAB_HWCACHE_ALIGN | SLAB_PANIC | SLAB_ACCOUNT);
+	if (!io_buf_cachep)
+		return -ENOMEM;
 
 	iou_wq = alloc_workqueue("iou_exit", WQ_UNBOUND, 64);
 
-- 
2.47.1

[PATCH 3/3] io_uring: check for iowq alloc_workqueue errors

[Pavel Begunkov]

alloc_workqueue() can fail, check the result and return an error back
from io_uring_init() if needed.

Fixes: 73eaa2b583493 ("io_uring: use private workqueue for exit work")
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
---
 io_uring/io_uring.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c
index b05580c1a6424..78a6cc84304f2 100644
--- a/io_uring/io_uring.c
+++ b/io_uring/io_uring.c
@@ -3925,6 +3925,8 @@ static int __init io_uring_init(void)
 		return -ENOMEM;
 
 	iou_wq = alloc_workqueue("iou_exit", WQ_UNBOUND, 64);
+	if (!iou_wq)
+		return -ENOMEM;
 
 #ifdef CONFIG_SYSCTL
 	register_sysctl_init("kernel", kernel_io_uring_disabled_table);
-- 
2.47.1