[PATCH v2 0/2] automake: 1.17 -> 1.18

[PATCH v2 0/2] automake: 1.17 -> 1.18

[liezhi.yang]

From: Robert Yang <liezhi.yang@windriver.com>

* V2:
  - Drop 0001-configure-don-t-report-error-when-the-path-of-Perl-c.patch as Ross
    suggested.
  - Take a pull request from github to fix libcheck's build error with automake
    1.18.

// Robert

The following changes since commit bf866a99d920331bc5c08c3dccc86f71b2d1b3bb:

  systemtap: put version in recipe filename (2025-06-09 17:43:20 +0100)

are available in the Git repository at:

  https://github.com/robertlinux/yocto rbt/automake
  https://github.com/robertlinux/yocto/tree/rbt/automake

Robert Yang (2):
  libcheck: Fix do_install error with automake 1.18
  automake: 1.17 -> 1.18

 ...report-error-when-the-path-of-Perl-c.patch | 34 -----------
 .../{automake_1.17.bb => automake_1.18.bb}    |  3 +-
 ...0001-Fix-texinfo-errors-and-warnings.patch | 60 +++++++++++++++++++
 .../libcheck/libcheck_0.15.2.bb               |  5 +-
 4 files changed, 65 insertions(+), 37 deletions(-)
 delete mode 100644 meta/recipes-devtools/automake/automake/0001-configure-don-t-report-error-when-the-path-of-Perl-c.patch
 rename meta/recipes-devtools/automake/{automake_1.17.bb => automake_1.18.bb} (85%)
 create mode 100644 meta/recipes-support/libcheck/libcheck/0001-Fix-texinfo-errors-and-warnings.patch

-- 
2.49.0

[PATCH v2 1/2] libcheck: Fix do_install error with automake 1.18

[liezhi.yang]

From: Robert Yang <liezhi.yang@windriver.com>

Fixed do_install error with automake 1.18
$ makeinfo -I ../../check-0.15.2/doc -o ../../check-0.15.2/doc/check.info \
    ../../check-0.15.2/doc/check.texi
[snip]
check.texi:2329: no matching `@end verbatim'
[snip]

The automake before 1.17's mdate-sh couldn't update libcheck's
doc/version.texi, so the doc/check.info wasn't re-generated, then we couldn't
see the build error.

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 ...0001-Fix-texinfo-errors-and-warnings.patch | 60 +++++++++++++++++++
 .../libcheck/libcheck_0.15.2.bb               |  5 +-
 2 files changed, 64 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-support/libcheck/libcheck/0001-Fix-texinfo-errors-and-warnings.patch

diff --git a/meta/recipes-support/libcheck/libcheck/0001-Fix-texinfo-errors-and-warnings.patch b/meta/recipes-support/libcheck/libcheck/0001-Fix-texinfo-errors-and-warnings.patch
new file mode 100644
index 0000000000..1edba3f1e1
--- /dev/null
+++ b/meta/recipes-support/libcheck/libcheck/0001-Fix-texinfo-errors-and-warnings.patch
@@ -0,0 +1,60 @@
+From 6cc46c8ac0bfc012fcb6b0fd27e20d8c06c50919 Mon Sep 17 00:00:00 2001
+From: Jerry James <loganjerry@gmail.com>
+Date: Thu, 16 Jan 2025 09:42:41 -0700
+Subject: [PATCH] Fix texinfo errors and warnings
+
+A missing "@end verbatim" is an error with texinfo 7.2.
+The warnings are due to menu and navigation mistakes.
+
+Upstream-Status: Submitted [https://github.com/libcheck/check/pull/361]
+
+Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
+---
+ doc/check.texi | 10 +++++++---
+ 1 file changed, 7 insertions(+), 3 deletions(-)
+
+diff --git a/doc/check.texi b/doc/check.texi
+index f6852bc..b241961 100644
+--- a/doc/check.texi
++++ b/doc/check.texi
+@@ -112,6 +112,11 @@ Test Fixtures
+ * Test Fixture Examples::       
+ * Checked vs Unchecked Fixtures::  
+ 
++Selective Running of Tests
++
++* Selecting Tests by Suite or Test Case::
++* Selecting Tests Based on Arbitrary Tags::
++
+ Test Logging
+ 
+ * XML Logging::                 
+@@ -974,8 +979,6 @@ easier for the developer to write, run, and analyze tests.
+ * Test Fixtures::               
+ * Multiple Suites in one SRunner::  
+ * Selective Running of Tests::
+-* Selecting Tests by Suite or Test Case::
+-* Selecting Tests Based on Arbitrary Tags::
+ * Testing Signal Handling and Exit Values::  
+ * Looping Tests::               
+ * Test Timeouts::               
+@@ -2048,7 +2051,7 @@ If both plain text and XML log files are specified, by any of above methods,
+ then check will log to both files. In other words logging in plain text and XML
+ format simultaneously is supported.
+ 
+-@node TAP Logging,  , Test Logging, Test Logging
++@node TAP Logging,  , XML Logging, Test Logging
+ @subsection TAP Logging
+ 
+ @findex srunner_set_tap
+@@ -2255,6 +2258,7 @@ your CMake build how to find it:
+ 
+ @verbatim
+ cmake -Dcheck_ROOT=${INSTALL_PREFIX}
++@end verbatim
+ 
+ Then use Check in your @file{CMakeLists.txt} like this:
+ 
+-- 
+2.49.0
+
diff --git a/meta/recipes-support/libcheck/libcheck_0.15.2.bb b/meta/recipes-support/libcheck/libcheck_0.15.2.bb
index 5ab67b8728..ab9684f03c 100644
--- a/meta/recipes-support/libcheck/libcheck_0.15.2.bb
+++ b/meta/recipes-support/libcheck/libcheck_0.15.2.bb
@@ -12,7 +12,10 @@ LIC_FILES_CHKSUM = "file://COPYING.LESSER;md5=2d5025d4aa3495befef8f17206a5b0a1"
 
 SRC_URI = "${GITHUB_BASE_URI}/download/${PV}/check-${PV}.tar.gz \
            file://automake-output.patch \
-           file://not-echo-compiler-info-to-check_stdint.h.patch"
+           file://not-echo-compiler-info-to-check_stdint.h.patch \
+           file://0001-Fix-texinfo-errors-and-warnings.patch \
+"
+
 SRC_URI[sha256sum] = "a8de4e0bacfb4d76dd1c618ded263523b53b85d92a146d8835eb1a52932fa20a"
 GITHUB_BASE_URI = "https://github.com/libcheck/check/releases/"
 
-- 
2.49.0

Patchtest results for [PATCH v2 1/2] libcheck: Fix do_install error with automake 1.18

[patchtest]

[-- Attachment #1: Type: text/plain, Size: 2965 bytes --]

Thank you for your submission. Patchtest identified one
or more issues with the patch. Please see the log below for
more information:

---
Testing patch /home/patchtest/share/mboxes/v2-1-2-libcheck-Fix-do_install-error-with-automake-1.18.patch

FAIL: test commit message user tags: Mbox includes one or more GitHub-style username tags. Ensure that any "@" symbols are stripped out of usernames (test_mbox.TestMbox.test_commit_message_user_tags)

PASS: pretest src uri left files (test_metadata.TestMetadata.pretest_src_uri_left_files)
PASS: test CVE check ignore (test_metadata.TestMetadata.test_cve_check_ignore)
PASS: test CVE tag format (test_patch.TestPatch.test_cve_tag_format)
PASS: test Signed-off-by presence (test_mbox.TestMbox.test_signed_off_by_presence)
PASS: test Signed-off-by presence (test_patch.TestPatch.test_signed_off_by_presence)
PASS: test Upstream-Status presence (test_patch.TestPatch.test_upstream_status_presence_format)
PASS: test author valid (test_mbox.TestMbox.test_author_valid)
PASS: test commit message presence (test_mbox.TestMbox.test_commit_message_presence)
PASS: test lic files chksum modified not mentioned (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned)
PASS: test max line length (test_metadata.TestMetadata.test_max_line_length)
PASS: test mbox format (test_mbox.TestMbox.test_mbox_format)
PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade)
PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format)
PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length)
PASS: test src uri left files (test_metadata.TestMetadata.test_src_uri_left_files)
PASS: test target mailing list (test_mbox.TestMbox.test_target_mailing_list)

SKIP: pretest pylint: No python related patches, skipping test (test_python_pylint.PyLint.pretest_pylint)
SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format)
SKIP: test lic files chksum presence: No added recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_presence)
SKIP: test license presence: No added recipes, skipping test (test_metadata.TestMetadata.test_license_presence)
SKIP: test pylint: No python related patches, skipping test (test_python_pylint.PyLint.test_pylint)
SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head)
SKIP: test summary presence: No added recipes, skipping test (test_metadata.TestMetadata.test_summary_presence)

---

Please address the issues identified and
submit a new revision of the patch, or alternatively, reply to this
email with an explanation of why the patch should be accepted. If you
believe these results are due to an error in patchtest, please submit a
bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category
under 'Yocto Project Subprojects'). For more information on specific
failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank
you!

[PATCH v2 2/2] automake: 1.17 -> 1.18

[liezhi.yang]

From: Robert Yang <liezhi.yang@windriver.com>

* Drop 0001-configure-don-t-report-error-when-the-path-of-Perl-c.patch, it is a
  warning not an error any more, so just drop it.

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 ...report-error-when-the-path-of-Perl-c.patch | 34 -------------------
 .../{automake_1.17.bb => automake_1.18.bb}    |  3 +-
 2 files changed, 1 insertion(+), 36 deletions(-)
 delete mode 100644 meta/recipes-devtools/automake/automake/0001-configure-don-t-report-error-when-the-path-of-Perl-c.patch
 rename meta/recipes-devtools/automake/{automake_1.17.bb => automake_1.18.bb} (85%)

diff --git a/meta/recipes-devtools/automake/automake/0001-configure-don-t-report-error-when-the-path-of-Perl-c.patch b/meta/recipes-devtools/automake/automake/0001-configure-don-t-report-error-when-the-path-of-Perl-c.patch
deleted file mode 100644
index 5a38feb16c..0000000000
--- a/meta/recipes-devtools/automake/automake/0001-configure-don-t-report-error-when-the-path-of-Perl-c.patch
+++ /dev/null
@@ -1,34 +0,0 @@
-From 4339a2298a2d486fb4636b72393499b59805edde Mon Sep 17 00:00:00 2001
-From: Changqing Li <changqing.li@windriver.com>
-Date: Thu, 21 Nov 2024 14:54:37 +0800
-Subject: [PATCH] configure: don't report error when the path of Perl contains
- spaces or tabs
-
-In order to make setting PERL to "/usr/bin/env perl" works well, patch
-configure as upstream suggested, refer [1]. 
-
-[1] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=74453
-
-Upstream-Status: Inappropriate [ oe-specific ]
-
-Signed-off-by: Changqing Li <changqing.li@windriver.com>
----
- configure | 2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
-
-diff --git a/configure b/configure
-index 45bf85a..68d3c7d 100755
---- a/configure
-+++ b/configure
-@@ -3514,7 +3514,7 @@ case $PERL in
-    as_fn_error $? "perl not found" "$LINENO" 5
-    ;;
-  *' '* | *'	'*)
--  as_fn_error $? "The path to your Perl contains spaces or tabs.
-+  : as_fn_error $? "The path to your Perl contains spaces or tabs.
- This would cause build failures later or unusable programs.
- Please use a path without spaces and try again." "$LINENO" 5
-   ;;
--- 
-2.25.1
-
diff --git a/meta/recipes-devtools/automake/automake_1.17.bb b/meta/recipes-devtools/automake/automake_1.18.bb
similarity index 85%
rename from meta/recipes-devtools/automake/automake_1.17.bb
rename to meta/recipes-devtools/automake/automake_1.18.bb
index 4cda04e47b..516d0a58d9 100644
--- a/meta/recipes-devtools/automake/automake_1.17.bb
+++ b/meta/recipes-devtools/automake/automake_1.18.bb
@@ -22,10 +22,9 @@ SRC_URI += "\
            file://0002-automake-Update-for-python.m4-to-respect-libdir.patch \
            file://0004-Add-a-new-distro-feature-ptest.patch \
            file://0006-automake-Remove-delays-in-configure-scripts-using-au.patch \
-           file://0001-configure-don-t-report-error-when-the-path-of-Perl-c.patch \
            "
 
-SRC_URI[sha256sum] = "397767d4db3018dd4440825b60c64258b636eaf6bf99ac8b0897f06c89310acd"
+SRC_URI[sha256sum] = "af6043a5d4b3beef0c48161f4a6936259321cd101a34c1ab0768328515626c8a"
 
 PERL = "${USRBINPATH}/perl"
 PERL:class-native = "${USRBINPATH}/env perl"
-- 
2.49.0

Re: [PATCH v2 2/2] automake: 1.17 -> 1.18

[Ross Burton]

On 10 Jun 2025, at 12:17, liezhi.yang@windriver.com wrote:
> 
> From: Robert Yang <liezhi.yang@windriver.com>
> 
> * Drop 0001-configure-don-t-report-error-when-the-path-of-Perl-c.patch, it is a
>  warning not an error any more, so just drop it.
> 
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>

I still request holding off this until the rebuild problem that I’ve seen has been investigated properly.

Ross

Re: [OE-core] [PATCH v2 2/2] automake: 1.17 -> 1.18

[Robert Yang]

Hi Ross,

On 6/10/25 19:21, Ross Burton via lists.openembedded.org wrote:
> On 10 Jun 2025, at 12:17, liezhi.yang@windriver.com wrote:
>>
>> From: Robert Yang <liezhi.yang@windriver.com>
>>
>> * Drop 0001-configure-don-t-report-error-when-the-path-of-Perl-c.patch, it is a
>>   warning not an error any more, so just drop it.
>>
>> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> 
> I still request holding off this until the rebuild problem that I’ve seen has been investigated properly.

I've replied in V1, did that address your problem? Or how can I reproduce the 
problem, please?

The automake before 1.17's mdate-sh couldn't update libcheck's
doc/version.texi, so the doc/check.info wasn't re-generated, then we couldn't
see the build error before.

I think this can also address Ross' question about rebuild libcheck failed
with automake 1.18, it is because doc/check.info wasn't re-generated
with automake 1.17, then we couldn't see the error.

And for other recipes' rebuild, I've done the testing with:
$ bitbake world
Edit autotools.bbclass to triger rebuild
$ bitbake world

All of them worked well.

// Robert


> 
> Ross
> 
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#218345): https://lists.openembedded.org/g/openembedded-core/message/218345
> Mute This Topic: https://lists.openembedded.org/mt/113567518/7304958
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [liezhi.yang@eng.windriver.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 

Re: [OE-core] [PATCH v2 2/2] automake: 1.17 -> 1.18

[Robert Yang]

Hi Ross,

On 6/10/25 19:32, Robert Yang wrote:
> Hi Ross,
> 
> On 6/10/25 19:21, Ross Burton via lists.openembedded.org wrote:
>> On 10 Jun 2025, at 12:17, liezhi.yang@windriver.com wrote:
>>>
>>> From: Robert Yang <liezhi.yang@windriver.com>
>>>
>>> * Drop 0001-configure-don-t-report-error-when-the-path-of-Perl-c.patch, it is a
>>>   warning not an error any more, so just drop it.
>>>
>>> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
>>
>> I still request holding off this until the rebuild problem that I’ve seen has 
>> been investigated properly.
> 
> I've replied in V1, did that address your problem? Or how can I reproduce the 
> problem, please?
> 
> The automake before 1.17's mdate-sh couldn't update libcheck's
> doc/version.texi, so the doc/check.info wasn't re-generated, then we couldn't
> see the build error before.
> 
> I think this can also address Ross' question about rebuild libcheck failed
> with automake 1.18, it is because doc/check.info wasn't re-generated
> with automake 1.17, then we couldn't see the error.
> 
> And for other recipes' rebuild, I've done the testing with:
> $ bitbake world
> Edit autotools.bbclass to triger rebuild
> $ bitbake world
> 
> All of them worked well.

Ping.

// Robert

> 
> // Robert
> 
> 
>>
>> Ross
>>
>>
>>
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>> View/Reply Online (#218345): 
>> https://lists.openembedded.org/g/openembedded-core/message/218345
>> Mute This Topic: https://lists.openembedded.org/mt/113567518/7304958
>> Group Owner: openembedded-core+owner@lists.openembedded.org
>> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
>> [liezhi.yang@eng.windriver.com]
>> -=-=-=-=-=-=-=-=-=-=-=-
>>

Re: [OE-core] [PATCH v2 2/2] automake: 1.17 -> 1.18

[Alexander Kanavin]

Robert, can you rebase to 1.18.1 and resend please?

Alex

On Mon, 16 Jun 2025 at 17:38, Robert Yang via lists.openembedded.org
<liezhi.yang=windriver.com@lists.openembedded.org> wrote:
>
> Hi Ross,
>
> On 6/10/25 19:32, Robert Yang wrote:
> > Hi Ross,
> >
> > On 6/10/25 19:21, Ross Burton via lists.openembedded.org wrote:
> >> On 10 Jun 2025, at 12:17, liezhi.yang@windriver.com wrote:
> >>>
> >>> From: Robert Yang <liezhi.yang@windriver.com>
> >>>
> >>> * Drop 0001-configure-don-t-report-error-when-the-path-of-Perl-c.patch, it is a
> >>>   warning not an error any more, so just drop it.
> >>>
> >>> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> >>
> >> I still request holding off this until the rebuild problem that I’ve seen has
> >> been investigated properly.
> >
> > I've replied in V1, did that address your problem? Or how can I reproduce the
> > problem, please?
> >
> > The automake before 1.17's mdate-sh couldn't update libcheck's
> > doc/version.texi, so the doc/check.info wasn't re-generated, then we couldn't
> > see the build error before.
> >
> > I think this can also address Ross' question about rebuild libcheck failed
> > with automake 1.18, it is because doc/check.info wasn't re-generated
> > with automake 1.17, then we couldn't see the error.
> >
> > And for other recipes' rebuild, I've done the testing with:
> > $ bitbake world
> > Edit autotools.bbclass to triger rebuild
> > $ bitbake world
> >
> > All of them worked well.
>
> Ping.
>
> // Robert
>
> >
> > // Robert
> >
> >
> >>
> >> Ross
> >>
> >>
> >>
> >>
> >>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#218830): https://lists.openembedded.org/g/openembedded-core/message/218830
> Mute This Topic: https://lists.openembedded.org/mt/113567518/1686489
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>

Re: [OE-core] [PATCH v2 2/2] automake: 1.17 -> 1.18

[Robert Yang]

On 9/2/25 17:42, Alexander Kanavin wrote:
> Robert, can you rebase to 1.18.1 and resend please?

Yes, I will.

// Robert

> 
> Alex
> 
> On Mon, 16 Jun 2025 at 17:38, Robert Yang via lists.openembedded.org
> <liezhi.yang=windriver.com@lists.openembedded.org> wrote:
>>
>> Hi Ross,
>>
>> On 6/10/25 19:32, Robert Yang wrote:
>>> Hi Ross,
>>>
>>> On 6/10/25 19:21, Ross Burton via lists.openembedded.org wrote:
>>>> On 10 Jun 2025, at 12:17, liezhi.yang@windriver.com wrote:
>>>>>
>>>>> From: Robert Yang <liezhi.yang@windriver.com>
>>>>>
>>>>> * Drop 0001-configure-don-t-report-error-when-the-path-of-Perl-c.patch, it is a
>>>>>    warning not an error any more, so just drop it.
>>>>>
>>>>> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
>>>>
>>>> I still request holding off this until the rebuild problem that I’ve seen has
>>>> been investigated properly.
>>>
>>> I've replied in V1, did that address your problem? Or how can I reproduce the
>>> problem, please?
>>>
>>> The automake before 1.17's mdate-sh couldn't update libcheck's
>>> doc/version.texi, so the doc/check.info wasn't re-generated, then we couldn't
>>> see the build error before.
>>>
>>> I think this can also address Ross' question about rebuild libcheck failed
>>> with automake 1.18, it is because doc/check.info wasn't re-generated
>>> with automake 1.17, then we couldn't see the error.
>>>
>>> And for other recipes' rebuild, I've done the testing with:
>>> $ bitbake world
>>> Edit autotools.bbclass to triger rebuild
>>> $ bitbake world
>>>
>>> All of them worked well.
>>
>> Ping.
>>
>> // Robert
>>
>>>
>>> // Robert
>>>
>>>
>>>>
>>>> Ross
>>>>
>>>>
>>>>
>>>>
>>>>
>>
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>> View/Reply Online (#218830): https://lists.openembedded.org/g/openembedded-core/message/218830
>> Mute This Topic: https://lists.openembedded.org/mt/113567518/1686489
>> Group Owner: openembedded-core+owner@lists.openembedded.org
>> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com]
>> -=-=-=-=-=-=-=-=-=-=-=-
>>