All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 0/1] fetch2: try_mirror_url(): Skip invalid local url
@ 2025-08-11 15:41 liezhi.yang
  2025-08-11 15:41 ` [PATCH v2 1/1] " liezhi.yang
  0 siblings, 1 reply; 3+ messages in thread
From: liezhi.yang @ 2025-08-11 15:41 UTC (permalink / raw)
  To: bitbake-devel, alex.kanavin

From: Robert Yang <liezhi.yang@windriver.com>

* V2
  - Move the code to try_mirror_url() as Alex suggested
  - Add more commit messages.

* V1
  - Initial version

// Robert

The following changes since commit 3b2f9c31dc17c3ba5f6a9971413afed3d450d826:

  poky.yaml.in: increase required disk space to 140G (2025-08-08 23:41:11 +0100)

are available in the Git repository at:

  https://github.com/robertlinux/bitbake rbt/mirror
  https://github.com/robertlinux/bitbake/tree/rbt/mirror

Robert Yang (1):
  fetch2: try_mirror_url(): Skip invalid local url

 bitbake/lib/bb/fetch2/__init__.py | 4 ++++
 1 file changed, 4 insertions(+)

-- 
2.49.0



^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH v2 1/1] fetch2: try_mirror_url(): Skip invalid local url
  2025-08-11 15:41 [PATCH v2 0/1] fetch2: try_mirror_url(): Skip invalid local url liezhi.yang
@ 2025-08-11 15:41 ` liezhi.yang
  2025-08-12  3:50   ` [bitbake-devel] " Robert Yang
  0 siblings, 1 reply; 3+ messages in thread
From: liezhi.yang @ 2025-08-11 15:41 UTC (permalink / raw)
  To: bitbake-devel, alex.kanavin

From: Robert Yang <liezhi.yang@windriver.com>

There can be multiple PREMIRRORs each PREMIRROR contains specifics sources for
each layer, each recipe will try the PREMIRRORs one by one until succeed, but
the trying would be failed if the PREMIRROR doesn't contain the required
sources, so return it immediately to make log.do_fetch clean, and tt also can
fix a warning when BB_GIT_SHALLOW and is enabled and failed to fetch the source
from the PREMIRROR:

Fast shallow clone failed, try to skip fast mode now.

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 bitbake/lib/bb/fetch2/__init__.py | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/bitbake/lib/bb/fetch2/__init__.py b/bitbake/lib/bb/fetch2/__init__.py
index 0ad987c596..1bab8f7f57 100644
--- a/bitbake/lib/bb/fetch2/__init__.py
+++ b/bitbake/lib/bb/fetch2/__init__.py
@@ -1067,6 +1067,10 @@ def try_mirror_url(fetch, origud, ud, ld, check = False):
     # Return of None or a value means we're finished
     # False means try another url
 
+    # Skip fetching it when the local url's path doesn't exist
+    if ud.parm.get('protocol', '') == 'file' and not os.path.exists(ud.path):
+        return False
+
     if ud.lockfile and ud.lockfile != origud.lockfile:
         lf = bb.utils.lockfile(ud.lockfile)
 
-- 
2.49.0



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [bitbake-devel] [PATCH v2 1/1] fetch2: try_mirror_url(): Skip invalid local url
  2025-08-11 15:41 ` [PATCH v2 1/1] " liezhi.yang
@ 2025-08-12  3:50   ` Robert Yang
  0 siblings, 0 replies; 3+ messages in thread
From: Robert Yang @ 2025-08-12  3:50 UTC (permalink / raw)
  To: bitbake-devel, alex.kanavin



On 8/11/25 23:41, Robert Yang via lists.openembedded.org wrote:
> From: Robert Yang <liezhi.yang@windriver.com>
> 
> There can be multiple PREMIRRORs each PREMIRROR contains specifics sources for
> each layer, each recipe will try the PREMIRRORs one by one until succeed, but
> the trying would be failed if the PREMIRROR doesn't contain the required
> sources, so return it immediately to make log.do_fetch clean, and tt also can
> fix a warning when BB_GIT_SHALLOW and is enabled and failed to fetch the source
> from the PREMIRROR:
> 
> Fast shallow clone failed, try to skip fast mode now.
> 
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
>   bitbake/lib/bb/fetch2/__init__.py | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/bitbake/lib/bb/fetch2/__init__.py b/bitbake/lib/bb/fetch2/__init__.py
> index 0ad987c596..1bab8f7f57 100644
> --- a/bitbake/lib/bb/fetch2/__init__.py
> +++ b/bitbake/lib/bb/fetch2/__init__.py
> @@ -1067,6 +1067,10 @@ def try_mirror_url(fetch, origud, ud, ld, check = False):
>       # Return of None or a value means we're finished
>       # False means try another url
>   
> +    # Skip fetching it when the local url's path doesn't exist
> +    if ud.parm.get('protocol', '') == 'file' and not os.path.exists(ud.path):

Sorry, this patch is incorrect, I need check repo and repo.git because git works 
with or without .git suffix. Will send a V3 for it.

// Robert

> +        return False
 > +>       if ud.lockfile and ud.lockfile != origud.lockfile:
>           lf = bb.utils.lockfile(ud.lockfile)
>   
> 
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#17861): https://lists.openembedded.org/g/bitbake-devel/message/17861
> Mute This Topic: https://lists.openembedded.org/mt/114649737/7304958
> Group Owner: bitbake-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/bitbake-devel/unsub [liezhi.yang@eng.windriver.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-08-12  3:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-11 15:41 [PATCH v2 0/1] fetch2: try_mirror_url(): Skip invalid local url liezhi.yang
2025-08-11 15:41 ` [PATCH v2 1/1] " liezhi.yang
2025-08-12  3:50   ` [bitbake-devel] " Robert Yang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.