From: Lukas Wunner <lukas@wunner.de>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Riana Tauro <riana.tauro@intel.com>,
Aravind Iddamsetty <aravind.iddamsetty@linux.intel.com>,
"Sean C. Dardis" <sean.c.dardis@intel.com>,
Terry Bowman <terry.bowman@amd.com>,
Sathyanarayanan Kuppuswamy
<sathyanarayanan.kuppuswamy@linux.intel.com>,
Niklas Schnelle <schnelle@linux.ibm.com>,
Linas Vepstas <linasvepstas@gmail.com>,
"Mahesh J Salgaonkar" <mahesh@linux.ibm.com>,
"Oliver OHalloran" <oohall@gmail.com>,
Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>,
linuxppc-dev@lists.ozlabs.org, linux-pci@vger.kernel.org,
Shahed Shaikh <shshaikh@marvell.com>,
Manish Chopra <manishc@marvell.com>,
GR-Linux-NIC-Dev@marvell.com, Nilesh Javali <njavali@marvell.com>,
GR-QLogic-Storage-Upstream@marvell.com,
Edward Cree <ecree.xilinx@gmail.com>,
linux-net-drivers@amd.com, James Smart <james.smart@broadcom.com>,
Dick Kennedy <dick.kennedy@broadcom.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vg er.kernel.org, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org
Subject: [PATCH 0/5] PCI: Reduce AER / EEH deviations
Date: Wed, 13 Aug 2025 07:11:00 +0200 [thread overview]
Message-ID: <cover.1755008151.git.lukas@wunner.de> (raw)
The kernel supports three different PCI error recovery mechanisms:
* AER per PCIe r7.0 sec 6.2 (drivers/pci/pcie/aer.c + err.c)
* EEH on PowerPC (arch/powerpc/kernel/eeh_driver.c)
* zPCI on s390 (arch/s390/pci/pci_event.c)
In theory, they should all follow Documentation/PCI/pci-error-recovery.rst
to afford uniform behavior to drivers across platforms.
In practice, there are deviations which this series seeks to reduce.
One particular pain point is AER not allowing drivers to opt in to a
Bus Reset on Non-Fatal Errors (patch [1/5]). EEH allows this and the
"xe" graphics driver would like to take advantage of it on AER-capable
platforms. Patches [2/5] to [4/5] address various other deviations,
while patch [5/5] cleans up old gunk in code comments.
I've gone through all drivers implementing pci_error_handlers to ascertain
that no regressions are introduced by these changes. Nevertheless further
reviewing and testing would be appreciated to raise the confidence.
Thanks!
Lukas Wunner (5):
PCI/AER: Allow drivers to opt in to Bus Reset on Non-Fatal Errors
PCI/ERR: Fix uevent on failure to recover
PCI/ERR: Notify drivers on failure to recover
PCI/ERR: Update device error_state already after reset
PCI/ERR: Remove remnants of .link_reset() callback
.../ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c | 1 -
.../net/ethernet/qlogic/qlcnic/qlcnic_main.c | 2 -
drivers/net/ethernet/sfc/efx_common.c | 3 --
drivers/net/ethernet/sfc/falcon/efx.c | 3 --
drivers/net/ethernet/sfc/siena/efx_common.c | 3 --
drivers/pci/pcie/err.c | 40 ++++++++++++++-----
drivers/scsi/lpfc/lpfc_init.c | 2 +-
drivers/scsi/qla2xxx/qla_os.c | 5 ---
8 files changed, 32 insertions(+), 27 deletions(-)
--
2.47.2
WARNING: multiple messages have this Message-ID (diff)
From: Lukas Wunner <lukas@wunner.de>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Riana Tauro <riana.tauro@intel.com>,
Aravind Iddamsetty <aravind.iddamsetty@linux.intel.com>,
"Sean C. Dardis" <sean.c.dardis@intel.com>,
Terry Bowman <terry.bowman@amd.com>,
Sathyanarayanan Kuppuswamy
<sathyanarayanan.kuppuswamy@linux.intel.com>,
Niklas Schnelle <schnelle@linux.ibm.com>,
Linas Vepstas <linasvepstas@gmail.com>,
"Mahesh J Salgaonkar" <mahesh@linux.ibm.com>,
"Oliver OHalloran" <oohall@gmail.com>,
Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>,
linuxppc-dev@lists.ozlabs.org, linux-pci@vger.kernel.org,
Shahed Shaikh <shshaikh@marvell.com>,
Manish Chopra <manishc@marvell.com>,
GR-Linux-NIC-Dev@marvell.com, Nilesh Javali <njavali@marvell.com>,
GR-QLogic-Storage-Upstream@marvell.com,
Edward Cree <ecree.xilinx@gmail.com>,
linux-net-drivers@amd.com, James Smart <james.smart@broadcom.com>,
Dick Kennedy <dick.kennedy@broadcom.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vg, er.kernel.org@lists.ozlabs.org,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org
Subject: [PATCH 0/5] PCI: Reduce AER / EEH deviations
Date: Wed, 13 Aug 2025 07:11:00 +0200 [thread overview]
Message-ID: <cover.1755008151.git.lukas@wunner.de> (raw)
The kernel supports three different PCI error recovery mechanisms:
* AER per PCIe r7.0 sec 6.2 (drivers/pci/pcie/aer.c + err.c)
* EEH on PowerPC (arch/powerpc/kernel/eeh_driver.c)
* zPCI on s390 (arch/s390/pci/pci_event.c)
In theory, they should all follow Documentation/PCI/pci-error-recovery.rst
to afford uniform behavior to drivers across platforms.
In practice, there are deviations which this series seeks to reduce.
One particular pain point is AER not allowing drivers to opt in to a
Bus Reset on Non-Fatal Errors (patch [1/5]). EEH allows this and the
"xe" graphics driver would like to take advantage of it on AER-capable
platforms. Patches [2/5] to [4/5] address various other deviations,
while patch [5/5] cleans up old gunk in code comments.
I've gone through all drivers implementing pci_error_handlers to ascertain
that no regressions are introduced by these changes. Nevertheless further
reviewing and testing would be appreciated to raise the confidence.
Thanks!
Lukas Wunner (5):
PCI/AER: Allow drivers to opt in to Bus Reset on Non-Fatal Errors
PCI/ERR: Fix uevent on failure to recover
PCI/ERR: Notify drivers on failure to recover
PCI/ERR: Update device error_state already after reset
PCI/ERR: Remove remnants of .link_reset() callback
.../ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c | 1 -
.../net/ethernet/qlogic/qlcnic/qlcnic_main.c | 2 -
drivers/net/ethernet/sfc/efx_common.c | 3 --
drivers/net/ethernet/sfc/falcon/efx.c | 3 --
drivers/net/ethernet/sfc/siena/efx_common.c | 3 --
drivers/pci/pcie/err.c | 40 ++++++++++++++-----
drivers/scsi/lpfc/lpfc_init.c | 2 +-
drivers/scsi/qla2xxx/qla_os.c | 5 ---
8 files changed, 32 insertions(+), 27 deletions(-)
--
2.47.2
next reply other threads:[~2025-08-13 5:21 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-13 5:11 Lukas Wunner [this message]
2025-08-13 5:11 ` [PATCH 0/5] PCI: Reduce AER / EEH deviations Lukas Wunner
2025-08-13 5:11 ` [PATCH 1/5] PCI/AER: Allow drivers to opt in to Bus Reset on Non-Fatal Errors Lukas Wunner
2025-08-13 23:01 ` Sathyanarayanan Kuppuswamy
2025-08-17 13:45 ` Lukas Wunner
2025-08-14 7:56 ` Niklas Schnelle
2025-08-14 9:36 ` Lukas Wunner
2025-08-14 19:29 ` Sathyanarayanan Kuppuswamy
2025-08-17 13:17 ` Lukas Wunner
2025-08-17 16:10 ` Sathyanarayanan Kuppuswamy
2025-08-14 20:31 ` Niklas Schnelle
2025-08-18 23:17 ` Linas Vepstas
2025-08-17 16:11 ` Sathyanarayanan Kuppuswamy
2025-08-13 5:11 ` [PATCH 2/5] PCI/ERR: Fix uevent on failure to recover Lukas Wunner
2025-08-13 23:01 ` Sathyanarayanan Kuppuswamy
2025-08-14 7:08 ` Niklas Schnelle
2025-08-13 5:11 ` [PATCH 3/5] PCI/ERR: Notify drivers " Lukas Wunner
2025-08-13 23:05 ` Sathyanarayanan Kuppuswamy
2025-08-13 5:11 ` [PATCH 4/5] PCI/ERR: Update device error_state already after reset Lukas Wunner
2025-08-13 23:43 ` Sathyanarayanan Kuppuswamy
2025-08-13 5:11 ` [PATCH 5/5] PCI/ERR: Remove remnants of .link_reset() callback Lukas Wunner
2025-08-14 0:40 ` Sathyanarayanan Kuppuswamy
2025-08-13 18:21 ` [PATCH 0/5] PCI: Reduce AER / EEH deviations Bjorn Helgaas
2025-08-14 0:30 ` Linas Vepstas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1755008151.git.lukas@wunner.de \
--to=lukas@wunner.de \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=aravind.iddamsetty@linux.intel.com \
--cc=dick.kennedy@broadcom.com \
--cc=ecree.xilinx@gmail.com \
--cc=helgaas@kernel.org \
--cc=james.smart@broadcom.com \
--cc=linasvepstas@gmail.com \
--cc=linux-net-drivers@amd.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-scsi@vg \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mahesh@linux.ibm.com \
--cc=manishc@marvell.com \
--cc=manivannan.sadhasivam@oss.qualcomm.com \
--cc=martin.petersen@oracle.com \
--cc=njavali@marvell.com \
--cc=oohall@gmail.com \
--cc=riana.tauro@intel.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=schnelle@linux.ibm.com \
--cc=sean.c.dardis@intel.com \
--cc=shshaikh@marvell.com \
--cc=terry.bowman@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.