All of lore.kernel.org
 help / color / mirror / Atom feed
* [bitbake][walnascar][2.12][PATCH 0/2] Patch review
@ 2025-09-10 15:55 Steve Sakoman
  2025-09-10 15:55 ` [bitbake][walnascar][2.12][PATCH 1/2] Use a "fork" multiprocessing context Steve Sakoman
  2025-09-10 15:55 ` [bitbake][walnascar][2.12][PATCH 2/2] bitbake: Bump version to 2.12.1 Steve Sakoman
  0 siblings, 2 replies; 10+ messages in thread
From: Steve Sakoman @ 2025-09-10 15:55 UTC (permalink / raw)
  To: bitbake-devel

Please review this set of changes for 2.12/walnascar and have comments back
by end of day Friday, September 12

Passed a-full on autobuilder:

https://autobuilder.yoctoproject.org/valkyrie/#/builders/29/builds/2348

The following changes since commit 710f98844ae30416bdf6a01b655df398b49574ec:

  utils: Optimise signal/sigmask performance (2025-07-31 09:32:00 -0700)

are available in the Git repository at:

  https://git.openembedded.org/bitbake-contrib stable/2.12-nut
  https://git.openembedded.org/bitbake-contrib/log/?h=stable/2.12-nut

Joshua Watt (1):
  Use a "fork" multiprocessing context

Martin Jansa (1):
  bitbake: Bump version to 2.12.1

 bin/bitbake                        |  2 +-
 lib/bb/__init__.py                 | 30 +++++++++++++++++++++++++++++-
 lib/bb/asyncrpc/serv.py            |  2 +-
 lib/bb/cooker.py                   |  2 +-
 lib/bb/server/process.py           |  2 +-
 lib/bb/tests/support/httpserver.py |  4 ++--
 lib/bb/utils.py                    |  4 +---
 lib/hashserv/tests.py              |  2 +-
 8 files changed, 37 insertions(+), 11 deletions(-)

-- 
2.43.0



^ permalink raw reply	[flat|nested] 10+ messages in thread

* [bitbake][walnascar][2.12][PATCH 1/2] Use a "fork" multiprocessing context
  2025-09-10 15:55 [bitbake][walnascar][2.12][PATCH 0/2] Patch review Steve Sakoman
@ 2025-09-10 15:55 ` Steve Sakoman
  2025-09-10 15:55 ` [bitbake][walnascar][2.12][PATCH 2/2] bitbake: Bump version to 2.12.1 Steve Sakoman
  1 sibling, 0 replies; 10+ messages in thread
From: Steve Sakoman @ 2025-09-10 15:55 UTC (permalink / raw)
  To: bitbake-devel

From: Joshua Watt <JPEWhacker@gmail.com>

Python 3.14 changes the default multiprocessing context from "fork" to
"forkserver"; however bitbake heavily relies on "fork" to efficiently
pass data to the child processes. As such, make "fork" context in the bb
namespace and use it in place of the normal multiprocessing module.

Note that multiprocessing contexts were added in Python 3.4, so this
should be safe to use even before Python 3.14

[YOCTO #15858]

Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Steve Sakoman <steve@sakoman.com>
---
 lib/bb/__init__.py                 | 28 ++++++++++++++++++++++++++++
 lib/bb/asyncrpc/serv.py            |  2 +-
 lib/bb/cooker.py                   |  2 +-
 lib/bb/server/process.py           |  2 +-
 lib/bb/tests/support/httpserver.py |  4 ++--
 lib/bb/utils.py                    |  4 +---
 lib/hashserv/tests.py              |  2 +-
 7 files changed, 35 insertions(+), 9 deletions(-)

diff --git a/lib/bb/__init__.py b/lib/bb/__init__.py
index 566835573..605355e1a 100644
--- a/lib/bb/__init__.py
+++ b/lib/bb/__init__.py
@@ -37,6 +37,34 @@ class BBHandledException(Exception):
 import os
 import logging
 from collections import namedtuple
+import multiprocessing as mp
+
+# Python 3.14 changes the default multiprocessing context from "fork" to
+# "forkserver". However, bitbake heavily relies on "fork" behavior to
+# efficiently pass data to the child processes. Places that need this should do:
+#   from bb import multiprocessing
+# in place of
+#   import multiprocessing
+
+class MultiprocessingContext(object):
+    """
+    Multiprocessing proxy object that uses the "fork" context for a property if
+    available, otherwise goes to the main multiprocessing module. This allows
+    it to be a drop-in replacement for the multiprocessing module, but use the
+    fork context
+    """
+    def __init__(self):
+        super().__setattr__("_ctx", mp.get_context("fork"))
+
+    def __getattr__(self, name):
+        if hasattr(self._ctx, name):
+            return getattr(self._ctx, name)
+        return getattr(mp, name)
+
+    def __setattr__(self, name, value):
+        raise AttributeError(f"Unable to set attribute {name}")
+
+multiprocessing = MultiprocessingContext()
 
 
 class NullHandler(logging.Handler):
diff --git a/lib/bb/asyncrpc/serv.py b/lib/bb/asyncrpc/serv.py
index 667217c5c..acdcaf08e 100644
--- a/lib/bb/asyncrpc/serv.py
+++ b/lib/bb/asyncrpc/serv.py
@@ -11,7 +11,7 @@ import os
 import signal
 import socket
 import sys
-import multiprocessing
+from bb import multiprocessing
 import logging
 from .connection import StreamConnection, WebsocketConnection
 from .exceptions import ClientError, ServerError, ConnectionClosedError, InvokeError
diff --git a/lib/bb/cooker.py b/lib/bb/cooker.py
index 1810bcc60..36659cee2 100644
--- a/lib/bb/cooker.py
+++ b/lib/bb/cooker.py
@@ -12,7 +12,7 @@ import enum
 import sys, os, glob, os.path, re, time
 import itertools
 import logging
-import multiprocessing
+from bb import multiprocessing
 import threading
 from io import StringIO, UnsupportedOperation
 from contextlib import closing
diff --git a/lib/bb/server/process.py b/lib/bb/server/process.py
index 4b35be62c..f74b3f1bf 100644
--- a/lib/bb/server/process.py
+++ b/lib/bb/server/process.py
@@ -13,7 +13,7 @@
 import bb
 import bb.event
 import logging
-import multiprocessing
+from bb import multiprocessing
 import threading
 import array
 import os
diff --git a/lib/bb/tests/support/httpserver.py b/lib/bb/tests/support/httpserver.py
index 78f766005..03327e923 100644
--- a/lib/bb/tests/support/httpserver.py
+++ b/lib/bb/tests/support/httpserver.py
@@ -3,7 +3,7 @@
 #
 
 import http.server
-import multiprocessing
+from bb import multiprocessing
 import os
 import traceback
 import signal
@@ -43,7 +43,7 @@ class HTTPService(object):
         self.process = multiprocessing.Process(target=self.server.server_start, args=[self.root_dir, self.logger])
 
         # The signal handler from testimage.bbclass can cause deadlocks here
-        # if the HTTPServer is terminated before it can restore the standard 
+        # if the HTTPServer is terminated before it can restore the standard
         #signal behaviour
         orig = signal.getsignal(signal.SIGTERM)
         signal.signal(signal.SIGTERM, signal.SIG_DFL)
diff --git a/lib/bb/utils.py b/lib/bb/utils.py
index 083242268..694e79f55 100644
--- a/lib/bb/utils.py
+++ b/lib/bb/utils.py
@@ -12,7 +12,7 @@ import sys
 import errno
 import logging
 import locale
-import multiprocessing
+from bb import multiprocessing
 import importlib
 import importlib.machinery
 import importlib.util
@@ -1198,8 +1198,6 @@ def process_profilelog(fn, pout = None):
 #
 def multiprocessingpool(*args, **kwargs):
 
-    import multiprocessing.pool
-    #import multiprocessing.util
     #multiprocessing.util.log_to_stderr(10)
     # Deal with a multiprocessing bug where signals to the processes would be delayed until the work
     # completes. Putting in a timeout means the signals (like SIGINT/SIGTERM) get processed.
diff --git a/lib/hashserv/tests.py b/lib/hashserv/tests.py
index da3f8e088..124d8aa00 100644
--- a/lib/hashserv/tests.py
+++ b/lib/hashserv/tests.py
@@ -10,7 +10,7 @@ from .server import DEFAULT_ANON_PERMS, ALL_PERMISSIONS
 from bb.asyncrpc import InvokeError
 import hashlib
 import logging
-import multiprocessing
+from bb import multiprocessing
 import os
 import sys
 import tempfile
-- 
2.43.0



^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [bitbake][walnascar][2.12][PATCH 2/2] bitbake: Bump version to 2.12.1
  2025-09-10 15:55 [bitbake][walnascar][2.12][PATCH 0/2] Patch review Steve Sakoman
  2025-09-10 15:55 ` [bitbake][walnascar][2.12][PATCH 1/2] Use a "fork" multiprocessing context Steve Sakoman
@ 2025-09-10 15:55 ` Steve Sakoman
  2025-09-17  7:27   ` [bitbake-devel] " Martin Jansa
  1 sibling, 1 reply; 10+ messages in thread
From: Steve Sakoman @ 2025-09-10 15:55 UTC (permalink / raw)
  To: bitbake-devel

From: Martin Jansa <martin.jansa@gmail.com>

To indicate compatibility with python 3.14

[YOCTO #15858]

Signed-off-by: Martin Jansa <martin.jansa@gmail.com>
Signed-off-by: Steve Sakoman <steve@sakoman.com>
---
 bin/bitbake        | 2 +-
 lib/bb/__init__.py | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/bin/bitbake b/bin/bitbake
index 09cbb54e8..05b6ba742 100755
--- a/bin/bitbake
+++ b/bin/bitbake
@@ -27,7 +27,7 @@ from bb.main import bitbake_main, BitBakeConfigParameters, BBMainException
 
 bb.utils.check_system_locale()
 
-__version__ = "2.12.0"
+__version__ = "2.12.1"
 
 if __name__ == "__main__":
     if __version__ != bb.__version__:
diff --git a/lib/bb/__init__.py b/lib/bb/__init__.py
index 605355e1a..eba7b8fdd 100644
--- a/lib/bb/__init__.py
+++ b/lib/bb/__init__.py
@@ -9,7 +9,7 @@
 # SPDX-License-Identifier: GPL-2.0-only
 #
 
-__version__ = "2.12.0"
+__version__ = "2.12.1"
 
 import sys
 if sys.version_info < (3, 9, 0):
-- 
2.43.0



^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [bitbake-devel] [bitbake][walnascar][2.12][PATCH 2/2] bitbake: Bump version to 2.12.1
  2025-09-10 15:55 ` [bitbake][walnascar][2.12][PATCH 2/2] bitbake: Bump version to 2.12.1 Steve Sakoman
@ 2025-09-17  7:27   ` Martin Jansa
  2025-09-17 13:57     ` Steve Sakoman
  2025-09-17 22:24     ` Richard Purdie
  0 siblings, 2 replies; 10+ messages in thread
From: Martin Jansa @ 2025-09-17  7:27 UTC (permalink / raw)
  To: steve; +Cc: bitbake-devel

Hello Steve,

I've noticed today that 1.12.3 tag was pushed for current 1.12 branch:

commit 710f98844ae30416bdf6a01b655df398b49574ec (tag: yocto-5.2.3,
tag: 2025-04.3-walnascar, tag: 2.12.3, origin/2.12, oe/2.12,
github/2.12, github.oe/2.12, 2.12)
Author: Richard Purdie <richard.purdie@linuxfoundation.org>
Date:   Tue Jul 29 16:42:25 2025 -0400

    utils: Optimise signal/sigmask performance

Should I redo this as 2.12.4 and adjust the related change for oe-core
to bump the minimal version to 2.12.4 as well?

Similarly for scarthgap and 2.8 bitbake, which has 2.8.12 tag already,
so instead of 2.8.1 I would bump it to 2.8.13.

commit 982645110a19ebb94d519926a4e14c8a2a205cfd (tag: yocto-5.0.12,
tag: 2024-04.12-scarthgap, tag: 2.8.12, origin/2.8, oe/2.8,
github/2.8, github.oe/2.8, 2.8)
Author: Richard Purdie <richard.purdie@linuxfoundation.org>
Date:   Tue Jul 29 14:43:09 2025 -0400

    utils: Optimise signal/sigmask performance

Regards,

On Wed, Sep 10, 2025 at 5:55 PM Steve Sakoman via
lists.openembedded.org <steve=sakoman.com@lists.openembedded.org>
wrote:
>
> From: Martin Jansa <martin.jansa@gmail.com>
>
> To indicate compatibility with python 3.14
>
> [YOCTO #15858]
>
> Signed-off-by: Martin Jansa <martin.jansa@gmail.com>
> Signed-off-by: Steve Sakoman <steve@sakoman.com>
> ---
>  bin/bitbake        | 2 +-
>  lib/bb/__init__.py | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/bin/bitbake b/bin/bitbake
> index 09cbb54e8..05b6ba742 100755
> --- a/bin/bitbake
> +++ b/bin/bitbake
> @@ -27,7 +27,7 @@ from bb.main import bitbake_main, BitBakeConfigParameters, BBMainException
>
>  bb.utils.check_system_locale()
>
> -__version__ = "2.12.0"
> +__version__ = "2.12.1"
>
>  if __name__ == "__main__":
>      if __version__ != bb.__version__:
> diff --git a/lib/bb/__init__.py b/lib/bb/__init__.py
> index 605355e1a..eba7b8fdd 100644
> --- a/lib/bb/__init__.py
> +++ b/lib/bb/__init__.py
> @@ -9,7 +9,7 @@
>  # SPDX-License-Identifier: GPL-2.0-only
>  #
>
> -__version__ = "2.12.0"
> +__version__ = "2.12.1"
>
>  import sys
>  if sys.version_info < (3, 9, 0):
> --
> 2.43.0
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#17999): https://lists.openembedded.org/g/bitbake-devel/message/17999
> Mute This Topic: https://lists.openembedded.org/mt/115172226/3617156
> Group Owner: bitbake-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/bitbake-devel/unsub [martin.jansa@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [bitbake-devel] [bitbake][walnascar][2.12][PATCH 2/2] bitbake: Bump version to 2.12.1
  2025-09-17  7:27   ` [bitbake-devel] " Martin Jansa
@ 2025-09-17 13:57     ` Steve Sakoman
  2025-09-17 14:05       ` Martin Jansa
  2025-09-17 22:24     ` Richard Purdie
  1 sibling, 1 reply; 10+ messages in thread
From: Steve Sakoman @ 2025-09-17 13:57 UTC (permalink / raw)
  To: Martin Jansa, Richard Purdie; +Cc: bitbake-devel

On Wed, Sep 17, 2025 at 12:27 AM Martin Jansa <martin.jansa@gmail.com> wrote:
>
> Hello Steve,
>
> I've noticed today that 1.12.3 tag was pushed for current 1.12 branch:
>
> commit 710f98844ae30416bdf6a01b655df398b49574ec (tag: yocto-5.2.3,
> tag: 2025-04.3-walnascar, tag: 2.12.3, origin/2.12, oe/2.12,
> github/2.12, github.oe/2.12, 2.12)
> Author: Richard Purdie <richard.purdie@linuxfoundation.org>
> Date:   Tue Jul 29 16:42:25 2025 -0400
>
>     utils: Optimise signal/sigmask performance
>
> Should I redo this as 2.12.4 and adjust the related change for oe-core
> to bump the minimal version to 2.12.4 as well?
>
> Similarly for scarthgap and 2.8 bitbake, which has 2.8.12 tag already,
> so instead of 2.8.1 I would bump it to 2.8.13.

Adding Richard since he is the bitbake maintainer.

I'm not sure what has been done historically.  We haven't been bumping
the version with each minor release, but it seems to make sense to me
to do the bump to 2.12.4 rather than 2.12.1

Steve

> commit 982645110a19ebb94d519926a4e14c8a2a205cfd (tag: yocto-5.0.12,
> tag: 2024-04.12-scarthgap, tag: 2.8.12, origin/2.8, oe/2.8,
> github/2.8, github.oe/2.8, 2.8)
> Author: Richard Purdie <richard.purdie@linuxfoundation.org>
> Date:   Tue Jul 29 14:43:09 2025 -0400
>
>     utils: Optimise signal/sigmask performance
>
> Regards,
>
> On Wed, Sep 10, 2025 at 5:55 PM Steve Sakoman via
> lists.openembedded.org <steve=sakoman.com@lists.openembedded.org>
> wrote:
> >
> > From: Martin Jansa <martin.jansa@gmail.com>
> >
> > To indicate compatibility with python 3.14
> >
> > [YOCTO #15858]
> >
> > Signed-off-by: Martin Jansa <martin.jansa@gmail.com>
> > Signed-off-by: Steve Sakoman <steve@sakoman.com>
> > ---
> >  bin/bitbake        | 2 +-
> >  lib/bb/__init__.py | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/bin/bitbake b/bin/bitbake
> > index 09cbb54e8..05b6ba742 100755
> > --- a/bin/bitbake
> > +++ b/bin/bitbake
> > @@ -27,7 +27,7 @@ from bb.main import bitbake_main, BitBakeConfigParameters, BBMainException
> >
> >  bb.utils.check_system_locale()
> >
> > -__version__ = "2.12.0"
> > +__version__ = "2.12.1"
> >
> >  if __name__ == "__main__":
> >      if __version__ != bb.__version__:
> > diff --git a/lib/bb/__init__.py b/lib/bb/__init__.py
> > index 605355e1a..eba7b8fdd 100644
> > --- a/lib/bb/__init__.py
> > +++ b/lib/bb/__init__.py
> > @@ -9,7 +9,7 @@
> >  # SPDX-License-Identifier: GPL-2.0-only
> >  #
> >
> > -__version__ = "2.12.0"
> > +__version__ = "2.12.1"
> >
> >  import sys
> >  if sys.version_info < (3, 9, 0):
> > --
> > 2.43.0
> >
> >
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#17999): https://lists.openembedded.org/g/bitbake-devel/message/17999
> > Mute This Topic: https://lists.openembedded.org/mt/115172226/3617156
> > Group Owner: bitbake-devel+owner@lists.openembedded.org
> > Unsubscribe: https://lists.openembedded.org/g/bitbake-devel/unsub [martin.jansa@gmail.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [bitbake-devel] [bitbake][walnascar][2.12][PATCH 2/2] bitbake: Bump version to 2.12.1
  2025-09-17 13:57     ` Steve Sakoman
@ 2025-09-17 14:05       ` Martin Jansa
  2025-09-17 16:25         ` Steve Sakoman
  0 siblings, 1 reply; 10+ messages in thread
From: Martin Jansa @ 2025-09-17 14:05 UTC (permalink / raw)
  To: Steve Sakoman; +Cc: Richard Purdie, bitbake-devel

I've sent the v2 of all 4 related changes to use 2.12.4 and 2.8.13.

I've also noticed that the sanity check for bitbake version is
executed too late after the utils.py is already failing with:
ERROR: Unable to parse oe-core/meta/lib/oe/utils.py
Traceback (most recent call last):
  File "oe-core/meta/lib/oe/utils.py", line 11, in <module>
    from bb import multiprocessing
ImportError: cannot import name 'multiprocessing' from 'bb'
(bitbake/lib/bb/__init__.py)

To avoid this issue I recommend to leave "lib/oe/utils: use
multiprocessing from bb" commit in oe-core scarthgap and walnascar for
some future batch and now merge just the bitbake version bump in
bitbake and the requirement for newer bitbake in oe-core, that way
people will hopefully update both before it gets really mandatory.

Cheers,

On Wed, Sep 17, 2025 at 3:57 PM Steve Sakoman <steve@sakoman.com> wrote:
>
> On Wed, Sep 17, 2025 at 12:27 AM Martin Jansa <martin.jansa@gmail.com> wrote:
> >
> > Hello Steve,
> >
> > I've noticed today that 1.12.3 tag was pushed for current 1.12 branch:
> >
> > commit 710f98844ae30416bdf6a01b655df398b49574ec (tag: yocto-5.2.3,
> > tag: 2025-04.3-walnascar, tag: 2.12.3, origin/2.12, oe/2.12,
> > github/2.12, github.oe/2.12, 2.12)
> > Author: Richard Purdie <richard.purdie@linuxfoundation.org>
> > Date:   Tue Jul 29 16:42:25 2025 -0400
> >
> >     utils: Optimise signal/sigmask performance
> >
> > Should I redo this as 2.12.4 and adjust the related change for oe-core
> > to bump the minimal version to 2.12.4 as well?
> >
> > Similarly for scarthgap and 2.8 bitbake, which has 2.8.12 tag already,
> > so instead of 2.8.1 I would bump it to 2.8.13.
>
> Adding Richard since he is the bitbake maintainer.
>
> I'm not sure what has been done historically.  We haven't been bumping
> the version with each minor release, but it seems to make sense to me
> to do the bump to 2.12.4 rather than 2.12.1
>
> Steve
>
> > commit 982645110a19ebb94d519926a4e14c8a2a205cfd (tag: yocto-5.0.12,
> > tag: 2024-04.12-scarthgap, tag: 2.8.12, origin/2.8, oe/2.8,
> > github/2.8, github.oe/2.8, 2.8)
> > Author: Richard Purdie <richard.purdie@linuxfoundation.org>
> > Date:   Tue Jul 29 14:43:09 2025 -0400
> >
> >     utils: Optimise signal/sigmask performance
> >
> > Regards,
> >
> > On Wed, Sep 10, 2025 at 5:55 PM Steve Sakoman via
> > lists.openembedded.org <steve=sakoman.com@lists.openembedded.org>
> > wrote:
> > >
> > > From: Martin Jansa <martin.jansa@gmail.com>
> > >
> > > To indicate compatibility with python 3.14
> > >
> > > [YOCTO #15858]
> > >
> > > Signed-off-by: Martin Jansa <martin.jansa@gmail.com>
> > > Signed-off-by: Steve Sakoman <steve@sakoman.com>
> > > ---
> > >  bin/bitbake        | 2 +-
> > >  lib/bb/__init__.py | 2 +-
> > >  2 files changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/bin/bitbake b/bin/bitbake
> > > index 09cbb54e8..05b6ba742 100755
> > > --- a/bin/bitbake
> > > +++ b/bin/bitbake
> > > @@ -27,7 +27,7 @@ from bb.main import bitbake_main, BitBakeConfigParameters, BBMainException
> > >
> > >  bb.utils.check_system_locale()
> > >
> > > -__version__ = "2.12.0"
> > > +__version__ = "2.12.1"
> > >
> > >  if __name__ == "__main__":
> > >      if __version__ != bb.__version__:
> > > diff --git a/lib/bb/__init__.py b/lib/bb/__init__.py
> > > index 605355e1a..eba7b8fdd 100644
> > > --- a/lib/bb/__init__.py
> > > +++ b/lib/bb/__init__.py
> > > @@ -9,7 +9,7 @@
> > >  # SPDX-License-Identifier: GPL-2.0-only
> > >  #
> > >
> > > -__version__ = "2.12.0"
> > > +__version__ = "2.12.1"
> > >
> > >  import sys
> > >  if sys.version_info < (3, 9, 0):
> > > --
> > > 2.43.0
> > >
> > >
> > > -=-=-=-=-=-=-=-=-=-=-=-
> > > Links: You receive all messages sent to this group.
> > > View/Reply Online (#17999): https://lists.openembedded.org/g/bitbake-devel/message/17999
> > > Mute This Topic: https://lists.openembedded.org/mt/115172226/3617156
> > > Group Owner: bitbake-devel+owner@lists.openembedded.org
> > > Unsubscribe: https://lists.openembedded.org/g/bitbake-devel/unsub [martin.jansa@gmail.com]
> > > -=-=-=-=-=-=-=-=-=-=-=-
> > >


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [bitbake-devel] [bitbake][walnascar][2.12][PATCH 2/2] bitbake: Bump version to 2.12.1
  2025-09-17 14:05       ` Martin Jansa
@ 2025-09-17 16:25         ` Steve Sakoman
  2025-09-17 22:34           ` Richard Purdie
  0 siblings, 1 reply; 10+ messages in thread
From: Steve Sakoman @ 2025-09-17 16:25 UTC (permalink / raw)
  To: Martin Jansa; +Cc: Richard Purdie, bitbake-devel

On Wed, Sep 17, 2025 at 7:05 AM Martin Jansa <martin.jansa@gmail.com> wrote:
>
> I've sent the v2 of all 4 related changes to use 2.12.4 and 2.8.13.
>
> I've also noticed that the sanity check for bitbake version is
> executed too late after the utils.py is already failing with:
> ERROR: Unable to parse oe-core/meta/lib/oe/utils.py
> Traceback (most recent call last):
>   File "oe-core/meta/lib/oe/utils.py", line 11, in <module>
>     from bb import multiprocessing
> ImportError: cannot import name 'multiprocessing' from 'bb'
> (bitbake/lib/bb/__init__.py)
>
> To avoid this issue I recommend to leave "lib/oe/utils: use
> multiprocessing from bb" commit in oe-core scarthgap and walnascar for
> some future batch and now merge just the bitbake version bump in
> bitbake and the requirement for newer bitbake in oe-core, that way
> people will hopefully update both before it gets really mandatory.

I'll be doing the final walnascar build at the end of next week, so we
either need to have this sorted by early next week, or just decide to
leave things as they are with walnascar since it is going end of life.

I'll pull the patches from scarthgap till we sort the proper version
numbering and we can then stage them as you suggest.

Steve

> On Wed, Sep 17, 2025 at 3:57 PM Steve Sakoman <steve@sakoman.com> wrote:
> >
> > On Wed, Sep 17, 2025 at 12:27 AM Martin Jansa <martin.jansa@gmail.com> wrote:
> > >
> > > Hello Steve,
> > >
> > > I've noticed today that 1.12.3 tag was pushed for current 1.12 branch:
> > >
> > > commit 710f98844ae30416bdf6a01b655df398b49574ec (tag: yocto-5.2.3,
> > > tag: 2025-04.3-walnascar, tag: 2.12.3, origin/2.12, oe/2.12,
> > > github/2.12, github.oe/2.12, 2.12)
> > > Author: Richard Purdie <richard.purdie@linuxfoundation.org>
> > > Date:   Tue Jul 29 16:42:25 2025 -0400
> > >
> > >     utils: Optimise signal/sigmask performance
> > >
> > > Should I redo this as 2.12.4 and adjust the related change for oe-core
> > > to bump the minimal version to 2.12.4 as well?
> > >
> > > Similarly for scarthgap and 2.8 bitbake, which has 2.8.12 tag already,
> > > so instead of 2.8.1 I would bump it to 2.8.13.
> >
> > Adding Richard since he is the bitbake maintainer.
> >
> > I'm not sure what has been done historically.  We haven't been bumping
> > the version with each minor release, but it seems to make sense to me
> > to do the bump to 2.12.4 rather than 2.12.1
> >
> > Steve
> >
> > > commit 982645110a19ebb94d519926a4e14c8a2a205cfd (tag: yocto-5.0.12,
> > > tag: 2024-04.12-scarthgap, tag: 2.8.12, origin/2.8, oe/2.8,
> > > github/2.8, github.oe/2.8, 2.8)
> > > Author: Richard Purdie <richard.purdie@linuxfoundation.org>
> > > Date:   Tue Jul 29 14:43:09 2025 -0400
> > >
> > >     utils: Optimise signal/sigmask performance
> > >
> > > Regards,
> > >
> > > On Wed, Sep 10, 2025 at 5:55 PM Steve Sakoman via
> > > lists.openembedded.org <steve=sakoman.com@lists.openembedded.org>
> > > wrote:
> > > >
> > > > From: Martin Jansa <martin.jansa@gmail.com>
> > > >
> > > > To indicate compatibility with python 3.14
> > > >
> > > > [YOCTO #15858]
> > > >
> > > > Signed-off-by: Martin Jansa <martin.jansa@gmail.com>
> > > > Signed-off-by: Steve Sakoman <steve@sakoman.com>
> > > > ---
> > > >  bin/bitbake        | 2 +-
> > > >  lib/bb/__init__.py | 2 +-
> > > >  2 files changed, 2 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/bin/bitbake b/bin/bitbake
> > > > index 09cbb54e8..05b6ba742 100755
> > > > --- a/bin/bitbake
> > > > +++ b/bin/bitbake
> > > > @@ -27,7 +27,7 @@ from bb.main import bitbake_main, BitBakeConfigParameters, BBMainException
> > > >
> > > >  bb.utils.check_system_locale()
> > > >
> > > > -__version__ = "2.12.0"
> > > > +__version__ = "2.12.1"
> > > >
> > > >  if __name__ == "__main__":
> > > >      if __version__ != bb.__version__:
> > > > diff --git a/lib/bb/__init__.py b/lib/bb/__init__.py
> > > > index 605355e1a..eba7b8fdd 100644
> > > > --- a/lib/bb/__init__.py
> > > > +++ b/lib/bb/__init__.py
> > > > @@ -9,7 +9,7 @@
> > > >  # SPDX-License-Identifier: GPL-2.0-only
> > > >  #
> > > >
> > > > -__version__ = "2.12.0"
> > > > +__version__ = "2.12.1"
> > > >
> > > >  import sys
> > > >  if sys.version_info < (3, 9, 0):
> > > > --
> > > > 2.43.0
> > > >
> > > >
> > > > -=-=-=-=-=-=-=-=-=-=-=-
> > > > Links: You receive all messages sent to this group.
> > > > View/Reply Online (#17999): https://lists.openembedded.org/g/bitbake-devel/message/17999
> > > > Mute This Topic: https://lists.openembedded.org/mt/115172226/3617156
> > > > Group Owner: bitbake-devel+owner@lists.openembedded.org
> > > > Unsubscribe: https://lists.openembedded.org/g/bitbake-devel/unsub [martin.jansa@gmail.com]
> > > > -=-=-=-=-=-=-=-=-=-=-=-
> > > >


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [bitbake-devel] [bitbake][walnascar][2.12][PATCH 2/2] bitbake: Bump version to 2.12.1
  2025-09-17  7:27   ` [bitbake-devel] " Martin Jansa
  2025-09-17 13:57     ` Steve Sakoman
@ 2025-09-17 22:24     ` Richard Purdie
  1 sibling, 0 replies; 10+ messages in thread
From: Richard Purdie @ 2025-09-17 22:24 UTC (permalink / raw)
  To: martin.jansa, steve; +Cc: bitbake-devel

On Wed, 2025-09-17 at 09:27 +0200, Martin Jansa via lists.openembedded.org wrote:
> Hello Steve,
> 
> I've noticed today that 1.12.3 tag was pushed for current 1.12
> branch:
> 
> commit 710f98844ae30416bdf6a01b655df398b49574ec (tag: yocto-5.2.3,
> tag: 2025-04.3-walnascar, tag: 2.12.3, origin/2.12, oe/2.12,
> github/2.12, github.oe/2.12, 2.12)
> Author: Richard Purdie <richard.purdie@linuxfoundation.org>
> Date:   Tue Jul 29 16:42:25 2025 -0400
> 
>     utils: Optimise signal/sigmask performance
> 
> Should I redo this as 2.12.4 and adjust the related change for oe-
> core
> to bump the minimal version to 2.12.4 as well?
> 
> Similarly for scarthgap and 2.8 bitbake, which has 2.8.12 tag
> already,
> so instead of 2.8.1 I would bump it to 2.8.13.

Sorry about the delay.

Your patches are right and the tags are messed up. They're getting
cleaned up and I've merged the patches in the meantime.

Cheers,

Richard


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [bitbake-devel] [bitbake][walnascar][2.12][PATCH 2/2] bitbake: Bump version to 2.12.1
  2025-09-17 16:25         ` Steve Sakoman
@ 2025-09-17 22:34           ` Richard Purdie
  2025-09-17 22:35             ` Steve Sakoman
  0 siblings, 1 reply; 10+ messages in thread
From: Richard Purdie @ 2025-09-17 22:34 UTC (permalink / raw)
  To: Steve Sakoman, Martin Jansa; +Cc: bitbake-devel

On Wed, 2025-09-17 at 09:25 -0700, Steve Sakoman wrote:
> On Wed, Sep 17, 2025 at 7:05 AM Martin Jansa <martin.jansa@gmail.com> wrote:
> > 
> > I've sent the v2 of all 4 related changes to use 2.12.4 and 2.8.13.
> > 
> > I've also noticed that the sanity check for bitbake version is
> > executed too late after the utils.py is already failing with:
> > ERROR: Unable to parse oe-core/meta/lib/oe/utils.py
> > Traceback (most recent call last):
> >   File "oe-core/meta/lib/oe/utils.py", line 11, in <module>
> >     from bb import multiprocessing
> > ImportError: cannot import name 'multiprocessing' from 'bb'
> > (bitbake/lib/bb/__init__.py)
> > 
> > To avoid this issue I recommend to leave "lib/oe/utils: use
> > multiprocessing from bb" commit in oe-core scarthgap and walnascar for
> > some future batch and now merge just the bitbake version bump in
> > bitbake and the requirement for newer bitbake in oe-core, that way
> > people will hopefully update both before it gets really mandatory.
> 
> I'll be doing the final walnascar build at the end of next week, so we
> either need to have this sorted by early next week, or just decide to
> leave things as they are with walnascar since it is going end of life.
> 
> I'll pull the patches from scarthgap till we sort the proper version
> numbering and we can then stage them as you suggest.

I've pushed what I think makes sense, hopefully that gets things unblocked.

Cheers,

Richard


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [bitbake-devel] [bitbake][walnascar][2.12][PATCH 2/2] bitbake: Bump version to 2.12.1
  2025-09-17 22:34           ` Richard Purdie
@ 2025-09-17 22:35             ` Steve Sakoman
  0 siblings, 0 replies; 10+ messages in thread
From: Steve Sakoman @ 2025-09-17 22:35 UTC (permalink / raw)
  To: Richard Purdie; +Cc: Martin Jansa, bitbake-devel

On Wed, Sep 17, 2025 at 3:34 PM Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
>
> On Wed, 2025-09-17 at 09:25 -0700, Steve Sakoman wrote:
> > On Wed, Sep 17, 2025 at 7:05 AM Martin Jansa <martin.jansa@gmail.com> wrote:
> > >
> > > I've sent the v2 of all 4 related changes to use 2.12.4 and 2.8.13.
> > >
> > > I've also noticed that the sanity check for bitbake version is
> > > executed too late after the utils.py is already failing with:
> > > ERROR: Unable to parse oe-core/meta/lib/oe/utils.py
> > > Traceback (most recent call last):
> > >   File "oe-core/meta/lib/oe/utils.py", line 11, in <module>
> > >     from bb import multiprocessing
> > > ImportError: cannot import name 'multiprocessing' from 'bb'
> > > (bitbake/lib/bb/__init__.py)
> > >
> > > To avoid this issue I recommend to leave "lib/oe/utils: use
> > > multiprocessing from bb" commit in oe-core scarthgap and walnascar for
> > > some future batch and now merge just the bitbake version bump in
> > > bitbake and the requirement for newer bitbake in oe-core, that way
> > > people will hopefully update both before it gets really mandatory.
> >
> > I'll be doing the final walnascar build at the end of next week, so we
> > either need to have this sorted by early next week, or just decide to
> > leave things as they are with walnascar since it is going end of life.
> >
> > I'll pull the patches from scarthgap till we sort the proper version
> > numbering and we can then stage them as you suggest.
>
> I've pushed what I think makes sense, hopefully that gets things unblocked.

It does.  Thanks!

Steve

>
> Cheers,
>
> Richard


^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2025-09-17 22:35 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-10 15:55 [bitbake][walnascar][2.12][PATCH 0/2] Patch review Steve Sakoman
2025-09-10 15:55 ` [bitbake][walnascar][2.12][PATCH 1/2] Use a "fork" multiprocessing context Steve Sakoman
2025-09-10 15:55 ` [bitbake][walnascar][2.12][PATCH 2/2] bitbake: Bump version to 2.12.1 Steve Sakoman
2025-09-17  7:27   ` [bitbake-devel] " Martin Jansa
2025-09-17 13:57     ` Steve Sakoman
2025-09-17 14:05       ` Martin Jansa
2025-09-17 16:25         ` Steve Sakoman
2025-09-17 22:34           ` Richard Purdie
2025-09-17 22:35             ` Steve Sakoman
2025-09-17 22:24     ` Richard Purdie

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.