* [PATCH v1 0/2] media: dt-bindings: Convert toshiba,et8ek8 and ti,omap3isp to YAML schema
@ 2025-12-20 22:03 ` Alex Tran
0 siblings, 0 replies; 15+ messages in thread
From: Alex Tran @ 2025-12-20 22:03 UTC (permalink / raw)
To: mchehab, robh, krzk+dt, conor+dt
Cc: pavel, sakari.ailus, mehdi.djait, alex.t.tran, laurent.pinchart,
hverkuil+cisco, linux-media, devicetree, linux-kernel
This patch series converts the dt-bindings for media components
toshiba,et8ek8 and ti,omap3isp from the TXT to YAML schema.
The series is composed of:
Patch 1: Converts the Toshiba ET8EK8 sensor binding and updates
the MAINTAINERS file under the NOKIA N900 CAMERA SUPPORT accordingly.
Patch 2: Converts the TI OMAP 3 ISP binding.
Alex Tran (2):
media: i2c: toshiba,et8ek8: dt-bindings: Convert to DT schema
media: ti,omap3isp: dt-bindings: Convert to DT schema
.../bindings/media/i2c/toshiba,et8ek8.txt | 55 ------
.../bindings/media/i2c/toshiba,et8ek8.yaml | 91 +++++++++
.../devicetree/bindings/media/ti,omap3isp.txt | 71 -------
.../bindings/media/ti,omap3isp.yaml | 182 ++++++++++++++++++
MAINTAINERS | 1 +
5 files changed, 274 insertions(+), 126 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt
create mode 100644 Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.yaml
delete mode 100644 Documentation/devicetree/bindings/media/ti,omap3isp.txt
create mode 100644 Documentation/devicetree/bindings/media/ti,omap3isp.yaml
--
2.51.0
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH v1 1/2] media: dt-bindings: i2c: toshiba,et8ek8: Convert to DT schema
2025-12-20 22:03 ` Alex Tran
@ 2025-12-20 22:03 ` Alex Tran
-1 siblings, 0 replies; 15+ messages in thread
From: Alex Tran @ 2025-12-20 20:42 UTC (permalink / raw)
To: mchehab, robh, krzk+dt, conor+dt
Cc: pavel, sakari.ailus, mehdi.djait, alex.t.tran, laurent.pinchart,
hverkuil+cisco, linux-media
Convert binding for toshiba,et8ek8 from TXT to YAML format.
Update MAINTAINERS file accordingly.
Signed-off-by: Alex Tran <alex.t.tran@gmail.com>
---
.../bindings/media/i2c/toshiba,et8ek8.txt | 55 -----------
.../bindings/media/i2c/toshiba,et8ek8.yaml | 91 +++++++++++++++++++
MAINTAINERS | 1 +
3 files changed, 92 insertions(+), 55 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt
create mode 100644 Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.yaml
diff --git a/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt
deleted file mode 100644
index 8d8e40c56872..000000000000
--- a/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt
+++ /dev/null
@@ -1,55 +0,0 @@
-Toshiba et8ek8 5MP sensor
-
-Toshiba et8ek8 5MP sensor is an image sensor found in Nokia N900 device
-
-More detailed documentation can be found in
-Documentation/devicetree/bindings/media/video-interfaces.txt .
-
-
-Mandatory properties
---------------------
-
-- compatible: "toshiba,et8ek8"
-- reg: I2C address (0x3e, or an alternative address)
-- vana-supply: Analogue voltage supply (VANA), 2.8 volts
-- clocks: External clock to the sensor
-- reset-gpios: XSHUTDOWN GPIO. The XSHUTDOWN signal is active low. The sensor
- is in hardware standby mode when the signal is in the low state.
-
-
-Optional properties
--------------------
-
-- flash-leds: See ../video-interfaces.txt
-- lens-focus: See ../video-interfaces.txt
-
-
-Endpoint node mandatory properties
-----------------------------------
-
-- remote-endpoint: A phandle to the bus receiver's endpoint node.
-
-
-Example
--------
-
-&i2c3 {
- clock-frequency = <400000>;
-
- cam1: camera@3e {
- compatible = "toshiba,et8ek8";
- reg = <0x3e>;
- vana-supply = <&vaux4>;
-
- clocks = <&isp 0>;
- assigned-clocks = <&isp 0>;
- assigned-clock-rates = <9600000>;
-
- reset-gpio = <&gpio4 6 GPIO_ACTIVE_HIGH>; /* 102 */
- port {
- csi_cam1: endpoint {
- remote-endpoint = <&csi_out1>;
- };
- };
- };
-};
diff --git a/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.yaml b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.yaml
new file mode 100644
index 000000000000..68a8134df8fc
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.yaml
@@ -0,0 +1,91 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/i2c/toshiba,et8ek8.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Toshiba et8ek8 5MP sensor
+
+maintainers:
+ - Pavel Machek <pavel@ucw.cz>
+ - Sakari Ailus <sakari.ailus@iki.fi>
+
+description:
+ Toshiba et8ek8 5MP sensor is an image sensor found in Nokia N900 device
+
+properties:
+ compatible:
+ const: toshiba,et8ek8
+
+ reg:
+ description:
+ I2C address (0x3e, or an alternative address)
+ maxItems: 1
+
+ vana-supply:
+ description:
+ Analogue voltage supply (VANA), 2.8 volts
+
+ clocks:
+ description:
+ External clock to the sensor
+ maxItems: 1
+
+ reset-gpios:
+ description:
+ XSHUTDOWN GPIO. The XSHUTDOWN signal is active low. The sensor
+ is in hardware standby mode when the signal is in the low state.
+ maxItems: 1
+
+ flash-leds:
+ $ref: /schemas/media/video-interfaces.yaml#
+
+ lens-focus:
+ $ref: /schemas/media/video-interfaces.yaml#
+
+ port:
+ $ref: /schemas/graph.yaml#/$defs/port-base
+ additionalProperties: false
+
+ properties:
+ endpoint:
+ $ref: /schemas/media/video-interfaces.yaml#
+ unevaluatedProperties: false
+
+ properties:
+ remote-endpoint: true
+
+required:
+ - compatible
+ - reg
+ - vana-supply
+ - clocks
+ - reset-gpios
+ - port
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ camera@3e {
+ compatible = "toshiba,et8ek8";
+ reg = <0x3e>;
+ vana-supply = <&vaux4>;
+ clocks = <&isp 0>;
+ assigned-clocks = <&isp 0>;
+ assigned-clock-rates = <9600000>;
+ reset-gpios = <&gpio4 6 GPIO_ACTIVE_HIGH>;
+
+ port {
+ csi_cam1: endpoint {
+ remote-endpoint = <&csi_out1>;
+ };
+ };
+ };
+ };
diff --git a/MAINTAINERS b/MAINTAINERS
index dc731d37c8fe..50722537d548 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -18582,6 +18582,7 @@ M: Sakari Ailus <sakari.ailus@iki.fi>
L: linux-media@vger.kernel.org
S: Maintained
F: Documentation/devicetree/bindings/media/i2c/adi,ad5820.yaml
+F: Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.yaml
F: drivers/media/i2c/ad5820.c
F: drivers/media/i2c/et8ek8
--
2.51.0
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH v1 1/2] media: dt-bindings: i2c: toshiba,et8ek8: Convert to DT schema
@ 2025-12-20 22:03 ` Alex Tran
0 siblings, 0 replies; 15+ messages in thread
From: Alex Tran @ 2025-12-20 22:03 UTC (permalink / raw)
To: mchehab, robh, krzk+dt, conor+dt
Cc: pavel, sakari.ailus, mehdi.djait, alex.t.tran, laurent.pinchart,
hverkuil+cisco, linux-media, devicetree, linux-kernel
Convert binding for toshiba,et8ek8 from TXT to YAML format.
Update MAINTAINERS file accordingly.
Signed-off-by: Alex Tran <alex.t.tran@gmail.com>
---
.../bindings/media/i2c/toshiba,et8ek8.txt | 55 -----------
.../bindings/media/i2c/toshiba,et8ek8.yaml | 91 +++++++++++++++++++
MAINTAINERS | 1 +
3 files changed, 92 insertions(+), 55 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt
create mode 100644 Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.yaml
diff --git a/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt
deleted file mode 100644
index 8d8e40c56872..000000000000
--- a/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt
+++ /dev/null
@@ -1,55 +0,0 @@
-Toshiba et8ek8 5MP sensor
-
-Toshiba et8ek8 5MP sensor is an image sensor found in Nokia N900 device
-
-More detailed documentation can be found in
-Documentation/devicetree/bindings/media/video-interfaces.txt .
-
-
-Mandatory properties
---------------------
-
-- compatible: "toshiba,et8ek8"
-- reg: I2C address (0x3e, or an alternative address)
-- vana-supply: Analogue voltage supply (VANA), 2.8 volts
-- clocks: External clock to the sensor
-- reset-gpios: XSHUTDOWN GPIO. The XSHUTDOWN signal is active low. The sensor
- is in hardware standby mode when the signal is in the low state.
-
-
-Optional properties
--------------------
-
-- flash-leds: See ../video-interfaces.txt
-- lens-focus: See ../video-interfaces.txt
-
-
-Endpoint node mandatory properties
-----------------------------------
-
-- remote-endpoint: A phandle to the bus receiver's endpoint node.
-
-
-Example
--------
-
-&i2c3 {
- clock-frequency = <400000>;
-
- cam1: camera@3e {
- compatible = "toshiba,et8ek8";
- reg = <0x3e>;
- vana-supply = <&vaux4>;
-
- clocks = <&isp 0>;
- assigned-clocks = <&isp 0>;
- assigned-clock-rates = <9600000>;
-
- reset-gpio = <&gpio4 6 GPIO_ACTIVE_HIGH>; /* 102 */
- port {
- csi_cam1: endpoint {
- remote-endpoint = <&csi_out1>;
- };
- };
- };
-};
diff --git a/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.yaml b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.yaml
new file mode 100644
index 000000000000..68a8134df8fc
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.yaml
@@ -0,0 +1,91 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/i2c/toshiba,et8ek8.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Toshiba et8ek8 5MP sensor
+
+maintainers:
+ - Pavel Machek <pavel@ucw.cz>
+ - Sakari Ailus <sakari.ailus@iki.fi>
+
+description:
+ Toshiba et8ek8 5MP sensor is an image sensor found in Nokia N900 device
+
+properties:
+ compatible:
+ const: toshiba,et8ek8
+
+ reg:
+ description:
+ I2C address (0x3e, or an alternative address)
+ maxItems: 1
+
+ vana-supply:
+ description:
+ Analogue voltage supply (VANA), 2.8 volts
+
+ clocks:
+ description:
+ External clock to the sensor
+ maxItems: 1
+
+ reset-gpios:
+ description:
+ XSHUTDOWN GPIO. The XSHUTDOWN signal is active low. The sensor
+ is in hardware standby mode when the signal is in the low state.
+ maxItems: 1
+
+ flash-leds:
+ $ref: /schemas/media/video-interfaces.yaml#
+
+ lens-focus:
+ $ref: /schemas/media/video-interfaces.yaml#
+
+ port:
+ $ref: /schemas/graph.yaml#/$defs/port-base
+ additionalProperties: false
+
+ properties:
+ endpoint:
+ $ref: /schemas/media/video-interfaces.yaml#
+ unevaluatedProperties: false
+
+ properties:
+ remote-endpoint: true
+
+required:
+ - compatible
+ - reg
+ - vana-supply
+ - clocks
+ - reset-gpios
+ - port
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ camera@3e {
+ compatible = "toshiba,et8ek8";
+ reg = <0x3e>;
+ vana-supply = <&vaux4>;
+ clocks = <&isp 0>;
+ assigned-clocks = <&isp 0>;
+ assigned-clock-rates = <9600000>;
+ reset-gpios = <&gpio4 6 GPIO_ACTIVE_HIGH>;
+
+ port {
+ csi_cam1: endpoint {
+ remote-endpoint = <&csi_out1>;
+ };
+ };
+ };
+ };
diff --git a/MAINTAINERS b/MAINTAINERS
index dc731d37c8fe..50722537d548 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -18582,6 +18582,7 @@ M: Sakari Ailus <sakari.ailus@iki.fi>
L: linux-media@vger.kernel.org
S: Maintained
F: Documentation/devicetree/bindings/media/i2c/adi,ad5820.yaml
+F: Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.yaml
F: drivers/media/i2c/ad5820.c
F: drivers/media/i2c/et8ek8
--
2.51.0
^ permalink raw reply related [flat|nested] 15+ messages in thread* Re: [PATCH v1 1/2] media: dt-bindings: i2c: toshiba,et8ek8: Convert to DT schema
2025-12-20 22:03 ` Alex Tran
(?)
@ 2025-12-21 13:15 ` Krzysztof Kozlowski
2025-12-21 15:01 ` Krzysztof Kozlowski
-1 siblings, 1 reply; 15+ messages in thread
From: Krzysztof Kozlowski @ 2025-12-21 13:15 UTC (permalink / raw)
To: Alex Tran, mchehab, robh, krzk+dt, conor+dt
Cc: pavel, sakari.ailus, mehdi.djait, laurent.pinchart,
hverkuil+cisco, linux-media
On 20/12/2025 21:42, Alex Tran wrote:
> Convert binding for toshiba,et8ek8 from TXT to YAML format.
> Update MAINTAINERS file accordingly.
>
> Signed-off-by: Alex Tran <alex.t.tran@gmail.com>
> ---
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.
Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.
You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time.
Please kindly resend and include all necessary To/Cc entries.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v1 1/2] media: dt-bindings: i2c: toshiba,et8ek8: Convert to DT schema
2025-12-21 13:15 ` Krzysztof Kozlowski
@ 2025-12-21 15:01 ` Krzysztof Kozlowski
2025-12-21 20:21 ` Alex Tran
2025-12-30 16:23 ` Rob Herring
0 siblings, 2 replies; 15+ messages in thread
From: Krzysztof Kozlowski @ 2025-12-21 15:01 UTC (permalink / raw)
To: Alex Tran, mchehab, robh, krzk+dt, conor+dt
Cc: pavel, sakari.ailus, mehdi.djait, laurent.pinchart,
hverkuil+cisco, linux-media
On Sun, Dec 21, 2025 at 02:15:10PM +0100, Krzysztof Kozlowski wrote:
> On 20/12/2025 21:42, Alex Tran wrote:
> > Convert binding for toshiba,et8ek8 from TXT to YAML format.
> > Update MAINTAINERS file accordingly.
> >
> > Signed-off-by: Alex Tran <alex.t.tran@gmail.com>
> > ---
>
>
> Please use scripts/get_maintainers.pl to get a list of necessary people
> and lists to CC. It might happen, that command when run on an older
> kernel, gives you outdated entries. Therefore please be sure you base
> your patches on recent Linux kernel.
>
> Tools like b4 or scripts/get_maintainer.pl provide you proper list of
> people, so fix your workflow. Tools might also fail if you work on some
> ancient tree (don't, instead use mainline) or work on fork of kernel
> (don't, instead use mainline). Just use b4 and everything should be
> fine, although remember about `b4 prep --auto-to-cc` if you added new
> patches to the patchset.
>
> You missed at least devicetree list (maybe more), so this won't be
> tested by automated tooling. Performing review on untested code might be
> a waste of time.
>
> Please kindly resend and include all necessary To/Cc entries.
Odd, I see this reached DT list, but was marked by one of my filters.
Everything seems fine, so apologies for the noise.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v1 1/2] media: dt-bindings: i2c: toshiba,et8ek8: Convert to DT schema
2025-12-21 15:01 ` Krzysztof Kozlowski
@ 2025-12-21 20:21 ` Alex Tran
2025-12-30 16:23 ` Rob Herring
1 sibling, 0 replies; 15+ messages in thread
From: Alex Tran @ 2025-12-21 20:21 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: mchehab, robh, krzk+dt, conor+dt, pavel, sakari.ailus,
mehdi.djait, laurent.pinchart, hverkuil+cisco, linux-media
On Sun, Dec 21, 2025 at 7:01 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On Sun, Dec 21, 2025 at 02:15:10PM +0100, Krzysztof Kozlowski wrote:
> > On 20/12/2025 21:42, Alex Tran wrote:
> > > Convert binding for toshiba,et8ek8 from TXT to YAML format.
> > > Update MAINTAINERS file accordingly.
> > >
> > > Signed-off-by: Alex Tran <alex.t.tran@gmail.com>
> > > ---
> >
> >
> > Please use scripts/get_maintainers.pl to get a list of necessary people
> > and lists to CC. It might happen, that command when run on an older
> > kernel, gives you outdated entries. Therefore please be sure you base
> > your patches on recent Linux kernel.
> >
> > Tools like b4 or scripts/get_maintainer.pl provide you proper list of
> > people, so fix your workflow. Tools might also fail if you work on some
> > ancient tree (don't, instead use mainline) or work on fork of kernel
> > (don't, instead use mainline). Just use b4 and everything should be
> > fine, although remember about `b4 prep --auto-to-cc` if you added new
> > patches to the patchset.
> >
> > You missed at least devicetree list (maybe more), so this won't be
> > tested by automated tooling. Performing review on untested code might be
> > a waste of time.
> >
> > Please kindly resend and include all necessary To/Cc entries.
>
> Odd, I see this reached DT list, but was marked by one of my filters.
>
> Everything seems fine, so apologies for the noise.
Originally, I sent the series forgetting to Cc the devicetree list and
the CI notified me about it and so I resent it accordingly. I wasn't
sure if it should be labeled as a v2 since there was no content
changed in the patch series (just adding 1 missing Cc) so I sent it
again as a v1. Sorry for the confusion and thanks for the tip on using
the b4 tool. It will reduce a lot of mistakes made like this when
running git send-email and manually inputting each maintainer and
mailing list.
--
Yours,
Alex Tran
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v1 1/2] media: dt-bindings: i2c: toshiba,et8ek8: Convert to DT schema
2025-12-21 15:01 ` Krzysztof Kozlowski
2025-12-21 20:21 ` Alex Tran
@ 2025-12-30 16:23 ` Rob Herring
1 sibling, 0 replies; 15+ messages in thread
From: Rob Herring @ 2025-12-30 16:23 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Alex Tran, mchehab, krzk+dt, conor+dt, pavel, sakari.ailus,
mehdi.djait, laurent.pinchart, hverkuil+cisco, linux-media
On Sun, Dec 21, 2025 at 9:01 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On Sun, Dec 21, 2025 at 02:15:10PM +0100, Krzysztof Kozlowski wrote:
> > On 20/12/2025 21:42, Alex Tran wrote:
> > > Convert binding for toshiba,et8ek8 from TXT to YAML format.
> > > Update MAINTAINERS file accordingly.
> > >
> > > Signed-off-by: Alex Tran <alex.t.tran@gmail.com>
> > > ---
> >
> >
> > Please use scripts/get_maintainers.pl to get a list of necessary people
> > and lists to CC. It might happen, that command when run on an older
> > kernel, gives you outdated entries. Therefore please be sure you base
> > your patches on recent Linux kernel.
> >
> > Tools like b4 or scripts/get_maintainer.pl provide you proper list of
> > people, so fix your workflow. Tools might also fail if you work on some
> > ancient tree (don't, instead use mainline) or work on fork of kernel
> > (don't, instead use mainline). Just use b4 and everything should be
> > fine, although remember about `b4 prep --auto-to-cc` if you added new
> > patches to the patchset.
> >
> > You missed at least devicetree list (maybe more), so this won't be
> > tested by automated tooling. Performing review on untested code might be
> > a waste of time.
> >
> > Please kindly resend and include all necessary To/Cc entries.
>
> Odd, I see this reached DT list, but was marked by one of my filters.
Perhaps it is because the new PW instance isn't dependent on the DT
list, but uses a lei filter.
Rob
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v1 1/2] media: dt-bindings: i2c: toshiba,et8ek8: Convert to DT schema
2025-12-20 22:03 ` Alex Tran
(?)
(?)
@ 2025-12-21 15:05 ` Krzysztof Kozlowski
2025-12-24 21:07 ` Alex Tran
-1 siblings, 1 reply; 15+ messages in thread
From: Krzysztof Kozlowski @ 2025-12-21 15:05 UTC (permalink / raw)
To: Alex Tran
Cc: mchehab, robh, krzk+dt, conor+dt, pavel, sakari.ailus,
mehdi.djait, laurent.pinchart, hverkuil+cisco, linux-media,
devicetree, linux-kernel
On Sat, Dec 20, 2025 at 02:03:24PM -0800, Alex Tran wrote:
> diff --git a/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.yaml b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.yaml
> new file mode 100644
> index 000000000000..68a8134df8fc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.yaml
> @@ -0,0 +1,91 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/i2c/toshiba,et8ek8.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Toshiba et8ek8 5MP sensor
> +
> +maintainers:
> + - Pavel Machek <pavel@ucw.cz>
> + - Sakari Ailus <sakari.ailus@iki.fi>
> +
> +description:
> + Toshiba et8ek8 5MP sensor is an image sensor found in Nokia N900 device
> +
> +properties:
> + compatible:
> + const: toshiba,et8ek8
> +
> + reg:
> + description:
> + I2C address (0x3e, or an alternative address)
> + maxItems: 1
> +
> + vana-supply:
> + description:
> + Analogue voltage supply (VANA), 2.8 volts
> +
> + clocks:
> + description:
> + External clock to the sensor
If there is going to be new version: drop description, obvious.
> + maxItems: 1
> +
> + reset-gpios:
> + description:
> + XSHUTDOWN GPIO. The XSHUTDOWN signal is active low. The sensor
> + is in hardware standby mode when the signal is in the low state.
> + maxItems: 1
> +
> + flash-leds:
> + $ref: /schemas/media/video-interfaces.yaml#
This and...
> +
> + lens-focus:
> + $ref: /schemas/media/video-interfaces.yaml#
... this are weird. LEDs are not video interfaces, for sure. lens focus
shouldn't be video interface, either.
You also miss unevaluatedProps there.
This needs careful fixing/rewriting, with explanation in commit msg.
> +
> + port:
> + $ref: /schemas/graph.yaml#/$defs/port-base
> + additionalProperties: false
> +
> + properties:
> + endpoint:
> + $ref: /schemas/media/video-interfaces.yaml#
> + unevaluatedProperties: false
> +
> + properties:
> + remote-endpoint: true
Drop, pointless.
> +
> +required:
> + - compatible
> + - reg
> + - vana-supply
> + - clocks
> + - reset-gpios
> + - port
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + camera@3e {
> + compatible = "toshiba,et8ek8";
> + reg = <0x3e>;
> + vana-supply = <&vaux4>;
> + clocks = <&isp 0>;
> + assigned-clocks = <&isp 0>;
> + assigned-clock-rates = <9600000>;
> + reset-gpios = <&gpio4 6 GPIO_ACTIVE_HIGH>;
> +
> + port {
> + csi_cam1: endpoint {
> + remote-endpoint = <&csi_out1>;
> + };
Please make the example complete - missing flash-leds and lens-focus. If
you provided them, you would see your binding is not correct.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PATCH v1 1/2] media: dt-bindings: i2c: toshiba,et8ek8: Convert to DT schema
2025-12-21 15:05 ` Krzysztof Kozlowski
@ 2025-12-24 21:07 ` Alex Tran
2025-12-25 8:37 ` Krzysztof Kozlowski
0 siblings, 1 reply; 15+ messages in thread
From: Alex Tran @ 2025-12-24 21:07 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: mchehab, robh, krzk+dt, conor+dt, pavel, sakari.ailus,
mehdi.djait, laurent.pinchart, hverkuil+cisco, linux-media,
devicetree, linux-kernel
> > + maxItems: 1
> > +
> > + reset-gpios:
> > + description:
> > + XSHUTDOWN GPIO. The XSHUTDOWN signal is active low. The sensor
> > + is in hardware standby mode when the signal is in the low state.
> > + maxItems: 1
> > +
> > + flash-leds:
> > + $ref: /schemas/media/video-interfaces.yaml#
>
> This and...
>
> > +
> > + lens-focus:
> > + $ref: /schemas/media/video-interfaces.yaml#
>
> ... this are weird. LEDs are not video interfaces, for sure. lens focus
> shouldn't be video interface, either.
>
> You also miss unevaluatedProps there.
>
> This needs careful fixing/rewriting, with explanation in commit msg.
>
My mistake. The correct schema reference for these 2 should be video
interface devices.
--
Yours,
Alex Tran
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v1 1/2] media: dt-bindings: i2c: toshiba,et8ek8: Convert to DT schema
2025-12-24 21:07 ` Alex Tran
@ 2025-12-25 8:37 ` Krzysztof Kozlowski
0 siblings, 0 replies; 15+ messages in thread
From: Krzysztof Kozlowski @ 2025-12-25 8:37 UTC (permalink / raw)
To: Alex Tran
Cc: mchehab, robh, krzk+dt, conor+dt, pavel, sakari.ailus,
mehdi.djait, laurent.pinchart, hverkuil+cisco, linux-media,
devicetree, linux-kernel
On 24/12/2025 22:07, Alex Tran wrote:
>>> + maxItems: 1
>>> +
>>> + reset-gpios:
>>> + description:
>>> + XSHUTDOWN GPIO. The XSHUTDOWN signal is active low. The sensor
>>> + is in hardware standby mode when the signal is in the low state.
>>> + maxItems: 1
>>> +
>>> + flash-leds:
>>> + $ref: /schemas/media/video-interfaces.yaml#
>>
>> This and...
>>
>>> +
>>> + lens-focus:
>>> + $ref: /schemas/media/video-interfaces.yaml#
>>
>> ... this are weird. LEDs are not video interfaces, for sure. lens focus
>> shouldn't be video interface, either.
>>
>> You also miss unevaluatedProps there.
>>
>> This needs careful fixing/rewriting, with explanation in commit msg.
>>
>
> My mistake. The correct schema reference for these 2 should be video
> interface devices.
No. LEDs are not video interface devices, either. LEDs are LEDs.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH v1 2/2] media: dt-bindings: ti,omap3isp: Convert to DT schema
2025-12-20 22:03 ` Alex Tran
@ 2025-12-20 22:03 ` Alex Tran
-1 siblings, 0 replies; 15+ messages in thread
From: Alex Tran @ 2025-12-20 20:42 UTC (permalink / raw)
To: mchehab, robh, krzk+dt, conor+dt
Cc: pavel, sakari.ailus, mehdi.djait, alex.t.tran, laurent.pinchart,
hverkuil+cisco, linux-media
Convert binding for ti,omap3isp from TXT to YAML format.
Signed-off-by: Alex Tran <alex.t.tran@gmail.com>
---
.../devicetree/bindings/media/ti,omap3isp.txt | 71 -------
.../bindings/media/ti,omap3isp.yaml | 182 ++++++++++++++++++
2 files changed, 182 insertions(+), 71 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/media/ti,omap3isp.txt
create mode 100644 Documentation/devicetree/bindings/media/ti,omap3isp.yaml
diff --git a/Documentation/devicetree/bindings/media/ti,omap3isp.txt b/Documentation/devicetree/bindings/media/ti,omap3isp.txt
deleted file mode 100644
index ac23de855641..000000000000
--- a/Documentation/devicetree/bindings/media/ti,omap3isp.txt
+++ /dev/null
@@ -1,71 +0,0 @@
-OMAP 3 ISP Device Tree bindings
-===============================
-
-The DT definitions can be found in include/dt-bindings/media/omap3-isp.h.
-
-Required properties
-===================
-
-compatible : must contain "ti,omap3-isp"
-
-reg : the two registers sets (physical address and length) for the
- ISP. The first set contains the core ISP registers up to
- the end of the SBL block. The second set contains the
- CSI PHYs and receivers registers.
-interrupts : the ISP interrupt specifier
-iommus : phandle and IOMMU specifier for the IOMMU that serves the ISP
-syscon : the phandle and register offset to the Complex I/O or CSI-PHY
- register
-ti,phy-type : 0 -- OMAP3ISP_PHY_TYPE_COMPLEX_IO (e.g. 3430)
- 1 -- OMAP3ISP_PHY_TYPE_CSIPHY (e.g. 3630)
-#clock-cells : Must be 1 --- the ISP provides two external clocks,
- cam_xclka and cam_xclkb, at indices 0 and 1,
- respectively. Please find more information on common
- clock bindings in ../clock/clock-bindings.txt.
-
-Port nodes (optional)
----------------------
-
-More documentation on these bindings is available in
-video-interfaces.txt in the same directory.
-
-reg : The interface:
- 0 - parallel (CCDC)
- 1 - CSIPHY1 -- CSI2C / CCP2B on 3630;
- CSI1 -- CSIb on 3430
- 2 - CSIPHY2 -- CSI2A / CCP2B on 3630;
- CSI2 -- CSIa on 3430
-
-Optional properties
-===================
-
-vdd-csiphy1-supply : voltage supply of the CSI-2 PHY 1
-vdd-csiphy2-supply : voltage supply of the CSI-2 PHY 2
-
-Endpoint nodes
---------------
-
-lane-polarities : lane polarity (required on CSI-2)
- 0 -- not inverted; 1 -- inverted
-data-lanes : an array of data lanes from 1 to 3. The length can
- be either 1 or 2. (required on CSI-2)
-clock-lanes : the clock lane (from 1 to 3). (required on CSI-2)
-
-
-Example
-=======
-
- isp@480bc000 {
- compatible = "ti,omap3-isp";
- reg = <0x480bc000 0x12fc
- 0x480bd800 0x0600>;
- interrupts = <24>;
- iommus = <&mmu_isp>;
- syscon = <&scm_conf 0x2f0>;
- ti,phy-type = <OMAP3ISP_PHY_TYPE_CSIPHY>;
- #clock-cells = <1>;
- ports {
- #address-cells = <1>;
- #size-cells = <0>;
- };
- };
diff --git a/Documentation/devicetree/bindings/media/ti,omap3isp.yaml b/Documentation/devicetree/bindings/media/ti,omap3isp.yaml
new file mode 100644
index 000000000000..3f3b0c0f46e5
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/ti,omap3isp.yaml
@@ -0,0 +1,182 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/ti,omap3isp.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Texas Instruments OMAP 3 Image Signal Processor (ISP)
+
+maintainers:
+ - Laurent Pinchart <laurent.pinchart@ideasonboard.com>
+ - Sakari Ailus <sakari.ailus@iki.fi>
+
+description:
+ The OMAP 3 ISP is an image signal processor present in OMAP 3 SoCs.
+
+properties:
+ compatible:
+ const: ti,omap3-isp
+
+ reg:
+ items:
+ - description: Core ISP registers up to the end of the SBL block
+ - description: CSI PHYs and receivers registers
+
+ interrupts:
+ maxItems: 1
+ description: the ISP interrupt specifier
+
+ iommus:
+ maxItems: 1
+ description: phandle and IOMMU specifier for the IOMMU that serves the ISP
+
+ syscon:
+ $ref: /schemas/types.yaml#/definitions/phandle-array
+ items:
+ - items:
+ - description: phandle to System Control Module
+ - description: register offset to Complex I/O or CSI-PHY register
+ description:
+ Phandle and register offset to the Complex I/O or CSI-PHY register
+
+ ti,phy-type:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ enum: [0, 1]
+ description:
+ 0 - OMAP3ISP_PHY_TYPE_COMPLEX_IO (e.g. OMAP 3430)
+ 1 - OMAP3ISP_PHY_TYPE_CSIPHY (e.g. OMAP 3630)
+
+ '#clock-cells':
+ const: 1
+ description:
+ The ISP provides two external clocks, cam_xclka and cam_xclkb,
+ at indices 0 and 1 respectively.
+
+ vdd-csiphy1-supply:
+ description: Voltage supply of the CSI-2 PHY 1
+
+ vdd-csiphy2-supply:
+ description: Voltage supply of the CSI-2 PHY 2
+
+ ports:
+ $ref: /schemas/graph.yaml#/properties/ports
+
+ properties:
+ port@0:
+ $ref: /schemas/graph.yaml#/$defs/port-base
+ unevaluatedProperties: false
+ description: Parallel (CCDC) interface
+
+ properties:
+ endpoint:
+ $ref: /schemas/media/video-interfaces.yaml#
+ unevaluatedProperties: false
+
+ port@1:
+ $ref: /schemas/graph.yaml#/$defs/port-base
+ unevaluatedProperties: false
+ description: |
+ CSIPHY1 interface:
+ OMAP 3630: CSI2C / CCP2B
+ OMAP 3430: CSI1 (CSIb)
+
+ properties:
+ endpoint:
+ $ref: /schemas/media/video-interfaces.yaml#
+ unevaluatedProperties: false
+
+ properties:
+ lane-polarities:
+ description: |
+ The lane polarity (required on CSI-2):
+ 0 - not inverted
+ 1 - inverted
+ minItems: 2
+ maxItems: 3
+ items:
+ enum: [0, 1]
+
+ data-lanes:
+ description: Data lanes (required on CSI-2)
+ minItems: 1
+ maxItems: 2
+ items:
+ minimum: 1
+ maximum: 3
+
+ clock-lanes:
+ description: The clock lane (required on CSI-2)
+ maxItems: 1
+ items:
+ minimum: 1
+ maximum: 3
+
+ port@2:
+ $ref: /schemas/graph.yaml#/$defs/port-base
+ unevaluatedProperties: false
+ description: |
+ CSIPHY2 interface:
+ OMAP 3630: CSI2A / CCP2B
+ OMAP 3430: CSI2 (CSIa)
+
+ properties:
+ endpoint:
+ $ref: /schemas/media/video-interfaces.yaml#
+ unevaluatedProperties: false
+
+ properties:
+ lane-polarities:
+ description: |
+ The lane polarity (required on CSI-2):
+ 0 - not inverted
+ 1 - inverted
+ minItems: 2
+ maxItems: 3
+ items:
+ enum: [0, 1]
+
+ data-lanes:
+ description: Data lanes (required on CSI-2)
+ minItems: 1
+ maxItems: 2
+ items:
+ minimum: 1
+ maximum: 3
+
+ clock-lanes:
+ description: The clock lane (required on CSI-2)
+ maxItems: 1
+ items:
+ minimum: 1
+ maximum: 3
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - iommus
+ - syscon
+ - ti,phy-type
+ - '#clock-cells'
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/media/omap3-isp.h>
+
+ isp@480bc000 {
+ compatible = "ti,omap3-isp";
+ reg = <0x480bc000 0x12fc>,
+ <0x480bd800 0x0600>;
+ interrupts = <24>;
+ iommus = <&mmu_isp>;
+ syscon = <&scm_conf 0x2f0>;
+ ti,phy-type = <OMAP3ISP_PHY_TYPE_CSIPHY>;
+ #clock-cells = <1>;
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ };
+ };
--
2.51.0
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH v1 2/2] media: dt-bindings: ti,omap3isp: Convert to DT schema
@ 2025-12-20 22:03 ` Alex Tran
0 siblings, 0 replies; 15+ messages in thread
From: Alex Tran @ 2025-12-20 22:03 UTC (permalink / raw)
To: mchehab, robh, krzk+dt, conor+dt
Cc: pavel, sakari.ailus, mehdi.djait, alex.t.tran, laurent.pinchart,
hverkuil+cisco, linux-media, devicetree, linux-kernel
Convert binding for ti,omap3isp from TXT to YAML format.
Signed-off-by: Alex Tran <alex.t.tran@gmail.com>
---
.../devicetree/bindings/media/ti,omap3isp.txt | 71 -------
.../bindings/media/ti,omap3isp.yaml | 182 ++++++++++++++++++
2 files changed, 182 insertions(+), 71 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/media/ti,omap3isp.txt
create mode 100644 Documentation/devicetree/bindings/media/ti,omap3isp.yaml
diff --git a/Documentation/devicetree/bindings/media/ti,omap3isp.txt b/Documentation/devicetree/bindings/media/ti,omap3isp.txt
deleted file mode 100644
index ac23de855641..000000000000
--- a/Documentation/devicetree/bindings/media/ti,omap3isp.txt
+++ /dev/null
@@ -1,71 +0,0 @@
-OMAP 3 ISP Device Tree bindings
-===============================
-
-The DT definitions can be found in include/dt-bindings/media/omap3-isp.h.
-
-Required properties
-===================
-
-compatible : must contain "ti,omap3-isp"
-
-reg : the two registers sets (physical address and length) for the
- ISP. The first set contains the core ISP registers up to
- the end of the SBL block. The second set contains the
- CSI PHYs and receivers registers.
-interrupts : the ISP interrupt specifier
-iommus : phandle and IOMMU specifier for the IOMMU that serves the ISP
-syscon : the phandle and register offset to the Complex I/O or CSI-PHY
- register
-ti,phy-type : 0 -- OMAP3ISP_PHY_TYPE_COMPLEX_IO (e.g. 3430)
- 1 -- OMAP3ISP_PHY_TYPE_CSIPHY (e.g. 3630)
-#clock-cells : Must be 1 --- the ISP provides two external clocks,
- cam_xclka and cam_xclkb, at indices 0 and 1,
- respectively. Please find more information on common
- clock bindings in ../clock/clock-bindings.txt.
-
-Port nodes (optional)
----------------------
-
-More documentation on these bindings is available in
-video-interfaces.txt in the same directory.
-
-reg : The interface:
- 0 - parallel (CCDC)
- 1 - CSIPHY1 -- CSI2C / CCP2B on 3630;
- CSI1 -- CSIb on 3430
- 2 - CSIPHY2 -- CSI2A / CCP2B on 3630;
- CSI2 -- CSIa on 3430
-
-Optional properties
-===================
-
-vdd-csiphy1-supply : voltage supply of the CSI-2 PHY 1
-vdd-csiphy2-supply : voltage supply of the CSI-2 PHY 2
-
-Endpoint nodes
---------------
-
-lane-polarities : lane polarity (required on CSI-2)
- 0 -- not inverted; 1 -- inverted
-data-lanes : an array of data lanes from 1 to 3. The length can
- be either 1 or 2. (required on CSI-2)
-clock-lanes : the clock lane (from 1 to 3). (required on CSI-2)
-
-
-Example
-=======
-
- isp@480bc000 {
- compatible = "ti,omap3-isp";
- reg = <0x480bc000 0x12fc
- 0x480bd800 0x0600>;
- interrupts = <24>;
- iommus = <&mmu_isp>;
- syscon = <&scm_conf 0x2f0>;
- ti,phy-type = <OMAP3ISP_PHY_TYPE_CSIPHY>;
- #clock-cells = <1>;
- ports {
- #address-cells = <1>;
- #size-cells = <0>;
- };
- };
diff --git a/Documentation/devicetree/bindings/media/ti,omap3isp.yaml b/Documentation/devicetree/bindings/media/ti,omap3isp.yaml
new file mode 100644
index 000000000000..3f3b0c0f46e5
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/ti,omap3isp.yaml
@@ -0,0 +1,182 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/ti,omap3isp.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Texas Instruments OMAP 3 Image Signal Processor (ISP)
+
+maintainers:
+ - Laurent Pinchart <laurent.pinchart@ideasonboard.com>
+ - Sakari Ailus <sakari.ailus@iki.fi>
+
+description:
+ The OMAP 3 ISP is an image signal processor present in OMAP 3 SoCs.
+
+properties:
+ compatible:
+ const: ti,omap3-isp
+
+ reg:
+ items:
+ - description: Core ISP registers up to the end of the SBL block
+ - description: CSI PHYs and receivers registers
+
+ interrupts:
+ maxItems: 1
+ description: the ISP interrupt specifier
+
+ iommus:
+ maxItems: 1
+ description: phandle and IOMMU specifier for the IOMMU that serves the ISP
+
+ syscon:
+ $ref: /schemas/types.yaml#/definitions/phandle-array
+ items:
+ - items:
+ - description: phandle to System Control Module
+ - description: register offset to Complex I/O or CSI-PHY register
+ description:
+ Phandle and register offset to the Complex I/O or CSI-PHY register
+
+ ti,phy-type:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ enum: [0, 1]
+ description:
+ 0 - OMAP3ISP_PHY_TYPE_COMPLEX_IO (e.g. OMAP 3430)
+ 1 - OMAP3ISP_PHY_TYPE_CSIPHY (e.g. OMAP 3630)
+
+ '#clock-cells':
+ const: 1
+ description:
+ The ISP provides two external clocks, cam_xclka and cam_xclkb,
+ at indices 0 and 1 respectively.
+
+ vdd-csiphy1-supply:
+ description: Voltage supply of the CSI-2 PHY 1
+
+ vdd-csiphy2-supply:
+ description: Voltage supply of the CSI-2 PHY 2
+
+ ports:
+ $ref: /schemas/graph.yaml#/properties/ports
+
+ properties:
+ port@0:
+ $ref: /schemas/graph.yaml#/$defs/port-base
+ unevaluatedProperties: false
+ description: Parallel (CCDC) interface
+
+ properties:
+ endpoint:
+ $ref: /schemas/media/video-interfaces.yaml#
+ unevaluatedProperties: false
+
+ port@1:
+ $ref: /schemas/graph.yaml#/$defs/port-base
+ unevaluatedProperties: false
+ description: |
+ CSIPHY1 interface:
+ OMAP 3630: CSI2C / CCP2B
+ OMAP 3430: CSI1 (CSIb)
+
+ properties:
+ endpoint:
+ $ref: /schemas/media/video-interfaces.yaml#
+ unevaluatedProperties: false
+
+ properties:
+ lane-polarities:
+ description: |
+ The lane polarity (required on CSI-2):
+ 0 - not inverted
+ 1 - inverted
+ minItems: 2
+ maxItems: 3
+ items:
+ enum: [0, 1]
+
+ data-lanes:
+ description: Data lanes (required on CSI-2)
+ minItems: 1
+ maxItems: 2
+ items:
+ minimum: 1
+ maximum: 3
+
+ clock-lanes:
+ description: The clock lane (required on CSI-2)
+ maxItems: 1
+ items:
+ minimum: 1
+ maximum: 3
+
+ port@2:
+ $ref: /schemas/graph.yaml#/$defs/port-base
+ unevaluatedProperties: false
+ description: |
+ CSIPHY2 interface:
+ OMAP 3630: CSI2A / CCP2B
+ OMAP 3430: CSI2 (CSIa)
+
+ properties:
+ endpoint:
+ $ref: /schemas/media/video-interfaces.yaml#
+ unevaluatedProperties: false
+
+ properties:
+ lane-polarities:
+ description: |
+ The lane polarity (required on CSI-2):
+ 0 - not inverted
+ 1 - inverted
+ minItems: 2
+ maxItems: 3
+ items:
+ enum: [0, 1]
+
+ data-lanes:
+ description: Data lanes (required on CSI-2)
+ minItems: 1
+ maxItems: 2
+ items:
+ minimum: 1
+ maximum: 3
+
+ clock-lanes:
+ description: The clock lane (required on CSI-2)
+ maxItems: 1
+ items:
+ minimum: 1
+ maximum: 3
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - iommus
+ - syscon
+ - ti,phy-type
+ - '#clock-cells'
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/media/omap3-isp.h>
+
+ isp@480bc000 {
+ compatible = "ti,omap3-isp";
+ reg = <0x480bc000 0x12fc>,
+ <0x480bd800 0x0600>;
+ interrupts = <24>;
+ iommus = <&mmu_isp>;
+ syscon = <&scm_conf 0x2f0>;
+ ti,phy-type = <OMAP3ISP_PHY_TYPE_CSIPHY>;
+ #clock-cells = <1>;
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ };
+ };
--
2.51.0
^ permalink raw reply related [flat|nested] 15+ messages in thread* Re: [PATCH v1 2/2] media: dt-bindings: ti,omap3isp: Convert to DT schema
2025-12-20 22:03 ` Alex Tran
(?)
@ 2025-12-21 15:08 ` Krzysztof Kozlowski
2025-12-24 21:46 ` Alex Tran
-1 siblings, 1 reply; 15+ messages in thread
From: Krzysztof Kozlowski @ 2025-12-21 15:08 UTC (permalink / raw)
To: Alex Tran
Cc: mchehab, robh, krzk+dt, conor+dt, pavel, sakari.ailus,
mehdi.djait, laurent.pinchart, hverkuil+cisco, linux-media,
devicetree, linux-kernel
On Sat, Dec 20, 2025 at 02:03:25PM -0800, Alex Tran wrote:
Thank you for your patch. There is something to discuss/improve.
> +maintainers:
> + - Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> + - Sakari Ailus <sakari.ailus@iki.fi>
> +
> +description:
> + The OMAP 3 ISP is an image signal processor present in OMAP 3 SoCs.
> +
> +properties:
> + compatible:
> + const: ti,omap3-isp
> +
> + reg:
> + items:
> + - description: Core ISP registers up to the end of the SBL block
> + - description: CSI PHYs and receivers registers
> +
> + interrupts:
> + maxItems: 1
> + description: the ISP interrupt specifier
Drop description, obvious.
> +
> + iommus:
> + maxItems: 1
> + description: phandle and IOMMU specifier for the IOMMU that serves the ISP
Ditto
> +
> + syscon:
> + $ref: /schemas/types.yaml#/definitions/phandle-array
> + items:
> + - items:
> + - description: phandle to System Control Module
> + - description: register offset to Complex I/O or CSI-PHY register
> + description:
> + Phandle and register offset to the Complex I/O or CSI-PHY register
> +
> + ti,phy-type:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + enum: [0, 1]
> + description:
> + 0 - OMAP3ISP_PHY_TYPE_COMPLEX_IO (e.g. OMAP 3430)
> + 1 - OMAP3ISP_PHY_TYPE_CSIPHY (e.g. OMAP 3630)
> +
> + '#clock-cells':
> + const: 1
> + description:
> + The ISP provides two external clocks, cam_xclka and cam_xclkb,
> + at indices 0 and 1 respectively.
> +
> + vdd-csiphy1-supply:
> + description: Voltage supply of the CSI-2 PHY 1
> +
> + vdd-csiphy2-supply:
> + description: Voltage supply of the CSI-2 PHY 2
> +
> + ports:
> + $ref: /schemas/graph.yaml#/properties/ports
> +
> + properties:
> + port@0:
> + $ref: /schemas/graph.yaml#/$defs/port-base
> + unevaluatedProperties: false
> + description: Parallel (CCDC) interface
> +
> + properties:
> + endpoint:
> + $ref: /schemas/media/video-interfaces.yaml#
> + unevaluatedProperties: false
> +
> + port@1:
> + $ref: /schemas/graph.yaml#/$defs/port-base
> + unevaluatedProperties: false
> + description: |
> + CSIPHY1 interface:
> + OMAP 3630: CSI2C / CCP2B
> + OMAP 3430: CSI1 (CSIb)
> +
> + properties:
> + endpoint:
> + $ref: /schemas/media/video-interfaces.yaml#
> + unevaluatedProperties: false
> +
> + properties:
> + lane-polarities:
> + description: |
> + The lane polarity (required on CSI-2):
> + 0 - not inverted
> + 1 - inverted
You do not need to describe standard properties. Are the values
different than what video-interfaces define?
Same everywhere else. Look at other bindings how these properties should
be defined/written.
> + minItems: 2
> + maxItems: 3
> + items:
> + enum: [0, 1]
> +
> + data-lanes:
> + description: Data lanes (required on CSI-2)
> + minItems: 1
> + maxItems: 2
> + items:
> + minimum: 1
> + maximum: 3
> +
> + clock-lanes:
> + description: The clock lane (required on CSI-2)
> + maxItems: 1
> + items:
> + minimum: 1
> + maximum: 3
> +
> + port@2:
> + $ref: /schemas/graph.yaml#/$defs/port-base
> + unevaluatedProperties: false
> + description: |
> + CSIPHY2 interface:
> + OMAP 3630: CSI2A / CCP2B
> + OMAP 3430: CSI2 (CSIa)
> +
> + properties:
> + endpoint:
> + $ref: /schemas/media/video-interfaces.yaml#
> + unevaluatedProperties: false
> +
> + properties:
> + lane-polarities:
> + description: |
> + The lane polarity (required on CSI-2):
> + 0 - not inverted
> + 1 - inverted
> + minItems: 2
> + maxItems: 3
> + items:
> + enum: [0, 1]
> +
> + data-lanes:
> + description: Data lanes (required on CSI-2)
> + minItems: 1
> + maxItems: 2
> + items:
> + minimum: 1
> + maximum: 3
> +
> + clock-lanes:
> + description: The clock lane (required on CSI-2)
> + maxItems: 1
> + items:
> + minimum: 1
> + maximum: 3
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - iommus
> + - syscon
> + - ti,phy-type
> + - '#clock-cells'
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/media/omap3-isp.h>
> +
> + isp@480bc000 {
> + compatible = "ti,omap3-isp";
> + reg = <0x480bc000 0x12fc>,
> + <0x480bd800 0x0600>;
> + interrupts = <24>;
> + iommus = <&mmu_isp>;
> + syscon = <&scm_conf 0x2f0>;
> + ti,phy-type = <OMAP3ISP_PHY_TYPE_CSIPHY>;
> + #clock-cells = <1>;
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
Make example complete, please.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PATCH v1 2/2] media: dt-bindings: ti,omap3isp: Convert to DT schema
2025-12-21 15:08 ` Krzysztof Kozlowski
@ 2025-12-24 21:46 ` Alex Tran
0 siblings, 0 replies; 15+ messages in thread
From: Alex Tran @ 2025-12-24 21:46 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: mchehab, robh, krzk+dt, conor+dt, pavel, sakari.ailus,
mehdi.djait, laurent.pinchart, hverkuil+cisco, linux-media,
devicetree, linux-kernel
On Sun, Dec 21, 2025 at 7:08 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On Sat, Dec 20, 2025 at 02:03:25PM -0800, Alex Tran wrote:
>
>
> Thank you for your patch. There is something to discuss/improve.
>
>
> > +maintainers:
> > + - Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > + - Sakari Ailus <sakari.ailus@iki.fi>
> > +
> > +description:
> > + The OMAP 3 ISP is an image signal processor present in OMAP 3 SoCs.
> > +
> > +properties:
> > + compatible:
> > + const: ti,omap3-isp
> > +
> > + reg:
> > + items:
> > + - description: Core ISP registers up to the end of the SBL block
> > + - description: CSI PHYs and receivers registers
> > +
> > + interrupts:
> > + maxItems: 1
> > + description: the ISP interrupt specifier
>
> Drop description, obvious.
>
> > +
> > + iommus:
> > + maxItems: 1
> > + description: phandle and IOMMU specifier for the IOMMU that serves the ISP
>
> Ditto
>
> > +
> > + syscon:
> > + $ref: /schemas/types.yaml#/definitions/phandle-array
> > + items:
> > + - items:
> > + - description: phandle to System Control Module
> > + - description: register offset to Complex I/O or CSI-PHY register
> > + description:
> > + Phandle and register offset to the Complex I/O or CSI-PHY register
> > +
> > + ti,phy-type:
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + enum: [0, 1]
> > + description:
> > + 0 - OMAP3ISP_PHY_TYPE_COMPLEX_IO (e.g. OMAP 3430)
> > + 1 - OMAP3ISP_PHY_TYPE_CSIPHY (e.g. OMAP 3630)
> > +
> > + '#clock-cells':
> > + const: 1
> > + description:
> > + The ISP provides two external clocks, cam_xclka and cam_xclkb,
> > + at indices 0 and 1 respectively.
> > +
> > + vdd-csiphy1-supply:
> > + description: Voltage supply of the CSI-2 PHY 1
> > +
> > + vdd-csiphy2-supply:
> > + description: Voltage supply of the CSI-2 PHY 2
> > +
> > + ports:
> > + $ref: /schemas/graph.yaml#/properties/ports
> > +
> > + properties:
> > + port@0:
> > + $ref: /schemas/graph.yaml#/$defs/port-base
> > + unevaluatedProperties: false
> > + description: Parallel (CCDC) interface
> > +
> > + properties:
> > + endpoint:
> > + $ref: /schemas/media/video-interfaces.yaml#
> > + unevaluatedProperties: false
> > +
> > + port@1:
> > + $ref: /schemas/graph.yaml#/$defs/port-base
> > + unevaluatedProperties: false
> > + description: |
> > + CSIPHY1 interface:
> > + OMAP 3630: CSI2C / CCP2B
> > + OMAP 3430: CSI1 (CSIb)
> > +
> > + properties:
> > + endpoint:
> > + $ref: /schemas/media/video-interfaces.yaml#
> > + unevaluatedProperties: false
> > +
> > + properties:
> > + lane-polarities:
> > + description: |
> > + The lane polarity (required on CSI-2):
> > + 0 - not inverted
> > + 1 - inverted
>
> You do not need to describe standard properties. Are the values
> different than what video-interfaces define?
>
> Same everywhere else. Look at other bindings how these properties should
> be defined/written.
>
> > + minItems: 2
> > + maxItems: 3
> > + items:
> > + enum: [0, 1]
> > +
> > + data-lanes:
> > + description: Data lanes (required on CSI-2)
> > + minItems: 1
> > + maxItems: 2
> > + items:
> > + minimum: 1
> > + maximum: 3
> > +
> > + clock-lanes:
> > + description: The clock lane (required on CSI-2)
> > + maxItems: 1
> > + items:
> > + minimum: 1
> > + maximum: 3
> > +
> > + port@2:
> > + $ref: /schemas/graph.yaml#/$defs/port-base
> > + unevaluatedProperties: false
> > + description: |
> > + CSIPHY2 interface:
> > + OMAP 3630: CSI2A / CCP2B
> > + OMAP 3430: CSI2 (CSIa)
> > +
> > + properties:
> > + endpoint:
> > + $ref: /schemas/media/video-interfaces.yaml#
> > + unevaluatedProperties: false
> > +
> > + properties:
> > + lane-polarities:
> > + description: |
> > + The lane polarity (required on CSI-2):
> > + 0 - not inverted
> > + 1 - inverted
> > + minItems: 2
> > + maxItems: 3
> > + items:
> > + enum: [0, 1]
> > +
> > + data-lanes:
> > + description: Data lanes (required on CSI-2)
> > + minItems: 1
> > + maxItems: 2
> > + items:
> > + minimum: 1
> > + maximum: 3
> > +
> > + clock-lanes:
> > + description: The clock lane (required on CSI-2)
> > + maxItems: 1
> > + items:
> > + minimum: 1
> > + maximum: 3
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - interrupts
> > + - iommus
> > + - syscon
> > + - ti,phy-type
> > + - '#clock-cells'
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/media/omap3-isp.h>
> > +
> > + isp@480bc000 {
> > + compatible = "ti,omap3-isp";
> > + reg = <0x480bc000 0x12fc>,
> > + <0x480bd800 0x0600>;
> > + interrupts = <24>;
> > + iommus = <&mmu_isp>;
> > + syscon = <&scm_conf 0x2f0>;
> > + ti,phy-type = <OMAP3ISP_PHY_TYPE_CSIPHY>;
> > + #clock-cells = <1>;
> > +
> > + ports {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
>
> Make example complete, please.
>
>
> Best regards,
> Krzysztof
>
Thanks for the review. I'll address these in v2. Also the check patch
script seems to be giving false positive warnings about DT binding
docs and includes should be a separate patch. This patch series does
not touch any files under the include/dt-bindings directory at all.
--
Yours,
Alex Tran
^ permalink raw reply [flat|nested] 15+ messages in thread