* [PATCH 0/2] arm: dts: socfpga: agilex5: Improve MMC/SD device tree organization
@ 2026-04-15 3:18 ` tze.yee.ng
0 siblings, 0 replies; 6+ messages in thread
From: tze.yee.ng @ 2026-04-15 2:03 UTC (permalink / raw)
To: u-boot
Cc: Marek Vasut, Simon Goldschmidt, Tien Fong Chee, Tom Rini,
Peng Fan, Jaehoon Chung
From: tzeyeeng <tzeyee.ng@altera.com>
This patch series refactors the MMC/SD device tree configuration for
Agilex5 SOCDK to improve maintainability and correctness.
The first patch reorganizes the configuration by moving board-specific
MMC properties from the common u-boot.dtsi to the board-specific dts
file, keeping only truly common configurations in the shared dtsi.
The second patch addresses a configuration issue where the eMMC device
tree was incorrectly inheriting SD card-specific properties. It removes
the SD UHS speed mode properties (sd-uhs-sdr50, sd-uhs-sdr104) that are
not applicable to eMMC and properly configures the capabilities mask to
enable 8-bit embedded device support.
tzeyeeng (2):
arm: dts: socfpga: agilex5: Move mmc node differs from base board dtsi
to dts
arm: dts: socfpga: Remove SD card properties from Agilex5 eMMC device
tree
arch/arm/dts/socfpga_agilex5_socdk-u-boot.dtsi | 1 -
arch/arm/dts/socfpga_agilex5_socdk.dts | 6 ++++++
arch/arm/dts/socfpga_agilex5_socdk_emmc.dts | 4 +++-
3 files changed, 9 insertions(+), 2 deletions(-)
--
2.43.7
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] arm: dts: socfpga: agilex5: Move mmc node differs from base board dtsi to dts
@ 2026-04-15 3:18 ` tze.yee.ng
0 siblings, 0 replies; 6+ messages in thread
From: tze.yee.ng @ 2026-04-15 2:03 UTC (permalink / raw)
To: u-boot
Cc: Marek Vasut, Simon Goldschmidt, Tien Fong Chee, Tom Rini,
Peng Fan, Jaehoon Chung
From: tzeyeeng <tzeyee.ng@altera.com>
The purpose of this change is to keep common configuration in
socfpga_agilex5_socdk-u-boot.dtsi and move differs to
socfpga_agilex5_socdk.dts.
Signed-off-by: tzeyeeng <tzeyee.ng@altera.com>
---
arch/arm/dts/socfpga_agilex5_socdk-u-boot.dtsi | 1 -
arch/arm/dts/socfpga_agilex5_socdk.dts | 6 ++++++
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/arch/arm/dts/socfpga_agilex5_socdk-u-boot.dtsi b/arch/arm/dts/socfpga_agilex5_socdk-u-boot.dtsi
index c03f78b2fdf..23c616b1afd 100644
--- a/arch/arm/dts/socfpga_agilex5_socdk-u-boot.dtsi
+++ b/arch/arm/dts/socfpga_agilex5_socdk-u-boot.dtsi
@@ -118,7 +118,6 @@
vqmmc-supply = <&sd_io_1v8_reg>;
max-frequency = <200000000>;
sdhci-caps = <0x00000000 0x0000c800>;
- sdhci-caps-mask = <0x00002000 0x0000ff00>;
/* SD card default speed (DS) and UHS-I SDR12 mode timing configuration */
cdns,phy-dqs-timing-delay-sd-ds = <0x00780000>;
diff --git a/arch/arm/dts/socfpga_agilex5_socdk.dts b/arch/arm/dts/socfpga_agilex5_socdk.dts
index 886cc89fdb6..cbb2bfbe3b4 100644
--- a/arch/arm/dts/socfpga_agilex5_socdk.dts
+++ b/arch/arm/dts/socfpga_agilex5_socdk.dts
@@ -74,6 +74,12 @@
status = "okay";
};
+&mmc {
+ sd-uhs-sdr50;
+ sd-uhs-sdr104;
+ sdhci-caps-mask = <0x00002000 0x0000ff00>;
+};
+
&uart0 {
status = "okay";
};
--
2.43.7
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] arm: dts: socfpga: Remove SD card properties from Agilex5 eMMC device tree
@ 2026-04-15 3:18 ` tze.yee.ng
0 siblings, 0 replies; 6+ messages in thread
From: tze.yee.ng @ 2026-04-15 2:03 UTC (permalink / raw)
To: u-boot
Cc: Marek Vasut, Simon Goldschmidt, Tien Fong Chee, Tom Rini,
Peng Fan, Jaehoon Chung
From: tzeyeeng <tzeyee.ng@altera.com>
eMMC inherit the configuration from socfpga_agilex5_socdk.dts, including
the SD card properties.
Changes:
- Remove sd-uhs-sdr50 and sd-uhs-sdr104, which are SD card speed mode from
eMMC device tree.
- Set SDHCI Capabilities bit18 to enable 8-bit embedded device support.
Signed-off-by: tzeyeeng <tzeyee.ng@altera.com>
---
arch/arm/dts/socfpga_agilex5_socdk_emmc.dts | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/arm/dts/socfpga_agilex5_socdk_emmc.dts b/arch/arm/dts/socfpga_agilex5_socdk_emmc.dts
index c06781064ca..f1e8b737e3f 100644
--- a/arch/arm/dts/socfpga_agilex5_socdk_emmc.dts
+++ b/arch/arm/dts/socfpga_agilex5_socdk_emmc.dts
@@ -18,6 +18,8 @@
};
&mmc {
+ /delete-property/ sd-uhs-sdr50;
+ /delete-property/ sd-uhs-sdr104;
status = "okay";
no-sd;
@@ -32,7 +34,7 @@
vqmmc-supply = <&emmc_io_1v8_reg>;
max-frequency = <200000000>;
sdhci-caps = <0x00000000 0x0004c800>; /* SDHCI_CAN_DO_8BIT */
- sdhci-caps-mask = <0x00000000 0x0000ff00>;
+ sdhci-caps-mask = <0x00000000 0x0004ff00>;
/* eMMC legacy mode timing configuration */
cdns,phy-dqs-timing-delay-sd-ds = <0x00780000>;
--
2.43.7
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 0/2] arm: dts: socfpga: agilex5: Improve MMC/SD device tree organization
@ 2026-04-15 3:18 ` tze.yee.ng
0 siblings, 0 replies; 6+ messages in thread
From: tze.yee.ng @ 2026-04-15 3:18 UTC (permalink / raw)
To: u-boot
Cc: Tze Yee Ng, Marek Vasut, Simon Goldschmidt, Tien Fong Chee,
Tom Rini, Peng Fan, Jaehoon Chung, Dinesh Maniyam, Chen Huei Lok,
Kok Kiang Hea, alif.zakuan.yuslaimi, Boon Khai Ng
From: tzeyeeng <tzeyee.ng@altera.com>
This patch series refactors the MMC/SD device tree configuration for
Agilex5 SOCDK to improve maintainability and correctness.
The first patch reorganizes the configuration by moving board-specific
MMC properties from the common u-boot.dtsi to the board-specific dts
file, keeping only truly common configurations in the shared dtsi.
The second patch addresses a configuration issue where the eMMC device
tree was incorrectly inheriting SD card-specific properties. It removes
the SD UHS speed mode properties (sd-uhs-sdr50, sd-uhs-sdr104) that are
not applicable to eMMC and properly configures the capabilities mask to
enable 8-bit embedded device support.
tzeyeeng (2):
arm: dts: socfpga: agilex5: Move mmc node differs from base board dtsi
to dts
arm: dts: socfpga: Remove SD card properties from Agilex5 eMMC device
tree
arch/arm/dts/socfpga_agilex5_socdk-u-boot.dtsi | 1 -
arch/arm/dts/socfpga_agilex5_socdk.dts | 6 ++++++
arch/arm/dts/socfpga_agilex5_socdk_emmc.dts | 4 +++-
3 files changed, 9 insertions(+), 2 deletions(-)
--
2.43.7
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] arm: dts: socfpga: agilex5: Move mmc node differs from base board dtsi to dts
@ 2026-04-15 3:18 ` tze.yee.ng
0 siblings, 0 replies; 6+ messages in thread
From: tze.yee.ng @ 2026-04-15 3:18 UTC (permalink / raw)
To: u-boot
Cc: Tze Yee Ng, Marek Vasut, Simon Goldschmidt, Tien Fong Chee,
Tom Rini, Peng Fan, Jaehoon Chung, Dinesh Maniyam, Chen Huei Lok,
Kok Kiang Hea, alif.zakuan.yuslaimi, Boon Khai Ng
From: tzeyeeng <tzeyee.ng@altera.com>
The purpose of this change is to keep common configuration in
socfpga_agilex5_socdk-u-boot.dtsi and move differs to
socfpga_agilex5_socdk.dts.
Signed-off-by: tzeyeeng <tzeyee.ng@altera.com>
---
arch/arm/dts/socfpga_agilex5_socdk-u-boot.dtsi | 1 -
arch/arm/dts/socfpga_agilex5_socdk.dts | 6 ++++++
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/arch/arm/dts/socfpga_agilex5_socdk-u-boot.dtsi b/arch/arm/dts/socfpga_agilex5_socdk-u-boot.dtsi
index c03f78b2fdf..23c616b1afd 100644
--- a/arch/arm/dts/socfpga_agilex5_socdk-u-boot.dtsi
+++ b/arch/arm/dts/socfpga_agilex5_socdk-u-boot.dtsi
@@ -118,7 +118,6 @@
vqmmc-supply = <&sd_io_1v8_reg>;
max-frequency = <200000000>;
sdhci-caps = <0x00000000 0x0000c800>;
- sdhci-caps-mask = <0x00002000 0x0000ff00>;
/* SD card default speed (DS) and UHS-I SDR12 mode timing configuration */
cdns,phy-dqs-timing-delay-sd-ds = <0x00780000>;
diff --git a/arch/arm/dts/socfpga_agilex5_socdk.dts b/arch/arm/dts/socfpga_agilex5_socdk.dts
index 886cc89fdb6..cbb2bfbe3b4 100644
--- a/arch/arm/dts/socfpga_agilex5_socdk.dts
+++ b/arch/arm/dts/socfpga_agilex5_socdk.dts
@@ -74,6 +74,12 @@
status = "okay";
};
+&mmc {
+ sd-uhs-sdr50;
+ sd-uhs-sdr104;
+ sdhci-caps-mask = <0x00002000 0x0000ff00>;
+};
+
&uart0 {
status = "okay";
};
--
2.43.7
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] arm: dts: socfpga: Remove SD card properties from Agilex5 eMMC device tree
@ 2026-04-15 3:18 ` tze.yee.ng
0 siblings, 0 replies; 6+ messages in thread
From: tze.yee.ng @ 2026-04-15 3:18 UTC (permalink / raw)
To: u-boot
Cc: Tze Yee Ng, Marek Vasut, Simon Goldschmidt, Tien Fong Chee,
Tom Rini, Peng Fan, Jaehoon Chung, Dinesh Maniyam, Chen Huei Lok,
Kok Kiang Hea, alif.zakuan.yuslaimi, Boon Khai Ng
From: tzeyeeng <tzeyee.ng@altera.com>
eMMC inherit the configuration from socfpga_agilex5_socdk.dts, including
the SD card properties.
Changes:
- Remove sd-uhs-sdr50 and sd-uhs-sdr104, which are SD card speed mode from
eMMC device tree.
- Set SDHCI Capabilities bit18 to enable 8-bit embedded device support.
Signed-off-by: tzeyeeng <tzeyee.ng@altera.com>
---
arch/arm/dts/socfpga_agilex5_socdk_emmc.dts | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/arm/dts/socfpga_agilex5_socdk_emmc.dts b/arch/arm/dts/socfpga_agilex5_socdk_emmc.dts
index c06781064ca..f1e8b737e3f 100644
--- a/arch/arm/dts/socfpga_agilex5_socdk_emmc.dts
+++ b/arch/arm/dts/socfpga_agilex5_socdk_emmc.dts
@@ -18,6 +18,8 @@
};
&mmc {
+ /delete-property/ sd-uhs-sdr50;
+ /delete-property/ sd-uhs-sdr104;
status = "okay";
no-sd;
@@ -32,7 +34,7 @@
vqmmc-supply = <&emmc_io_1v8_reg>;
max-frequency = <200000000>;
sdhci-caps = <0x00000000 0x0004c800>; /* SDHCI_CAN_DO_8BIT */
- sdhci-caps-mask = <0x00000000 0x0000ff00>;
+ sdhci-caps-mask = <0x00000000 0x0004ff00>;
/* eMMC legacy mode timing configuration */
cdns,phy-dqs-timing-delay-sd-ds = <0x00780000>;
--
2.43.7
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-04-15 4:11 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-15 2:03 [PATCH 0/2] arm: dts: socfpga: agilex5: Improve MMC/SD device tree organization tze.yee.ng
2026-04-15 3:18 ` tze.yee.ng
2026-04-15 2:03 ` [PATCH 1/2] arm: dts: socfpga: agilex5: Move mmc node differs from base board dtsi to dts tze.yee.ng
2026-04-15 3:18 ` tze.yee.ng
2026-04-15 2:03 ` [PATCH 2/2] arm: dts: socfpga: Remove SD card properties from Agilex5 eMMC device tree tze.yee.ng
2026-04-15 3:18 ` tze.yee.ng
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.