[PATCH 0/3] hw/loongarch/virt: Fix clock property name typo and order

All of lore.kernel.org
 help / color / mirror / Atom feed

* [PATCH 0/3] hw/loongarch/virt: Fix clock property name typo and order
@ 2026-10-12 11:39 pillow
  2026-10-12 11:39 ` [PATCH 1/3] bios-tables-test-allowed-diff.h: Allow LoongArch DSDT.* pillow
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: pillow @ 2026-10-12 11:39 UTC (permalink / raw)
  To: qemu-devel
  Cc: 17746591750, maobibo, lixianglai, jiaxun.yang, mst, imammedo,
	anisinha, pillow

The property was incorrectly named "clock-frenquency" and is now corrected to "clock-frequency". The order between the property name and its frequency value has also been adjusted for consistency.

pillow (3):
  bios-tables-test-allowed-diff.h: Allow LoongArch DSDT.*
  hw/loongarch/virt: Fix clock property name typo and order
  tests/data/acpi/loongarch64: Update expected DSDT.*

 hw/loongarch/virt-acpi-build.c                |   2 +-
 tests/data/acpi/loongarch64/virt/DSDT         | Bin 4603 -> 4599 bytes
 tests/data/acpi/loongarch64/virt/DSDT.memhp   | Bin 5824 -> 5820 bytes
 tests/data/acpi/loongarch64/virt/DSDT.numamem | Bin 4609 -> 4605 bytes
 .../data/acpi/loongarch64/virt/DSDT.topology  | Bin 4905 -> 4901 bytes
 5 files changed, 1 insertion(+), 1 deletion(-)


base-commit: 615ece3c406b262996e569f29ea6eed0d81c4d8d
-- 
2.56.0



^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/3] bios-tables-test-allowed-diff.h: Allow LoongArch DSDT.*
  2026-10-12 11:39 [PATCH 0/3] hw/loongarch/virt: Fix clock property name typo and order pillow
@ 2026-10-12 11:39 ` pillow
  2026-10-12 11:39 ` [PATCH 2/3] hw/loongarch/virt: Fix clock property name typo and order pillow
  2026-10-12 11:39 ` [PATCH 3/3] tests/data/acpi/loongarch64: Update expected DSDT.* pillow
  2 siblings, 0 replies; 4+ messages in thread
From: pillow @ 2026-10-12 11:39 UTC (permalink / raw)
  To: qemu-devel
  Cc: 17746591750, maobibo, lixianglai, jiaxun.yang, mst, imammedo,
	anisinha, pillow

Signed-off-by: pillow <waysorrypub@gmail.com>
---
 tests/qtest/bios-tables-test-allowed-diff.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
index dfb8523..2ed837f 100644
--- a/tests/qtest/bios-tables-test-allowed-diff.h
+++ b/tests/qtest/bios-tables-test-allowed-diff.h
@@ -1 +1,5 @@
 /* List of comma-separated changed AML files to ignore */
+"tests/data/acpi/loongarch64/virt/DSDT",
+"tests/data/acpi/loongarch64/virt/DSDT.memhp",
+"tests/data/acpi/loongarch64/virt/DSDT.numamem",
+"tests/data/acpi/loongarch64/virt/DSDT.topology",
-- 
2.56.0



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/3] hw/loongarch/virt: Fix clock property name typo and order
  2026-10-12 11:39 [PATCH 0/3] hw/loongarch/virt: Fix clock property name typo and order pillow
  2026-10-12 11:39 ` [PATCH 1/3] bios-tables-test-allowed-diff.h: Allow LoongArch DSDT.* pillow
@ 2026-10-12 11:39 ` pillow
  2026-10-12 11:39 ` [PATCH 3/3] tests/data/acpi/loongarch64: Update expected DSDT.* pillow
  2 siblings, 0 replies; 4+ messages in thread
From: pillow @ 2026-10-12 11:39 UTC (permalink / raw)
  To: qemu-devel
  Cc: 17746591750, maobibo, lixianglai, jiaxun.yang, mst, imammedo,
	anisinha, pillow

The original code had a typo in the clock preperty name, and the
property name and frequency value were in reversed order.
According to the _DSD format rules, the property name string comes
first, followed by the property value:
https://github.com/UEFI/DSD-Guide/blob/main/src/dsd-guide.adoc#data-format-definition

Signed-off-by: pillow <waysorrypub@gmail.com>
---
 hw/loongarch/virt-acpi-build.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/loongarch/virt-acpi-build.c b/hw/loongarch/virt-acpi-build.c
index 54965f0..4081730 100644
--- a/hw/loongarch/virt-acpi-build.c
+++ b/hw/loongarch/virt-acpi-build.c
@@ -336,8 +336,8 @@ static void build_uart_device_aml(Aml *table, int index)
                                   AML_SHARED, &uart_irq, 1));
     aml_append(dev, aml_name_decl("_CRS", crs));
     pkg0 = aml_package(0x2);
+    aml_append(pkg0, aml_string("clock-frequency"));
     aml_append(pkg0, aml_int(0x05F5E100));
-    aml_append(pkg0, aml_string("clock-frenquency"));
     pkg1 = aml_package(0x1);
     aml_append(pkg1, pkg0);
     pkg2 = aml_package(0x2);
-- 
2.56.0



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 3/3] tests/data/acpi/loongarch64: Update expected DSDT.*
  2026-10-12 11:39 [PATCH 0/3] hw/loongarch/virt: Fix clock property name typo and order pillow
  2026-10-12 11:39 ` [PATCH 1/3] bios-tables-test-allowed-diff.h: Allow LoongArch DSDT.* pillow
  2026-10-12 11:39 ` [PATCH 2/3] hw/loongarch/virt: Fix clock property name typo and order pillow
@ 2026-10-12 11:39 ` pillow
  2 siblings, 0 replies; 4+ messages in thread
From: pillow @ 2026-10-12 11:39 UTC (permalink / raw)
  To: qemu-devel
  Cc: 17746591750, maobibo, lixianglai, jiaxun.yang, mst, imammedo,
	anisinha, pillow

    --- DSDT (before)
    +++ DSDT (after)
    @@ -23,18 +23,18 @@
                 })
                 Name (_DSD, Package (0x02)  // _DSD: Device-Specific Data
                 {
                     ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301") /* Device Properties for _DSD */,
                     Package (0x01)
                     {
                         Package (0x02)
                         {
    -                        0x05F5E100,
    -                        "clock-frenquency"
    +                        "clock-frequency",
    +                        0x05F5E100
                         }
                     }
                 })
             }
         }

         Scope (_SB)
         {
    @@ -59,18 +59,18 @@
                 })
                 Name (_DSD, Package (0x02)  // _DSD: Device-Specific Data
                 {
                     ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301") /* Device Properties for _DSD */,
                     Package (0x01)
                     {
                         Package (0x02)
                         {
    -                        0x05F5E100,
    -                        "clock-frenquency"
    +                        "clock-frequency",
    +                        0x05F5E100
                         }
                     }
                 })
             }
         }

         Scope (_SB)
         {
    @@ -95,18 +95,18 @@
                 })
                 Name (_DSD, Package (0x02)  // _DSD: Device-Specific Data
                 {
                     ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301") /* Device Properties for _DSD */,
                     Package (0x01)
                     {
                         Package (0x02)
                         {
    -                        0x05F5E100,
    -                        "clock-frenquency"
    +                        "clock-frequency",
    +                        0x05F5E100
                         }
                     }
                 })
             }
         }

         Scope (_SB)
         {
    @@ -131,18 +131,18 @@
                 })
                 Name (_DSD, Package (0x02)  // _DSD: Device-Specific Data
                 {
                     ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301") /* Device Properties for _DSD */,
                     Package (0x01)
                     {
                         Package (0x02)
                         {
    -                        0x05F5E100,
    -                        "clock-frenquency"
    +                        "clock-frequency",
    +                        0x05F5E100
                         }
                     }
                 })
             }
         }

         Device (L000)
         {
    --- DSDT.memhp (before)
    +++ DSDT.memhp (after)
    @@ -23,18 +23,18 @@
                 })
                 Name (_DSD, Package (0x02)  // _DSD: Device-Specific Data
                 {
                     ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301") /* Device Properties for _DSD */,
                     Package (0x01)
                     {
                         Package (0x02)
                         {
    -                        0x05F5E100,
    -                        "clock-frenquency"
    +                        "clock-frequency",
    +                        0x05F5E100
                         }
                     }
                 })
             }
         }

         Scope (_SB)
         {
    @@ -59,18 +59,18 @@
                 })
                 Name (_DSD, Package (0x02)  // _DSD: Device-Specific Data
                 {
                     ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301") /* Device Properties for _DSD */,
                     Package (0x01)
                     {
                         Package (0x02)
                         {
    -                        0x05F5E100,
    -                        "clock-frenquency"
    +                        "clock-frequency",
    +                        0x05F5E100
                         }
                     }
                 })
             }
         }

         Scope (_SB)
         {
    @@ -95,18 +95,18 @@
                 })
                 Name (_DSD, Package (0x02)  // _DSD: Device-Specific Data
                 {
                     ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301") /* Device Properties for _DSD */,
                     Package (0x01)
                     {
                         Package (0x02)
                         {
    -                        0x05F5E100,
    -                        "clock-frenquency"
    +                        "clock-frequency",
    +                        0x05F5E100
                         }
                     }
                 })
             }
         }

         Scope (_SB)
         {
    @@ -131,18 +131,18 @@
                 })
                 Name (_DSD, Package (0x02)  // _DSD: Device-Specific Data
                 {
                     ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301") /* Device Properties for _DSD */,
                     Package (0x01)
                     {
                         Package (0x02)
                         {
    -                        0x05F5E100,
    -                        "clock-frenquency"
    +                        "clock-frequency",
    +                        0x05F5E100
                         }
                     }
                 })
             }
         }

         Device (L000)
         {
    --- DSDT.numamem (before)
    +++ DSDT.numamem (after)
    @@ -23,18 +23,18 @@
                 })
                 Name (_DSD, Package (0x02)  // _DSD: Device-Specific Data
                 {
                     ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301") /* Device Properties for _DSD */,
                     Package (0x01)
                     {
                         Package (0x02)
                         {
    -                        0x05F5E100,
    -                        "clock-frenquency"
    +                        "clock-frequency",
    +                        0x05F5E100
                         }
                     }
                 })
             }
         }

         Scope (_SB)
         {
    @@ -59,18 +59,18 @@
                 })
                 Name (_DSD, Package (0x02)  // _DSD: Device-Specific Data
                 {
                     ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301") /* Device Properties for _DSD */,
                     Package (0x01)
                     {
                         Package (0x02)
                         {
    -                        0x05F5E100,
    -                        "clock-frenquency"
    +                        "clock-frequency",
    +                        0x05F5E100
                         }
                     }
                 })
             }
         }

         Scope (_SB)
         {
    @@ -95,18 +95,18 @@
                 })
                 Name (_DSD, Package (0x02)  // _DSD: Device-Specific Data
                 {
                     ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301") /* Device Properties for _DSD */,
                     Package (0x01)
                     {
                         Package (0x02)
                         {
    -                        0x05F5E100,
    -                        "clock-frenquency"
    +                        "clock-frequency",
    +                        0x05F5E100
                         }
                     }
                 })
             }
         }

         Scope (_SB)
         {
    @@ -131,18 +131,18 @@
                 })
                 Name (_DSD, Package (0x02)  // _DSD: Device-Specific Data
                 {
                     ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301") /* Device Properties for _DSD */,
                     Package (0x01)
                     {
                         Package (0x02)
                         {
    -                        0x05F5E100,
    -                        "clock-frenquency"
    +                        "clock-frequency",
    +                        0x05F5E100
                         }
                     }
                 })
             }
         }

         Device (L000)
         {
    --- DSDT.topology (before)
    +++ DSDT.topology (after)
    @@ -23,18 +23,18 @@
                 })
                 Name (_DSD, Package (0x02)  // _DSD: Device-Specific Data
                 {
                     ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301") /* Device Properties for _DSD */,
                     Package (0x01)
                     {
                         Package (0x02)
                         {
    -                        0x05F5E100,
    -                        "clock-frenquency"
    +                        "clock-frequency",
    +                        0x05F5E100
                         }
                     }
                 })
             }
         }

         Scope (_SB)
         {
    @@ -59,18 +59,18 @@
                 })
                 Name (_DSD, Package (0x02)  // _DSD: Device-Specific Data
                 {
                     ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301") /* Device Properties for _DSD */,
                     Package (0x01)
                     {
                         Package (0x02)
                         {
    -                        0x05F5E100,
    -                        "clock-frenquency"
    +                        "clock-frequency",
    +                        0x05F5E100
                         }
                     }
                 })
             }
         }

         Scope (_SB)
         {
    @@ -95,18 +95,18 @@
                 })
                 Name (_DSD, Package (0x02)  // _DSD: Device-Specific Data
                 {
                     ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301") /* Device Properties for _DSD */,
                     Package (0x01)
                     {
                         Package (0x02)
                         {
    -                        0x05F5E100,
    -                        "clock-frenquency"
    +                        "clock-frequency",
    +                        0x05F5E100
                         }
                     }
                 })
             }
         }

         Scope (_SB)
         {
    @@ -131,18 +131,18 @@
                 })
                 Name (_DSD, Package (0x02)  // _DSD: Device-Specific Data
                 {
                     ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301") /* Device Properties for _DSD */,
                     Package (0x01)
                     {
                         Package (0x02)
                         {
    -                        0x05F5E100,
    -                        "clock-frenquency"
    +                        "clock-frequency",
    +                        0x05F5E100
                         }
                     }
                 })
             }
         }

         Device (L000)
         {

Signed-off-by: pillow <waysorrypub@gmail.com>
---
 tests/data/acpi/loongarch64/virt/DSDT         | Bin 4603 -> 4599 bytes
 tests/data/acpi/loongarch64/virt/DSDT.memhp   | Bin 5824 -> 5820 bytes
 tests/data/acpi/loongarch64/virt/DSDT.numamem | Bin 4609 -> 4605 bytes
 .../data/acpi/loongarch64/virt/DSDT.topology  | Bin 4905 -> 4901 bytes
 tests/qtest/bios-tables-test-allowed-diff.h   |   4 ----
 5 files changed, 4 deletions(-)

diff --git a/tests/data/acpi/loongarch64/virt/DSDT b/tests/data/acpi/loongarch64/virt/DSDT
index 09aa903c4e875f541223e36f59b28e101599df20..9040b02efa416565e3591fcecf5fea685e831be9 100644
GIT binary patch
delta 222
zcmeyZ{9T#LCD<k8yC4Gtqs~MwX-+4u_+Y2_=q9g;dg+WtlkYQ%sY){nNigvy=j116
z>!uZ@7M7;wC08==Fg*OqDu7Ua394KRpK@oY>E4{q{=P<&6_`XO_cQtvVGms6WND@h
Ph<a%}7H!_f<jM~KweUh|

delta 217
zcmeya{9BpJCD<k8w;%%pW6VS@X-;RZ_+Y2_=qB%pdg+YDlN*`D)MOZiB$;>^9)4xz
zP0q<r&elyUO3f=QP0dTLWDr28zetpN7pVC@lS>#gh_L{nL4paYK?a|THg95b<p%(F
Cm_Y{s

diff --git a/tests/data/acpi/loongarch64/virt/DSDT.memhp b/tests/data/acpi/loongarch64/virt/DSDT.memhp
index a069d6878fb45fa6b0e6342eedb0eb3d25eb20da..0220f6abc21f6b1fc4d68a159fa3e332a84be7dc 100644
GIT binary patch
delta 222
zcmX@0yGNJHCD<ioj~D|3qv1p@X-+4u_+Y2_=q9g;dg+WtlkYQ%sY){nNigvy=j116
z>!uZ@7M7;wC08==Fg*OqDu7Ua394KRpK@oY>E4{q{=P<&6_`XO_cQtvVGms6WND@h
Ph<a%}7H!_f#3cd%H|{~8

delta 217
zcmdm^dq9`VCD<k8fEWV<W8y?EX-;RZ_+Y2_=qB%pdg+YDlN*`D)MOZiB$;>^9)4xz
zP0q<r&elyUO3f=QP0dTLWDr28zetpN7pVC@lS>#gh_L{nL4paYK?a|THg96$5&;1G
CW<Wjw

diff --git a/tests/data/acpi/loongarch64/virt/DSDT.numamem b/tests/data/acpi/loongarch64/virt/DSDT.numamem
index 78ece52f57a383db128c7d1a08526e15ab911bb7..274d4ebdfed4b700103b0f7b79c877b02d217c85 100644
GIT binary patch
delta 222
zcmZov`K!$366_N4SCD~$amPe1X-+4u_+Y2_=q9g;dg+WtlkYQ%sY){nNigvy=j116
z>!uZ@7M7;wC08==Fg*OqDu7Ua394KRpK@oY>E4{q{=P<&6_`XO_cQtvVGms6WND@h
Ph<a%}7H!_f<joHN$n!#u

delta 217
zcmeyX+^E9k66_MfD8#_P_<SOlG^aCHe6Uk|bd&c)y>v$7$&E~6YBG#Ml1w}d55KbV
zCg<cQXX~aFrREiursgGAG6*2lUnEMs3)Fm{$t8>##8`mPAi)IHAcN0En>R6e^8*07
C^FS;B

diff --git a/tests/data/acpi/loongarch64/virt/DSDT.topology b/tests/data/acpi/loongarch64/virt/DSDT.topology
index 7ab23f47cc82dd7bc1975e17893a8cd61039e66d..07a0cdc05fffbb7e96bfd3ca39d1589a913d1be1 100644
GIT binary patch
delta 222
zcmZ3fwp5MFCD<iIRhWT+asEUuX-+4u_+Y2_=q9g;dg+WtlkYQ%sY){nNigvy=j116
z>!uZ@7M7;wC08==Fg*OqDu7Ua394KRpK@oY>E4{q{=P<&6_`XO_cQtvVGms6WND@h
Ph<a%}7H!_fR4f1h-Y`L(

delta 217
zcmZ3gwo;ADCD<iIQ<#B)@%%(CX-;RZ_+Y2_=qB%pdg+YDlN*`D)MOZiB$;>^9)4xz
zP0q<r&elyUO3f=QP0dTLWDr28zetpN7pVC@lS>#gh_L{nL4paYK?a|THg94o761UG
Czd$<x

diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
index 2ed837f..dfb8523 100644
--- a/tests/qtest/bios-tables-test-allowed-diff.h
+++ b/tests/qtest/bios-tables-test-allowed-diff.h
@@ -1,5 +1 @@
 /* List of comma-separated changed AML files to ignore */
-"tests/data/acpi/loongarch64/virt/DSDT",
-"tests/data/acpi/loongarch64/virt/DSDT.memhp",
-"tests/data/acpi/loongarch64/virt/DSDT.numamem",
-"tests/data/acpi/loongarch64/virt/DSDT.topology",
-- 
2.56.0



^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-10-12 11:54 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-12 11:39 [PATCH 0/3] hw/loongarch/virt: Fix clock property name typo and order pillow
2026-10-12 11:39 ` [PATCH 1/3] bios-tables-test-allowed-diff.h: Allow LoongArch DSDT.* pillow
2026-10-12 11:39 ` [PATCH 2/3] hw/loongarch/virt: Fix clock property name typo and order pillow
2026-10-12 11:39 ` [PATCH 3/3] tests/data/acpi/loongarch64: Update expected DSDT.* pillow

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.