All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/2] media: qcom: camss: Fix the X1E80100 lite CSID paths
@ 2026-11-20 17:40 Jesse Casco
  2026-11-20 17:40 ` [PATCH 1/2] media: qcom: camss: x1e80100: Use the lite clocks for the lite CSIDs Jesse Casco
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Jesse Casco @ 2026-11-20 17:40 UTC (permalink / raw)
  To: Bryan O'Donoghue, Vladimir Zapolskiy, Loic Poulain,
	Mauro Carvalho Chehab
  Cc: Nihal Kumar Gupta, Allan Siriani, linux-media, linux-arm-msm

The X1E80100 CAMSS resources, which Glymur reuses for its CSIDs and VFEs
(also with Nihal's Glymur-specific resources [1]), have two problems on
the lite paths:

- the lite CSIDs are given the full CSID clocks, so their CSI-2
  receiver is never clocked and they never see a frame;
- CAMSS assumes CSID n feeds VFE n, but X1E80100 has three full CSIDs
  and two full VFEs, so CSID_LITE0 powers VFE_LITE1, CSID_LITE1 has no
  VFE to power and CSID2 powers VFE_LITE0.

Tested on an Asus Zenbook A16 (Glymur), Linux 7.3 with the X1E80100
CSID/VFE tables, streaming 8 frames from the HM1092 IR sensor on CSIPHY0
through each CSID/VFE pair with media-ctl and v4l2-ctl:

                     before          after
  CSID0 -> VFE0      8 frames        8 frames
  CSID1 -> VFE1      8 frames        8 frames
  LITE0 -> LITE0     no frames       8 frames
  LITE1 -> LITE1     -EINVAL         8 frames
  CSID2 -> VFE0      no frames       -EINVAL

The OV02C10 RGB sensor on CSIPHY4 through LITE1 -> LITE1 also goes from
-EINVAL to 8 frames. libcamera still captures from both cameras. I ran
the same tests again with Nihal's v3 [1] applied and the board's CSIPHY4
link on port@2, with the same results.

I don't have an X1E80100 machine; testing there would be welcome.

The series applies on its own and in either order with [1]. Patch 2
touches vfe_parent_dev_ops_get() like Allan's "media: qcom: camss: do
not fail CSID power up without a matching VFE" [2]. They don't depend
on each other; I'm happy to rebase on whichever lands first.

[1] https://lore.kernel.org/r/20261119-glymur_camss-v3-0-71ab966c41c9@oss.qualcomm.com
[2] https://lore.kernel.org/r/20261111135338.27008-5-allan@fatecpompeia.edu.br

Jesse Casco (2):
  media: qcom: camss: x1e80100: Use the lite clocks for the lite CSIDs
  media: qcom: camss: Map each CSID to the VFE it feeds

 drivers/media/platform/qcom/camss/camss.c | 54 +++++++++++++++++++----
 1 file changed, 45 insertions(+), 9 deletions(-)


base-commit: adcad7f4e6332cff3d6d7165f41584899f598534
-- 
2.56.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2026-11-20 20:01 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-20 17:40 [PATCH 0/2] media: qcom: camss: Fix the X1E80100 lite CSID paths Jesse Casco
2026-11-20 17:40 ` [PATCH 1/2] media: qcom: camss: x1e80100: Use the lite clocks for the lite CSIDs Jesse Casco
2026-11-20 19:29   ` Loic Poulain
2026-11-20 17:40 ` [PATCH 2/2] media: qcom: camss: Map each CSID to the VFE it feeds Jesse Casco
2026-11-20 19:39   ` Loic Poulain
2026-11-20 19:56     ` Gjorgji Rosikopulos (Consultant)
2026-11-20 20:01 ` [PATCH 0/2] media: qcom: camss: Fix the X1E80100 lite CSID paths Gjorgji Rosikopulos (Consultant)

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.