From: Chris Wilson <chris@chris-wilson.co.uk>
To: Ben Widawsky <ben@bwidawsk.net>, Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 11/11] drm/i915: add HAS_ALIASING_PPGTT parameter for userspace
Date: Tue, 06 Dec 2011 18:31:14 +0000 [thread overview]
Message-ID: <d08817$2f0cd5@azsmga001.ch.intel.com> (raw)
In-Reply-To: <20111206173938.GA32563@bolo_yeung.jf.intel.com>
On Tue, 6 Dec 2011 09:39:39 -0800, Ben Widawsky <ben@bwidawsk.net> wrote:
> On Mon, Nov 28, 2011 at 10:24:55PM +0100, Daniel Vetter wrote:
> > On Sanybridge a few MI read/write commands only work when ppgtt is
> > enabled. Userspace therefore needs to be able to check whether ppgtt
> > is enabled. For added hilarity, you need to reset the "use global GTT"
> > bit on both snb/ivb when ppgtt is enabled, otherwise it won't work.
> > Despite what bspec says about automatically using ppgtt ...
> >
> > Luckily PIPE_CONTROL (the only write cmd current userspace uses) is
> > not affected by all this, as tested by tests/gem_pipe_control_store_loop.
>
> Since this is all SNB only, and we have no good benchmarks to show
> performance gains, can we not just enable this for IVB+?
Don't we have the same basic problem with IVB, that we need to adjust
the commands in the batchbuffer depending on whether HAS_ALIASING_PPGTT
is true? Or do you mean that we should just assume that IVB uses the
ppgtt and so kernel 3.3+, which will be around March...
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2011-12-06 18:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-28 21:24 [PATCH 08/11] drm/i915: enable ppgtt Daniel Vetter
2011-11-28 21:24 ` [PATCH 09/11] drm/i915: split out dma mapping from global gtt bind/unbind functions Daniel Vetter
2011-11-28 21:24 ` [PATCH 10/11] drm/i915: bind objects to the global gtt only when needed Daniel Vetter
2011-11-28 22:32 ` [PATCH 1/3] " Daniel Vetter
2011-11-28 22:32 ` [PATCH 2/3] drm/i915: implement SNB workaround for lazy global gtt Daniel Vetter
2011-12-02 22:07 ` [PATCH] " Daniel Vetter
2011-11-28 22:32 ` [PATCH 3/3] drm/i915: enable lazy global-gtt binding Daniel Vetter
2011-11-29 11:27 ` [PATCH] drm/i915: bind objects to the global gtt only when needed Daniel Vetter
2011-11-29 1:55 ` [PATCH 10/11] " Eric Anholt
2011-12-02 22:12 ` Daniel Vetter
2011-11-28 21:24 ` [PATCH 11/11] drm/i915: add HAS_ALIASING_PPGTT parameter for userspace Daniel Vetter
2011-12-06 17:39 ` Ben Widawsky
2011-12-06 18:31 ` Chris Wilson [this message]
2011-12-06 19:59 ` Daniel Vetter
2011-11-29 12:47 ` [PATCH 08/11] drm/i915: enable ppgtt Chris Wilson
2011-11-30 0:05 ` Ben Widawsky
2011-12-02 22:19 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='d08817$2f0cd5@azsmga001.ch.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=ben@bwidawsk.net \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.