From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH 08/11] drm/i915: enable ppgtt
Date: Tue, 29 Nov 2011 12:47:50 +0000 [thread overview]
Message-ID: <e0d58a$2db4l2@orsmga002.jf.intel.com> (raw)
In-Reply-To: <1322515495-13049-1-git-send-email-daniel.vetter@ffwll.ch>
On Mon, 28 Nov 2011 22:24:52 +0100, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> +void i915_gem_init_ppgtt(struct drm_device *dev)
> +{
> + drm_i915_private_t *dev_priv = dev->dev_private;
> + uint32_t pd_offset;
> + struct intel_ring_buffer *ring;
> + int i;
> +
> + if (!HAS_ALIASING_PPGTT(dev))
> + return;
This wants to be
if (dev_priv->mm.aliasing_ppgtt == NULL)
return;
instead. Slightly safer against the clumsy ;-)
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2011-11-29 12:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-28 21:24 [PATCH 08/11] drm/i915: enable ppgtt Daniel Vetter
2011-11-28 21:24 ` [PATCH 09/11] drm/i915: split out dma mapping from global gtt bind/unbind functions Daniel Vetter
2011-11-28 21:24 ` [PATCH 10/11] drm/i915: bind objects to the global gtt only when needed Daniel Vetter
2011-11-28 22:32 ` [PATCH 1/3] " Daniel Vetter
2011-11-28 22:32 ` [PATCH 2/3] drm/i915: implement SNB workaround for lazy global gtt Daniel Vetter
2011-12-02 22:07 ` [PATCH] " Daniel Vetter
2011-11-28 22:32 ` [PATCH 3/3] drm/i915: enable lazy global-gtt binding Daniel Vetter
2011-11-29 11:27 ` [PATCH] drm/i915: bind objects to the global gtt only when needed Daniel Vetter
2011-11-29 1:55 ` [PATCH 10/11] " Eric Anholt
2011-12-02 22:12 ` Daniel Vetter
2011-11-28 21:24 ` [PATCH 11/11] drm/i915: add HAS_ALIASING_PPGTT parameter for userspace Daniel Vetter
2011-12-06 17:39 ` Ben Widawsky
2011-12-06 18:31 ` Chris Wilson
2011-12-06 19:59 ` Daniel Vetter
2011-11-29 12:47 ` Chris Wilson [this message]
2011-11-30 0:05 ` [PATCH 08/11] drm/i915: enable ppgtt Ben Widawsky
2011-12-02 22:19 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='e0d58a$2db4l2@orsmga002.jf.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.